A double quote character doesn't need to be escaped when it is a char literal
and single quote character doesn't need to be escaped when it is in a string.
This change updates the toString() output of annotations to account for the
different escaping requirements of strings and characters.
Corr
On Wed, 31 Jan 2024 23:53:16 GMT, Sandhya Viswanathan
wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1613:
>>
>>> 1611: vpand(xtmp, idx_vec, xtmp, vlen_enc);
>>> 1612: // Load double words from normalized indices.
>>> 1613: evpgatherdd(dst, gmask, Address(base, xtmp, scale),
On Wed, 31 Jan 2024 22:24:14 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319344)
> which adds MessageFormat pattern support for the following subformats:
> ListFormat, CompactNumberFormat, and DateTimeFormatter. This change is
> intended to prov
On Wed, 31 Jan 2024 21:31:21 GMT, Sandhya Viswanathan
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolutions.
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1613:
>
>> 1611: vpand(
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319344)
which adds MessageFormat pattern support for the following subformats:
ListFormat, CompactNumberFormat, and DateTimeFormatter. This change is intended
to provide pattern support for the more recently added JDK Format su
On Sun, 21 Jan 2024 06:55:43 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch optimizes sub-word gather operation for x86 targets with AVX2 and
>> AVX512 features.
>>
>> Following is the summary of changes:-
>>
>> 1) Intrinsify sub-word gather using hybrid algorithm which initially
>> p
On Wed, 31 Jan 2024 13:12:10 GMT, Per Minborg wrote:
> This PR fixes a typo in the documentation for the `Arena::ofShared`.
LGTM
-
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17653#pullrequestreview-1854679366
On Wed, 31 Jan 2024 13:04:07 GMT, Per Minborg wrote:
> This PR proposes to implement `hashCode()` and `equals()` methods for
> implementations of `PathElement`.
>
> In doing so, the previous `PathElementImpl` was removed and replaced in favor
> of distinct `record` implementations, each reflec
On Fri, 12 Jan 2024 15:17:42 GMT, Per Minborg wrote:
> This PR proposes to remove the snippet files in
> `java/lang/foreign/snippet-files` from the build.
This pull request has now been integrated.
Changeset: f2920533
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/f2920
On Tue, 30 Jan 2024 23:09:17 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314822)
>> which allows for the _Format_ segment of a ChoiceFormat pattern to use the
>> ChoiceFormat Relational symbols without the need to escape them using
>> quotes. P
> The testcase requires root permissions.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains 15 additional commits
since the last revision:
On Fri, 12 Jan 2024 17:12:37 GMT, Severin Gehwolf wrote:
> Walking the directory hierarchy (**and** interface files) on every call of
> `physical_memory()` (or `active_processor_count()` for CPU) seems concerning.
I have therefore implemented a hierarchical `memory.stat` extension for cgroup2
On Fri, 8 Sep 2023 14:17:29 GMT, Aggelos Biboudis
wrote:
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
This pull request has now been integrated.
Changeset: 1733d2ea
On Wed, 31 Jan 2024 13:16:08 GMT, Eirik Bjørsnøs wrote:
>> Thank you for the update. This test-only change looks OK to me.
>>
>> Hello Sundar @sundararajana, given your past work on this test, do you have
>> any thoughts on this change?
>
>> Hello Sundar @sundararajana, given your past work on
On Wed, 24 Jan 2024 06:50:36 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which rewrites the BadFactoryTest to pure Java/JUnit.
>> The test is currently implemented using a mix of shell script and a Java
>> main method.
>>
>> Reviewers may notice the following changes:
>>
>> - The she
On Mon, 27 Nov 2023 17:44:24 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which rewrites the BadFactoryTest to pure Java/JUnit.
> The test is currently implemented using a mix of shell script and a Java main
> method.
>
> Reviewers may notice the following changes:
>
> - The shell scri
On Wed, 31 Jan 2024 14:02:13 GMT, Eirik Bjørsnøs wrote:
>
> Whoops, I just integrated after the approval from @sundararajana, seconds
> before this comment.
That's alright.
>
> What is the best action here, just have a rollback PR ready in case of
> failures?
Typically when such failures
On Wed, 31 Jan 2024 13:16:08 GMT, Eirik Bjørsnøs wrote:
>> Thank you for the update. This test-only change looks OK to me.
>>
>> Hello Sundar @sundararajana, given your past work on this test, do you have
>> any thoughts on this change?
>
>> Hello Sundar @sundararajana, given your past work on
On Wed, 24 Jan 2024 07:08:11 GMT, Jaikiran Pai wrote:
> Hello Sundar @sundararajana, given your past work on this test, do you have
> any thoughts on this change?
@jaikiran We have not heard back from @sundararajana in the last week. It would
be nice to see this low-risk change integrated.
I
This PR fixes a typo in the documentation for the `Arena::ofShared`.
-
Commit messages:
- Fix typo
Changes: https://git.openjdk.org/jdk/pull/17653/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17653&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8325001
Stats: 1 l
This PR proposes to implement `hashCode()` and `equals()` methods for
implementations of `PathElement`.
In doing so, the previous `PathElementImpl` was removed and replaced in favor
of distinct `record` implementations, each reflecting its own path element
selection type. This also allowed the
On Mon, 29 Jan 2024 16:57:00 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this PR which updates zlib from 1.3 to 1.3.1 in OpenJDK
>
> The [Zlib Data Compression Library](https://github.com/madler/zlib) has
> released Zlib 1.3.1 on January 24, 2024.
>
> There are a [small number of
On Tue, 30 Jan 2024 16:58:35 GMT, Per Minborg wrote:
>> This PR proposes to add an improved Improve
>> `LayoutPath.PathElement::toString` method simplifying debugging.
>>
>> Opinions and suggestions for `static PathElement sequenceElement(long start,
>> long step)` are welcome.
>
> Per Minborg
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
Aggelos Biboudis has updated the pull request with a new target base due to a
merge or a rebase. The pull request now cont
On Mon, 15 Jan 2024 07:56:13 GMT, Per Minborg wrote:
> This PR proposes to add an improved Improve
> `LayoutPath.PathElement::toString` method simplifying debugging.
>
> Opinions and suggestions for `static PathElement sequenceElement(long start,
> long step)` are welcome.
This pull request h
On Tue, 30 Jan 2024 14:15:57 GMT, Magnus Ihse Bursie wrote:
>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
>> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
>> native libraries.
>
> Magnus Ihse Bursie has updated the pull request with a
On Wed, 31 Jan 2024 00:48:35 GMT, Joe Darcy wrote:
> Can we maybe see if we can fix these tests without exclusive-accessing them?
> I find it surprising that `java/lang/StringBuilder` tests are problematic,
> but `java/lang/StringBuffer` tests are not. Which tests fail?
It is a bit arbitrary w
27 matches
Mail list logo
