On Wed, 31 Jan 2024 13:16:08 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> Thank you for the update. This test-only change looks OK to me. >> >> Hello Sundar @sundararajana, given your past work on this test, do you have >> any thoughts on this change? > >> Hello Sundar @sundararajana, given your past work on this test, do you have >> any thoughts on this change? > > @jaikiran We have not heard back from @sundararajana in the last week. It > would be nice to see this low-risk change integrated. > > I'm sure we can respond to any post-integration feedback with a follow-up PR. > Do you agree? > Hello Eirik @eirbjo, please give me a few more hours. I just now noticed that > this test resides in tier2, so github actions job doesn't cover it. I'll > trigger a CI run and once it's done successfully, you can go ahead and > integrate this. Whoops, I just integrated after the approval from @sundararajana, seconds before this comment. What is the best action here, just have a rollback PR ready in case of failures? ------------- PR Comment: https://git.openjdk.org/jdk/pull/16830#issuecomment-1919164228
