On Tue, 30 Jan 2024 14:02:41 GMT, Matthias Baesken wrote:
>>> Yes there is a nice define in the AIX header
>>
>> *sigh* On linux, they go to some lengths to avoid this, using a __REDEFINE
>> mechanism. Oh well.
>>
>> Anyway, I think this particular can be resolved by not including the
>> sta
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by feature,
Align the specification of `Unsafe.allocateMemory` with its implementation and
with the specification of `Unsafe.reallocateMemory`.
-
Commit messages:
- 8324960: Unsafe.allocateMemory documentation incorrect regarding zero return
value
Changes: https://git.openjdk.org/jdk/pull/176
On Mon, 27 Nov 2023 22:52:10 GMT, Hans Boehm wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates to clear() and enqueue()
>
> src/java.base/share/classes/java/lang/ref/package-info.java line 109:
>
>> 107:
On Mon, 27 Nov 2023 21:51:01 GMT, Hans Boehm wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates to clear() and enqueue()
>
> src/java.base/share/classes/java/lang/ref/package-info.java line 104:
>
>> 102:
On Tue, 30 Jan 2024 17:21:07 GMT, Aleksey Shipilev wrote:
> Can we maybe see if we can fix these tests without exclusive-accessing them?
> I find it surprising that `java/lang/StringBuilder` tests are problematic,
> but `java/lang/StringBuffer` tests are not. Which tests fail?
I agree it would
On Thu, 30 Nov 2023 22:39:26 GMT, Brent Christian wrote:
>> IMO, the core of the semantics here are that the reachabilityFence() call
>> happens before clearing or enqueueing of any References to the argument. I
>> think it's the call itself, not the end of the argument.s scope (which may
>> n
On Wed, 31 Jan 2024 00:10:26 GMT, Maurizio Cimadamore
wrote:
>> The implementation of method `VectorSpecies::fromMemorySegment`, in
>> `AbstractSpecies::fromMemorySegment`, neglects to perform bounds checks on
>> the offset argument when the method is compiled by C2 (bounds checks are
>> perf
On Mon, 29 Jan 2024 19:45:41 GMT, Paul Sandoz wrote:
> The implementation of method `VectorSpecies::fromMemorySegment`, in
> `AbstractSpecies::fromMemorySegment`, neglects to perform bounds checks on
> the offset argument when the method is compiled by C2 (bounds checks are
> performed when in
On Mon, 29 Jan 2024 19:45:41 GMT, Paul Sandoz wrote:
> The implementation of method `VectorSpecies::fromMemorySegment`, in
> `AbstractSpecies::fromMemorySegment`, neglects to perform bounds checks on
> the offset argument when the method is compiled by C2 (bounds checks are
> performed when in
On Tue, 30 Jan 2024 19:57:01 GMT, Eirik Bjørsnøs wrote:
> Please review this test-only PR which improves test coverage of
> `String.regionMatches` when comparing the Turkic "dotted I" and "dotless i"
> characters with their latin cousins.
>
> The test `CompactStrings/RegionMatches.java` curre
On Tue, 30 Jan 2024 19:57:01 GMT, Eirik Bjørsnøs wrote:
> Please review this test-only PR which improves test coverage of
> `String.regionMatches` when comparing the Turkic "dotted I" and "dotless i"
> characters with their latin cousins.
>
> The test `CompactStrings/RegionMatches.java` curre
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314822)
> which allows for the _Format_ segment of a ChoiceFormat pattern to use the
> ChoiceFormat Relational symbols without the need to escape them using quotes.
> Previously, using a non escaped Relational symbol within a
On Tue, 30 Jan 2024 22:36:29 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update wording on quoting behavior
>
> src/java.base/share/classes/java/text/ChoiceFormat.java line 185:
>
>> 183: *
>> 1
On Mon, 27 Nov 2023 22:33:16 GMT, Hans Boehm wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates to clear() and enqueue()
>
> src/java.base/share/classes/java/lang/ref/Reference.java line 546:
>
>> 544:
On Tue, 30 Jan 2024 19:57:01 GMT, Eirik Bjørsnøs wrote:
> Please review this test-only PR which improves test coverage of
> `String.regionMatches` when comparing the Turkic "dotted I" and "dotless i"
> characters with their latin cousins.
>
> The test `CompactStrings/RegionMatches.java` curre
On Tue, 30 Jan 2024 21:19:27 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314822)
> which allows for the _Format_ segment of a ChoiceFormat pattern to use the
> ChoiceFormat Relational symbols without the need to escape them using quotes.
> Previ
On Tue, 30 Jan 2024 16:41:28 GMT, Weijun Wang wrote:
>> src/java.management/share/classes/com/sun/jmx/remote/security/MBeanServerFileAccessController.java
>> line 307:
>>
>>> 305: AccessController.doPrivileged(new PrivilegedAction<>() {
>>> 306: public Subject ru
> This code change adds an alternative implementation of user-based
> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
> Depending on if the Security Manager is allowed, the methods store the
> current subject differently. See the spec change in the `Subject.java` file
On Thu, 25 Jan 2024 23:09:51 GMT, Brent Christian wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314822)
which allows for the _Format_ segment of a ChoiceFormat pattern to use the
ChoiceFormat Relational symbols without the need to escape them using quotes.
Previously, using a non escaped Relational symbol within a _Format
On Mon, 29 Jan 2024 23:53:08 GMT, Aggelos Biboudis
wrote:
>> This is the proposed patch for Primitive types in patterns, instanceof, and
>> switch (Preview).
>>
>> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
>
> Aggelos Biboudis has updated the pull request increment
On Tue, 30 Jan 2024 16:45:34 GMT, Weijun Wang wrote:
>> OK - things seem to be a bit convoluted here and some pieces might be
>> missing. I suspect that what needs to be done is more complicated:
>>
>> `RMIConnectionImpl` sets up an ACC and calls doPrivileged with that ACC, on
>> the assumptio
> This code change adds an alternative implementation of user-based
> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
> Depending on if the Security Manager is allowed, the methods store the
> current subject differently. See the spec change in the `Subject.java` file
Please review this test-only PR which improves test coverage of
`String.regionMatches` when comparing the Turkic "dotted I" and "dotless i"
characters with their latin cousins.
The test `CompactStrings/RegionMatches.java` currently includes cases comparing
these characters against the lowercas
On Fri, 23 Jul 2021 03:37:44 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8271147? `make docs-image` worked
> fine and the generated javadoc looks fine.
This pull request has now been integrated.
On Fri, 23 Jul 2021 03:37:44 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8271147? `make docs-image` worked
> fine and the generated javadoc looks fine.
Thank you for the review, Iris.
---
On Fri, 23 Jul 2021 03:37:44 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8271147? `make docs-image` worked
> fine and the generated javadoc looks fine.
Marked as reviewed by iris (Reviewer).
Can I please get a review for this change which fixes the typo noted in
https://bugs.openjdk.java.net/browse/JDK-8271147? `make docs-image` worked fine
and the generated javadoc looks fine.
-
Commit messages:
- 8271147: java/nio/file/Path.java javadoc typo
Changes: https://git.ope
> Please consider this fix to ensure that going from `MessageFormat` to pattern
> string via `toPattern()` and then back via `new MessageFormat()` results in a
> format that is equivalent to the original.
>
> The quoting and escaping rules for `MessageFormat` pattern strings are really
> tricky
On Tue, 30 Jan 2024 09:08:28 GMT, Matthias Baesken wrote:
> On some Windows machines we see sometimes OOM errors because of high resource
> (memory/swap) consumption. This is especially seen when the jtreg runs have
> higher concurrency. A solution is to put the java/lang/StringBuilder tests in
On Tue, 30 Jan 2024 16:58:35 GMT, Per Minborg wrote:
>> This PR proposes to add an improved Improve
>> `LayoutPath.PathElement::toString` method simplifying debugging.
>>
>> Opinions and suggestions for `static PathElement sequenceElement(long start,
>> long step)` are welcome.
>
> Per Minborg
On Tue, 30 Jan 2024 13:56:53 GMT, Daniel Fuchs wrote:
>> This code change adds an alternative implementation of user-based
>> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
>> Depending on if the Security Manager is allowed, the methods store the
>> current subject
On Tue, 30 Jan 2024 14:19:02 GMT, Daniel Fuchs wrote:
>> src/java.management/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java
>> line 349:
>>
>>> 347: @SuppressWarnings("removal")
>>> 348: private Subject getSubject() {
>>> 349: return Subject.current();
>>
>
> This PR proposes to add an improved Improve
> `LayoutPath.PathElement::toString` method simplifying debugging.
>
> Opinions and suggestions for `static PathElement sequenceElement(long start,
> long step)` are welcome.
Per Minborg has updated the pull request incrementally with one additional
> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
> to `ZipEntry.externalAttributes`.
>
> This field was introduced in
> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
> the name `ZipEntry.posixPerms`.
> [JDK-8250968](https://bugs.openj
On Wed, 17 Jan 2024 23:41:53 GMT, Weijun Wang wrote:
> This code change adds an alternative implementation of user-based
> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
> Depending on if the Security Manager is allowed, the methods store the
> current subject diffe
On Tue, 30 Jan 2024 13:53:37 GMT, Daniel Fuchs wrote:
>> This code change adds an alternative implementation of user-based
>> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
>> Depending on if the Security Manager is allowed, the methods store the
>> current subject
> The testcase requires root permissions.
Jan Kratochvil has updated the pull request incrementally with one additional
commit since the last revision:
Remove unneeded jdk.test.lib.helpers.ClassFileInstaller
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17198/files
- new
On Fri, 12 Jan 2024 16:26:58 GMT, Severin Gehwolf wrote:
>> Jan Kratochvil has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix gtest testcases compilation errors
>
> test/hotspot/jtreg/containers/cgroup/NestedCgroup.java line 97:
>
>> 9
> The testcase requires root permissions.
Jan Kratochvil has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains ten additional
commits since the last revision
On Wed, 17 Jan 2024 23:41:53 GMT, Weijun Wang wrote:
> This code change adds an alternative implementation of user-based
> authorization `Subject` APIs that doesn't depend on Security Manager APIs.
> Depending on if the Security Manager is allowed, the methods store the
> current subject diffe
On Mon, 29 Jan 2024 23:53:08 GMT, Aggelos Biboudis
wrote:
>> This is the proposed patch for Primitive types in patterns, instanceof, and
>> switch (Preview).
>>
>> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
>
> Aggelos Biboudis has updated the pull request increment
On some Windows machines we see sometimes OOM errors because of high resource
(memory/swap) consumption. This is especially seen when the jtreg runs have
higher concurrency. A solution is to put the java/lang/StringBuilder tests in
the exclusiveAccess.dirs group so that they are not executed con
On Mon, 29 Jan 2024 16:16:00 GMT, Jan Lahoda wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove redundant null check and introduce a const boolean for
>> unconditionally exact pairs
>
> javac changes look
45 matches
Mail list logo
