On Mon, 29 Jan 2024 23:53:08 GMT, Aggelos Biboudis <abimpou...@openjdk.org> wrote:
>> This is the proposed patch for Primitive types in patterns, instanceof, and >> switch (Preview). >> >> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/ > > Aggelos Biboudis has updated the pull request incrementally with one > additional commit since the last revision: > > Address review by Jan test/jdk/java/lang/runtime/ExactnessConversionsSupportTest.java line 46: > 44: * @test > 45: * @bug 8304487 > 46: * @summary Compiler Implementation for Primitive types in patterns, > instanceof, and switch (Preview) While the bug synopsis isn't off-topic for the summary, the summary could be more informative, something like: "Verify boundary and special cases of exact conversion predicates", etc. test/jdk/java/lang/runtime/ExactnessConversionsSupportTest.java line 65: > 63: } > 64: > 65: public static void testByte() { If this test had the likelihood of needing to be updated, I would recommend some kind of refactoring so that the implicit loops ("for each of these boundary values in type T..") were explicit, but given that the test should not need to be updated often, I think the current approach is fine. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1471963476 PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1471968497
