> Add a few apiNote concerning source-level modifiers that are not represented
> in java.lang.reflect.Modifier.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Refine wording per review feedback.
-
Changes:
- all: https:
On Fri, 12 Jan 2024 07:22:09 GMT, Alan Bateman wrote:
> Just curious if this was found by inspection or when debugging some issue
> with LDAP authentication? Asking on whether it is feasible or not to have
> more tests in this area.
It was found by the code inspection.
-
PR Comme
On Thu, 11 Jan 2024 06:28:51 GMT, Sergey Bylokhov wrote:
> SaslInputStream.read() should return a value in the range from 0 to 255 per
> the spec of InputStream.read() but it returns the signed byte from the inBuf
> as is.
Just curious if this was found by inspection or when debugging some iss
Reviewed-by: Yi Yang
-
Commit messages:
- 8323640: [TESTBUG]testMemoryFailCount in
jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because
OOM killed
Changes: https://git.openjdk.org/jdk/pull/17386/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17386
On Thu, 11 Jan 2024 16:50:42 GMT, Alan Bateman wrote:
>> This test was recently dialled down via JDK-8323002 but it still makes slow
>> progress on some test machines, esp. macox-x64-debug builds. The issue is
>> that the sampling of the target thread is skewed towards the unmounted case
>> so
On Thu, 11 Jan 2024 22:56:38 GMT, Joe Wang wrote:
> Backport to fix the regression introduced in JDK 22.
This pull request has now been integrated.
Changeset: 46f1df38
Author:Joe Wang
URL:
https://git.openjdk.org/jdk22/commit/46f1df38a0f972333d7ff93a00c7eb6b14d3dfb9
Stats: 357 l
On Fri, 5 Jan 2024 09:07:57 GMT, Stefan Karlsson wrote:
>> Tests using ProcessTools.executeProcess gets the following output written to
>> stdout:
>> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
>> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process 25171
SaslInputStream.read() should return a value in the range from 0 to 255 per the
spec of InputStream.read() but it returns the signed byte from the inBuf as is.
-
Commit messages:
- 8323562: SaslInputStream.read() may return wrong value
Changes: https://git.openjdk.org/jdk/pull/1736
On Thu, 11 Jan 2024 06:28:51 GMT, Sergey Bylokhov wrote:
> SaslInputStream.read() should return a value in the range from 0 to 255 per
> the spec of InputStream.read() but it returns the signed byte from the inBuf
> as is.
I'll wait until GA will be fixed.
-
PR Comment: https://g
On Thu, 11 Jan 2024 22:56:38 GMT, Joe Wang wrote:
> Backport to fix the regression introduced in JDK 22.
Verified changes same as those in main-line.
-
Marked as reviewed by iris (Reviewer).
PR Review: https://git.openjdk.org/jdk22/pull/63#pullrequestreview-1817021441
On Thu, 11 Jan 2024 22:56:38 GMT, Joe Wang wrote:
> Backport to fix the regression introduced in JDK 22.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk22/pull/63#pullrequestreview-1817006707
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> BenchmarkScore
> Latest
Backport to fix the regression introduced in JDK 22.
-
Commit messages:
- Backport e4389d8dc224419b8c1ee08e9f2dea0f103c6845
Changes: https://git.openjdk.org/jdk22/pull/63/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=63&range=00
Issue: https://bugs.openjdk.org/browse/J
On Thu, 11 Jan 2024 18:19:15 GMT, Alexey Semenyuk wrote:
> Change the full path of a unit file passed to `systemctl enable` command to
> the unit file name. This prevents the command from creating a symlink in
> `/etc/systemd/system/` directory
This pull request has now been integrated.
Chang
On Thu, 11 Jan 2024 18:19:15 GMT, Alexey Semenyuk wrote:
> Change the full path of a unit file passed to `systemctl enable` command to
> the unit file name. This prevents the command from creating a symlink in
> `/etc/systemd/system/` directory
Marked as reviewed by almatvee (Reviewer).
-
On Thu, 11 Jan 2024 18:36:39 GMT, Joe Wang wrote:
> Fix a regression in the source resolution process where it failed to
> recognize a custom InputSource when both the public and system IDs are null.
> The particular issue is fixed at line 1233, the rest of the changes is
> formatting to make
Change the full path of a unit file passed to `systemctl enable` command to the
unit file name. This prevents the command from creating a symlink in
`/etc/systemd/system/` directory
-
Commit messages:
- empty
- Merge branch 'master' into JDK-8322799
- 8322799: Test JPKG003-013: S
On Thu, 11 Jan 2024 18:19:15 GMT, Alexey Semenyuk wrote:
> Change the full path of a unit file passed to `systemctl enable` command to
> the unit file name. This prevents the command from creating a symlink in
> `/etc/systemd/system/` directory
Fix looks good. I will approve once "Integration
On Thu, 11 Jan 2024 18:19:15 GMT, Alexey Semenyuk wrote:
> Change the full path of a unit file passed to `systemctl enable` command to
> the unit file name. This prevents the command from creating a symlink in
> `/etc/systemd/system/` directory
@sashamatveev please review
-
PR Co
On Fri, 23 Jun 2023 17:27:00 GMT, Pavel Rappo wrote:
> Please review this PR to use modern APIs and language features to simplify
> equals, hashCode, and compareTo for BigInteger. If you have any performance
> concerns, please raise them.
>
> This PR is cherry-picked from a bigger, not-yet-pub
> Fix a regression in the source resolution process where it failed to
> recognize a custom InputSource when both the public and system IDs are null.
> The particular issue is fixed at line 1233, the rest of the changes is
> formatting to make the null-check on InputSource the first.
>
> Test i
On Thu, 11 Jan 2024 20:35:33 GMT, Naoto Sato wrote:
> LGTM. If the file was modified this year, put 2024 in the header
Copyright year fixed. Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/17377#issuecomment-1887951201
On Wed, 3 Jan 2024 23:30:41 GMT, Justin Lu wrote:
> Please review this PR which splits up the _LocaleProvidersRun_ test file for
> performance and maintenance reasons.
>
> _LocaleProvidersRun_ which tests against the various Locale Providers (CLDR,
> HOST, SPI, etc.) was getting rather long, a
On Thu, 11 Jan 2024 18:36:39 GMT, Joe Wang wrote:
> Fix a regression in the source resolution process where it failed to
> recognize a custom InputSource when both the public and system IDs are null.
> The particular issue is fixed at line 1233, the rest of the changes is
> formatting to make
On Thu, 11 Jan 2024 19:30:09 GMT, Justin Lu wrote:
>> Please review this PR which implements toString() for the `Format`
>> subclasses. Corresponding CSR:
>> [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088)
>>
>> The general specification follows a template that provides the locale (
> Please review this PR which implements toString() for the `Format`
> subclasses. Corresponding CSR:
> [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088)
>
> The general specification follows a template that provides the locale (if the
> class is localized) and any relevant patterns. T
On Thu, 11 Jan 2024 09:40:07 GMT, Volker Simonis wrote:
> tryPresize(int size) is doing and if its size argument is supposed to contain
> the additional number of elements which will be inserted into the hash map or
> if it is a hint for the new total size of the hash map
Argument `size` for `
On Thu, 11 Jan 2024 18:36:39 GMT, Joe Wang wrote:
> Fix a regression in the source resolution process where it failed to
> recognize a custom InputSource when both the public and system IDs are null.
> The particular issue is fixed at line 1233, the rest of the changes is
> formatting to make
Fix a regression in the source resolution process where it failed to recognize
a custom InputSource when both the public and system IDs are null. The
particular issue is fixed at line 1233, the rest of the changes is formatting
to make the null-check on InputSource the first.
Test is provided b
On Thu, 11 Jan 2024 14:17:39 GMT, Erik Joelsson wrote:
>> In principle, I think tests should be executed from their corresponding
>> test-support directory. (I think there is some JBS issue for this that's
>> been around for some while.) The rationale is that this is a good directory
>> for an
On Fri, 17 Nov 2023 16:27:44 GMT, Tim Prinzing wrote:
> Updated to use ProcessTool helper class to run test passing flags.
This pull request has now been integrated.
Changeset: b78896b9
Author:Tim Prinzing
Committer: Mandy Chung
URL:
https://git.openjdk.org/jdk/commit/b78896b9aafcb
On Wed, 10 Jan 2024 17:02:05 GMT, Eirik Bjørsnøs wrote:
>> Sounds like a CSR is needed for the behavioral change proposed here.
>
>> Sounds like a CSR is needed for the behavioral change proposed here.
>
> Thanks for flagging this @jddarcy
>
> I'm personally not 100% convinced a CSR is warrant
On Thu, 11 Jan 2024 13:21:16 GMT, Jaikiran Pai wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Run in othervm mode
>
> test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java
> line 52:
>
>> 50:
> This test was recently dialled down via JDK-8323002 but it still makes slow
> progress on some test machines, esp. macox-x64-debug builds. The issue is
> that the sampling of the target thread is skewed towards the unmounted case
> so the target thread is disabled from being scheduled and does
On Thu, 11 Jan 2024 15:23:14 GMT, Jorn Vernee wrote:
>> Peter Levart has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move special-case check for equal segments to the instance method (more
>> probable)
>
> src/java.base/share/classes/jd
> I belive there is a bug in `AbstractMemorySegmentImpl#mismatch` method. It
> returns `-1` (meaning that regions are equal) when passing the same instance
> of MemorySegment as both `srcSegment` and `dstSegment` parameters regardless
> of whether `srcFromOffset` and `dstFromOffset` as well as `
On Thu, 11 Jan 2024 13:30:44 GMT, Peter Levart wrote:
>> I belive there is a bug in `AbstractMemorySegmentImpl#mismatch` method. It
>> returns `-1` (meaning that regions are equal) when passing the same instance
>> of MemorySegment as both `srcSegment` and `dstSegment` parameters regardless
>>
On Thu, 11 Jan 2024 14:17:39 GMT, Erik Joelsson wrote:
>> In principle, I think tests should be executed from their corresponding
>> test-support directory. (I think there is some JBS issue for this that's
>> been around for some while.) The rationale is that this is a good directory
>> for an
On Thu, 28 Dec 2023 15:19:23 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>
> Jan Kratochvil has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix gtest testcases compilation errors
I'm looking at it. Review should
On Thu, 11 Jan 2024 11:23:55 GMT, Magnus Ihse Bursie wrote:
> In principle, I think tests should be executed from their corresponding
> test-support directory. (I think there is some JBS issue for this that's been
> around for some while.) The rationale is that this is a good directory for
> a
On Thu, 11 Jan 2024 14:12:03 GMT, Alan Bateman wrote:
> There are intermittent states and the stack walk will depend on whether the
> target is mounted or not.
Thank you for that detail.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/17353#discussion_r1448930993
On Thu, 11 Jan 2024 13:49:14 GMT, Jaikiran Pai wrote:
>> This test was recently dialled down via JDK-8323002 but it still makes slow
>> progress on some test machines, esp. macox-x64-debug builds. The issue is
>> that the sampling of the target thread is skewed towards the unmounted case
>> so
On Wed, 10 Jan 2024 20:25:21 GMT, Alan Bateman wrote:
> This test was recently dialled down via JDK-8323002 but it still makes slow
> progress on some test machines, esp. macox-x64-debug builds. The issue is
> that the sampling of the target thread is skewed towards the unmounted case
> so the
> I belive there is a bug in `AbstractMemorySegmentImpl#mismatch` method. It
> returns `-1` (meaning that regions are equal) when passing the same instance
> of MemorySegment as both `srcSegment` and `dstSegment` parameters regardless
> of whether `srcFromOffset` and `dstFromOffset` as well as `
On Wed, 10 Jan 2024 20:25:21 GMT, Alan Bateman wrote:
> This test was recently dialled down via JDK-8323002 but it still makes slow
> progress on some test machines, esp. macox-x64-debug builds. The issue is
> that the sampling of the target thread is skewed towards the unmounted case
> so the
> The notification method `VirtualThread.notifyJvmtiDisableSuspend` should be
> static.
> The method disables/enables suspend of the current virtual thread, a no-op if
> the current thread is a platform thread. It is confusing for this to be an
> instance method, it should be static to make it c
On Wed, 10 Jan 2024 17:42:21 GMT, Weibing Xiao wrote:
> Better Error Handling for Jar Tool When Processing Non-existent Files.
>
> It needs to be backported to JDK22.
This pull request has now been integrated.
Changeset: 3daa936f
Author:Weibing Xiao
Committer: Jaikiran Pai
URL:
h
On Wed, 10 Jan 2024 13:18:17 GMT, Jorn Vernee wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [d2d58dd6](https://github.com/openjdk/jdk/commit/d2d58dd6a8ec366a4bc3eb12a253b252de24557e)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Wed, 10 Jan 2024 17:42:21 GMT, Weibing Xiao wrote:
> Better Error Handling for Jar Tool When Processing Non-existent Files.
>
> It needs to be backported to JDK22.
Clean backport of a P3 bug fix.
-
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk2
On Thu, 14 Dec 2023 11:04:09 GMT, Aggelos Biboudis
wrote:
>> This is the proposed patch for Primitive types in patterns, instanceof, and
>> switch (Preview).
>>
>> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
>
> Aggelos Biboudis has updated the pull request with a ne
On Wed, 10 Jan 2024 15:10:58 GMT, Claes Redestad wrote:
> JMH microbenchmarks may have dependencies on artifacts in the test image
> outside of the benchmarks.jar. This includes native libraries (built into
> `$TEST_IMAGE/micro/native`) and may soon include other test libraries like
> wb.jar (
On Wed, 1 Nov 2023 00:06:35 GMT, Leonid Mesnik wrote:
> Test thread factory is a mode similar to VM flags and should not be used in
> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
> createTestJavaProcessBuilder() should use it like jtreg VM options.
>
> Adding the test thread factor
On Thu, 11 Jan 2024 10:34:45 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals, hashCode, and compareTo for BigInteger. If you have any performance
>> concerns, please raise them.
>>
>> This PR is cherry-picked from a bigger, not-ye
> Please review this PR to use modern APIs and language features to simplify
> equals, hashCode, and compareTo for BigInteger. If you have any performance
> concerns, please raise them.
>
> This PR is cherry-picked from a bigger, not-yet-published PR, to test the
> waters. That latter PR will b
On Thu, 28 Dec 2023 15:19:23 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>
> Jan Kratochvil has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix gtest testcases compilation errors
ping, are there some concerns dur
On Mon, 8 Jan 2024 20:27:59 GMT, Joshua Cao wrote:
> We don't need to compute max() here.
> [tryPresize()](https://github.com/openjdk/jdk/blob/8a4dc79e1a40e7115e2971af81623b6b0368f41c/src/java.base/share/classes/java/util/concurrent/ConcurrentHashMap.java#L2397)
> does that already.
The code y
On Wed, 10 Jan 2024 10:17:10 GMT, Pavel Rappo wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implement review feedback.
>
> src/java.base/share/classes/java/lang/reflect/Modifier.java line 238:
>
>> 236: * modi
On Wed, 10 Jan 2024 20:30:26 GMT, Alan Bateman wrote:
> Updated version looks much better.
Thanks @AlanBateman!
-
PR Comment: https://git.openjdk.org/jdk/pull/17082#issuecomment-1886591099
On Tue, 12 Dec 2023 15:13:01 GMT, Viktor Klang wrote:
> While this might not fix 8314515, it should at least make it more exact.
This pull request has now been integrated.
Changeset: 35e96627
Author:Viktor Klang
URL:
https://git.openjdk.org/jdk/commit/35e9662767cc0a1dea9b5afa2a6d61a
On Tue, 9 Jan 2024 23:40:35 GMT, Naoto Sato wrote:
>> Adding an explanation of the locale-related system properties in the
>> `System.getProperties()` method. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase
> This PR proposes to add a clarification that an `Arena` always returns
> zeroed-out segments for `Arena::allocate` methods.
>
> Note that other overloaded methods refer to the abstract `Arena::allocate`
> method via implementation notes.
Per Minborg has updated the pull request incrementally
61 matches
Mail list logo
