On Wed, 3 Jan 2024 23:30:41 GMT, Justin Lu <j...@openjdk.org> wrote: > Please review this PR which splits up the _LocaleProvidersRun_ test file for > performance and maintenance reasons. > > _LocaleProvidersRun_ which tests against the various Locale Providers (CLDR, > HOST, SPI, etc.) was getting rather long, as all related bugs were added to > the single test file. To improve maintainability, this change splits up the > single test file into separate test files focused on specific areas (ex: > _j.text.Format_). The original _LocaleProvidersRun_ test file remains and is > used for more general Locale Provider testing such as the adapter loading. > > In addition, the previously single test file used to suffer from performance > issues, as each test method had to launch a new JVM (since Locale Providers > are set at Java startup time). With this change, these tests files can be ran > with VM flags and not cause timeout, thus `@requires vm.flagless` is no > longer needed (Tiers 6-8 tested). > > Other updates > - For OS/locale specific tests, the OS/locale is now checked before (not > after) launching a JVM > - Added comments for each test method
This pull request has now been integrated. Changeset: 4ea7b364 Author: Justin Lu <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/4ea7b36447ea96d62b1ca164c34e2b2b74a16579 Stats: 569 lines in 8 files changed: 425 ins; 85 del; 59 mod 8322235: Split up and improve LocaleProvidersRun Reviewed-by: naoto ------------- PR: https://git.openjdk.org/jdk/pull/17257
