Hello David,
testing the gatherer api, I also wanted a "window" operation as the one you are
describing.
My use cases is a text file with some sections containing items organized like
this
:section1
item1
item2
item3
:section2
item1
item2
...
For me the signature of such method, win
On Tue, 9 Jan 2024 22:16:59 GMT, Mandy Chung wrote:
> This pull request contains a backport of commit
> [f3be138e](https://github.com/openjdk/jdk/commit/f3be138eb80c9e7f6cc21afb75cda9e49b667c8a)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being backported w
backported from jdk mainline "as is" without any modifications.
-
Commit messages:
- Backport 176606d0cb9117ca9080261f898cd57339fa5a85
Changes: https://git.openjdk.org/jdk22/pull/49/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=49&range=00
Issue: https://bugs.openjdk.o
And this may also be better named as a split method instead of the long
conditionalWindowFixed.
On Wed, Jan 10, 2024 at 1:17 AM David Alayachew
wrote:
> Oh, I made a mistake. Let me try it again.
>
> If the predicate is true, add the element to the current list (create list
> prior if needed). E
Oh, I made a mistake. Let me try it again.
If the predicate is true, add the element to the current list (create list
prior if needed). Else if the predicate is false, send the list down to the
stream, then add the element to a new list (the new current list, if you
will).
On Wed, Jan 10, 2024 a
Hello Core Libs Dev Team,
I have been reading through JEP 461 (https://openjdk.org/jeps/461) about
Gatherers, and I'm really excited for what this will enable for us.
By far, the most important functionality that this API facilitates is the
ability to create windows. Anytime I needed a window, I
Add a few apiNote concerning source-level modifiers that are not represented in
java.lang.reflect.Modifier.
-
Commit messages:
- JDK-8322979: Add informative discussion to Modifier
Changes: https://git.openjdk.org/jdk/pull/17338/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&
On Tue, 9 Jan 2024 11:08:39 GMT, Viktor Klang wrote:
>> As per conversation in the issue.
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Updating copyright year for zgc and zgc-gen problem lists
> - Removing OOMEInAQS f
On Tue, 9 Jan 2024 11:08:39 GMT, Viktor Klang wrote:
>> As per conversation in the issue.
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Updating copyright year for zgc and zgc-gen problem lists
> - Removing OOMEInAQS f
On Tue, 9 Jan 2024 23:55:30 GMT, Naoto Sato wrote:
> Backporting the document clarification to JDK22
Confirmed that this change corresponds to the changes in main-line and the
previously approved CSR.
-
Marked as reviewed by iris (Reviewer).
PR Review: https://git.openjdk.org/jdk
Backporting the document clarification to JDK22
-
Commit messages:
- Backport 376051a9be95e0e4acf3c59d0eba3e9ef8727d79
Changes: https://git.openjdk.org/jdk22/pull/47/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=47&range=00
Issue: https://bugs.openjdk.org/browse/JDK-83
> Adding an explanation of the locale-related system properties in the
> `System.getProperties()` method. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 18 commits:
- Merge branch
On Tue, 9 Jan 2024 20:06:10 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/lang/System.java line 819:
>>
>>> 817: *
>>> 818: * Additional locale-related system properties defined by the
>>> 819: * {@link Locale##default_locale Default Locale} section in the
>>> {@co
On Wed, 20 Dec 2023 21:28:04 GMT, Serguei Spitsyn wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [0f8e4e0a](https://github.com/openjdk/jdk/commit/0f8e4e0a81257c678e948c341a241dc0b810494f)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Mon, 11 Dec 2023 18:54:25 GMT, Naoto Sato wrote:
> This is a doc change to clarify what the `Default Locale` is, and how it is
> established during the system startup using the system properties. Those
> locale-related system properties have existed since the early days of Java,
> but have
On Tue, 9 Jan 2024 19:27:12 GMT, Justin Lu wrote:
> Please review this PR which is the backport of the ISO 4217 Amendment 176
> Update. Commit
> [8b24851b](https://github.com/openjdk/jdk/commit/8b24851b9d3619c41c7a6cdb9193ed26a9b732dc)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repo
This pull request contains a backport of commit
[f3be138e](https://github.com/openjdk/jdk/commit/f3be138eb80c9e7f6cc21afb75cda9e49b667c8a)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Mandy Chung on 9 Jan 2024 and was
reviewed by Al
On Tue, 9 Jan 2024 10:22:40 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests that `Files.setPosixPermissions`as implemented by
>> `ZipFileSystem` should preserve the leading seven bits of the 'external file
>> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
>> and 'sti
On Tue, 9 Jan 2024 00:17:48 GMT, Mandy Chung wrote:
> One optimization of Jlink SystemModulesPlugin pre-resolves the module graph
> for modules with a main class. It stores the name of the initial module and
> the generated `SystemModules` class name in two arrays that can be obtained
> from
> As recently discussed on core libs, sealed-ness information could be included
> in the Class.toGenericString() output, analagous to how "modifiers" that also
> correspond to JVM access flags are handled.
>
> This is the initial spec, implementation, and test updated needed for that
> change.
On Mon, 13 Nov 2023 18:11:12 GMT, Alan Bateman wrote:
>> That would probably also involve taking existing documentation such as the
>> note about not opening entries with "."/"..", and the POSIX permissions
>> mappings? Would it make sense to split the rest of the changes in this PR
>> from th
On Wed, 22 Nov 2023 22:23:18 GMT, Yakov Shafranovich wrote:
>> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 77:
>>
>>> 75: *
>>> 76: * Whenever possible, {@linkplain ZipFile} should be used for parsing
>>> ZIP
>>> 77: * archives since it correctly reads data from the ce
> The various Zip/Jar-file related Java APIs have some long-standing
> differences or peculiarities with respect to the ZIP-file specification or
> compared to other implementations which should be documented in the API-doc.
> This documents the following:
> - Cache of JAR files in JarURLConnect
On Tue, 9 Jan 2024 19:23:53 GMT, Naoto Sato wrote:
>> Adding an explanation of the locale-related system properties in the
>> `System.getProperties()` method. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since th
On Tue, 9 Jan 2024 19:23:53 GMT, Naoto Sato wrote:
>> Adding an explanation of the locale-related system properties in the
>> `System.getProperties()` method. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since th
On Tue, 9 Jan 2024 19:23:53 GMT, Naoto Sato wrote:
>> Adding an explanation of the locale-related system properties in the
>> `System.getProperties()` method. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since th
On Tue, 9 Jan 2024 20:01:28 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/java/lang/System.java line 819:
>
>> 817: *
>> 818: * Add
On Tue, 9 Jan 2024 19:23:53 GMT, Naoto Sato wrote:
>> Adding an explanation of the locale-related system properties in the
>> `System.getProperties()` method. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since th
On Tue, 9 Jan 2024 19:23:53 GMT, Naoto Sato wrote:
>> Adding an explanation of the locale-related system properties in the
>> `System.getProperties()` method. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since th
On Tue, 9 Jan 2024 19:37:54 GMT, Joe Darcy wrote:
>> As recently discussed on core libs, sealed-ness information could be
>> included in the Class.toGenericString() output, analagous to how "modifiers"
>> that also correspond to JVM access flags are handled.
>>
>> This is the initial spec, imp
On Tue, 9 Jan 2024 19:27:12 GMT, Justin Lu wrote:
> Please review this PR which is the backport of the ISO 4217 Amendment 176
> Update. Commit
> [8b24851b](https://github.com/openjdk/jdk/commit/8b24851b9d3619c41c7a6cdb9193ed26a9b732dc)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repo
On Tue, 9 Jan 2024 19:27:12 GMT, Justin Lu wrote:
> Please review this PR which is the backport of the ISO 4217 Amendment 176
> Update. Commit
> [8b24851b](https://github.com/openjdk/jdk/commit/8b24851b9d3619c41c7a6cdb9193ed26a9b732dc)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repo
Please review this PR which is the backport of the ISO 4217 Amendment 176
Update. Commit
[8b24851b](https://github.com/openjdk/jdk/commit/8b24851b9d3619c41c7a6cdb9193ed26a9b732dc)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
-
Commit messages:
- Backport 8b24851
> As recently discussed on core libs, sealed-ness information could be included
> in the Class.toGenericString() output, analagous to how "modifiers" that also
> correspond to JVM access flags are handled.
>
> This is the initial spec, implementation, and test updated needed for that
> change.
On Tue, 9 Jan 2024 19:02:39 GMT, Iris Clark wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/java/lang/System.java line 818:
>
>> 816: * {@link #getProper
> Adding an explanation of the locale-related system properties in the
> `System.getProperties()` method. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflects review comments
-
On Tue, 9 Jan 2024 00:51:28 GMT, Naoto Sato wrote:
> Adding an explanation of the locale-related system properties in the
> `System.getProperties()` method. Corresponding CSR has also been drafted.
src/java.base/share/classes/java/lang/System.java line 818:
> 816: * {@link #getProperty(St
On Mon, 8 Jan 2024 15:28:50 GMT, Adam Sotona wrote:
>> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy
>> classes.
>>
>> This patch converts it to use Classfile API.
>>
>> It is continuation of https://github.com/openjdk/jdk/pull/10991
>>
>> Any comments and suggestions
On Mon, 8 Jan 2024 18:20:09 GMT, Brian Burkhalter wrote:
> Do you have any benchmark results demonstrating the increased throughput?
I just uploaded a class for random tests. But during the execution, I've found
a non banal problem concerning the old implementation's running time.
The problem i
On Tue, 9 Jan 2024 10:42:58 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java
>> line 87:
>>
>>> 85: }
>>> 86: if (cl.isEnum()) {
>>> 87: commitEvent(cl, SUID_NAME + " in an enum class is not
>>> effectiv
> The method `MutableBigInteger.divWord(long, int)` can use the algorithm of
> Hacker's Delight (2nd ed), section 9.3, the same used in
> `Long.divideUnsigned(long, long)` and `Long.remainderUnsigned(long, long)`,
> to get the computation faster.
fabioromano1 has updated the pull request increm
Adding an explanation of the locale-related system properties in the
`System.getProperties()` method. Corresponding CSR has alos been drafted.
-
Depends on: https://git.openjdk.org/jdk/pull/17065
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/17317/fil
On Tue, 9 Jan 2024 18:13:43 GMT, Mandy Chung wrote:
>> One optimization of Jlink SystemModulesPlugin pre-resolves the module graph
>> for modules with a main class. It stores the name of the initial module and
>> the generated `SystemModules` class name in two arrays that can be obtained
>> f
> The method `MutableBigInteger.divWord(long, int)` can use the algorithm of
> Hacker's Delight (2nd ed), section 9.3, the same used in
> `Long.divideUnsigned(long, long)` and `Long.remainderUnsigned(long, long)`,
> to get the computation faster.
fabioromano1 has updated the pull request with a
> One optimization of Jlink SystemModulesPlugin pre-resolves the module graph
> for modules with a main class. It stores the name of the initial module and
> the generated `SystemModules` class name in two arrays that can be obtained
> from `SystemModulesMap::moduleNames` and `SystemModulesMap:
> One optimization of Jlink SystemModulesPlugin pre-resolves the module graph
> for modules with a main class. It stores the name of the initial module and
> the generated `SystemModules` class name in two arrays that can be obtained
> from `SystemModulesMap::moduleNames` and `SystemModulesMap:
On Fri, 5 Jan 2024 17:05:04 GMT, Dan Lutker wrote:
> Clean backport tzdata 2023d.
> `make test TEST="test/jdk/java/util/TimeZone test/jdk/java/time/test
> test/jdk/sun/util/resources test/jdk/sun/text/resources
> test/jdk/sun/util/calendar"` is all passing
This pull request has now been integr
On Fri, 5 Jan 2024 17:05:04 GMT, Dan Lutker wrote:
> Clean backport tzdata 2023d.
> `make test TEST="test/jdk/java/util/TimeZone test/jdk/java/time/test
> test/jdk/sun/util/resources test/jdk/sun/text/resources
> test/jdk/sun/util/calendar"` is all passing
Marked as reviewed by iris (Reviewer)
On Fri, 5 Jan 2024 17:05:04 GMT, Dan Lutker wrote:
> Clean backport tzdata 2023d.
> `make test TEST="test/jdk/java/util/TimeZone test/jdk/java/time/test
> test/jdk/sun/util/resources test/jdk/sun/text/resources
> test/jdk/sun/util/calendar"` is all passing
LGTM. Thanks for the backport.
-
On Tue, 9 Jan 2024 08:10:16 GMT, Per Minborg wrote:
> 8321786: SegmentAllocator:allocateFrom(ValueLayout,
> MemorySegment,ValueLayout,long,long) spec mismatch in exception scenario
src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 1944:
> 1942: * in the provide
On Tue, 9 Jan 2024 10:06:29 GMT, Alan Bateman wrote:
>> One optimization of Jlink SystemModulesPlugin pre-resolves the module graph
>> for modules with a main class. It stores the name of the initial module and
>> the generated `SystemModules` class name in two arrays that can be obtained
>>
On Tue, 9 Jan 2024 13:06:56 GMT, Eirik Bjørsnøs wrote:
>> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
>> number of compressed or uncompressed bytes read from the inflater is larger
>> than the Zip64 magic value.
>>
>> While the ZIP format mandates that the data des
On Tue, 9 Jan 2024 14:18:37 GMT, Jorn Vernee wrote:
> The issue with this test, and the test of JDK-8322324, seems to be that the
> forked processes write to stderr/stdout, without this output being read
> before the process terminates. The buffer might fill up if the output is not
> being rea
On Tue, 2 Jan 2024 14:37:27 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals, hashCode, and compareTo for BigInteger. If you have any performance
>> concerns, please raise them.
>>
>> This PR is cherry-picked from a bigger, not-yet
> Hi,
>
> Patch optimizes non-subword vector compress and expand APIs for x86 AVX2 only
> targets.
> Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2
> instruction set.
> These are very frequently used APIs in columnar database filter operation.
>
> Implementation uses a
On Mon, 8 Jan 2024 15:43:34 GMT, Jaikiran Pai wrote:
> The crucial part here is that the "current" `ZipEntry` is the one which was
> created by a previous call to `ZipInputStream.getNextEntry()` method, which
> is a public overridable method. Furthermore, the `ZipEntry.getExtra()` method
> too
On Tue, 2 Jan 2024 14:37:27 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals, hashCode, and compareTo for BigInteger. If you have any performance
>> concerns, please raise them.
>>
>> This PR is cherry-picked from a bigger, not-yet
On Mon, 8 Jan 2024 15:04:58 GMT, Jaikiran Pai wrote:
>> Eirik Bjørsnøs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 33 commits:
>>
>> - Merge branch 'master' into data-descriptor
>> - Extract ZIP64_BLOCK_SIZE_OFFSET as a cons
The issue with this test, and the test of JDK-8322324, seems to be that the
forked processes write to stderr/stdout, without this output being read before
the process terminates. The buffer might fill up if the output is not being
read, which means that the process will stall when writing (see s
On Thu, 21 Dec 2023 15:21:08 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Mon, 8 Jan 2024 22:29:47 GMT, Joe Darcy wrote:
>>> Since it doesn't seem possible to do so, I did not attempt to relay
>>> "non-sealed" information in this PR :-)
>>
>> Naively, I thought that something like this is possible _in principle_; I
>> might be mistaken though:
>>
>> diff --git a
On Mon, 8 Jan 2024 20:48:39 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Tue, 9 Jan 2024 10:22:40 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests that `Files.setPosixPermissions`as implemented by
>> `ZipFileSystem` should preserve the leading seven bits of the 'external file
>> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
>> and 'sti
On Tue, 9 Jan 2024 06:13:44 GMT, Jatin Bhateja wrote:
>> Yes, IF it is vectorized, then there is no difference between high and low
>> density. My concern was more if vectorization is preferrable over the scalar
>> alternative in the low-density case, where branch prediction is more stable.
>
>
On Mon, 8 Jan 2024 06:23:46 GMT, Jatin Bhateja wrote:
>> Hi,
>>
>> Patch optimizes non-subword vector compress and expand APIs for x86 AVX2
>> only targets.
>> Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2
>> instruction set.
>> These are very frequently used APIs in
On Tue, 9 Jan 2024 13:30:58 GMT, Adam Sotona wrote:
>> ClassFile API performance related improvements have been separated from
>> #17121 into this PR.
>>
>> These improvements are important to minimize performance regression of
>> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to u
> ClassFile API performance related improvements have been separated from
> #17121 into this PR.
>
> These improvements are important to minimize performance regression of
> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the
> Classfile API to generate proxy classes #17121
>
On Mon, 8 Jan 2024 14:59:40 GMT, Jaikiran Pai wrote:
>> Eirik Bjørsnøs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 33 commits:
>>
>> - Merge branch 'master' into data-descriptor
>> - Extract ZIP64_BLOCK_SIZE_OFFSET as a cons
> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
> number of compressed or uncompressed bytes read from the inflater is larger
> than the Zip64 magic value.
>
> While the ZIP format mandates that the data descriptor `SHOULD be stored in
> ZIP64 format (as 8 byte values
On Tue, 9 Jan 2024 04:15:38 GMT, Jaikiran Pai wrote:
>> As per conversation in the issue.
>
> Hello Viktor, the skara bot very helpfully has noted that this test has been
> problemlisted in a couple of files:
>
>> 8309218 is used in problem lists: [test/jdk/ProblemList-zgc.txt,
>> test/jdk/Pro
> As per conversation in the issue.
Viktor Klang has updated the pull request incrementally with two additional
commits since the last revision:
- Updating copyright year for zgc and zgc-gen problem lists
- Removing OOMEInAQS from zgc and zgc-gen problem lists
-
Changes:
- all:
On Mon, 8 Jan 2024 18:15:36 GMT, Roger Riggs wrote:
>> Raffaello Giulietti has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 15
>> additional comm
On Mon, 8 Jan 2024 18:38:52 GMT, Roger Riggs wrote:
>> Raffaello Giulietti has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 15
>> additional comm
On Tue, 9 Jan 2024 10:22:40 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests that `Files.setPosixPermissions`as implemented by
>> `ZipFileSystem` should preserve the leading seven bits of the 'external file
>> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
>> and 'sti
> This PR suggests that `Files.setPosixPermissions`as implemented by
> `ZipFileSystem` should preserve the leading seven bits of the 'external file
> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
> and 'sticky' bits. These are unrelated to permissions and should not
On Tue, 28 Nov 2023 12:18:23 GMT, Ryan Wallace wrote:
>> Hi all,
>>
>> Please review this fix for jar tool not producing an archive if there is a
>> missing file supplied.
>> The current behaviour will recognise missing files as an error but continue
>> processing,
>> creating a temporary arch
On Tue, 9 Jan 2024 00:17:48 GMT, Mandy Chung wrote:
> One optimization of Jlink SystemModulesPlugin pre-resolves the module graph
> for modules with a main class. It stores the name of the initial module and
> the generated `SystemModules` class name in two arrays that can be obtained
> from
> ClassFile API performance related improvements have been separated from
> #17121 into this PR.
>
> These improvements are important to minimize performance regression of
> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the
> Classfile API to generate proxy classes #17121
>
8321786: SegmentAllocator:allocateFrom(ValueLayout,
MemorySegment,ValueLayout,long,long) spec mismatch in exception scenario
-
Commit messages:
- Backport 7edd10e5fa71dafbbad2343b7f5ff0a75ac9
Changes: https://git.openjdk.org/jdk22/pull/42/files
Webrev: https://webrevs.openjdk.
79 matches
Mail list logo
