On Tue, 26 Sep 2023 09:40:11 GMT, Matthias Baesken wrote:
> AIX currently does not have the jdk.jpackage system module. We have to take
> this into account for these jpackage tests.
This pull request has now been integrated.
Changeset: b659e034
Author:Matthias Baesken
URL:
https://
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote:
>> AIX currently does not have the jdk.jpackage system module. We have to take
>> this into account for these jpackage tests.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last rev
Remove cases of redundant type arguments in the java.util.stream package.
-
Commit messages:
- Remove redundant type arguments.
Changes: https://git.openjdk.org/jdk/pull/15936/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15936&range=00
Issue: https://bugs.openjdk.org/br
On Tue, 19 Sep 2023 14:30:18 GMT, 温绍锦 wrote:
>> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
>> were discussed.
>>
>> But if the input is byte[], using lookup table can improve performance.
>>
>> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(
On Tue, 19 Sep 2023 14:30:18 GMT, 温绍锦 wrote:
>> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
>> were discussed.
>>
>> But if the input is byte[], using lookup table can improve performance.
>>
>> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(
On Tue, 26 Sep 2023 22:27:55 GMT, Naoto Sato wrote:
>> Some CLDR locales have partial list patterns, such as only the "end"
>> pattern, and expect "start" and "middle" patterns to be inherited from
>> parent locales. Made the code capable of the inheritance.
>
> Naoto Sato has updated the pull
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the followin
On Tue, 26 Sep 2023 18:44:01 GMT, Paul Sandoz wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix typos
>
> src/java.base/share/classes/java/lang/Module.java line 328:
>
>> 326: System.err.printf(""
On Tue, 26 Sep 2023 21:59:35 GMT, Paul Sandoz wrote:
> In the implementation the functional interfaces
> `BindingInterpreter.StoreFunc/LoadFunc` are package private, but are used in
> internal public signatures. This was previously like this and it's not a big
> deal but i recommend making tho
On Tue, 26 Sep 2023 21:28:43 GMT, Paul Sandoz wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix typos
>
> src/java.base/share/classes/java/lang/foreign/Linker.java line 35:
>
>> 33:
>> 34: import java.lang.invok
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and ForkJ
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull request incrementally w
> Some CLDR locales have partial list patterns, such as only the "end" pattern,
> and expect "start" and "middle" patterns to be inherited from parent locales.
> Made the code capable of the inheritance.
Naoto Sato has updated the pull request incrementally with one additional
commit since the
On Mon, 25 Sep 2023 16:54:10 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
Some CLDR locales have partial list patterns, such as only the "end" pattern,
and expect "start" and "middle" patterns to be inherited from parent locales.
Made the code capable of the inheritance.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/15935
On Mon, 25 Sep 2023 16:54:10 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Mon, 25 Sep 2023 16:54:10 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote:
>> AIX currently does not have the jdk.jpackage system module. We have to take
>> this into account for these jpackage tests.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last rev
On Mon, 25 Sep 2023 16:54:10 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Mon, 25 Sep 2023 16:54:10 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
On Tue, 19 Sep 2023 14:30:18 GMT, 温绍锦 wrote:
>> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
>> were discussed.
>>
>> But if the input is byte[], using lookup table can improve performance.
>>
>> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote:
>> AIX currently does not have the jdk.jpackage system module. We have to take
>> this into account for these jpackage tests.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last rev
On Tue, 26 Sep 2023 16:23:58 GMT, Roger Riggs wrote:
>> Aleksei Voitylov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review comments
>
>> test/jdk/java/lang/String/RegionMatches.java was converted to testng and
>> split into
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000: Mo
On Tue, 26 Sep 2023 17:03:00 GMT, Roger Riggs wrote:
> The timing of the test can be disturbed by -Xcomp so do not run with -Xcomp.
> The problem appears with the Graal compiler but may also occur on other
> platforms.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://
The timing of the test can be disturbed by -Xcomp so do not run with -Xcomp.
The problem appears with the Graal compiler but may also occur on other
platforms.
-
Commit messages:
- 8315721: CloseRace.java#id0 fails transiently on libgraal
Changes: https://git.openjdk.org/jdk/pull/1
On Tue, 26 Sep 2023 16:18:09 GMT, Aleksei Voitylov
wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with
>> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
>> default. The fix is to return true immediately if len is negative, since for
>>
On Tue, 26 Sep 2023 14:29:05 GMT, Roger Riggs wrote:
>> Aleksei Voitylov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/java.base/share/classes/java/lang/String.java
>>
>> Co-authored-by: Raffaello Giulietti
>
> src/jav
> test java.lang.String.RegionMatches1Tests fails on all platforms with
> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
> default. The fix is to return true immediately if len is negative, since for
> negative length this condition will never be satisfied.
>
> Tes
On Tue, 26 Sep 2023 14:19:55 GMT, Technici4n wrote:
> Fixes the issue (hopefully) by resolving automatic modules and automatic
> module dependencies after propagation of non-automatic transitive
> dependencies. The module tests run.
>
> I also added a few asserts to validate that the automatic
On Tue, 26 Sep 2023 14:19:55 GMT, Technici4n wrote:
> Fixes the issue (hopefully) by resolving automatic modules and automatic
> module dependencies after propagation of non-automatic transitive
> dependencies. The module tests run.
>
> I also added a few asserts to validate that the automatic
On Tue, 26 Sep 2023 14:19:55 GMT, Technici4n wrote:
> Fixes the issue (hopefully) by resolving automatic modules and automatic
> module dependencies after propagation of non-automatic transitive
> dependencies. The module tests run.
>
> I also added a few asserts to validate that the automatic
> This PR finalizes the feature of unnamed variables and patterns.
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit mess
On Mon, 25 Sep 2023 17:05:49 GMT, Jan Lahoda wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review by @lahodaj
>
> test/langtools/tools/javac/diags/examples/UnderscoreInLambdaExpression.java
> line 24
On Tue, 26 Sep 2023 14:06:56 GMT, Aleksei Voitylov
wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with
>> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
>> default. The fix is to return true immediately if len is negative, since for
>>
Fixes the issue (hopefully) by resolving automatic modules and automatic module
dependencies after propagation of non-automatic transitive dependencies. The
module tests run.
I also added a few asserts to validate that the automatic modules don't read
themselves (previously this was the case wi
Since the tests are now TestNG, I think it would make more sense to use
TestNG `assertTrue` rather than using explicit `if`s and `throw`s.
On 2023-09-26 16:09, Aleksei Voitylov wrote:
On Tue, 26 Sep 2023 12:38:46 GMT, Aleksei Voitylov
wrote:
test java.lang.String.RegionMatches1Tests fails
On Fri, 8 Sep 2023 14:17:29 GMT, Aggelos Biboudis
wrote:
> This is the first draft of a patch for Primitive types in patterns,
> instanceof, and switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html
src/java.base/
On Tue, 26 Sep 2023 12:38:46 GMT, Aleksei Voitylov
wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with
>> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
>> default. The fix is to return true immediately if len is negative, since for
>>
> test java.lang.String.RegionMatches1Tests fails on all platforms with
> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
> default. The fix is to return true immediately if len is negative, since for
> negative length this condition will never be satisfied.
>
> Tes
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote:
>> AIX currently does not have the jdk.jpackage system module. We have to take
>> this into account for these jpackage tests.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last rev
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote:
>> AIX currently does not have the jdk.jpackage system module. We have to take
>> this into account for these jpackage tests.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last rev
On Tue, 26 Sep 2023 13:10:15 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> PreviewFeature annotated with JEP 457
>
> src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 82:
>
>
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Tue, 26 Sep 2023 12:38:46 GMT, Aleksei Voitylov
wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with
>> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
>> default. The fix is to return true immediately if len is negative, since for
>>
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote:
>> AIX currently does not have the jdk.jpackage system module. We have to take
>> this into account for these jpackage tests.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last rev
> test java.lang.String.RegionMatches1Tests fails on all platforms with
> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
> default. The fix is to return true immediately if len is negative, since for
> negative length this condition will never be satisfied.
>
> Tes
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR goe
> AIX currently does not have the jdk.jpackage system module. We have to take
> this into account for these jpackage tests.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
remove added blank lines
-
Changes:
- all
On Tue, 26 Sep 2023 09:40:11 GMT, Matthias Baesken wrote:
> AIX currently does not have the jdk.jpackage system module. We have to take
> this into account for these jpackage tests.
Thanks for the hint, adding the module info to TEST.properties works too.
-
PR Comment: https://git
> AIX currently does not have the jdk.jpackage system module. We have to take
> this into account for these jpackage tests.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
move module info to TEST.properties
-
Chang
On Mon, 25 Sep 2023 16:59:30 GMT, Jan Lahoda wrote:
>> This PR finalizes the feature of unnamed variables and patterns.
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Chan
On Tue, 26 Sep 2023 09:53:08 GMT, Jaikiran Pai wrote:
>> AIX currently does not have the jdk.jpackage system module. We have to take
>> this into account for these jpackage tests.
>
> test/jdk/tools/jpackage/junit/jdk.jpackage/jdk/jpackage/internal/AppImageFileTest.java
> line 26:
>
>> 24: /*
On Tue, 26 Sep 2023 09:40:11 GMT, Matthias Baesken wrote:
> AIX currently does not have the jdk.jpackage system module. We have to take
> this into account for these jpackage tests.
Instead of adding those directives to all 11 files, can you please try adding
`modules = ...` line to the associ
On Tue, 26 Sep 2023 09:40:11 GMT, Matthias Baesken wrote:
> AIX currently does not have the jdk.jpackage system module. We have to take
> this into account for these jpackage tests.
test/jdk/tools/jpackage/junit/jdk.jpackage/jdk/jpackage/internal/AppImageFileTest.java
line 26:
> 24: /*
> 25:
On Wed, 13 Sep 2023 09:48:00 GMT, Adam Sotona wrote:
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and t
AIX currently does not have the jdk.jpackage system module. We have to take
this into account for these jpackage tests.
-
Commit messages:
- JDK-8316897
Changes: https://git.openjdk.org/jdk/pull/15916/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15916&range=00
Issue: h
Classfile API is an internal library under package `jdk.internal.classfile` in
JDK 21.
This pull request turns the Classfile API into a preview feature and moves it
into `java.lang.classfile`.
It repackages all uses across JDK and tests and adds lots of missing Javadoc.
This PR goes in sync with
On Mon, 25 Sep 2023 20:25:41 GMT, Brian Burkhalter wrote:
>> On Windows, do not return `true` from the `java.io.File` methods
>> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
>> file does not exist.
>
> Brian Burkhalter has updated the pull request incrementally w
60 matches
Mail list logo
