Since the tests are now TestNG, I think it would make more sense to use
TestNG `assertTrue` rather than using explicit `if`s and `throw`s.
On 2023-09-26 16:09, Aleksei Voitylov wrote:
On Tue, 26 Sep 2023 12:38:46 GMT, Aleksei Voitylov <avoity...@openjdk.org>
wrote:
test java.lang.String.RegionMatches1Tests fails on all platforms with
-XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
default. The fix is to return true immediately if len is negative, since for
negative length this condition will never be satisfied.
Testing: JCK, JTREG passed with the fix with -XX:-CompactStrings on x86_64 and
on ARM32.
Aleksei Voitylov has updated the pull request incrementally with one additional
commit since the last revision:
add regression test
@rgiulietti @simonis @AlanBateman thank you for the suggestions!
test/jdk/java/lang/String/RegionMatches.java was converted to testng and split
into two @Tests, the latter now covers 8316879.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15906#issuecomment-1735615353
