> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the same time, performance is likely improved
> because t
> `LocalVariable` and `LocalVariableType` includes `writeTo(BufWriter)`, which
> should be implementation details.
>
> See
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html
> for context.
>
> This patch moves the implementation to `DirectCodeBuilder`'s original use
On Tue, 19 Sep 2023 22:49:36 GMT, Naoto Sato wrote:
> Fixing a test case that fails in some time zones. Making sure the test is run
> in `UTC` zone will fix the issue. Confirmed the fix by manually setting
> machine's time zone to Europe/Dublin.
Hello Naoto, the use of `UTC` looks good to me.
On Tue, 19 Sep 2023 21:45:13 GMT, Brian Burkhalter wrote:
>> Add a `finally` block to delete the created files.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8315960: Fix indentation
test/jdk/java/io/File/TempDirDoes
On Mon, 18 Sep 2023 18:10:12 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes java.dll load shell32.dll earlier.
>> Delay-loading requires some additional code (delayimp.lib), and offers no
>> benefits since we always load shell32 during JVM startup.
>>
>> Other than removing
On Mon, 26 Jun 2023 14:14:54 GMT, Lance Andersen wrote:
> @LanceAndersen This one is going to require checking that startup isn't
> impacted.
Now that `ByteArrayLittleEndian` is used in Integer toString, don't think this
patch will affect the startup class loading sequence.
-
PR
On Mon, 11 Sep 2023 16:24:32 GMT, Brian Burkhalter wrote:
> These also fail with "Bad pathname" with the master but give the erroneous
> results `C:\\\foo` and `C:`, respectively, with the patch. This
> needs to be fixed.
The problem here might be that `File.getCanonicalPath` resolves the path
On Tue, 19 Sep 2023 18:38:06 GMT, ExE Boss wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutable
>> maps `@ValueBased` and at t
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote:
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the
On Tue, 19 Sep 2023 21:10:18 GMT, Justin Lu wrote:
>> src/java.base/share/classes/sun/util/calendar/CalendarUtils.java line 132:
>>
>>> 130: * Mimics sprintf(buf, "%0*d", decaimal, width).
>>> 131: */
>>> 132: public static StringBuilder sprintf0d(StringBuilder sb, int value,
>>>
Fixing a test case that fails in some time zones. Making sure the test is run
in `UTC` zone will fix the issue. Confirmed the fix by manually setting
machine's time zone to Europe/Dublin.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/15829/files
We
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000: Ad
On Fri, 15 Sep 2023 14:35:43 GMT, Alan Bateman wrote:
>> If this code does not interact with ACL-based security, then it's not clear
>> to me that there's anything to be done here.
>
>> If this code does not interact with ACL-based security, then it's not clear
>> to me that there's anything to
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000: Re
> Windows 11 does not reserve as many names as prior versions of Windows so do
> not expect exceptions for COM7 and LPT1.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8274122: Make value of exceptionExpected more robust to Win
On Tue, 19 Sep 2023 01:57:44 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Tue, 19 Sep 2023 20:15:20 GMT, Alexey Semenyuk wrote:
> Strip
>
> /*
> * @test
> * @modules jdk.jpackage
> * @compile --patch-module jdk.jpackage=${test.src} --add-reads
> jdk.jpackage=ALL-UNNAMED --add-exports
> jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED AppImageFileTest.java
> * @
> Add a `finally` block to delete the created files.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8315960: Fix indentation
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15757/files
- new: https://git.open
> Add a `finally` block to delete the created files.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8315960: Rename MethodSources; use Stream.toList; check value returned by
file deletion
-
Changes:
- all: https:
On Tue, 19 Sep 2023 21:23:40 GMT, Brian Burkhalter wrote:
>> That definitely sounds more reasonable. Unfortunate nomenclature on my part.
>
> I think maybe instead "tempDirSource' and "noTempDirSource."
So changed in 50411b85aeefb2576a149ae126b7d55aad6e2be0.
-
PR Review Comment: ht
On Tue, 19 Sep 2023 20:55:00 GMT, Naoto Sato wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8315960: Remove vestigial unused import
>
> test/jdk/java/io/File/TempDirDoesNotExist.java line 192:
>
>> 190:
On Tue, 19 Sep 2023 21:17:02 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/File/TempDirDoesNotExist.java line 118:
>>
>>> 116: }
>>> 117:
>>> 118: public static Stream nonexistentProvider() {
>>
>> The `nonexistentProvider` seems like an odd name. The only provider here is
>> the j
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations. Drive by
> cleanup included.
>
> As the implementation is long-standing and complete with no intent for future
> sub-classing, the CalendarSystem sho
On Tue, 19 Sep 2023 20:53:44 GMT, Brian Burkhalter wrote:
>> Add a `finally` block to delete the created files.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8315960: Improve test as suggested by Reviewer
test/jdk/ja
On Tue, 19 Sep 2023 21:15:36 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8315960: Improve test as suggested by Reviewer
>
> test/jdk/java/io/File/TempDirDoesNotExist.java line 118:
>
>> 11
Fix a NPE. The DTD patch (JDK-8306632) moved initialization to factories, for
example, for SAXParser, the SecurityManagers are created in the
SAXParserFactory impl and passed on to instances of SAXParsers. The
(deprecated) XMLReaderFactory however, instantiates SAXParsers directly, thus
without
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations. Drive by
> cleanup included.
>
> As the implementation is long-standing and complete with no intent for future
> sub-classing, the CalendarSystem sho
On Tue, 19 Sep 2023 16:48:54 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 15 commits:
>>
>> - Re-import Locale after merge for Formatter
>> - Merge master
>> - Replace sprintf0d with Forma
On Tue, 19 Sep 2023 20:15:20 GMT, Alexey Semenyuk wrote:
> Strip
>
> /*
> * @test
> * @modules jdk.jpackage
> * @compile --patch-module jdk.jpackage=${test.src} --add-reads
> jdk.jpackage=ALL-UNNAMED --add-exports
> jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED AppImageFileTest.java
> * @
On Tue, 19 Sep 2023 20:15:18 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8315960: Remove vestigial unused import
>
> test/jdk/java/io/File/TempDirDoesNotExist.java line 53:
>
>> 51: pr
On Fri, 15 Sep 2023 21:51:22 GMT, Brian Burkhalter wrote:
>> Add a `finally` block to delete the created files.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8315960: Remove vestigial unused import
test/jdk/java/io/F
On Tue, 19 Sep 2023 15:35:11 GMT, Tim Prinzing wrote:
>> The socket read/write JFR events currently use instrumentation of java.base
>> code using templates in the jdk.jfr modules. This results in some java.base
>> code residing in the jdk.jfr module which is undesirable.
>>
>> JDK19 added sta
> Add a `finally` block to delete the created files.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8315960: Improve test as suggested by Reviewer
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15757/files
-
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations. Drive by
> cleanup included.
>
> As the implementation is long-standing and complete with no intent for future
> sub-classing, the CalendarSystem sho
On Tue, 19 Sep 2023 18:55:28 GMT, Naoto Sato wrote:
>> This PR is to incorporate the latest Unicode 15.1, which was released
>> yesterday. Besides the usual character data update, an upgraded
>> implementation of RegEx which reflects the Indic Conjunct Break specified in
>> the latest [Unicode
On Tue, 19 Sep 2023 18:55:28 GMT, Naoto Sato wrote:
>> This PR is to incorporate the latest Unicode 15.1, which was released
>> yesterday. Besides the usual character data update, an upgraded
>> implementation of RegEx which reflects the Indic Conjunct Break specified in
>> the latest [Unicode
On Fri, 15 Sep 2023 21:51:22 GMT, Brian Burkhalter wrote:
>> Add a `finally` block to delete the created files.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8315960: Remove vestigial unused import
test/jdk/java/io/F
Strip
/*
* @test
* @modules jdk.jpackage
* @compile --patch-module jdk.jpackage=${test.src} --add-reads
jdk.jpackage=ALL-UNNAMED --add-exports
jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED AppImageFileTest.java
* @run junit/othervm --patch-module jdk.jpackage=${test.classes} --add-reads
jd
On Thu, 14 Sep 2023 08:58:56 GMT, Andrey Turbanov wrote:
> A few classes in `sun.util` package have non-final fields which could easily
> be marked `final`.
src/java.base/share/classes/sun/util/PropertyResourceBundleCharset.java line 71:
> 69: private final class PropertiesFileDecoder exte
A few classes in `sun.util` package have non-final fields which could easily be
marked `final`.
-
Commit messages:
- [PATCH] Make fields final in 'sun.util' package
Changes: https://git.openjdk.org/jdk/pull/15736/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15736&range=0
> Fixed the failing (well, false-positive) test case. Made the following
> changes to the test:
>
> - Corrected the path to the mapping files directory
> - Made sure to fail if the directory path is incorrect
> - Took care of `GB18030` alias, which is dynamically derived at runtime
> - Provided `
On Tue, 19 Sep 2023 18:15:54 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Included the failed directory location in the exception message
>
> test/jdk/sun/nio/cs/TestCharsetMapping.java line 574:
>
On Tue, 19 Sep 2023 18:53:30 GMT, Naoto Sato wrote:
>> look at https://www.unicode.org/Public/UCD/latest/ for example, it points
>> you only to license.txt.
>
> We are checking on it and will update it if necessary.
it was unnecessary to mention copyright.html or terms of use in the source
lic
On Tue, 19 Sep 2023 17:00:39 GMT, Steven Loomis wrote:
>> src/java.base/share/legal/unicode.md line 49:
>>
>>> 47: --
>>> 48:
>>> 49: Unicode® Copyright and Terms of Use
>>
>> You shouldn't need to pull in all of this — the entire license file is at
>> https://www.unicode.org/
On Tue, 19 Sep 2023 17:54:52 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits sinc
On Tue, 19 Sep 2023 16:18:18 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits since t
On Tue, 19 Sep 2023 18:55:28 GMT, Naoto Sato wrote:
>> This PR is to incorporate the latest Unicode 15.1, which was released
>> yesterday. Besides the usual character data update, an upgraded
>> implementation of RegEx which reflects the Indic Conjunct Break specified in
>> the latest [Unicode
> This PR is to incorporate the latest Unicode 15.1, which was released
> yesterday. Besides the usual character data update, an upgraded
> implementation of RegEx which reflects the Indic Conjunct Break specified in
> the latest [Unicode Annex #29 ("Unicode Text
> Segmentation")](https://unico
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote:
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the
> This PR is to incorporate the latest Unicode 15.1, which was released
> yesterday. Besides the usual character data update, an upgraded
> implementation of RegEx which reflects the Indic Conjunct Break specified in
> the latest [Unicode Annex #29 ("Unicode Text
> Segmentation")](https://unico
> Modified all tests under lib-test/jdk to use JUnit
Qing Xiao has updated the pull request incrementally with three additional
commits since the last revision:
- Update test/lib-test/jdk/test/lib/hexdump/ObjectStreamPrinterTest.java
Co-authored-by: liach <7806504+li...@users.noreply.git
On Tue, 19 Sep 2023 01:01:14 GMT, Naoto Sato wrote:
> Fixed the failing (well, false-positive) test case. Made the following
> changes to the test:
>
> - Corrected the path to the mapping files directory
> - Made sure to fail if the directory path is incorrect
> - Took care of `GB18030` alias,
On Mon, 18 Sep 2023 18:33:20 GMT, Naoto Sato wrote:
>> This PR is to incorporate the latest Unicode 15.1, which was released
>> yesterday. Besides the usual character data update, an upgraded
>> implementation of RegEx which reflects the Indic Conjunct Break specified in
>> the latest [Unicode
On Thu, 10 Aug 2023 17:21:31 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a "jmodless" jlink mode to the JDK.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> install might not come with the packaged modules (directory `jmods`). This
>> is
Test
com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java
check how beans work with VM flags and ignore external flags.
It doesn't make sense to run it with external options so just mark it as
flagless.
Tested with running tier1 and test with/without additional options.
-
Comm
On Mon, 18 Sep 2023 22:42:09 GMT, Justin Lu wrote:
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations.
>
> As the implementation is long-standing and complete with no intent for future
> sub-classing,
On Tue, 19 Sep 2023 16:57:57 GMT, Steven Loomis wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits si
On Mon, 18 Sep 2023 18:33:20 GMT, Naoto Sato wrote:
>> This PR is to incorporate the latest Unicode 15.1, which was released
>> yesterday. Besides the usual character data update, an upgraded
>> implementation of RegEx which reflects the Indic Conjunct Break specified in
>> the latest [Unicode
On Mon, 18 Sep 2023 22:42:09 GMT, Justin Lu wrote:
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations.
>
> As the implementation is long-standing and complete with no intent for future
> sub-classing,
On 18/09/2023 14:51, Andrew Leonard wrote:
Thanks for the clarification Alan.
To ensure the reproducibility of the whole JDK image regardless of the
specific bootjdk used, would it make sense once the "Build JDK" has
been built, we re-build jrt-fs.jar again using the "Build JDK" ? Thus
jrt-fs
On Mon, 18 Sep 2023 18:33:20 GMT, Naoto Sato wrote:
>> This PR is to incorporate the latest Unicode 15.1, which was released
>> yesterday. Besides the usual character data update, an upgraded
>> implementation of RegEx which reflects the Indic Conjunct Break specified in
>> the latest [Unicode
On Wed, 13 Sep 2023 14:22:35 GMT, 温绍锦 wrote:
>> improve date toString performance, includes:
>>
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has u
On Wed, 13 Sep 2023 14:08:15 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request incremental
> The socket read/write JFR events currently use instrumentation of java.base
> code using templates in the jdk.jfr modules. This results in some java.base
> code residing in the jdk.jfr module which is undesirable.
>
> JDK19 added static support for event classes. The old instrumentor classes
On Thu, 7 Sep 2023 21:54:44 GMT, Tim Prinzing wrote:
> No. I think it's a relic from the distant past though. I think the timeout
> field should be removed. It's not used on SocketChannel at all, and it
> doesn't seem useful on Socket.
Should we log an RFE to that effect?
-
PR Re
On Thu, 7 Sep 2023 21:50:17 GMT, Tim Prinzing wrote:
>> The socket read/write JFR events currently use instrumentation of java.base
>> code using templates in the jdk.jfr modules. This results in some java.base
>> code residing in the jdk.jfr module which is undesirable.
>>
>> JDK19 added stat
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]),
> If the length of byte[] is larger, the pe
On Tue, 19 Sep 2023 10:41:51 GMT, 温绍锦 wrote:
>> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
>> were discussed.
>>
>> But if the input is byte[], using lookup table can improve performance.
>>
>> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(
On Tue, 19 Sep 2023 01:35:49 GMT, 温绍锦 wrote:
>> The original (and current) is coded to avoid a condition inside the loop.
>
> I also think that the way of writing for_0 combined with if > 0 is easier to
> understand, The operation overhead of if > 0 is very small, and it will not
> affect perfo
On Thu, 14 Sep 2023 11:19:08 GMT, 温绍锦 wrote:
>> BigDecimal is a commonly used class in business development, It is often
>> necessary to perform toString or toPlainString operations on BigDecimal.
>>
>> The current version uses StringBuilder resulting in multiple memory
>> allocations, I made
On Fri, 21 Jul 2023 18:01:45 GMT, Alan Bateman wrote:
> Thread::getState is an API for monitoring and management purposes to report
> the thread state. If a virtual thread is parked with LockSupport.parkNanos,
> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI
> GetThr
On Tue, 19 Sep 2023 10:35:33 GMT, Alan Bateman wrote:
>> Thread::getState is an API for monitoring and management purposes to report
>> the thread state. If a virtual thread is parked with LockSupport.parkNanos,
>> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI
>> Ge
On Tue, 19 Sep 2023 10:26:50 GMT, 温绍锦 wrote:
>> If we changed DIGITS to be encoded with the uppercase digits then the
>> expression could be simplified to
>> ```return ucase ? v : (short) (v | 0b0010__0010_); // or 0x2020```
>
> Some performance-focused scenarios, such as UUID.toString,
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]),
> If the length of byte[] is larger, the pe
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]),
> If the length of byte[] is larger, the pe
On Wed, 6 Sep 2023 15:55:21 GMT, Tim Prinzing wrote:
>>> https://bugs.openjdk.org/browse/JDK-8310979 - better exception handling
>>> https://bugs.openjdk.org/browse/JDK-8310978 - missing code paths for event
>>> generation https://bugs.openjdk.org/browse/JDK-8310994 - non-blocking,
>>> event f
> Thread::getState is an API for monitoring and management purposes to report
> the thread state. If a virtual thread is parked with LockSupport.parkNanos,
> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI
> GetThreadState has the same issue in that it returns
> JVMTI_
On Tue, 19 Sep 2023 09:34:56 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/jdk/internal/util/HexDigits.java line 103:
>>
>>> 101: short v = DIGITS[i & 0xff];
>>> 102: return ucase
>>> 103: ? (short) (v - ((v & 0b0100__0100_) >> 1)) //
>>> real
On Thu, 7 Sep 2023 07:15:06 GMT, Qing Xiao wrote:
>> Modified all tests under lib-test/jdk to use JUnit
>
> Qing Xiao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change test static method to instance method
test/lib-test/jdk/test/lib/f
On Thu, 7 Sep 2023 07:15:06 GMT, Qing Xiao wrote:
>> Modified all tests under lib-test/jdk to use JUnit
>
> Qing Xiao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change test static method to instance method
test/lib-test/jdk/test/lib/h
On Tue, 15 Aug 2023 08:07:09 GMT, Christian Stein wrote:
>> test/lib-test/jdk/test/lib/format/ArrayDiffTest.java line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2020, 2021, 2023, Oracle and/or its affiliates. All
>>> rights reserved.
>>
>> Should it just modify the second year, here is `2021`, to
> Please review this PR to use modern APIs and language features to simplify
> equals, hashCode, and compareTo for BigInteger. If you have any performance
> concerns, please raise them.
>
> This PR is cherry-picked from a bigger, not-yet-published PR, to test the
> waters. That latter PR will b
On Tue, 19 Sep 2023 09:25:36 GMT, Chen Liang wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> "-" -> "& ~"
>
> src/java.base/share/classes/jdk/internal/util/HexDigits.java line 103:
>
>> 101: short v = DIGITS[i & 0x
On Tue, 19 Sep 2023 09:03:35 GMT, 温绍锦 wrote:
>> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
>> were discussed.
>>
>> But if the input is byte[], using lookup table can improve performance.
>>
>> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]),
> If the length of byte[] is larger, the pe
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote:
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the
On Fri, 8 Sep 2023 16:13:16 GMT, Per Minborg wrote:
>> This PR proposes to slightly improve some iterators of `AbstractMap`:
>>
>> * Declare two fields `final`
>> * Use distinct classes rather than anonymous classes
>
> Per Minborg has updated the pull request incrementally with two additional
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]),
> If the length of byte[] is larger, the pe
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote:
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote:
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the
This PR outlines a solution for making immutable maps `@ValueBased` by removing
cacheing of certain values in `AbstractMap`.
By removing these caching fields in `AbstractMap`, we can make the immutable
maps `@ValueBased` and at the same time, performance is likely improved because
the JVM is pr
On Mon, 18 Sep 2023 18:10:12 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes java.dll load shell32.dll earlier.
>> Delay-loading requires some additional code (delayimp.lib), and offers no
>> benefits since we always load shell32 during JVM startup.
>>
>> Other than removing
> WinHTTP functions are only used when an application:
> - uses DefaultProxySelector to resolve proxies, and
> - is run with -Djava.net.useSystemProxies=true
>
> In all other cases, loading winhttp.dll is a waste of resources.
>
> Verified that:
> - existing tier1 and tier2 tests still pass
> - t
On Tue, 19 Sep 2023 06:41:11 GMT, Alan Bateman wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert test changes
>
> test/jdk/java/net/ProxySelector/SystemProxies.java line 26:
>
>> 24: /*
>> 25: * @test
>>
94 matches
Mail list logo
