On Tue, 19 Sep 2023 01:01:14 GMT, Naoto Sato <na...@openjdk.org> wrote:
> Fixed the failing (well, false-positive) test case. Made the following
> changes to the test:
>
> - Corrected the path to the mapping files directory
> - Made sure to fail if the directory path is incorrect
> - Took care of `GB18030` alias, which is dynamically derived at runtime
> - Provided `MS950_HKSCS.map`, which is simply a copy of `HKSCS2008.map`
> - Excluded other failing tests for IBM charsets that do not have map files.
Actually tests 138 charsets now, looks good
test/jdk/sun/nio/cs/TestCharsetMapping.java line 574:
> 572: "/../../../../../make/data/charsetmapping");
> 573: if (!Files.exists(dir)) {
> 574: throw new Exception("charsetmapping directory cannot be
> located.");
Might be helpful to provide directory location in exception message
-------------
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/15807#pullrequestreview-1633923524
PR Review Comment: https://git.openjdk.org/jdk/pull/15807#discussion_r1330529497
