Hi,
On Tue, Sep 12, 2023 at 11:44 PM David Holmes wrote:
>
> Hi Simone,
>
> Thanks for the logs. Unfortunately they shed no light on what is
> happening. There is no sign of the MutableHttpFields class starting
> actual initialization, though we can see that it was linked (verified).
> And there
On Wed, 13 Sep 2023 02:17:00 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request incremental
On Wed, 13 Sep 2023 01:12:52 GMT, Mandy Chung wrote:
> This PR improves IllegalAccessException message thrown by `Lookup::findXXX`
> APIs if the method's variable arity modifier bit is set and
> `asVarargsCollector` fails. It will increase the exception message thrown by
> asVarargsCollector`
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
温绍锦 has updated the pull request incrementally with two additional
On Tue, 12 Sep 2023 23:10:43 GMT, Claes Redestad wrote:
>>> Have you considered potentially more generalizable optimizations to
>>> `DateTimeFormatter.ISO_INSTANT.format(this)` here?
>>>
>>> Hand-rolling a fixed-length buffer, skipping the `StringBuilder` ..
>>> understandably this can have a
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
温绍锦 has updated the pull request incrementally with one additional
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
温绍锦 has updated the pull request incrementally with one additional commit since
the last revision
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
温绍锦 has updated the pull request incrementally with one additional commit since
the last revision
1. Reduce duplicate stringSize code
2. Move java.lang.StringLatin1.getChars to
jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
packages also need to use this method
-
Commit messages:
- move StringLatin1::getChars to
jdk.internal.util.DecimalDigits::getCha
This PR improves IllegalAccessException message thrown by `Lookup::findXXX`
APIs if the method's variable arity modifier bit is set and
`asVarargsCollector` fails. It will increase the exception message thrown by
asVarargsCollector`.
-
Commit messages:
- 8267509: Improve IllegalA
On Tue, 12 Sep 2023 17:53:47 GMT, ExE Boss wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> merge from master
>
> src/java.base/share/classes/java/time/LocalTime.java line 141:
>
>> 139: @Stable
>> 140: static final
On Wed, 13 Sep 2023 01:15:38 GMT, 温绍锦 wrote:
>> improve date toString performance, includes:
>>
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has u
On Tue, 12 Sep 2023 23:08:25 GMT, Claes Redestad wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> merge from master
>
> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 77:
>
>> 75:
>> 76: static {
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
温绍锦 has updated the pull request incrementally with one additional
On Tue, 12 Sep 2023 22:44:35 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/jdk/internal/util/HexDigits.java line 112:
>>
>>> 110: | (DIGITS[b1 & 0xff] << 16)
>>> 111: | (((long) DIGITS[b2 & 0xff]) << 32)
>>> 112: | (((long) DIGITS[b3 & 0xff]) << 4
On Tue, 12 Sep 2023 13:10:42 GMT, 温绍锦 wrote:
>> Of course, the optimization of DateTimeFormatter is more general, and we can
>> spend time doing it later. The format of toString is fixed, we can not use
>> DateTimeFormatter.
>
>> Have you considered potentially more generalizable optimizations
On Tue, 12 Sep 2023 17:23:00 GMT, 温绍锦 wrote:
>> improve date toString performance, includes:
>>
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has u
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote:
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
> would improve readability to see the native characters instead of escape
> sequences (especially for the L10n process). The majority of files changed
> are local
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX512 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> This PR shows upto ~7x improvement for 32-bit datatypes (int, floa
On Mon, 11 Sep 2023 18:17:41 GMT, Jatin Bhateja wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix regression when intrinsics are disabled; enable insertion sort in
>> intrinsic, change library name to l
On Fri, 8 Sep 2023 23:02:02 GMT, Justin Lu wrote:
> Please review this change which adjusts the pattern syntax specification for
> the two classes to represent the actual behavior. That is, U+FFFE and U+
> are allowed in the suffix/prefix. (Additionally; 'Unicode' is dropped from
> the def
On Mon, 11 Sep 2023 16:13:01 GMT, 温绍锦 wrote:
>> It was a suggestion, implicitly paired with removing ` + (year < 0 ? 1 : 0)`
>> from line 2188.
>
> The reason for not using off++ is that it can be executed out of order, which
> may result in better performance.
I don't think that would outweig
Curiosity. I was setting up a new Windows 10 VirtualBox image to do jpackage.
It told me I needed Wix. First I needed dotnet to install wix. I then got a Wix
v4. jpackage told me I needed candle.exe and light.exe from v3. I installed v3
but haven’t had a chance to try it.
However, if v4 isn’t
On Tue, 12 Sep 2023 19:23:13 GMT, Roger Riggs wrote:
>> 温绍锦 has updated the pull request with a new target base due to a merge or a
>> rebase. The pull request now contains 19 commits:
>>
>> - merge from master
>> - Merge branch 'master' into optimization_for_uuid_to_string
>>
>># Con
JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
would improve readability to see the native characters instead of escape
sequences (especially for the L10n process). The majority of files changed are
localized resource files.
This change converts the Unicode escape
Hi Simone,
Thanks for the logs. Unfortunately they shed no light on what is
happening. There is no sign of the MutableHttpFields class starting
actual initialization, though we can see that it was linked (verified).
And there are no exceptions indicated relevant to the class loading and
initi
On Tue, 12 Sep 2023 21:09:25 GMT, Mandy Chung wrote:
>> test/micro/org/openjdk/bench/java/lang/CallerClassBench.java line 45:
>>
>>> 43: public class CallerClassBench {
>>> 44: static final StackWalker INST =
>>> StackWalker.getInstance(StackWalker.Option.RETAIN_CLASS_REFERENCE);
>>> 45:
>
On Tue, 12 Sep 2023 21:06:15 GMT, Brent Christian wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cleanup
>
> test/micro/org/openjdk/bench/java/lang/CallerClassBench.java line 45:
>
>> 43: public class CallerClassB
On Mon, 11 Sep 2023 17:52:56 GMT, Mandy Chung wrote:
>> Typically it will find the caller class at the second stack frame from the
>> frame of executing `StackWalker::getCallerClass`. The initial size of the
>> buffer can be changed from 8 to 4 (the top 2 elements are reserved for
>> impleme
On Tue, 12 Sep 2023 19:11:30 GMT, Roger Riggs wrote:
>> Mandy Chung has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
A field `short _Depth` in the
`jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element` class is unused and
can be removed.
-
Commit messages:
- [PATCH] Remove unused field
jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element#_Depth
Changes: https://git.openjdk.org/jdk/pull/1569
On Windows, restart app launcher in a way that when the parent app launcher
process terminates, the child app launcher process is automatically terminated.
-
Commit messages:
- 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
Changes: https://git.openjdk.org/jdk/p
On Tue, 12 Sep 2023 16:58:20 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make te
On Tue, 12 Sep 2023 16:37:28 GMT, Mandy Chung wrote:
>> This reimplements
>> `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method
>> handles.
>>
>> This API currently generates the bytecode which fails the verification
>> because `new C; invokespecial A()` where the giv
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the
> `java.text.ChoiceFormat` specification regarding its pattern.
>
> `j.text.ChoiceFormat` provides an example pattern in the class description,
> but beyond that it does not specify
On Tue, 12 Sep 2023 17:23:00 GMT, 温绍锦 wrote:
>> improve date toString performance, includes:
>>
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has u
On Fri, 8 Sep 2023 21:11:11 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the
>> `java.text.ChoiceFormat` specification regarding its pattern.
>>
>> `j.text.ChoiceFormat` provides an example pattern in the c
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
温绍锦 has updated the pull request incrementally with one additional
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
温绍锦 has updated the pull request with a new target base due to a me
> BigDecimal is a commonly used class in business development, It is often
> necessary to perform toString or toPlainString operations on BigDecimal.
>
> The current version uses StringBuilder resulting in multiple memory
> allocations, I made a modification to improve performance.
>
> Because
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
> discussions, continue to make improvements.
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.util.UUIDBench.toString"
>
>
> ##
On Sun, 10 Sep 2023 16:15:01 GMT, 温绍锦 wrote:
> java.util.DecimalDigits::DIGITS and java.lang.StringLatin1.PACKED_DIGITS are
> duplicates, We need to move
> java.util.Digits/OctalDigits/DecimalDigits/HexDigits to the jdk.internal.util
> package, and modify these classes to public class, so that
> This reimplements
> `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method
> handles.
>
> This API currently generates the bytecode which fails the verification
> because `new C; invokespecial A()` where the given class `C` and invoke a
> no-arg constructor of `C`'s firs
On Fri, 8 Sep 2023 16:57:14 GMT, Mandy Chung wrote:
> Typically it will find the caller class at the second stack frame from the
> frame of executing `StackWalker::getCallerClass`. The initial size of the
> buffer can be changed from 8 to 4 (the top 2 elements are reserved for
> implementati
On Tue, 12 Sep 2023 14:38:07 GMT, Volker Simonis wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cleanup
>
> src/java.base/share/classes/java/lang/StackStreamFactory.java line 766:
>
>> 764: @Override
>> 76
On Fri, 11 Aug 2023 02:33:05 GMT, chenggwang wrote:
> Sorry, my description in Issue JDK-8314194(which I submitted) is ambiguous
> and makes you think of Phaser. My intention is that each generation of
> CyclicBarrier barrierCommand can change. Let me give you a scenario
> For example, the U.S.
On Tue, 12 Sep 2023 13:27:29 GMT, 温绍锦 wrote:
>> java.util.DecimalDigits::DIGITS and java.lang.StringLatin1.PACKED_DIGITS are
>> duplicates, We need to move
>> java.util.Digits/OctalDigits/DecimalDigits/HexDigits to the
>> jdk.internal.util package, and modify these classes to public class, so
On Tue, 12 Sep 2023 13:27:29 GMT, 温绍锦 wrote:
>> java.util.DecimalDigits::DIGITS and java.lang.StringLatin1.PACKED_DIGITS are
>> duplicates, We need to move
>> java.util.Digits/OctalDigits/DecimalDigits/HexDigits to the
>> jdk.internal.util package, and modify these classes to public class, so
On Tue, 12 Sep 2023 13:24:56 GMT, 温绍锦 wrote:
> I prefer to use little endian, most environments are little endian. Changes
> to HexDigit will have to wait until #PR 14745 is merged.
I don't have a very strong opinion except that we should be consistent across
these related implementations. If
> Thread::getState is an API for monitoring and management purposes to report
> the thread state. If a virtual thread is parked with LockSupport.parkNanos,
> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI
> GetThreadState has the same issue in that it returns
> JVMTI_
On Tue, 12 Sep 2023 14:16:27 GMT, Roger Riggs wrote:
> > The title has been updated, please help update the title of JIRA
>
> The description needs an update too.
The description has also been updated
-
PR Comment: https://git.openjdk.org/jdk/pull/15651#issuecomment-1715880514
On Mon, 11 Sep 2023 17:52:56 GMT, Mandy Chung wrote:
>> Typically it will find the caller class at the second stack frame from the
>> frame of executing `StackWalker::getCallerClass`. The initial size of the
>> buffer can be changed from 8 to 4 (the top 2 elements are reserved for
>> impleme
On Tue, 12 Sep 2023 13:54:34 GMT, Roger Riggs wrote:
> You haven't make the case for these changes, please describe the use cases
> when performance is a significant constraint on application performance. The
> changes largely just add more code to maintain without otherwise adding
> sufficien
On Tue, 12 Sep 2023 13:27:29 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess, whic
On Tue, 12 Sep 2023 14:13:06 GMT, 温绍锦 wrote:
> The title has been updated, please help update the title of JIRA
The description needs an update too.
-
PR Comment: https://git.openjdk.org/jdk/pull/15651#issuecomment-1715814638
On Tue, 12 Sep 2023 13:49:09 GMT, Roger Riggs wrote:
> Please update this PR title and description to indicate this refactoring to
> move to jdk.internal.util. I can update the Jira title and description to
> match after that.
The title has been updated, please help update the title of JIRA
-
On Tue, 12 Sep 2023 13:05:19 GMT, 温绍锦 wrote:
>> improve date toString performance, includes:
>>
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has u
On Tue, 12 Sep 2023 13:27:29 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess, whic
> Some codes in core libs are duplicated, including:
> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>
> We can reduce duplication through JavaLangAccess, which is also needed in
> other places, such as:
> http
On Tue, 12 Sep 2023 10:11:53 GMT, Claes Redestad wrote:
> Running some additional testing. This mostly looks fine.
>
> One issue is that you're swapping the byte-order in `DecimalDigits::DIGITS`
> but not in `OctalDigits` and `HexDigits`. I think we need to keep these
> internally consistent t
On Mon, 11 Sep 2023 14:59:25 GMT, 温绍锦 wrote:
>> The performance of optimizing DateTimeFormatter cannot be as fast as using
>> ixed-length buffer directly.
>
> Of course, the optimization of DateTimeFormatter is more general, and we can
> spend time doing it later. The format of toString is fixe
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
温绍锦 has updated the pull request incrementally with two additional
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the followin
On Tue, 12 Sep 2023 10:11:53 GMT, Claes Redestad wrote:
> If there's no significant performance difference I would prefer if we kept
> `DecimalDigits::DIGITS` big-endian encoded - which is more intuitive to most
> - and adjust code depending on `DecimalDigits::digitPair` to use `ByteArray`
> r
On Tue, 12 Sep 2023 01:00:39 GMT, 温绍锦 wrote:
>> Some codes in core libs are duplicated, including:
>> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS
>> java.util.DecimalDigits::size -> java.lang.Long.stringSize
>>
>> We can reduce duplication through JavaLangAccess, whic
On Sat, 9 Sep 2023 14:33:53 GMT, Lance Andersen wrote:
> Please review this PR which improves the Zip64 extra header validation:
>
> - Throw a ZipException If the extra len field is 0 and :
> -- size, csize, or loc offset are set to 0x
> -- disk starting number is set to 0x
>
> - We
David,
On Mon, Sep 11, 2023 at 9:29 AM Simone Bordet wrote:
>
> Hi,
>
> On Mon, Sep 11, 2023 at 7:22 AM David Holmes wrote:
> > I've looked at the dump and there is no sign that the MutableHttpFields
> > is actively in use. It suggests to me that class initialization has
> > failed but the class
On Mon, 11 Sep 2023 17:58:20 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
This pull request has now been integrated.
Changeset: f55e7994
Author:Pavel Rappo
URL:
https://git.openjdk.org/jdk/commit/f55e799491c39dcaf7b3935b6d560ee0a3239191
Stats: 7 lines in 2 files chan
On Fri, 8 Sep 2023 15:54:05 GMT, Alan Bateman wrote:
> There are several methods defined by sun.misc.Unsafe that have standard API
> equivalents for many years and releases. The change proposed here is to
> deprecate, for removal, the park, unpark, getLoadAverage, loadFence,
> storeFence, and
71 matches
Mail list logo
