On Fri, 8 Sep 2023 21:11:11 GMT, Justin Lu <j...@openjdk.org> wrote: >> Please review this PR and associated >> [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the >> `java.text.ChoiceFormat` specification regarding its pattern. >> >> `j.text.ChoiceFormat` provides an example pattern in the class description, >> but beyond that it does not specify any well-defined syntax for creating a >> pattern. In addition, methods related to the pattern String are >> under-specified. >> >> The wording for `getLimits()` and `getFormats()` was also adjusted, as there >> are other ways to set the limits and formats beyond the constructor. >> >> The pattern syntax may be easier to view -> >> https://cr.openjdk.org/~jlu/api/java.base/java/text/ChoiceFormat.html > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Drop Unicode from definition, implied
src/java.base/share/classes/java/text/ChoiceFormat.java line 160: > 158: * <i>Note:The relation ≤ is not equivalent to <=</i> > 159: * > 160: * <p>Below is an example of constructing a ChoiceFormat with a pattern: FWIW, in other parts of core libs such as java.lang.Double, I've used a definition list `<dl>` with terms `<dt>` and definitions `<dd>` to represent such grammars. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15392#discussion_r1323380975
