Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v14]

2023-09-08 Thread Claes Redestad
On Fri, 8 Sep 2023 23:49:04 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/util/HexDigits.java line 66: >> >>> 64: */ >>> 65: @Stable >>> 66: private static final short[] DIGITS; >> >> Maybe it should be `char[]` instead since it’s encoded using unsigned 16‑bit  >> inte

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v14]

2023-09-08 Thread Chen Liang
On Fri, 8 Sep 2023 21:06:25 GMT, ExE Boss wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> lo | hi => hi | lo > > src/java.base/share/classes/java/util/HexDigits.java line 66: > >> 64: */ >> 65: @Stable >> 66:

Re: RFR: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths [v2]

2023-09-08 Thread Brian Burkhalter
On Fri, 8 Sep 2023 10:00:42 GMT, Alan Bateman wrote: > The two cases that I'm wondering about are `\\\?\` and `\\\?\\UNC`. Both of these cases throw an IOE with message "Bad pathname" for `getCanonicalPath()` and `getParentFile().getCanonicalPath()` with both the mainline and with this change.

Re: RFR: 8277954: Replace use of monitors with explicit locks in the JDK LDAP provider implementation [v2]

2023-09-08 Thread Aleksei Efimov
On Fri, 8 Sep 2023 14:59:38 GMT, Daniel Fuchs wrote: > Look reasonable to me. If tier2 and all jndi tests are still passing, I'm > good with it. Thanks for the review Daniel. `tier1`, `tier2`, `tier3` and JNDI/LDAP JCK tests showed no failures with the change proposed here. - PR

Re: RFR: 8277954: Replace use of monitors with explicit locks in the JDK LDAP provider implementation [v2]

2023-09-08 Thread Aleksei Efimov
> The change proposed in this PR improves the behavior of the JDK JNDI/LDAP > provider when running in a virtual thread. Currently, when an LDAP operation > is performed from a virtual thread context a pinned carrier thread is > detected: > > Thread[#29,ForkJoinPool-1-worker-1,5,CarrierThr

RFR: JDK-8315946: DecimalFormat and CompactNumberFormat do allow U+FFFE and U+FFFF in the pattern

2023-09-08 Thread Justin Lu
Please review this change which adjusts the pattern syntax specification for the two classes to represent the actual behavior. That is, U+FFFE and U+ are allowed in the suffix/prefix. (Additionally; 'Unicode' is dropped from the definitions, as a Java character is composed of Unicode code po

Integrated: 8315410: Undocumented exceptions in java.text.StringCharacterIterator

2023-09-08 Thread Justin Lu
On Fri, 1 Sep 2023 23:12:28 GMT, Justin Lu wrote: > Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315558) > which is a conformance change to document some exceptions in the > specification of java.text.StringCharacterIterator. This pull request has now been integrated.

Re: RFR: 8041488: Locale-Dependent List Patterns [v17]

2023-09-08 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v6]

2023-09-08 Thread Justin Lu
> Please review this PR and associated > [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the > `java.text.ChoiceFormat` specification regarding its pattern. > > `j.text.ChoiceFormat` provides an example pattern in the class description, > but beyond that it does not specify

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v5]

2023-09-08 Thread Justin Lu
On Fri, 8 Sep 2023 20:21:56 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Make starting sentence consistent with other Format classes. Improve >> wording, a choiceFormat does NOT have to be crea

Re: RFR: 8315938: Deprecate for removal Unsafe methods that have standard APIs for many releases

2023-09-08 Thread Iris Clark
On Fri, 8 Sep 2023 15:54:05 GMT, Alan Bateman wrote: > There are several methods defined by sun.misc.Unsafe that have standard API > equivalents for many years and releases. The change proposed here is to > deprecate, for removal, the park, unpark, getLoadAverage, loadFence, > storeFence, and

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v14]

2023-09-08 Thread ExE Boss
On Fri, 8 Sep 2023 20:36:31 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make tes

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v14]

2023-09-08 Thread 温绍锦
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved > discussions, continue to make improvements. > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.util.UUIDBench.toString" > > > ##

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v13]

2023-09-08 Thread 温绍锦
On Fri, 8 Sep 2023 20:13:01 GMT, Roger Riggs wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> add DIGITS description > > src/java.base/share/classes/java/util/HexDigits.java line 81: > >> 79: for (int j = 0; j <

Integrated: 8306632: Add a JDK Property for specifying DTD support

2023-09-08 Thread Joe Wang
On Fri, 28 Jul 2023 18:41:48 GMT, Joe Wang wrote: > Add a JDK Impl specific property 'jdk.xml.dtd.support' for applications to > specify how DTDs are handled. This property is uniformly supported across the > JDK XML libraries. It complements, rather than replaces, the existing > properties th

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v5]

2023-09-08 Thread Naoto Sato
On Fri, 8 Sep 2023 17:14:06 GMT, Justin Lu wrote: >> Please review this PR and associated >> [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the >> `java.text.ChoiceFormat` specification regarding its pattern. >> >> `j.text.ChoiceFormat` provides an example pattern in the c

Re: RFR: 8306632: Add a JDK Property for specifying DTD support [v2]

2023-09-08 Thread Joe Wang
On Fri, 8 Sep 2023 16:44:31 GMT, Joe Wang wrote: >> Add a JDK Impl specific property 'jdk.xml.dtd.support' for applications to >> specify how DTDs are handled. This property is uniformly supported across >> the JDK XML libraries. It complements, rather than replaces, the existing >> properties

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v13]

2023-09-08 Thread Roger Riggs
On Fri, 8 Sep 2023 20:01:20 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make tes

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v13]

2023-09-08 Thread 温绍锦
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved > discussions, continue to make improvements. > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.util.UUIDBench.toString" > > > ##

Re: RFR: 8315789: Minor HexFormat performance improvements

2023-09-08 Thread 温绍锦
On Fri, 8 Sep 2023 08:47:04 GMT, Raffaello Giulietti wrote: > I'm not sure that micro-benchmarks are very indicative on whether a lookup > table performs better than short and straightforward code. > The reason is that, once in the CPU caches, a lookup table in > micro-benchmarks stays there,

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v12]

2023-09-08 Thread 温绍锦
On Fri, 8 Sep 2023 18:59:09 GMT, Roger Riggs wrote: > This request got buried in a "resolved" comment: > > > A description of the DIGITS array layout and indexing is needed; it will > > help with the comprehension of the masking and shifts in the packDigits > > methods. > > The DIGITS table i

Re: RFR: 8315938: Deprecate for removal Unsafe methods that have standard APIs for many releases

2023-09-08 Thread Paul Sandoz
On Fri, 8 Sep 2023 15:54:05 GMT, Alan Bateman wrote: > There are several methods defined by sun.misc.Unsafe that have standard API > equivalents for many years and releases. The change proposed here is to > deprecate, for removal, the park, unpark, getLoadAverage, loadFence, > storeFence, and

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v34]

2023-09-08 Thread Srinivas Vamsi Parasa
On Fri, 8 Sep 2023 18:10:33 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8315938: Deprecate for removal Unsafe methods that have standard APIs for many releases

2023-09-08 Thread Mandy Chung
On Fri, 8 Sep 2023 15:54:05 GMT, Alan Bateman wrote: > There are several methods defined by sun.misc.Unsafe that have standard API > equivalents for many years and releases. The change proposed here is to > deprecate, for removal, the park, unpark, getLoadAverage, loadFence, > storeFence, and

Re: RFR: 8315850: Improve AbstractMap anonymous Iterator classes [v3]

2023-09-08 Thread Rémi Forax
On Fri, 8 Sep 2023 18:55:29 GMT, altrisi wrote: >> Per Minborg has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix additional formating issue >> - Don't use polymorphism and reformat code > > With the recent changes this ends up just

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v30]

2023-09-08 Thread Srinivas Vamsi Parasa
On Fri, 1 Sep 2023 10:57:57 GMT, iaroslavski wrote: >>> @AlanBateman If it helps, the changes made by @vamsi-parasa to >>> DualPivotQuickSort.java don't change the logic as written in Java. They >>> only carve out the functionality into separate Java methods retaining the >>> meaning exactly a

RFR: 8315938: Deprecate for removal Unsafe methods that have standard APIs for many releases

2023-09-08 Thread Alan Bateman
There are several methods defined by sun.misc.Unsafe that have standard API equivalents for many years and releases. The change proposed here is to deprecate, for removal, the park, unpark, getLoadAverage, loadFence, storeFence, and fullFence methods. Code using these methods should move to Loc

Re: RFR: 8315585: Optimization for decimal to string [v11]

2023-09-08 Thread 温绍锦
> BigDecimal is a commonly used class in business development, It is often > necessary to perform toString or toPlainString operations on BigDecimal. > > The current version uses StringBuilder resulting in multiple memory > allocations, I made a modification to improve performance. > > Because

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v12]

2023-09-08 Thread Roger Riggs
On Fri, 8 Sep 2023 00:00:16 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make tes

Re: RFR: 8315850: Improve AbstractMap anonymous Iterator classes [v3]

2023-09-08 Thread altrisi
On Fri, 8 Sep 2023 16:13:16 GMT, Per Minborg wrote: >> This PR proposes to slightly improve some iterators of `AbstractMap`: >> >> * Code reuse >> * A field declared `final` >> * Add missing `@Override` annotations > > Per Minborg has updated the pull request incrementally with two additional >

Re: RFR: 8315585: Optimization for decimal to string [v10]

2023-09-08 Thread 温绍锦
On Fri, 8 Sep 2023 18:17:12 GMT, 温绍锦 wrote: >> BigDecimal is a commonly used class in business development, It is often >> necessary to perform toString or toPlainString operations on BigDecimal. >> >> The current version uses StringBuilder resulting in multiple memory >> allocations, I made a

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v34]

2023-09-08 Thread Srinivas Vamsi Parasa
On Fri, 8 Sep 2023 18:10:33 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock. [v2]

2023-09-08 Thread Brent Christian
On Fri, 8 Sep 2023 08:03:51 GMT, Alan Bateman wrote: > > We could do this mid-term in some follow up action. > > It shouldn't be hard to try it. If it works out then it would mean this old > crufty code goes away and the JDK is in a better place. If it doesn't work > out then the a plan B woul

Re: RFR: 8315585: Optimization for decimal to string [v10]

2023-09-08 Thread 温绍锦
> BigDecimal is a commonly used class in business development, It is often > necessary to perform toString or toPlainString operations on BigDecimal. > > The current version uses StringBuilder resulting in multiple memory > allocations, I made a modification to improve performance. > > Because

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v34]

2023-09-08 Thread Srinivas Vamsi Parasa
> The goal is to develop faster sort routines for x86_64 CPUs by taking > advantage of AVX512 instructions. This enhancement provides an order of > magnitude speedup for Arrays.sort() using int, long, float and double arrays. > > This PR shows upto ~7x improvement for 32-bit datatypes (int, floa

Re: RFR: 8041488: Locale-Dependent List Patterns [v16]

2023-09-08 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of Stri

Re: RFR: 8041488: Locale-Dependent List Patterns [v15]

2023-09-08 Thread Naoto Sato
On Fri, 8 Sep 2023 14:43:59 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 24 additional >> commits since

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v12]

2023-09-08 Thread 温绍锦
On Fri, 8 Sep 2023 00:00:16 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make tes

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v11]

2023-09-08 Thread Roger Riggs
On Thu, 7 Sep 2023 17:58:09 GMT, Roger Riggs wrote: > A description of the DIGITS array layout and indexing is needed; it will help > with the comprehension of the masking and shifts in the packDigits methods. The DIGITS table is missing a description of its indexing. - PR Review

RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass

2023-09-08 Thread Mandy Chung
Typically it will find the caller class at the second stack frame from the frame of executing `StackWalker::getCallerClass`. The initial size of the buffer can be changed from 8 to 4 (the top 2 elements are reserved for implementation use). If it fetches another batch, `getCallerClass` may b

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v5]

2023-09-08 Thread Justin Lu
> Please review this PR and associated > [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the > `java.text.ChoiceFormat` specification regarding its pattern. > > `j.text.ChoiceFormat` provides an example pattern in the class description, > but beyond that it does not specify

Re: RFR: 8315585: Optimization for decimal to string [v9]

2023-09-08 Thread 温绍锦
> BigDecimal is a commonly used class in business development, It is often > necessary to perform toString or toPlainString operations on BigDecimal. > > The current version uses StringBuilder resulting in multiple memory > allocations, I made a modification to improve performance. > > Because

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-09-08 Thread 温绍锦
On Fri, 8 Sep 2023 16:25:27 GMT, Roger Riggs wrote: >> I'll have a look at #14655 though I note that @RogerRiggs has already >> commented that this might not carry its own weight. These internal API >> bridges are a nuisance so we need to take care to make sure that any >> addition is actually

Re: RFR: 8306632: Add a JDK Property for specifying DTD support

2023-09-08 Thread Joe Wang
On Fri, 28 Jul 2023 18:41:48 GMT, Joe Wang wrote: > Add a JDK Impl specific property 'jdk.xml.dtd.support' for applications to > specify how DTDs are handled. This property is uniformly supported across the > JDK XML libraries. It complements, rather than replaces, the existing > properties th

Re: RFR: 8306632: Add a JDK Property for specifying DTD support [v2]

2023-09-08 Thread Joe Wang
> Add a JDK Impl specific property 'jdk.xml.dtd.support' for applications to > specify how DTDs are handled. This property is uniformly supported across the > JDK XML libraries. It complements, rather than replaces, the existing > properties that are supportDTD for StAX and disallow-doctype-decl

Integrated: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null"

2023-09-08 Thread Maurizio Cimadamore
On Fri, 8 Sep 2023 10:19:05 GMT, Maurizio Cimadamore wrote: > This PR adds a privileged block surrounding the request to load the fallback > linker library in LibFallback. > The lack of this block is causing test failures when platforms using the > fallback linker are tested using a security m

Re: RFR: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null" [v2]

2023-09-08 Thread Per Minborg
On Fri, 8 Sep 2023 10:52:06 GMT, Maurizio Cimadamore wrote: >> This PR adds a privileged block surrounding the request to load the fallback >> linker library in LibFallback. >> The lack of this block is causing test failures when platforms using the >> fallback linker are tested using a securi

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-09-08 Thread Roger Riggs
On Fri, 8 Sep 2023 15:48:55 GMT, Claes Redestad wrote: >> Going from `jla.newStringNoRepl(bytes, ISO_...)` to >> `jla.newStringLatin1NoRepl(bytes)` isn't much of a code simplification, so >> this distracts a bit from the bulk of the changes in this PR. I agree that >> it *might* help inlining

Re: RFR: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null" [v2]

2023-09-08 Thread Daniel D . Daugherty
On Fri, 8 Sep 2023 10:52:06 GMT, Maurizio Cimadamore wrote: >> This PR adds a privileged block surrounding the request to load the fallback >> linker library in LibFallback. >> The lack of this block is causing test failures when platforms using the >> fallback linker are tested using a securi

Re: RFR: 8315942: Sort platform enums and definitions after JDK-8304913 follow-ups

2023-09-08 Thread Roger Riggs
On Fri, 8 Sep 2023 15:31:02 GMT, Aleksey Shipilev wrote: > @RogerRiggs asked for this. The moves are mechanical, so nothing should be > lost. Tell me if other things need to be sorted as well. > > I would wait a little to see if there are any more JDK-8304913 followups. LGTM, thanks -

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-09-08 Thread 温绍锦
On Fri, 8 Sep 2023 15:48:55 GMT, Claes Redestad wrote: >> Going from `jla.newStringNoRepl(bytes, ISO_...)` to >> `jla.newStringLatin1NoRepl(bytes)` isn't much of a code simplification, so >> this distracts a bit from the bulk of the changes in this PR. I agree that >> it *might* help inlining

Re: RFR: 8315850: Improve AbstractMap anonymous Iterator classes [v3]

2023-09-08 Thread Per Minborg
> This PR proposes to slightly improve some iterators of `AbstractMap`: > > * Code reuse > * A field declared `final` > * Add missing `@Override` annotations Per Minborg has updated the pull request incrementally with two additional commits since the last revision: - Fix additional formating i

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-09-08 Thread Claes Redestad
On Fri, 8 Sep 2023 15:41:41 GMT, Claes Redestad wrote: >> Notice there is patch https://github.com/openjdk/jdk/pull/14655 (bug >> 8310901) for converting these usages to a new `newStringLatin1NoRepl`. > > Going from `jla.newStringNoRepl(bytes, ISO_...)` to > `jla.newStringLatin1NoRepl(bytes)` i

Re: RFR: 8315585: Optimization for decimal to string [v8]

2023-09-08 Thread 温绍锦
> BigDecimal is a commonly used class in business development, It is often > necessary to perform toString or toPlainString operations on BigDecimal. > > The current version uses StringBuilder resulting in multiple memory > allocations, I made a modification to improve performance. > > Because

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-09-08 Thread Claes Redestad
On Fri, 8 Sep 2023 15:39:47 GMT, Chen Liang wrote: >> newStringLatin1NoRepl does not significantly help performance, but it >> simplifies the code. >> >> Of course, there is another advantage: because the call will be simpler, >> making it easier for the caller method to implement codeSize sm

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-09-08 Thread Chen Liang
On Fri, 8 Sep 2023 15:34:16 GMT, 温绍锦 wrote: >> src/java.base/share/classes/java/lang/String.java line 699: >> >>> 697: } >>> 698: >>> 699: static String newStringLatin1NoRepl(byte[] bytes) { >> >> How much does this help compared to calling `jla.newStringNoRepl(bytes, >> StandardChars

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-09-08 Thread 温绍锦
On Fri, 8 Sep 2023 12:25:02 GMT, Claes Redestad wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Continue to optimize and reduce duplicate code > > src/java.base/share/classes/java/lang/String.java line 699: > >> 697: }

Re: RFR: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths [v2]

2023-09-08 Thread Brian Burkhalter
On Fri, 8 Sep 2023 10:00:42 GMT, Alan Bateman wrote: > I'm trying to see how this case fails in the badPaths list. I'll investigate the other topics you raise, but I should point out that the results of this test are the same as for the mainline except for the last two good paths list

RFR: 8315942: Sort platform enums and definitions after JDK-8304913 follow-ups

2023-09-08 Thread Aleksey Shipilev
@RogerRiggs asked for this. The moves are mechanical, so nothing should be lost. Tell me if other things need to be sorted as well. I would wait a little to see if there are any more JDK-8304913 followups. - Commit messages: - Fix Changes: https://git.openjdk.org/jdk/pull/15640/fi

Re: RFR: 8310929: Optimization for Integer.toString [v21]

2023-09-08 Thread Roger Riggs
On Wed, 6 Sep 2023 22:22:12 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.Integers.toStrin

Integrated: 8315578: PPC builds are broken after JDK-8304913

2023-09-08 Thread Aleksey Shipilev
On Mon, 4 Sep 2023 07:26:37 GMT, Aleksey Shipilev wrote: > Similar to other issues in the same area. I have no PPC32 machine to test the > build on, but this matches other fixes for other architectures > (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) > after t

Re: RFR: 8315578: PPC builds are broken after JDK-8304913 [v3]

2023-09-08 Thread Aleksey Shipilev
On Thu, 7 Sep 2023 16:21:18 GMT, Aleksey Shipilev wrote: >> Similar to other issues in the same area. I have no PPC32 machine to test >> the build on, but this matches other fixes for other architectures >> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) >> aft

Re: RFR: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing [v4]

2023-09-08 Thread Alan Bateman
> In the virtual thread implementation, thread identity switches to the carrier > before freezing and switches back to the virtual thread after thawing. This > was a forced move due to issues getting JVMTI to work with virtual threads. > JVMTI can now hide events during transitions so we can inv

Re: RFR: 8277954: Replace use of monitors with explicit locks in the JDK LDAP provider implementation

2023-09-08 Thread Daniel Fuchs
On Thu, 31 Aug 2023 22:48:30 GMT, Aleksei Efimov wrote: > The change proposed in this PR improves the behavior of the JDK JNDI/LDAP > provider when running in a virtual thread. Currently, when an LDAP operation > is performed from a virtual thread context a pinned carrier thread is > detected:

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v16]

2023-09-08 Thread Jorn Vernee
On Fri, 8 Sep 2023 11:20:39 GMT, ExE Boss wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add support for sliced allocation > > src/java.base/share/classes/jdk/internal/foreign/NativeMemorySegmentImpl.java > line 1

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-09-08 Thread Claes Redestad
On Fri, 8 Sep 2023 12:00:17 GMT, 温绍锦 wrote: >> BigDecimal is a commonly used class in business development, It is often >> necessary to perform toString or toPlainString operations on BigDecimal. >> >> The current version uses StringBuilder resulting in multiple memory >> allocations, I made a

Re: RFR: 8315578: PPC builds are broken after JDK-8304913 [v3]

2023-09-08 Thread Roger Riggs
On Thu, 7 Sep 2023 16:21:18 GMT, Aleksey Shipilev wrote: >> Similar to other issues in the same area. I have no PPC32 machine to test >> the build on, but this matches other fixes for other architectures >> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) >> aft

Re: RFR: 8041488: Locale-Dependent List Patterns [v15]

2023-09-08 Thread Roger Riggs
On Thu, 7 Sep 2023 18:20:28 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >> patterns](https://www.unicode.org/reports/tr35/tr35-general

Re: RFR: 8041488: Locale-Dependent List Patterns [v14]

2023-09-08 Thread Naoto Sato
On Thu, 7 Sep 2023 16:57:20 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporating suggested changes > > src/java.base/share/classes/java/text/ListFormat.java line 95: > >> 93: * On parsing,

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v19]

2023-09-08 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the followin

Integrated: 8315696: SignedLoggerFinderTest.java test failed

2023-09-08 Thread Sean Coffey
On Tue, 5 Sep 2023 20:06:41 GMT, Sean Coffey wrote: > Update the recently added LoggerFinder tests to cater for a possible > condition where the test finishes before the boot logger executor service has > flushed its pending data. > > By simulating a slow thread in the ExecutorService used in

Re: RFR: 8315696: SignedLoggerFinderTest.java test failed

2023-09-08 Thread Daniel Fuchs
On Tue, 5 Sep 2023 20:06:41 GMT, Sean Coffey wrote: > Update the recently added LoggerFinder tests to cater for a possible > condition where the test finishes before the boot logger executor service has > flushed its pending data. > > By simulating a slow thread in the ExecutorService used in

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-09-08 Thread iaroslavski
On Fri, 1 Sep 2023 06:12:57 GMT, Alan Bateman wrote: >> Hi team, >> @AlanBateman, @rose00, @mbreinhold >> >> There are a big efforts now to improve sorting with x86_64 AVX512 >> https://github.com/openjdk/jdk/pull/14227, no changes of >> Dual-Pivot Quicksort logic. >> >> But at the same time t

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v25]

2023-09-08 Thread Doug Lea
On Thu, 7 Sep 2023 08:46:09 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Allow ThreadGroup access in tck tests > > test/jdk/java/util/concurrent/tck/JSR166TestCase.java line 1687: > >> 1685:

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v26]

2023-09-08 Thread Doug Lea
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and ForkJ

Re: RFR: 8315585: Optimization for decimal to string [v3]

2023-09-08 Thread 温绍锦
On Tue, 5 Sep 2023 18:13:39 GMT, Claes Redestad wrote: >> 温绍锦 has updated the pull request with a new target base due to a merge or a >> rebase. The incremental webrev excludes the unrelated changes brought in by >> the merge/rebase. The pull request contains four additional commits since >> t

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-09-08 Thread 温绍锦
> BigDecimal is a commonly used class in business development, It is often > necessary to perform toString or toPlainString operations on BigDecimal. > > The current version uses StringBuilder resulting in multiple memory > allocations, I made a modification to improve performance. > > Because

Re: RFR: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null" [v2]

2023-09-08 Thread Jorn Vernee
On Fri, 8 Sep 2023 10:52:06 GMT, Maurizio Cimadamore wrote: >> This PR adds a privileged block surrounding the request to load the fallback >> linker library in LibFallback. >> The lack of this block is causing test failures when platforms using the >> fallback linker are tested using a securi

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v16]

2023-09-08 Thread ExE Boss
On Thu, 7 Sep 2023 13:07:50 GMT, Jorn Vernee wrote: >> This patch contains the implementation of the foreign linker & memory API >> JEP for Java 22. The initial patch is composed of commits brought over >> directly from the [panama-foreign >> repo](https://github.com/openjdk/panama-foreign). T

Re: RFR: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null" [v2]

2023-09-08 Thread Athijegannathan Sundararajan
On Fri, 8 Sep 2023 10:52:06 GMT, Maurizio Cimadamore wrote: >> This PR adds a privileged block surrounding the request to load the fallback >> linker library in LibFallback. >> The lack of this block is causing test failures when platforms using the >> fallback linker are tested using a securi

Re: RFR: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null" [v2]

2023-09-08 Thread Maurizio Cimadamore
> This PR adds a privileged block surrounding the request to load the fallback > linker library in LibFallback. > The lack of this block is causing test failures when platforms using the > fallback linker are tested using a security manager. Maurizio Cimadamore has updated the pull request incre

Re: RFR: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null" [v2]

2023-09-08 Thread Maurizio Cimadamore
On Fri, 8 Sep 2023 10:24:22 GMT, Jorn Vernee wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix library name > > src/java.base/share/classes/jdk/internal/foreign/abi/fallback/LibFallback.java > line 42: >

Re: RFR: 8315585: Optimization for decimal to string [v6]

2023-09-08 Thread 温绍锦
> BigDecimal is a commonly used class in business development, It is often > necessary to perform toString or toPlainString operations on BigDecimal. > > The current version uses StringBuilder resulting in multiple memory > allocations, I made a modification to improve performance. > > Because

Re: RFR: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null"

2023-09-08 Thread Jorn Vernee
On Fri, 8 Sep 2023 10:19:05 GMT, Maurizio Cimadamore wrote: > This PR adds a privileged block surrounding the request to load the fallback > linker library in LibFallback. > The lack of this block is causing test failures when platforms using the > fallback linker are tested using a security m

Re: RFR: 8315789: Minor HexFormat performance improvements

2023-09-08 Thread Claes Redestad
On Wed, 6 Sep 2023 13:36:22 GMT, Claes Redestad wrote: > This PR seeks to improve formatting of hex digits using `java.util.HexFormat` > somewhat. > > This is achieved getting rid of a couple of lookup tables, caching the result > of `HexFormat.of().withUpperCase()`, and removing tiny allocati

Re: RFR: 8315789: Minor HexFormat performance improvements [v2]

2023-09-08 Thread Claes Redestad
> This PR seeks to improve formatting of hex digits using `java.util.HexFormat` > somewhat. > > This is achieved getting rid of a couple of lookup tables, caching the result > of `HexFormat.of().withUpperCase()`, and removing tiny allocation that > happens in the `formatHex(A, byte)` method. Im

RFR: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null"

2023-09-08 Thread Maurizio Cimadamore
This PR adds a privileged block surrounding the request to load the fallback linker library in LibFallback. The lack of this block is causing test failures when platforms using the fallback linker are tested using a security manager. - Commit messages: - Initial push Changes: http

Re: RFR: 8315678: Classfile API ConstantPool::entryCount and ConstantPool::entryByIndex methods are confusing [v3]

2023-09-08 Thread Adam Sotona
> Classfile API `ConstantPool::entryCount` and `ConstantPool::entryByIndex` > methods are confusing and unsafe to use without knowledge of constant pool > specification. > This patch renames `ConstantPool::entryCount` to `ConstantPool::size` and > adds checks to `ConstantPool::entryByIndex` for

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-08 Thread Adam Sotona
On Thu, 7 Sep 2023 03:10:33 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 227 commits: >> >> - Merge branch 'master' into JDK-8294969-javap >> - Merge branch 'master' into JDK-8294969-

Re: RFR: 8314544: Matrix multiple benchmark using Vector API [v2]

2023-09-08 Thread Eric Liu
On Mon, 21 Aug 2023 03:55:42 GMT, Martin Stypinski wrote: >> Added a bunch of different implementations for Vector API Matrix >> Multiplications: >> >> - Baseline >> - Blocked (Cache Local) >> - FMA >> - Vector API Simple Implementation >> - Vector API Blocked Implementation >> >> Commit was d

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v13]

2023-09-08 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: applied suggest

Re: RFR: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths [v2]

2023-09-08 Thread Alan Bateman
On Fri, 8 Sep 2023 01:07:17 GMT, Brian Burkhalter wrote: >> In the Windows implementation of java.io.File.getCanonicalPath, strip any >> long path or UNC prefix before canonicalizing the remainder of the pathname. > > Brian Burkhalter has updated the pull request incrementally with one > additi

Re: RFR: 8315789: Minor HexFormat performance improvements

2023-09-08 Thread Claes Redestad
On Fri, 8 Sep 2023 08:47:04 GMT, Raffaello Giulietti wrote: >> This PR seeks to improve formatting of hex digits using >> `java.util.HexFormat` somewhat. >> >> This is achieved getting rid of a couple of lookup tables, caching the >> result of `HexFormat.of().withUpperCase()`, and removing ti

Re: RFR: 8315789: Minor HexFormat performance improvements

2023-09-08 Thread Raffaello Giulietti
On Wed, 6 Sep 2023 13:36:22 GMT, Claes Redestad wrote: > This PR seeks to improve formatting of hex digits using `java.util.HexFormat` > somewhat. > > This is achieved getting rid of a couple of lookup tables, caching the result > of `HexFormat.of().withUpperCase()`, and removing tiny allocati

Re: RFR: 8315578: PPC builds are broken after JDK-8304913 [v3]

2023-09-08 Thread Martin Doerr
On Thu, 7 Sep 2023 16:21:18 GMT, Aleksey Shipilev wrote: >> Similar to other issues in the same area. I have no PPC32 machine to test >> the build on, but this matches other fixes for other architectures >> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) >> aft

Re: RFR: 8315578: PPC builds are broken after JDK-8304913 [v2]

2023-09-08 Thread Aleksey Shipilev
On Thu, 7 Sep 2023 13:54:25 GMT, Martin Doerr wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> com

Re: RFR: 8315578: PPC builds are broken after JDK-8304913 [v2]

2023-09-08 Thread Aleksey Shipilev
On Thu, 7 Sep 2023 14:07:05 GMT, Roger Riggs wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> comm

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock. [v2]

2023-09-08 Thread Alan Bateman
On Fri, 8 Sep 2023 07:44:21 GMT, Matthias Baesken wrote: > We could do this mid-term in some follow up action. It shouldn't be hard to try it. If it works out then it would mean this old crufty code goes away and the JDK is in a better place. If it doesn't work out then the a plan B would be t

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock. [v2]

2023-09-08 Thread Matthias Baesken
On Fri, 8 Sep 2023 07:19:55 GMT, Alan Bateman wrote: > we shouldn't be hardcoding the values of error numbers like this. Then print the good old int value and rely on OS tools to convert this, it is rather easy and available on some distros). Or move the current error-code handling code from ni

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock. [v2]

2023-09-08 Thread Alan Bateman
On Mon, 4 Sep 2023 11:57:47 GMT, Matthias Baesken wrote: >>> Hi Alan , Your assumption 'I assume the use of System.getProperty is >>> problematic when running with a SM.' is most likely correct. >> >> You'll need to test with a SM that denies reading the system property to be >> sure. There ar

  1   2   >