On Thu, 24 Aug 2023 17:36:46 GMT, Erik Joelsson wrote:
>> In the JDK build we have various build tools that generate source code from
>> data files. For most of these tools, the source files are based on template
>> files, which already have copyright headers, but for some, the complete
>> sou
On Sun, 7 Mar 2021 03:15:46 GMT, Yasumasa Suenaga wrote:
> I saw error during jpackage compilation with VS 2019 (16.9.0) as following
> (on Japanese locale):
>
>
> c:\progra~2\micros~2\2019\commun~1\vc\tools\msvc\1428~1.299\include\utility(604):
> error C2440: '=': '_Other' から '_Ty' に変換できません。
On Fri, 25 Aug 2023 02:07:54 GMT, Sandhya Viswanathan
wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Decomposed DPQS using AVX512 partitioning and AVX512 sort (for small
>> arrays). Works for serial and
On Fri, 25 Aug 2023 01:57:41 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Thu, 24 Aug 2023 17:36:46 GMT, Erik Joelsson wrote:
>> In the JDK build we have various build tools that generate source code from
>> data files. For most of these tools, the source files are based on template
>> files, which already have copyright headers, but for some, the complete
>> sou
On Fri, 25 Aug 2023 01:51:12 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Thu, 24 Aug 2023 06:23:29 GMT, Srinivas Vamsi Parasa
wrote:
>>> Improvements are nice but it would not pay off if you have big regressions.
>>> I can accept 0.9x but 0.4x - 0.8x regressions should be investigated and
>>> implementation adjusted to avoid them.
>>
>> Hi Vladimir,
>>
>> Than
On Thu, 24 Aug 2023 20:02:23 GMT, Alexey Semenyuk wrote:
> > I'm wondering how MSVC is compiling without the header
>
> For older MSVC it picks unique_ptr from
> https://github.com/openjdk/jdk/blob/2624324ac216aadc938a870075f6fad287fedf05/src/jdk.jpackage/share/native/common/kludge_c%2B%2B11.h
On Thu, 24 Aug 2023 13:56:12 GMT, Martin Doerr wrote:
> I've found a way to solve the remaining FFI problem on linux PPC64 Big
> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
> require shifting the Bytes in the last slot if the size is not a multiple of
> 8. This P
On Thu, 24 Aug 2023 23:55:28 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/Binding.java line 695:
>>
>>> 693: * Negative [shiftAmount] shifts right and converts to int if
>>> needed.
>>> 694: */
>>> 695: record ShiftLeft(int shiftAmount
On Thu, 24 Aug 2023 23:36:22 GMT, Maurizio Cimadamore
wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big
>> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
>> require shifting the Bytes in the last slot if the size is not a multiple of
On Thu, 24 Aug 2023 13:56:12 GMT, Martin Doerr wrote:
> I've found a way to solve the remaining FFI problem on linux PPC64 Big
> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
> require shifting the Bytes in the last slot if the size is not a multiple of
> 8. This P
On Thu, 24 Aug 2023 13:56:12 GMT, Martin Doerr wrote:
> I've found a way to solve the remaining FFI problem on linux PPC64 Big
> Endian. Large structs (>8 Bytes) which are passed in registers or on stack
> require shifting the Bytes in the last slot if the size is not a multiple of
> 8. This P
On Thu, 24 Aug 2023 22:03:53 GMT, Mandy Chung wrote:
> I like separating this from `Option` as it specifies what information to be
> collected from each frame whereas `Option` controls everything else such as
> what frames to be filtered
In my mind, `Option` _already_ can control what informat
> Please refer to JDK-8314063.
>
> The failure scenario is due to the setting of connection timeout. It is
> either too small or not an optimal value for the system. When the client
> tries to connect to the server with LDAPs protocol. It requires the handshake
> after the socket is created and
On Thu, 24 Aug 2023 18:44:14 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
> `Collections.rotate` method contains a bug. This method throws
> IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way to
> reproduce:
>
> final int size = (1 << 30) + 1;
> final List list = new ArrayList<>(size);
> for (int i = 0; i < size; ++i)
> list.add((byte) 0);
On Thu, 24 Aug 2023 18:44:14 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
> `Collections.rotate` method contains a bug. This method throws
> IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way to
> reproduce:
>
> final int size = (1 << 30) + 1;
> final List list = new ArrayList<>(size);
> for (int i = 0; i < size; ++i)
> list.add((byte) 0);
On Thu, 24 Aug 2023 21:38:41 GMT, Kevin Walls wrote:
>> Several tests from test/jdk/sun/tools/jstatd are intermittent.
>>
>> Port clashes when run at the same time on the same machine have been a
>> problem.
>> The RMI error "no such object in table" can mean a reference on the RMI
>> server h
On Thu, 24 Aug 2023 20:48:01 GMT, Weibing Xiao wrote:
>> Please refer to JDK-8314063.
>>
>> The failure scenario is due to the setting of connection timeout. It is
>> either too small or not an optimal value for the system. When the client
>> tries to connect to the server with LDAPs protocol.
Please review this PR and [CSR
](https://bugs.openjdk.org/browse/JDK-8314974)which clarifies behavior for
BreakIterator instances when text has not been set.
For example, calling `BreakIterator.getWordInstance().next();` has an
ambiguous result.
A boundary searching operation was called but no
> Several tests from test/jdk/sun/tools/jstatd are intermittent.
>
> Port clashes when run at the same time on the same machine have been a
> problem.
> The RMI error "no such object in table" can mean a reference on the RMI
> server has been GC'd.
> Either way, jstatd fails to startup and and t
On Thu, 24 Aug 2023 18:08:13 GMT, Mark Sheppard wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Less specific error message, could be ports or other failure..
>
> test/jdk/sun/tools/jstatd/JstatdTest.java line 327:
> Please refer to JDK-8314063.
>
> The failure scenario is due to the setting of connection timeout. It is
> either too small or not an optimal value for the system. When the client
> tries to connect to the server with LDAPs protocol. It requires the handshake
> after the socket is created and
On Sun, 7 Mar 2021 03:15:46 GMT, Yasumasa Suenaga wrote:
> I saw error during jpackage compilation with VS 2019 (16.9.0) as following
> (on Japanese locale):
>
>
> c:\progra~2\micros~2\2019\commun~1\vc\tools\msvc\1428~1.299\include\utility(604):
> error C2440: '=': '_Other' から '_Ty' に変換できません。
On Thu, 24 Aug 2023 18:45:01 GMT, Weibing Xiao wrote:
>> Please refer to JDK-8314063.
>>
>> The failure scenario is due to the setting of connection timeout. It is
>> either too small or not an optimal value for the system. When the client
>> tries to connect to the server with LDAPs protocol.
> Please refer to JDK-8314063.
>
> The failure scenario is due to the setting of connection timeout. It is
> either too small or not an optimal value for the system. When the client
> tries to connect to the server with LDAPs protocol. It requires the handshake
> after the socket is created and
> 8268829: Provide an optimized way to walk the stack with Class object only
>
> `StackWalker::walk` creates one `StackFrame` per frame and the current
> implementation
> allocates one `StackFrameInfo` and one `MemberName` objects per frame. Some
> frameworks
> like logging may only interest in
On Fri, 18 Aug 2023 23:14:20 GMT, Brian Burkhalter wrote:
> Revise some verbiage about the `RandomAccessFile(String,String)` constructor
> so that the string name of a file is referred to as _pathname string_ for
> consistency with `java.io.File`.
This pull request has now been integrated.
Ch
Hi Alex,
Yes, I understand that this issue is about fixing a bug in the current approach.
Although it is a moot point, my opinion is that the current approach is
ill-conceived and should be scrapped,
so improving it is a wasted effort.
The problems with the current approach:
1. An attempt is m
On Thu, 24 Aug 2023 14:57:47 GMT, Kevin Walls wrote:
>> Several tests from test/jdk/sun/tools/jstatd are intermittent.
>>
>> Port clashes when run at the same time on the same machine have been a
>> problem.
>> The RMI error "no such object in table" can mean a reference on the RMI
>> server h
On Thu, 24 Aug 2023 14:57:47 GMT, Kevin Walls wrote:
>> Several tests from test/jdk/sun/tools/jstatd are intermittent.
>>
>> Port clashes when run at the same time on the same machine have been a
>> problem.
>> The RMI error "no such object in table" can mean a reference on the RMI
>> server h
On Thu, 24 Aug 2023 17:36:46 GMT, Erik Joelsson wrote:
>> In the JDK build we have various build tools that generate source code from
>> data files. For most of these tools, the source files are based on template
>> files, which already have copyright headers, but for some, the complete
>> sou
On Thu, 24 Aug 2023 04:46:31 GMT, David Holmes wrote:
>> Erik Joelsson has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Suggestion from dholmes
>
> make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java
> line 62:
> In the JDK build we have various build tools that generate source code from
> data files. For most of these tools, the source files are based on template
> files, which already have copyright headers, but for some, the complete
> source file is generated by the tool, which is providing the cop
On Wed, 23 Aug 2023 16:41:23 GMT, Alan Bateman wrote:
> If yielding fails due to the pinning then VirtualThread.parkNanos parks on
> the carrier thread with the remaining time. The calculation of the remaining
> time needs to be replaced so that it obviously uses the difference between
> the s
On Thu, 24 Aug 2023 13:49:29 GMT, Daniel Fuchs wrote:
>> Mandy Chung has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - fix whitespace
>> - move retainClassRef to ClassFrameInfo as a bit set in the flags field
>> - fixup the factory m
On Thu, 24 Aug 2023 13:47:42 GMT, Daniel Fuchs wrote:
>> Mandy Chung has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - fix whitespace
>> - move retainClassRef to ClassFrameInfo as a bit set in the flags field
>> - fixup the factory m
On Tue, 30 May 2023 13:03:27 GMT, Aleksandar Pejovic
wrote:
> The current code for cgroup support in the JDK has large and expensive
> dependencies: it uses NIO, streams, and regular expressions. This leads to
> unnecessary class loading and slows down startup, especially when the code is
> e
Hello,I don’t really understand this discussion,is the normal IO and NIO api not already interpreting error codes? (I am quite sure I often see nationalized error messages in exceptions).https://github.com/openjdk/jdk/blob/76b9011c9ecb8c0c713a58d034f281ba70d65d4e/src/java.
> Port clashes happening when several tests from test/jdk/sun/tools/jstatd run
> at the same time on the same machine.
>
> There is logic in here for detecting this, but it's not working.
>
> We recently saw this fail with a port in use, and the failure is:
>
> [Jstatd-Thread] Could not bind //
On Wed, 23 Aug 2023 20:27:38 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
On Thu, 24 Aug 2023 13:37:36 GMT, Alan Bateman wrote:
> Something fishy here, is this working around a bug in GraaVM native image or
> why does this change need to be in JDK?
I've now realized that the bug had an incorrect statement in the description.
The cycle happens due to the `Runtime.get
I've found a way to solve the remaining FFI problem on linux PPC64 Big Endian.
Large structs (>8 Bytes) which are passed in registers or on stack require
shifting the Bytes in the last slot if the size is not a multiple of 8. This PR
adds the required functionality to the Java code.
Please revi
On Thu, 24 Aug 2023 00:10:54 GMT, Weibing Xiao wrote:
>> Please refer to JDK-8314063.
>>
>> The failure scenario is due to the setting of connection timeout. It is
>> either too small or not an optimal value for the system. When the client
>> tries to connect to the server with LDAPs protocol.
On Thu, 24 Aug 2023 13:16:16 GMT, Severin Gehwolf wrote:
> Please review this rather trivial fix to not use `nio` in `CgroupUtil`, part
> of the
> JDK's Metrics API. The primary motivating factor is that it allows one to use
> the
> JDK's version of `Metrics` in GraalVM. See the bug for details
Please review this rather trivial fix to not use `nio` in `CgroupUtil`, part of
the
JDK's Metrics API. The primary motivating factor is that it allows one to use
the
JDK's version of `Metrics` in GraalVM. See the bug for details as to why this is
needed.
Testing:
- [x] GraalVM builds with/withou
On Thu, 24 Aug 2023 11:55:20 GMT, Daniel Fuchs wrote:
> Although... what happens if parkOnCarrierThread is called with a negative
> value (as that could happen here)?
Not an issue, nothing has changed there.
-
PR Comment: https://git.openjdk.org/jdk/pull/15405#issuecomment-1691569
On Thu, 24 Aug 2023 11:34:13 GMT, Kevin Walls wrote:
> Port clashes happening when several tests from test/jdk/sun/tools/jstatd run
> at the same time on the same machine.
>
> There is logic in here for detecting this, but it's not working.
>
> We recently saw this fail with a port in use, and
On Wed, 23 Aug 2023 16:41:23 GMT, Alan Bateman wrote:
> If yielding fails due to the pinning then VirtualThread.parkNanos parks on
> the carrier thread with the remaining time. The calculation of the remaining
> time needs to be replaced so that it obviously uses the difference between
> the s
On Wed, 23 Aug 2023 16:41:23 GMT, Alan Bateman wrote:
> If yielding fails due to the pinning then VirtualThread.parkNanos parks on
> the carrier thread with the remaining time. The calculation of the remaining
> time needs to be replaced so that it obviously uses the difference between
> the s
On Wed, 16 Aug 2023 13:36:38 GMT, Matthias Baesken wrote:
> We run into some BackingStoreException: Couldn't get file lock. e.g. here :
>
> [JShell] Exception in thread "main" java.lang.IllegalStateException:
> java.util.prefs.BackingStoreException: Couldn't get file lock.
> [JShell] at
> jdk.
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and ForkJ
Port clashes happening when several tests from test/jdk/sun/tools/jstatd run at
the same time on the same machine.
There is logic in here for detecting this, but it's not working.
We recently saw this fail with a port in use, and the failure is:
[Jstatd-Thread] Could not bind //:33859/TestJstat
On Thu, 10 Aug 2023 09:54:43 GMT, Christoph Langer wrote:
> On Windows, the test java/lang/ProcessHandle/InfoTest.java can fail when run
> as user that is member of the Administrators group. In that case new files
> are not owned by the user but instead by BUILTIN\ADMINISTRATORS. This breaks
>
On Wed, 23 Aug 2023 15:41:16 GMT, Sean Coffey wrote:
> Recursive initialization calls possible during loading of LoggerFinder
> service.
>
> This fix detects the recursive call and returns a temporary LoggerFinder that
> is backed by a lazy logger. Automated test case developed to simulate l
> Recursive initialization calls possible during loading of LoggerFinder
> service.
>
> This fix detects the recursive call and returns a temporary LoggerFinder that
> is backed by a lazy logger. Automated test case developed to simulate loading
> of an external LoggerFinder service while als
On Wed, 23 Aug 2023 13:45:14 GMT, Matthias Baesken wrote:
> There seems to be a codepath in
> Java_java_util_prefs_FileSystemPreferences_lockFile0 where the errno is not
> stored but potentially accessed in the calling Java code.
Thanks for the reviews !
-
PR Comment: https://git
On Wed, 23 Aug 2023 13:45:14 GMT, Matthias Baesken wrote:
> There seems to be a codepath in
> Java_java_util_prefs_FileSystemPreferences_lockFile0 where the errno is not
> stored but potentially accessed in the calling Java code.
This pull request has now been integrated.
Changeset: 97b94cb1
On Wed, 23 Aug 2023 13:45:14 GMT, Matthias Baesken wrote:
> There seems to be a codepath in
> Java_java_util_prefs_FileSystemPreferences_lockFile0 where the errno is not
> stored but potentially accessed in the calling Java code.
Looks OK to me.
-
Marked as reviewed by vtewari (C
On Wed, 23 Aug 2023 13:45:14 GMT, Matthias Baesken wrote:
> There seems to be a codepath in
> Java_java_util_prefs_FileSystemPreferences_lockFile0 where the errno is not
> stored but potentially accessed in the calling Java code.
Looks reasonable.
-
Marked as reviewed by shade (R
On Wed, 23 Aug 2023 16:41:23 GMT, Alan Bateman wrote:
> If yielding fails due to the pinning then VirtualThread.parkNanos parks on
> the carrier thread with the remaining time. The calculation of the remaining
> time needs to be replaced so that it obviously uses the difference between
> the s
On Wed, 23 Aug 2023 21:41:41 GMT, Brian Burkhalter wrote:
>> Vyom Tewari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> make the isOpen method to package private
>
> src/java.base/share/classes/java/io/FilterOutputStream.java line 210:
Thanks Roger, Remi.
Just want to understand full picture.
For both solutions, private static final nested class and dynamic anonymous
overloading, based on dipole/boolean pattern where all methods has opposite
charge, JVM produces separate code for classes that in total has:
- >10% less commands,
On Sun, 7 Mar 2021 03:15:46 GMT, Yasumasa Suenaga wrote:
> I saw error during jpackage compilation with VS 2019 (16.9.0) as following
> (on Japanese locale):
>
>
> c:\progra~2\micros~2\2019\commun~1\vc\tools\msvc\1428~1.299\include\utility(604):
> error C2440: '=': '_Other' から '_Ty' に変換できません。
On Wed, 23 Aug 2023 12:26:36 GMT, Martin Doerr wrote:
> Please check windows-aarch64 build error: unresolved external symbol
> dlopen_ext
Hi Martin, thanks ! I did a small adjustment, now the windows aarch64 build
works.
-
PR Comment: https://git.openjdk.org/jdk/pull/15264#issue
On Wed, 23 Aug 2023 13:45:14 GMT, Matthias Baesken wrote:
> There seems to be a codepath in
> Java_java_util_prefs_FileSystemPreferences_lockFile0 where the errno is not
> stored but potentially accessed in the calling Java code.
Hi jaikiran, thanks for the review !
-
PR Comment:
68 matches
Mail list logo
