On Wed, 23 Aug 2023 21:41:41 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> Vyom Tewari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> make the isOpen method to package private > > src/java.base/share/classes/java/io/FilterOutputStream.java line 210: > >> 208: */ >> 209: boolean isOpen(){ >> 210: return !closed; > > Wouldn't you want `synchronized (closeLock)` here? 'closed' is volatile, we don't need synchronized (closeLock) here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15361#discussion_r1303968655