On Wed, 2 Aug 2023 05:24:28 GMT, David Holmes wrote:
> @jaikiran I would concur - back out the change that caused the problem.
Hello David, I have now opened a PR to revert that change
https://github.com/openjdk/jdk/pull/15118
-
PR Comment: https://git.openjdk.org/jdk/pull/15102#i
On Mon, 31 Jul 2023 18:13:07 GMT, Roger Riggs wrote:
>Please change the bug priority to P2; that is needed to be considered.
> Add a comment as described headlined with "Fix Request" and the described
> rationale and information.
Added comment and set priority to P2. This is low risk code chan
On Tue, 1 Aug 2023 10:31:13 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address the build
>> failure noted in https://bugs.openjdk.org/browse/JDK-8313274?
>>
>> The build failure is consistently reproducible with `--with-jobs=1`. Martin,
>> in that JB
On Mon, 31 Jul 2023 08:13:55 GMT, Jorn Vernee wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [6fca2898](https://github.com/openjdk/jdk/commit/6fca28988794b52a6aa974bed1ed6f4f07e0994b)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Tue, 1 Aug 2023 21:02:36 GMT, Matias Saavedra Silva
wrote:
>> src/hotspot/share/oops/constantPool.cpp line 308:
>>
>>> 306: assert(java_lang_String::is_instance(obj), "must be");
>>> 307: if (!ArchiveHeapWriter::is_string_too_large_to_archive(obj))
>>> {
>>> 308:
On Mon, 31 Jul 2023 12:22:00 GMT, Yasumasa Suenaga wrote:
> In FFM, native function would be called via `nep_invoker_blob`. If the
> function has two arguments, it would be following:
>
>
> Decoding RuntimeStub - nep_invoker_blob 0x7fcae394cd10
> ---
On Tue, 1 Aug 2023 19:32:40 GMT, Joe Wang wrote:
> Please review a patch that adds the @since tag to DOM package.
This pull request has now been integrated.
Changeset: 528596fa
Author:Joe Wang
URL:
https://git.openjdk.org/jdk/commit/528596fa937f8589f71fa06929fbb75f62142a4f
Stats:
On Tue, 1 Aug 2023 19:32:40 GMT, Joe Wang wrote:
> Please review a patch that adds the @since tag to DOM package.
Thanks all!
-
PR Comment: https://git.openjdk.org/jdk/pull/15109#issuecomment-1661344704
On Wed, 26 Jul 2023 20:41:36 GMT, Justin Lu wrote:
> Please review this PR which contains the translations for updates to
> localized resources in the JDK since RDP1.
>
> Included in this change are improved translations for certain values, which
> also includes global updates for translations
On Mon, 31 Jul 2023 21:13:16 GMT, Justin Lu wrote:
> Please review this change which contains a backport of commit
> [c6396dce](https://github.com/openjdk/jdk/commit/c6396dceb9a64578d5b335af27ad1d968190a1fa)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This PR is a jav
Hi all,
This pull request contains a backport of
[JDK-8311822](https://bugs.openjdk.org/browse/JDK-8311822), commit
[d1cc2782](https://github.com/openjdk/jdk/commit/d1cc2782606e8a3cfead9055aa845e48e851edd4)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backpo
On Tue, 1 Aug 2023 21:08:05 GMT, Matias Saavedra Silva
wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have
> Currently we exit the VM after static dumping with
> `MetaspaceShared::exit_after_static_dump()`.
>
>
> // We have finished dumping the static archive. At this point, there may be
> pending VM
> // operations. We have changed some global states (such as
> vmClasses::_klasses) that
> // m
On Tue, 1 Aug 2023 17:02:46 GMT, Calvin Cheung wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Ioi comments
>
> src/hotspot/share/oops/constantPool.cpp line 308:
>
>> 306: assert(java_lang_Strin
> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where
> aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the
> in-house cache with WeakHashMap, and removed the Key class as it is no longer
> needed (thus the original NPE will no longer be possible). A
On Tue, 1 Aug 2023 09:01:49 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the build
> failure noted in https://bugs.openjdk.org/browse/JDK-8313274?
>
> The build failure is consistently reproducible with `--with-jobs=1`. Martin,
> in that JBS iss
On Tue, 1 Aug 2023 19:32:40 GMT, Joe Wang wrote:
> Please review a patch that adds the @since tag to DOM package.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15109#pullrequestreview-1557752047
On Tue, 1 Aug 2023 19:32:40 GMT, Joe Wang wrote:
> Please review a patch that adds the @since tag to DOM package.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15109#pullrequestreview-1557745601
On Tue, 1 Aug 2023 19:32:40 GMT, Joe Wang wrote:
> Please review a patch that adds the @since tag to DOM package.
Added @since tags follow existing convention for XML APIs in java.xml and
jdk.xml.dom modules.
-
Marked as reviewed by iris (Reviewer).
PR Review: https://git.openjdk
Please review a patch that adds the @since tag to DOM package.
-
Commit messages:
- 8310991: missing @since tags in java.xml
Changes: https://git.openjdk.org/jdk/pull/15109/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15109&range=00
Issue: https://bugs.openjdk.org/brows
On Thu, 27 Jul 2023 19:09:00 GMT, Matias Saavedra Silva
wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have
On Tue, 1 Aug 2023 11:17:57 GMT, ExE Boss wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign). The
On Tue, 1 Aug 2023 10:29:06 GMT, Jorn Vernee wrote:
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The m
On Tue, 1 Aug 2023 10:29:06 GMT, Jorn Vernee wrote:
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The m
This patch contains the implementation of the foreign linker & memory API JEP
for Java 22. The initial patch is composed of commits brought over directly
from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). The
main changes found in this patch come from the following PRs:
On Mon, 31 Jul 2023 19:48:45 GMT, Roger Riggs wrote:
> A doc-only change to improve javadoc in java.time.
This pull request has now been integrated.
Changeset: a228185e
Author:Roger Riggs
URL:
https://git.openjdk.org/jdk21/commit/a228185ebbda9b2004262b494f648ab62078fcde
Stats: 8
On Mon, 31 Jul 2023 12:22:00 GMT, Yasumasa Suenaga wrote:
> In FFM, native function would be called via `nep_invoker_blob`. If the
> function has two arguments, it would be following:
>
>
> Decoding RuntimeStub - nep_invoker_blob 0x7fcae394cd10
> ---
On Tue, 1 Aug 2023 09:01:49 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the build
> failure noted in https://bugs.openjdk.org/browse/JDK-8313274?
>
> The build failure is consistently reproducible with `--with-jobs=1`. Martin,
> in that JBS iss
On Tue, 1 Aug 2023 10:30:18 GMT, Alan Bateman wrote:
> It also opens the door to accidental mix 'n match of modules from different
> JDK modules. So I don't think this the right change for this issue.
-
PR Comment: https://git.openjdk.org/jdk/pull/15102#issuecomment-1660035694
On Tue, 1 Aug 2023 09:01:49 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the build
> failure noted in https://bugs.openjdk.org/browse/JDK-8313274?
>
> The build failure is consistently reproducible with `--with-jobs=1`. Martin,
> in that JBS iss
On Tue, 1 Aug 2023 09:01:49 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the build
> failure noted in https://bugs.openjdk.org/browse/JDK-8313274?
>
> The build failure is consistently reproducible with `--with-jobs=1`. Martin,
> in that JBS iss
31 matches
Mail list logo
