Re: [jdk21] RFR: 8313260: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on linux-x86

2023-07-27 Thread Christoph Langer
On Thu, 27 Jul 2023 18:21:45 GMT, Sergey Bylokhov wrote: > This patch adds the java/lang/ScopedValue/StressStackOverflow.java to the > problem list for linux-x86 where it intermittently fails on a GA, ex: > https://github.com/openjdk/jdk21/pull/148 > > This is only for JDK 21, test passes on

Re: [jdk21] RFR: 8313260: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on linux-x86

2023-07-27 Thread Sergey Bylokhov
On Thu, 27 Jul 2023 18:21:45 GMT, Sergey Bylokhov wrote: > This patch adds the java/lang/ScopedValue/StressStackOverflow.java to the > problem list for linux-x86 where it intermittently fails on a GA, ex: > https://github.com/openjdk/jdk21/pull/148 > > This is only for JDK 21, test passes on

Re: [jdk21] RFR: 8313260: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on linux-x86

2023-07-27 Thread Jaikiran Pai
On Thu, 27 Jul 2023 18:21:45 GMT, Sergey Bylokhov wrote: > This patch adds the java/lang/ScopedValue/StressStackOverflow.java to the > problem list for linux-x86 where it intermittently fails on a GA, ex: > https://github.com/openjdk/jdk21/pull/148 > > This is only for JDK 21, test passes on

[jdk21] RFR: 8313260: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on linux-x86

2023-07-27 Thread Sergey Bylokhov
This patch adds the java/lang/ScopedValue/StressStackOverflow.java to the problem list for linux-x86 where it intermittently fails on a GA, ex: https://github.com/openjdk/jdk21/pull/148 This is only for JDK 21, test passes on JDK 22. - Commit messages: - use linux-i586 - 8313260

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v3]

2023-07-27 Thread sid8606
On Fri, 21 Jul 2023 12:17:55 GMT, Martin Doerr wrote: >> sid8606 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address suggestions from Jorn Vernee > > I can see it failing with `make run-test TEST="jdk/java/foreign"` on g9-z15, > gli

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v3]

2023-07-27 Thread sid8606
On Thu, 27 Jul 2023 05:05:57 GMT, sid8606 wrote: >> src/hotspot/cpu/s390/downcallLinker_s390.cpp line 162: >> >>> 160: >>> 161: assert(!_needs_return_buffer, "unexpected needs_return_buffer"); >>> 162: bool should_save_return_value = _needs_transition;; >> >> This should always be `true`,

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

2023-07-27 Thread sid8606
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). sid8606 has updated the pull request incrementally with one additional commit since the last revision: Preserve and restore register Z_R6 Though Z_R6 is argument register it is a saved register so preserve and r

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v5]

2023-07-27 Thread sid8606
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). sid8606 has updated the pull request incrementally with one additional commit since the last revision: remove if statements around the spill/fill code See: #15025 (should_save_return_value being dependent on _need

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v4]

2023-07-27 Thread sid8606
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). sid8606 has updated the pull request incrementally with one additional commit since the last revision: revert platform byte ordering changes - Changes: - all: https://git.openjdk.org/jdk/pull/14801/file

Withdrawn: 8308804: Improve UUID.randomUUID performance with bulk/scalable PRNG access

2023-07-27 Thread duke
On Wed, 24 May 2023 19:36:44 GMT, Aleksey Shipilev wrote: > UUID is the very important class that is used to track identities of objects > in large scale systems. On some of our systems, `UUID.randomUUID` takes >1% > of total CPU time, and is frequently a scalability bottleneck due to > `Secur

Re: RFR: 8294979: test/jdk/tools/jlink 3 test classes use ASM library

2023-07-27 Thread Mandy Chung
On Thu, 13 Jul 2023 18:35:42 GMT, Qing Xiao wrote: > Modified 3 of 3 test/jdk/tools/jlink test classes to replace > com.sun.tools.classfile library. Looks good. - Marked as reviewed by mchung (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14877#pullrequestreview-15509595

Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v2]

2023-07-27 Thread Sergey Tsypanov
On Thu, 27 Jul 2023 16:59:58 GMT, Brian Burkhalter wrote: >> Then I guess we don't need this `if`-clause > > Then I think one gets an error if `0 < len < BUF_SIZE`: > > > $ cat free.c > #include > > int main(int argc, char** argv) > { > char stackBuf[8]; > char* buf; > > buf = st

Re: CFV: New Core Libraries Group Member: Joe Wang

2023-07-27 Thread mandy . chung
Vote: Yes Mandy On 7/27/23 11:36 AM, Roger Riggs wrote: |I hereby nominate Joe Wang||to Membership in the Core Libraries Group Joe has been working in the core library team since 2012. He has been maintaining and improving the XML library APIs and implementations including ||DOM, SAX, StAX, Tr

Re: CFV: New Core Libraries Group Member: Brent Christian

2023-07-27 Thread mandy . chung
Vote: Yes Mandy On 7/27/23 11:36 AM, Roger Riggs wrote: |I hereby nominate |Brent Christian|to Membership in the Core Libraries Group Brent has been working in the Core Library team at Oracle since 2012. He has made contributions to many areas of OpenJDK including java.lang strings, class load

Re: CFV: New Core Libraries Group Member: Brian Burkhalter

2023-07-27 Thread mandy . chung
Vote: Yes Mandy On 7/27/23 11:35 AM, Roger Riggs wrote: |I hereby nominate |Brian Burkhalter|to Membership in the Core Libraries Group Brian has been working in the Core Library team since 2012. Brian's many contributions to the OpenJDK libraries include java.io subsystems, NIO channels, files

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v4]

2023-07-27 Thread Matias Saavedra Silva
> Currently we exit the VM after static dumping with > `MetaspaceShared::exit_after_static_dump()`. > > > // We have finished dumping the static archive. At this point, there may be > pending VM > // operations. We have changed some global states (such as > vmClasses::_klasses) that > // m

Re: CFV: New Core Libraries Group Member: Brian Burkhalter

2023-07-27 Thread Roger Riggs
Vote: Yes On 7/27/23 2:35 PM, Roger Riggs wrote: |I hereby nominate |Brian Burkhalter|to Membership in the Core Libraries Group|

Re: CFV: New Core Libraries Group Member: Joe Wang

2023-07-27 Thread Naoto Sato
Vote: yes Naoto On 7/27/23 11:36 AM, Roger Riggs wrote: |I hereby nominate Joe Wang||to Membership in the Core Libraries Group Joe has been working in the core library team since 2012. He has been maintaining and improving the XML library APIs and implementations including ||DOM, SAX, StAX, Tr

Re: CFV: New Core Libraries Group Member: Brent Christian

2023-07-27 Thread Roger Riggs
Vote: Yes On 7/27/23 2:36 PM, Roger Riggs wrote: |I hereby nominate |Brent Christian|to Membership in the Core Libraries Group|

Re: CFV: New Core Libraries Group Member: Joe Wang

2023-07-27 Thread Roger Riggs
Vote: Yes On 7/27/23 2:36 PM, Roger Riggs wrote: |I hereby nominate Joe Wang||to Membership in the Core Libraries Group|

Re: CFV: New Core Libraries Group Member: Brent Christian

2023-07-27 Thread Naoto Sato
Vote: yes Naoto On 7/27/23 11:36 AM, Roger Riggs wrote: |I hereby nominate |Brent Christian|to Membership in the Core Libraries Group Brent has been working in the Core Library team at Oracle since 2012. He has made contributions to many areas of OpenJDK including java.lang strings, class load

Re: CFV: New Core Libraries Group Member: Brian Burkhalter

2023-07-27 Thread Naoto Sato
Vote: yes Naoto On 7/27/23 11:35 AM, Roger Riggs wrote: |I hereby nominate |Brian Burkhalter|to Membership in the Core Libraries Group Brian has been working in the Core Library team since 2012. Brian's many contributions to the OpenJDK libraries include java.io subsystems, NIO channels, files

Re: CFV: New Core Libraries Group Member: Joe Wang

2023-07-27 Thread Joseph D. Darcy
Vote: yes On 7/27/2023 11:36 AM, Roger Riggs wrote: |I hereby nominate Joe Wang||to Membership in the Core Libraries Group Joe has been working in the core library team since 2012. He has been maintaining and improving the XML library APIs and implementations including ||DOM, SAX, StAX, Transfo

Re: CFV: New Core Libraries Group Member: Brent Christian

2023-07-27 Thread Joseph D. Darcy
Vote: yes On 7/27/2023 11:36 AM, Roger Riggs wrote: |I hereby nominate |Brent Christian|to Membership in the Core Libraries Group Brent has been working in the Core Library team at Oracle since 2012. He has made contributions to many areas of OpenJDK including java.lang strings, class loader,

Re: CFV: New Core Libraries Group Member: Brian Burkhalter

2023-07-27 Thread Joseph D. Darcy
Vote: yes On 7/27/2023 11:35 AM, Roger Riggs wrote: |I hereby nominate |Brian Burkhalter|to Membership in the Core Libraries Group Brian has been working in the Core Library team since 2012. Brian's many contributions to the OpenJDK libraries include java.io subsystems, NIO channels, files, and

CFV: New Core Libraries Group Member: Brian Burkhalter

2023-07-27 Thread Roger Riggs
|I hereby nominate |Brian Burkhalter|to Membership in the Core Libraries Group Brian has been working in the Core Library team since 2012. Brian's many contributions to the OpenJDK libraries include java.io subsystems, NIO channels, files, and buffers. He applies his background in math and image

CFV: New Core Libraries Group Member: Brent Christian

2023-07-27 Thread Roger Riggs
|I hereby nominate |Brent Christian|to Membership in the Core Libraries Group Brent has been working in the Core Library team at Oracle since 2012. He has made contributions to many areas of OpenJDK including java.lang strings, class loader, NIO Jar, and many more. Most recently he has been work

CFV: New Core Libraries Group Member: Joe Wang

2023-07-27 Thread Roger Riggs
|I hereby nominate Joe Wang||to Membership in the Core Libraries Group Joe has been working in the core library team since 2012. He has been maintaining and improving the XML library APIs and implementations including ||DOM, SAX, StAX, Transform, Validation, XPath and Catalog. Recently he has be

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v3]

2023-07-27 Thread Ioi Lam
On Thu, 27 Jul 2023 13:40:56 GMT, Matias Saavedra Silva wrote: >> Currently we exit the VM after static dumping with >> `MetaspaceShared::exit_after_static_dump()`. >> >> >> // We have finished dumping the static archive. At this point, there may be >> pending VM >> // operations. We have

Re: RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-07-27 Thread Naoto Sato
On Wed, 26 Jul 2023 20:41:36 GMT, Justin Lu wrote: > Please review this PR which contains the translations for updates to > localized resources in the JDK since RDP1. > > Included in this change are improved translations for certain values, which > also includes global updates for translations

Re: RFR: 8294979: test/jdk/tools/jlink 3 test classes use ASM library

2023-07-27 Thread Adam Sotona
On Thu, 13 Jul 2023 18:35:42 GMT, Qing Xiao wrote: > Modified 3 of 3 test/jdk/tools/jlink test classes to replace > com.sun.tools.classfile library. I would suggest to minimise footprint of the patch and do not change unrelated code. Any unnecessary reformat can cause conflicts when merging in

Re: RFR: 8294979: test/jdk/tools/jlink 3 test classes use ASM library

2023-07-27 Thread Adam Sotona
On Sun, 16 Jul 2023 12:37:44 GMT, Chen Liang wrote: > I think these exports can probably be removed completely; no test code uses > ASM, meaning the export was likely redundant from the very beginning. I can confirm, the tests are passing even without the exports. - PR Comment: ht

RFR: 8294979: test/jdk/tools/jlink 3 test classes use ASM library

2023-07-27 Thread Qing Xiao
Modified 3 of 3 test/jdk/tools/jlink test classes to replace com.sun.tools.classfile library. - Commit messages: - Dropped unnecessary exports. - Rollback the original format - 8294979: test/jdk/tools/jlink 3 test classes use ASM library Changes: https://git.openjdk.org/jdk/pull/

Re: RFR: 8294979: test/jdk/tools/jlink 3 test classes use ASM library

2023-07-27 Thread Chen Liang
On Thu, 13 Jul 2023 18:35:42 GMT, Qing Xiao wrote: > Modified 3 of 3 test/jdk/tools/jlink test classes to replace > com.sun.tools.classfile library. I think these exports can probably be removed completely; no test code uses ASM, meaning the export was likely redundant from the very beginning.

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-07-27 Thread Adam Sotona
On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target b

Re: RFR: 8312491: Update Classfile API snippets and examples [v3]

2023-07-27 Thread Adam Sotona
> 8312491: Update Classfile API snippets and examples Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixing javadoc - Changes: - all: https://git.openjdk.org/jdk/pull/14968/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: 8312491: Update Classfile API snippets and examples [v2]

2023-07-27 Thread Adam Sotona
> 8312491: Update Classfile API snippets and examples Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixing javadoc - Changes: - all: https://git.openjdk.org/jdk/pull/14968/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v2]

2023-07-27 Thread Brian Burkhalter
On Thu, 27 Jul 2023 16:35:05 GMT, Sergey Tsypanov wrote: >> I don't see how this is possible. The value of `buf` is either `stackBuf` or >> a value returned by `malloc()`. In any case, this code will be superseded. > > Then I guess we don't need this `if`-clause Then I think one gets an error i

Re: RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-07-27 Thread Damon Nguyen
On Thu, 27 Jul 2023 06:48:32 GMT, Justin Lu wrote: >> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n.properties >> line 185: >> >>> 183: jshell.console.no.javadoc = >>> 184: jshell.console.do.nothing = Do nothing >>> 185: jshell.console.choice = Choice:\u0020 >> >> I see

Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v2]

2023-07-27 Thread Sergey Tsypanov
On Thu, 27 Jul 2023 15:54:30 GMT, Brian Burkhalter wrote: >> src/java.base/share/native/libjava/io_util.c line 199: >> >>> 197: } >>> 198: >>> 199: if (buf != stackBuf) >> >> Wouldn't this cause a leak when if-condition is not met and `free(buf)` is >> not called? > > I don't see how

Integrated: 8311104: dangling-gsl warning in libwixhelper.cpp

2023-07-27 Thread Alexey Semenyuk
On Wed, 26 Jul 2023 18:42:47 GMT, Alexey Semenyuk wrote: > 8311104: dangling-gsl warning in libwixhelper.cpp This pull request has now been integrated. Changeset: 0ca2bfd7 Author:Alexey Semenyuk URL: https://git.openjdk.org/jdk/commit/0ca2bfd77960a84486d10d910aa47b2aa9c14e22 Stats:

Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v2]

2023-07-27 Thread Brian Burkhalter
On Thu, 27 Jul 2023 13:42:43 GMT, Sergey Tsypanov wrote: >> Brian Burkhalter has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - 6478546: Decrease malloc limit to 1.5 MB >> - 6478546: Minor refactoring >> - 6478546: Prevent short read

Re: RFR: 8312491: Update Classfile API snippets and examples

2023-07-27 Thread Adam Sotona
On Thu, 27 Jul 2023 14:59:49 GMT, Brian Goetz wrote: >> 8312491: Update Classfile API snippets and examples > > src/java.base/share/classes/jdk/internal/classfile/CodeBuilder.java line 1239: > >> 1237: return ldc(BytecodeHelpers.constantEntry(constantPool(), >> value)); >> 1238: } >

Re: RFR: 8312491: Update Classfile API snippets and examples

2023-07-27 Thread Brian Goetz
On Fri, 21 Jul 2023 09:37:10 GMT, Adam Sotona wrote: > 8312491: Update Classfile API snippets and examples src/java.base/share/classes/jdk/internal/classfile/CodeBuilder.java line 1239: > 1237: return ldc(BytecodeHelpers.constantEntry(constantPool(), > value)); > 1238: } > 1239:

RFR: 8312491: Update Classfile API snippets and examples

2023-07-27 Thread Adam Sotona
8312491: Update Classfile API snippets and examples - Commit messages: - 8312491: Update Classfile API snippets and examples Changes: https://git.openjdk.org/jdk/pull/14968/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14968&range=00 Issue: https://bugs.openjdk.org/brows

Integrated: 8310033: Clarify return value of Java Time compareTo methods

2023-07-27 Thread Roger Riggs
On Wed, 14 Jun 2023 20:35:54 GMT, Roger Riggs wrote: > In java.time packages, clarify timeline order javadoc to mention "before" and > "after" in the value of the `compareTo` method return values. > Add javadoc @see tags to isBefore and isAfter methods > > Replace use of "negative" and positiv

Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v2]

2023-07-27 Thread Sergey Tsypanov
On Tue, 25 Jul 2023 23:50:07 GMT, Brian Burkhalter wrote: >> Limit native memory allocation and move write loop from the native layer >> into Java. This change should make the OOME reported in the issue much less >> likely. > > Brian Burkhalter has updated the pull request incrementally with th

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v3]

2023-07-27 Thread Matias Saavedra Silva
> Currently we exit the VM after static dumping with > `MetaspaceShared::exit_after_static_dump()`. > > > // We have finished dumping the static archive. At this point, there may be > pending VM > // operations. We have changed some global states (such as > vmClasses::_klasses) that > // m

Question on "Improved ZIP64 Extra Field Validation" (JDK-8302483)

2023-07-27 Thread Jan Peter Stotz
Hi, could somebody please explain to me how JDK-8302483 made it into all JDK versions? This patch breaks hundred of software systems as it modifies the behavior of java.util.zip.ZipFile, making it unable to read perfectly valid ZIP files. Even more this behavior can not be changed at run-time (e.

Re: RFR: 8310929: Optimization for Integer.toString [v13]

2023-07-27 Thread 温绍锦
On Wed, 26 Jul 2023 20:31:16 GMT, Quan Anh Mai wrote: > It could be worth it to have a cache for small integers to skip the > calculations altogether. this PR is only for calculation optimization. caching small values should be a separate PR - PR Comment: https://git.openjdk.org/

RFR: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match

2023-07-27 Thread Raffaello Giulietti
Fixes a bug showing up after [JDK-8132995](https://bugs.openjdk.org/browse/JDK-8132995) when there are capturing groups outside the match. - Commit messages: - 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match Changes: https://git.openjdk.org/

Re: RFR: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match

2023-07-27 Thread Raffaello Giulietti
On Thu, 27 Jul 2023 11:25:57 GMT, Raffaello Giulietti wrote: > Fixes a bug showing up after > [JDK-8132995](https://bugs.openjdk.org/browse/JDK-8132995) when there are > capturing groups outside the match. Once integrated in mainline, the fix should be backported to 21, where the bug was int

Re: RFR: 8313231: Redundant if statement in ZoneInfoFile

2023-07-27 Thread Pavel Rappo
On Thu, 27 Jul 2023 06:46:46 GMT, John Jiang wrote: > if (i < savingsInstantTransitions.length) { > // javazic writes the last GMT offset into index 0! > if (i < savingsInstantTransitions.length) { > offsets[0] = standardOffsets[standardOffsets.length - 1] * 1000; > nOffse

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v7]

2023-07-27 Thread Laurent Bourgès
On Thu, 15 Jun 2023 09:21:13 GMT, Laurent Bourgès wrote: >> * improved mixed insertion sort (makes whole sorting faster) >> * introduced Radix which sort shows several times boost of performance and >> has linear complexity instead of n*ln(n) >> * improved merging sort for almost sorted data >>

Re: [jdk21] Integrated: 8313208: ProblemList java/util/concurrent/tck/JSR166TestCase.java on select platforms

2023-07-27 Thread Tobias Hartmann
On Wed, 26 Jul 2023 19:22:08 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/concurrent/tck/JSR166TestCase.java on > select platforms. I agree, we will temporarily disable the assert in JDK 21 and revert the problem listing change with https://github.com/openjdk/jdk21

Re: RFR: 8313231: Redundant if statement in ZoneInfoFile

2023-07-27 Thread Jie Fu
On Thu, 27 Jul 2023 06:46:46 GMT, John Jiang wrote: > if (i < savingsInstantTransitions.length) { > // javazic writes the last GMT offset into index 0! > if (i < savingsInstantTransitions.length) { > offsets[0] = standardOffsets[standardOffsets.length - 1] * 1000; > nOffse