On Thu, 22 Jun 2023 00:13:06 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Mon, 12 Jun 2023 14:32:07 GMT, Alan Bateman wrote:
> StructuredTaskScope's class description introduces the join method as waiting
> for all subtasks to finish but the API docs for join/joinUntil are phrased in
> terms of waiting for all threads to finish. ShutdownOnXXX join/joinUntil
> inh
On Thu, 22 Jun 2023 00:13:06 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
> On Windows, the basic Java Integer types are defined as long and __int64
> respectively. In particular, the former is rather problematic since it breaks
> compilation as the Visual C++ becomes stricter and more compliant with every
> release, which means the way Windows code treats long as a t
> On Windows, the basic Java Integer types are defined as long and __int64
> respectively. In particular, the former is rather problematic since it breaks
> compilation as the Visual C++ becomes stricter and more compliant with every
> release, which means the way Windows code treats long as a t
On Thu, 22 Jun 2023 00:33:33 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Wed, 21 Jun 2023 23:06:23 GMT, Chen Liang wrote:
>> Mandy Chung has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits s
On Thu, 22 Jun 2023 00:13:06 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
> The API specification for descriptorString not being a strict inverse of
> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>
> 1. Class::descriptorString was never an inverse of Class::forName, which
> takes a binary name instead. Class::getName was a partial inve
On Thu, 15 Jun 2023 10:01:31 GMT, Alan Bateman wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update the note for getName
>
> src/java.base/share/classes/java/lang/invoke/MethodType.java line 1233:
>
>> 1231:
On Thu, 22 Jun 2023 00:13:06 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
Please review this PR as apart of
[JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors some
tests in Locale to use JUnit. Other cleanup and small changes are included as
well. More refactoring in Locale tests will be done in separate PRs.
If the test had a bugN.java na
On Thu, 22 Jun 2023 01:03:11 GMT, Roger Riggs wrote:
> fyi, the title of this PR need to match exactly the title of the bug
> [JDK-8310502](https://bugs.openjdk.org/browse/JDK-8310502). The mismatch is
> an Integration blocker. (See the comment in the description).
i have made the changes. is
On Thu, 22 Jun 2023 00:13:06 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Thu, 22 Jun 2023 00:19:03 GMT, Joe Darcy wrote:
> Small cleanup, minor differences in the wording of portions of
> toString(Object, String), nonNull(Object), requireNonNullElse, and
> requireNonNullElseGet.
Looks good. I had to refresh my understanding of the exact behavior of the
inline `
On Wed, 21 Jun 2023 22:02:16 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Thu, 22 Jun 2023 00:33:33 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
> The API specification for descriptorString not being a strict inverse of
> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>
> 1. Class::descriptorString was never an inverse of Class::forName, which
> takes a binary name instead. Class::getName was a partial inve
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
Mandy Chung has updated the pull request incrementally with one additional
commit since the last rev
On Wed, 21 Jun 2023 13:32:32 GMT, 温绍锦 wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8310502 : hex literal
>
> * benchmark code
> https://github.com/wenshao/jdk_8310502_test/blob/main/src/main/java/com/alibaba/openjdk/UUID
Small cleanup, minor differences in the wording of portions of toString(Object,
String), nonNull(Object), requireNonNullElse, and requireNonNullElseGet.
-
Commit messages:
- JDK-8310571: Use inline @return tag on java.util.Objects
Changes: https://git.openjdk.org/jdk/pull/14608/fil
On Wed, 21 Jun 2023 22:02:16 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
On Wed, 21 Jun 2023 15:21:45 GMT, Roger Riggs wrote:
> CDS can initialize arrays efficiently. The Long class already uses CDS to
> initialize the cache of Long values. See the LongCache code for an example of
> initializing from CDS with a fallback to direct initialization. You could
> move th
> By optimizing the implementation of java.lang.Long#fastUUID, the performance
> of the java.util.UUID#toString method can be significantly improved.
>
> The following are the test results of JMH:
>
> Benchmark Mode Cnt Score Error Units
> UUIDUtilsBenchmark.new
On Wed, 21 Jun 2023 07:34:20 GMT, Per Minborg wrote:
>> Possible suggestion/thing to try: use a bullet list to spell out all cases
>> for `index`. E.g. we know there's index == 0 (all variadic). Then we know
>> there's index = N (no variadic). Then there's index == m, 0 < m < N - which
>> mean
> Improve the specification of `Linker.Option.firstVariadicArg`, by specifying
> more clearly which index values are valid.
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
polish doc, review comments
-
Changes:
- all:
On Wed, 21 Jun 2023 16:59:22 GMT, Stuart Marks wrote:
> Are we using a convention of `implRead` or `readImpl`? Either is ok with me,
> but I think we had been using `readImpl` and similar elsewhere.
This code is already using implXXX so it's just be consistent.
-
PR Review Comment
On Wed, 21 Jun 2023 09:46:35 GMT, Alan Bateman wrote:
>> The socket read/write JFR events currently use instrumentation of java.base
>> code using templates in the jdk.jfr modules. This results in some java.base
>> code residing in the jdk.jfr module which is undesirable.
>>
>> JDK19 added sta
The socket read/write JFR events currently use instrumentation of java.base
code using templates in the jdk.jfr modules. This results in some java.base
code residing in the jdk.jfr module which is undesirable.
JDK19 added static support for event classes. The old instrumentor classes
should be
On Tue, 6 Jun 2023 19:39:31 GMT, Tim Prinzing wrote:
> The socket read/write JFR events currently use instrumentation of java.base
> code using templates in the jdk.jfr modules. This results in some java.base
> code residing in the jdk.jfr module which is undesirable.
>
> JDK19 added static su
On Wed, 21 Jun 2023 22:02:16 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
Mandy Chung has updated the pull request with a new target base due to a merge
or a rebase. The incr
On Wed, 21 Jun 2023 15:18:19 GMT, Matthias Baesken wrote:
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
Mostly seems okay - a couple of things need further adjusting I think.
Thanks.
src/jdk.compiler/share/classes/c
On Wed, 21 Jun 2023 21:05:11 GMT, Mikael Vidstedt wrote:
>> A trivial fix to ProblemList
>> java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads
>> on linux-all
>
> Marked as reviewed by mikael (Reviewer).
@vidmik - Thanks for your review also.
-
PR Comment
On Wed, 21 Jun 2023 21:02:58 GMT, David Holmes wrote:
>> A trivial fix to ProblemList
>> java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads
>> on linux-all
>
> Marked as reviewed by dholmes (Reviewer).
@dholmes-ora - Thanks for the lightning fast review!
-
On Wed, 21 Jun 2023 20:59:43 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads
> on linux-all
This pull request has now been integrated.
Changeset: ac44ef19
Author:Daniel D. Daugherty
URL:
On Wed, 21 Jun 2023 20:59:43 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads
> on linux-all
Marked as reviewed by mikael (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14606#p
On Wed, 21 Jun 2023 20:59:43 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads
> on linux-all
Marked as reviewed by dholmes (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14606#
A trivial fix to ProblemList
java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on
linux-all
-
Commit messages:
- 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default
with virtual threads on linux-all
Changes: https://git.openjdk.or
On Tue, 20 Jun 2023 13:23:16 GMT, Matthias Baesken wrote:
> Currently, a number of tests fail on macOS because they miss the core file
> (e.g. serviceability/sa/TestJmapCore.java).
> The reason is that configure detects on some setups that codesign does not
> work ("checking if debug mode codes
On Tue, 20 Jun 2023 13:23:16 GMT, Matthias Baesken wrote:
> Currently, a number of tests fail on macOS because they miss the core file
> (e.g. serviceability/sa/TestJmapCore.java).
> The reason is that configure detects on some setups that codesign does not
> work ("checking if debug mode codes
On Wed, 21 Jun 2023 19:02:59 GMT, ExE Boss wrote:
>> src/java.base/share/classes/java/lang/Long.java line 563:
>>
>>> 561: StringUTF16.putChar(buf, 7, (byte) i3);
>>> 562: StringUTF16.putChar(buf, 8, '-');
>>> 563: StringUTF16.putChar(buf, 9, (byte) (i4 >> 8))
> By optimizing the implementation of java.lang.Long#fastUUID, the performance
> of the java.util.UUID#toString method can be significantly improved.
>
> The following are the test results of JMH:
>
> Benchmark Mode Cnt Score Error Units
> UUIDUtilsBenchmark.new
> By optimizing the implementation of java.lang.Long#fastUUID, the performance
> of the java.util.UUID#toString method can be significantly improved.
>
> The following are the test results of JMH:
>
> Benchmark Mode Cnt Score Error Units
> UUIDUtilsBenchmark.new
On Tue, 20 Jun 2023 13:23:16 GMT, Matthias Baesken wrote:
> Currently, a number of tests fail on macOS because they miss the core file
> (e.g. serviceability/sa/TestJmapCore.java).
> The reason is that configure detects on some setups that codesign does not
> work ("checking if debug mode codes
On Wed, 21 Jun 2023 14:39:18 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Wed, 21 Jun 2023 14:53:22 GMT, Roger Riggs wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> add annotation Stable
>
> src/java.base/share/classes/java/lang/Long.java line 563:
>
>> 561: StringUTF16.putChar(bu
On Wed, 21 Jun 2023 13:00:38 GMT, Alan Bateman wrote:
>> That is, a clear connection to what's being described by that `@implSpec`.
>
> This method has an existing apiNote and implSpec. I suspect Joe meant to add
> this sentence to the apiNote, not the implSpec.
I did mean to add the cross-refe
On Wed, 21 Jun 2023 17:09:58 GMT, Kevin Rushforth wrote:
> Since this Enhancement was rejected for JDK 21, this PR should be closed.
Closing without integration accordingly, thanks.
-
PR Comment: https://git.openjdk.org/jdk21/pull/26#issuecomment-1601273074
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote:
> 8307858: [REDO] JDK-8307194 Add make target for optionally building a
> complete set of all JDK and hotspot libjvm static libraries
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote:
> 8307858: [REDO] JDK-8307194 Add make target for optionally building a
> complete set of all JDK and hotspot libjvm static libraries
Since this Enhancement was rejected for JDK 21, this PR should be closed.
-
PR Comment: https
On Wed, 21 Jun 2023 15:18:19 GMT, Matthias Baesken wrote:
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
The update to Java.gmk is good.
-
Marked as reviewed by erikj (Reviewer).
PR Review: https://git.o
On Mon, 12 Jun 2023 14:32:07 GMT, Alan Bateman wrote:
> StructuredTaskScope's class description introduces the join method as waiting
> for all subtasks to finish but the API docs for join/joinUntil are phrased in
> terms of waiting for all threads to finish. ShutdownOnXXX join/joinUntil
> inh
> In java.time packages, clarify timeline order javadoc to mention "before" and
> "after" in the value of the `compareTo` method return values.
> Add javadoc @see tags to isBefore and isAfter methods
>
> Replace use of "negative" and positive with "less than zero" and "greater
> than zero" in j
On Sun, 18 Jun 2023 20:24:07 GMT, Stephen Colebourne
wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> c
On Tue, 20 Jun 2023 13:23:16 GMT, Matthias Baesken wrote:
> Currently, a number of tests fail on macOS because they miss the core file
> (e.g. serviceability/sa/TestJmapCore.java).
> The reason is that configure detects on some setups that codesign does not
> work ("checking if debug mode codes
There are a few references to rt.jar in comments and in the codebase itself.
Some of them might be removed or adjusted.
-
Commit messages:
- JDK-8310550
Changes: https://git.openjdk.org/jdk/pull/14593/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14593&range=00
Issue: h
On Wed, 21 Jun 2023 14:31:20 GMT, Chen Liang wrote:
>> Not sure if this can be applied but some months ago, I optimized Bits to use
>> VarHandles rather than explicitly shifting bits around. This gave us a
>> significant performance increase:
>>
>> https://github.com/openjdk/jdk/pull/11840/fil
On Tue, 20 Jun 2023 13:23:16 GMT, Matthias Baesken wrote:
> Currently, a number of tests fail on macOS because they miss the core file
> (e.g. serviceability/sa/TestJmapCore.java).
> The reason is that configure detects on some setups that codesign does not
> work ("checking if debug mode codes
On Wed, 21 Jun 2023 14:27:26 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/io/PipedOutputStream.java line 166:
>>
>>> 164: @Override
>>> 165: public synchronized void flush() throws IOException {
>>> 166: PipedInputStream sink = this.sink;
>>
>> Suggestion:
>>
>>
> Just a tiny clean-up to remove racy read within synchronized method
Sergey Tsypanov has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/java/io/PipedOutputStream.java
Co-authored-by: liach <7806504+li...@users
On Wed, 21 Jun 2023 00:08:03 GMT, Jorn Vernee wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [e022e876](https://github.com/openjdk/jdk/commit/e022e876543b65b531027662326f35b497861f33)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Wed, 21 Jun 2023 14:39:18 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
> By optimizing the implementation of java.lang.Long#fastUUID, the performance
> of the java.util.UUID#toString method can be significantly improved.
>
> The following are the test results of JMH:
>
> Benchmark Mode Cnt Score Error Units
> UUIDUtilsBenchmark.new
On Wed, 21 Jun 2023 14:13:34 GMT, Per Minborg wrote:
>>> > Another thing to try is moving fastUUID out of Long - moving to an array
>>> > of precomputed hex values means it is not tied to Long internals anymore.
>>>
>>> A note about `@Stable`: `Integer.digits` and `HEX256` are not, and they
>>
On Wed, 21 Jun 2023 14:03:23 GMT, Chen Liang wrote:
>> Just a tiny clean-up to remove racy read within synchronized method
>
> src/java.base/share/classes/java/io/PipedOutputStream.java line 166:
>
>> 164: @Override
>> 165: public synchronized void flush() throws IOException {
>> 166:
On Wed, 21 Jun 2023 09:48:54 GMT, 温绍锦 wrote:
>>> Another thing to try is moving fastUUID out of Long - moving to an array of
>>> precomputed hex values means it is not tied to Long internals anymore.
>>
>> A note about `@Stable`: `Integer.digits` and `HEX256` are not, and they
>> might see per
On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy wrote:
> I had occasion to read over the javadoc sources in java.lang.Object recently
> and noticed a few items that could be updated.
>
> There are some new or expanded API notes referring to methods in
> java.util.Objects. I added these references
On Wed, 21 Jun 2023 00:08:03 GMT, Jorn Vernee wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [e022e876](https://github.com/openjdk/jdk/commit/e022e876543b65b531027662326f35b497861f33)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Wed, 21 Jun 2023 14:01:33 GMT, Sergey Tsypanov wrote:
> Just a tiny clean-up to remove racy read within synchronized method
src/java.base/share/classes/java/io/PipedOutputStream.java line 166:
> 164: @Override
> 165: public synchronized void flush() throws IOException {
> 166:
Just a tiny clean-up to remove racy read within synchronized method
-
Commit messages:
- 8310530: PipedOutputStream.flush() accesses sink racily
Changes: https://git.openjdk.org/jdk/pull/14589/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14589&range=00
Issue: https://bu
On Wed, 21 Jun 2023 11:06:08 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Wed, 21 Jun 2023 11:49:54 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/lang/Object.java line 260:
>>
>>> 258: * }
>>> 259: * The {@link java.util.Objects#toIdentityString(Object)
>>> 260: * Objects.toIdentityString} method returns the string for an
>>
>> That la
On Wed, 21 Jun 2023 00:00:54 GMT, Joe Darcy wrote:
> Correct misstatement that the Class object for a primitive type can only be
> be access via fields like java.lang.Integer.TYPE.
src/java.base/share/classes/java/lang/Class.java line 823:
> 821: *
> 822: * @apiNote
> 823: * The
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy wrote:
> I had occasion to read over the javadoc sources in java.lang.Object recently
> and noticed a few items that could be updated.
>
> There are some new or expanded API notes referring to methods in
> java.util.Objects. I added these references
On Wed, 21 Jun 2023 11:39:43 GMT, Pavel Rappo wrote:
>> I had occasion to read over the javadoc sources in java.lang.Object recently
>> and noticed a few items that could be updated.
>>
>> There are some new or expanded API notes referring to methods in
>> java.util.Objects. I added these refe
On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy wrote:
> I had occasion to read over the javadoc sources in java.lang.Object recently
> and noticed a few items that could be updated.
>
> There are some new or expanded API notes referring to methods in
> java.util.Objects. I added these references
On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy wrote:
> I had occasion to read over the javadoc sources in java.lang.Object recently
> and noticed a few items that could be updated.
>
> There are some new or expanded API notes referring to methods in
> java.util.Objects. I added these references
> By optimizing the implementation of java.lang.Long#fastUUID, the performance
> of the java.util.UUID#toString method can be significantly improved.
>
> The following are the test results of JMH:
>
> Benchmark Mode Cnt Score Error Units
> UUIDUtilsBenchmark.new
On Wed, 21 Jun 2023 10:11:09 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
> By optimizing the implementation of java.lang.Long#fastUUID, the performance
> of the java.util.UUID#toString method can be significantly improved.
>
> The following are the test results of JMH:
>
> Benchmark Mode Cnt Score Error Units
> UUIDUtilsBenchmark.new
On Wed, 21 Jun 2023 09:54:53 GMT, Alan Bateman wrote:
>> Binary name is a long-standing behavior. It's a spec bug.
>
>> Binary name is a long-standing behavior. It's a spec bug.
>
> Yes, I view this PR as just specifying long standing behavior. The name used
> for array class may be surprising
On Tue, 20 Jun 2023 17:45:03 GMT, Mandy Chung wrote:
> Binary name is a long-standing behavior. It's a spec bug.
Yes, I view this PR as just specifying long standing behavior. The name used
for array class may be surprising but I don't think it can be changed.
-
PR Review Comment:
On Wed, 21 Jun 2023 08:58:53 GMT, Chen Liang wrote:
> > Another thing to try is moving fastUUID out of Long - moving to an array of
> > precomputed hex values means it is not tied to Long internals anymore.
>
> A note about `@Stable`: `Integer.digits` and `HEX256` are not, and they might
> see
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Wed, 21 Jun 2023 08:40:43 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/java/lang/Long.java line 97:
>>
>>> 95: + (lo < 10 ? '0' + lo : 'a' + lo - 10));
>>> 96: }
>>> 97: }
>>
>> Are you checking the impact on startup? I guess I would have expected to see
>>
On Wed, 21 Jun 2023 07:58:11 GMT, Alan Bateman wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mo
8310191: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java second
failure on AIX
-
Commit messages:
- Backport 6a63badd8ea3e79cd9fc3cb33aff499fc9a6d3f1
Changes: https://git.openjdk.org/jdk21/pull/45/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=45&range=00
Iss
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Mon, 19 Jun 2023 14:58:13 GMT, Per Minborg wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [b412fc79](https://github.com/openjdk/jdk/commit/b412fc79c3c2548df10918090beedaf6b2d08d96)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Thu, 15 Jun 2023 17:22:32 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected c
On Mon, 19 Jun 2023 14:58:13 GMT, Per Minborg wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [b412fc79](https://github.com/openjdk/jdk/commit/b412fc79c3c2548df10918090beedaf6b2d08d96)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Wed, 21 Jun 2023 07:28:54 GMT, 温绍锦 wrote:
> By optimizing the implementation of java.lang.Long#fastUUID, the performance
> of the java.util.UUID#toString method can be significantly improved.
>
> The following are the test results of JMH:
>
> Benchmark Mode Cnt Sc
On Wed, 21 Jun 2023 07:55:31 GMT, David Holmes wrote:
>> I'm not aware of any other uses either; its not intended to be used outside
>> of ProcessImpl especially since the addition of the new protocol to
>> communicate parameters and confirm launching of the child.
>
> This curiosity has been p
On Tue, 20 Jun 2023 16:27:38 GMT, Roger Riggs wrote:
>> I wondered about this, it looked so deliberate. So I wondered whether
>> jspawnhelper is used outside of the posix_spawn context, but cannot find
>> anything. Maybe historic?
>
> I'm not aware of any other uses either; its not intended to
On Sun, 11 Jun 2023 16:38:31 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request with a new target base due to a
> merge or a r
On Wed, 21 Jun 2023 00:07:54 GMT, Maurizio Cimadamore
wrote:
> Possible suggestion/thing to try: use a bullet list to spell out all cases
> for `index`. E.g. we know there's index == 0 (all variadic). Then we know
> there's index = N (no variadic). Then there's index == m, 0 < m < N - which
>
1 - 100 of 103 matches
Mail list logo
