On Thu, 15 Jun 2023 06:29:09 GMT, Alan Bateman wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Incorporate review comments from Roger and tweak some code
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.j
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
LoongArch64 Zero builds are broken after
[JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913):
jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No enum
constant jdk.internal.util.Architecture.LOONGARCH64
at
jdk.jlink/jdk.tools.jlink.builder.DefaultImageBuilder.storeFiles
On Thu, 15 Jun 2023 02:38:08 GMT, Chen Liang wrote:
>> The API specification for descriptorString not being a strict inverse of
>> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>>
>> 1. Class::descriptorString was never an inverse of Class::forName, which
>> tak
> The API specification for descriptorString not being a strict inverse of
> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>
> 1. Class::descriptorString was never an inverse of Class::forName, which
> takes a binary name instead. Class::getName was a partial inve
On Thu, 15 Jun 2023 02:01:18 GMT, Chen Liang wrote:
>> What about:
>>
>>
>> * This is not a strict inverse of {@link #forName(String) forName}.
>> * Distinct classes which share a common name but have different class
>> * loaders will have the identical name. {@linkplain #isHidde
On Wed, 14 Jun 2023 16:28:31 GMT, Mandy Chung wrote:
>> This might wish to refer to "classes that can be described nominally", but
>> same might be said for hidden classes as well. So your suggestion is better.
>
> What about:
>
>
> * This is not a strict inverse of {@link #forName(String
On Wed, 14 Jun 2023 23:38:01 GMT, Jorn Vernee wrote:
>> Add missing alignment checks for the alignment constraint of the root layout
>> of a VarHandle created through `MemoryLayout::varHandle` and a MethodHandle
>> `MemoryLayout::sliceHandle`.
>>
>> Testing: `jdk_foreign` test suite
>
> Jorn V
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
Man Cao has updated the pull request with a new target base due to a merge or a
rebase. The incremental webrev excludes the unre
On Thu, 15 Jun 2023 00:05:32 GMT, Man Cao wrote:
>> Hi all,
>>
>> Could anyone review this small fix for a data race in
>> java.io.ClassCache$CacheRef? This fix makes the code safer by making the
>> code data-race-free.
>
> Man Cao has updated the pull request incrementally with one additional
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
Man Cao has updated the pull request incrementally with one additional commit
since the last revision:
Removed volatile and c
On Wed, 14 Jun 2023 23:38:01 GMT, Jorn Vernee wrote:
>> Add missing alignment checks for the alignment constraint of the root layout
>> of a VarHandle created through `MemoryLayout::varHandle` and a MethodHandle
>> `MemoryLayout::sliceHandle`.
>>
>> Testing: `jdk_foreign` test suite
>
> Jorn V
On Wed, 14 Jun 2023 22:28:38 GMT, Jorn Vernee wrote:
>> Add missing alignment checks for the alignment constraint of the root layout
>> of a VarHandle created through `MemoryLayout::varHandle` and a MethodHandle
>> `MemoryLayout::sliceHandle`.
>>
>> Testing: `jdk_foreign` test suite
>
> Jorn V
> Add missing alignment checks for the alignment constraint of the root layout
> of a VarHandle created through `MemoryLayout::varHandle` and a MethodHandle
> `MemoryLayout::sliceHandle`.
>
> Testing: `jdk_foreign` test suite
Jorn Vernee has updated the pull request incrementally with one addit
On Wed, 14 Jun 2023 22:48:34 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> formatting
>
> test/jdk/java/foreign/TestLayoutPaths.java line 152:
>
>> 150: String expectedMessag
On Wed, 14 Jun 2023 22:28:38 GMT, Jorn Vernee wrote:
>> Add missing alignment checks for the alignment constraint of the root layout
>> of a VarHandle created through `MemoryLayout::varHandle` and a MethodHandle
>> `MemoryLayout::sliceHandle`.
>>
>> Testing: `jdk_foreign` test suite
>
> Jorn V
On Wed, 14 Jun 2023 22:28:38 GMT, Jorn Vernee wrote:
>> Add missing alignment checks for the alignment constraint of the root layout
>> of a VarHandle created through `MemoryLayout::varHandle` and a MethodHandle
>> `MemoryLayout::sliceHandle`.
>>
>> Testing: `jdk_foreign` test suite
>
> Jorn V
> Add missing alignment checks for the alignment constraint of the root layout
> of a VarHandle created through `MemoryLayout::varHandle` and a MethodHandle
> `MemoryLayout::sliceHandle`.
>
> Testing: `jdk_foreign` test suite
Jorn Vernee has updated the pull request incrementally with one addit
> Add missing alignment checks for the alignment constraint of the root layout
> of a VarHandle created through `MemoryLayout::varHandle` and a MethodHandle
> `MemoryLayout::sliceHandle`.
>
> Testing: `jdk_foreign` test suite
Jorn Vernee has updated the pull request incrementally with one addit
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote:
> Updated the version to 22-ea and year to 2024.
>
> The following unpublished changes will also be included in this update:
> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage
> contains a special character
> - [
Add missing alignment checks for the alignment constraint of the root layout of
a VarHandle created through `MemoryLayout::varHandle` and a MethodHandle
`MemoryLayout::sliceHandle`.
Testing: `jdk_foreign` test suite
-
Commit messages:
- Add root layout alignment check to varHandle
On Wed, 14 Jun 2023 21:28:01 GMT, David Holmes wrote:
> > Just curious, since you have access to the secret closed sources, can you
> > not backport these changes yourself? Instead of just deleting them and
> > expecting someone else to rescue them from oblivion?
>
> @archiecobbs we (Oracle) w
On Wed, 14 Jun 2023 19:21:01 GMT, Archie Cobbs wrote:
> Just curious, since you have access to the secret closed sources, can you not
> backport these changes yourself? Instead of just deleting them and expecting
> someone else to rescue them from oblivion?
@archiecobbs we (Oracle) will take
On Wed, 14 Jun 2023 09:25:14 GMT, Serguei Spitsyn wrote:
>> Updated the version to 22-ea and year to 2024.
>>
>> The following unpublished changes will also be included in this update:
>> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool
>> manpage contains a special charact
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
On Mon, 12 Jun 2023 05:47:41 GMT, Oliver Kopp wrote:
>> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
>> "MethodTooLargeException thrown while creating a jlink image".
>>
>> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
>> of the fix is to sp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
>
>
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote:
> The following changes, to javac.1, were never applied to the closed sources
> and are "lost" by this update. These changes will need to be re-applied
> directly in JDK 21 and JDK 22
Just curious, since you have access to the secret closed
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote:
> Updated the version to 22-ea and year to 2024.
>
> The following unpublished changes will also be included in this update:
> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage
> contains a special character
> - [
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote:
> Updated the version to 22-ea and year to 2024.
>
> The following unpublished changes will also be included in this update:
> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage
> contains a special character
> - [
On Tue, 13 Jun 2023 15:50:59 GMT, Alan Bateman wrote:
> The implementation changes look good.
>
> The update to test looks okay too although I would like to see if we can do
> better in SVC and STS when there is a SO.
That would be nice, but it's something of a can of worms.
> In passing, I
On Wed, 14 Jun 2023 02:13:23 GMT, Chen Liang wrote:
>> The API specification for descriptorString not being a strict inverse of
>> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>>
>> 1. Class::descriptorString was never an inverse of Class::forName, which
>> tak
On Wed, 14 Jun 2023 07:12:13 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/Class.java line 928:
>>
>>> 926: * @apiNote
>>> 927: * This is not a strict inverse of {@link #forName(String)
>>> forName}.
>>> 928: * For normal classes, distinct classes which share a
On Tue, 13 Jun 2023 18:50:42 GMT, Justin Lu wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties
>> line 140:
>>
>>> 138:
>>> 139: # 0: type, 1: name
>>> 140: compiler.err.annotation.unrecognized.attribute.name=Annotation @{0}
>>> weist das unbekannte
On Wed, 14 Jun 2023 13:29:39 GMT, Daniel Fuchs wrote:
>>> Replaced it with a ReentrantLock
>>
>> The concern is that this is a system-wide lock and so creates the potential
>> for contention when many threads are bashing on Locale.of and other methods.
>> Moving to use the JDK's ReferenceKeyMa
On Wed, 14 Jun 2023 15:50:19 GMT, Roger Riggs wrote:
>> Add mipsel and mips64el to the Architecture enum.
>> (Later to be backported to JDK 21)
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add tests for MIPSEL and MIPS64E
> Add mipsel and mips64el to the Architecture enum.
> (Later to be backported to JDK 21)
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Add tests for MIPSEL and MIPS64EL
-
Changes:
- all: https://git.openjdk.org/jdk/pu
On Wed, 14 Jun 2023 15:04:41 GMT, Roger Riggs wrote:
> Add mipsel and mips64el to the Architecture enum.
> (Later to be backported to JDK 21)
Looking at how other platforms do it, I think this patch is incomplete. See
e.g. ARM32 patch:
https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164b
On Fri, 9 Jun 2023 18:59:41 GMT, Paul Sandoz wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove meaningless target calls and clear outdated cache as needed
>
> Something was bothering me about the current complex
On Wed, 14 Jun 2023 15:04:41 GMT, Roger Riggs wrote:
> Add mipsel and mips64el to the Architecture enum.
> (Later to be backported to JDK 21)
Lgtm.
-
Marked as reviewed by phh (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14471#pullrequestreview-1479721055
Add mipsel and mips64el to the Architecture enum.
(Later to be backported to JDK 21)
-
Commit messages:
- Corrected return values of isMIPSEL() and isMIPS64EL().
- 8310019: MIPS builds are broken after JDK-8304913
Changes: https://git.openjdk.org/jdk/pull/14471/files
Webrev: https
Please review and test PR 14471.
https://github.com/openjdk/jdk/pull/14471/
Confirm that the Architecture.isLittleEndian() method returns the
expected values for big and little endian builds.
Regards, Roger
On 6/14/23 10:25 AM, Roger Riggs wrote:
Hi,
I can propose a PR with the patch using
Hi,
I can propose a PR with the patch using the issue 8304913; but am unable
to test it.
Regards, Roger
On 6/14/23 7:20 AM, Aleksey Shipilev wrote:
On 14.06.23 13:17, Aleksey Shipilev wrote:
On 14.06.23 11:36, Vladimir Petko wrote
After JDK-8304913, OpenJDK fails to build on mips[1] and
On Wed, 14 Jun 2023 11:52:35 GMT, Weijun Wang wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Incorporate review comments from Roger and tweak some code
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.ja
On Wed, 14 Jun 2023 13:13:50 GMT, Alan Bateman wrote:
>> Replaced it with a ReentrantLock
>
>> Replaced it with a ReentrantLock
>
> The concern is that this is a system-wide lock and so creates the potential
> for contention when many threads are bashing on Locale.of and other methods.
> Movin
On Tue, 13 Jun 2023 17:57:36 GMT, Naoto Sato wrote:
> Replaced it with a ReentrantLock
The concern is that this is a system-wide lock and so creates the potential for
contention when many threads are bashing on Locale.of and other methods. Moving
to use the JDK's ReferenceKeyMap with a CHM, or
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
On Tue, 13 Jun 2023 12:48:12 GMT, Jorn Vernee wrote:
> Update the make/autoconf/lib-ffi.m4 script to support using libffi on Windows
> and Mac.
>
> For Windows I had to tweak `fallbackLinker.c` to be able to build: there was
> an import of `stdint.h` missing, and since it was using `WSAGetLast
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Incorporate review comments from Roger and tweak some code
On Tue, 13 Jun 2023 13:57:13 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev exclu
On Tue, 13 Jun 2023 14:30:57 GMT, Roger Riggs wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits si
On 14.06.23 13:17, Aleksey Shipilev wrote:
On 14.06.23 11:36, Vladimir Petko wrote
After JDK-8304913, OpenJDK fails to build on mips[1] and mips64el[2].
Would it be possible to consider adding those architectures to the
Architecture enumeration (see attached patch)/
Submitted:
https://bugs.
On 14.06.23 11:36, Vladimir Petko wrote
After JDK-8304913, OpenJDK fails to build on mips[1] and mips64el[2].
Would it be possible to consider adding those architectures to the
Architecture enumeration (see attached patch)/
Submitted:
https://bugs.openjdk.org/browse/JDK-8310019
Are you able
On Wed, 14 Jun 2023 01:15:51 GMT, Martin Buchholz wrote:
> * we never want to inherit AbstractFoo @implNotes
`@implNote`, `@apiNote` and `@implSpec` can only be inherited via explicit
`{@inheritDoc}`:
@implSpec {@inheritDoc}
> * ConcurrentMap does _not_ have the same spec as ConcurrentHas
On Tue, 13 Jun 2023 20:42:49 GMT, Man Cao wrote:
>> Hi all,
>>
>> Could anyone review this small fix for a data race in
>> java.io.ClassCache$CacheRef? This fix makes the code safer by making the
>> code data-race-free.
>
> Man Cao has updated the pull request incrementally with one additional
Dear Maintainers,
After JDK-8304913, OpenJDK fails to build on mips[1] and mips64el[2].
Would it be possible to consider adding those architectures to the
Architecture enumeration (see attached patch)/
Best Regards,
Vladimir.
[1]
https://buildd.debian.org/status/fetch.php?pkg=openjdk-21&arch=m
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote:
> Updated the version to 22-ea and year to 2024.
>
> The following unpublished changes will also be included in this update:
> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage
> contains a special character
> - [
On Wed, 14 Jun 2023 01:19:57 GMT, Martin Buchholz wrote:
> We don't currently have a way to diff rendered javadoc, like my ancient
> BlenderRev hack?
I've generated something you might find helpful:
https://cr.openjdk.org/~prappo/8285368/specdiff/overview-summary.html
-
PR Commen
On Thu, 1 Jun 2023 19:25:19 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 55:
>>
>>> 53:
>>> 54: static Classfile of() {
>>> 55: return new ClassfileImpl();
>>
>> We can create a static final field in `ClassfileImpl` holding a def
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Wed, 14 Jun 2023 06:03:48 GMT, Alan Bateman wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Convert the note in fromDescriptorString to apiNote
>
> src/java.base/share/classes/java/lang/Class.java line 928:
>
>>
On Wed, 14 Jun 2023 02:13:23 GMT, Chen Liang wrote:
>> The API specification for descriptorString not being a strict inverse of
>> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>>
>> 1. Class::descriptorString was never an inverse of Class::forName, which
>> tak
66 matches
Mail list logo
