> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.org/browse/JDK-8308184?
>
> When an application is launched, the `app` classloader internally uses a
> `jdk.internal.loader.URLClassPath` to find and load the main class being
> launched.
On Sat, 10 Jun 2023 05:16:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8308184?
>>
>> When an application is launched, the `app` classloader internally uses a
>> `jdk.internal.loader.URLC
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.org/browse/JDK-8308184?
>
> When an application is launched, the `app` classloader internally uses a
> `jdk.internal.loader.URLClassPath` to find and load the main class being
> launched.
On Fri, 9 Jun 2023 17:40:58 GMT, Mandy Chung wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> newline at end of test file
>
> test/jdk/java/net/URL/HandlersPkgPrefix/LargeClasspathWithPkgPrefix.java line
> 115:
>
On Fri, 9 Jun 2023 16:42:21 GMT, Alan Bateman wrote:
> I wouldn't normally suggest dropping an import and using a qualified class
> name but "Handler" is a very generic class name, replacing it with "new
> sun.net.www.protocol.jar.Handler()" might be clearer.
I agree. I have now updated the PR
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.org/browse/JDK-8308184?
>
> When an application is launched, the `app` classloader internally uses a
> `jdk.internal.loader.URLClassPath` to find and load the main class being
> launched.
On Thu, 9 Mar 2023 19:53:44 GMT, Eirik Bjorsnos wrote:
> Please review this PR which brings the DataDescriptorSignatureMissing test
> back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a
> Data Descriptor without the recommended but optional signature.
On Fri, 9 Jun 2023 23:04:33 GMT, Jiangli Zhou wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where
aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the
in-house cache with WeakHashMap, and removed the Key class as it is no longer
needed (thus the original NPE will no longer be possible). Also with
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
On Fri, 9 Jun 2023 19:44:32 GMT, Chris Hegarty wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [cee5724d](https://github.com/openjdk/jdk/commit/cee5724d09b9ef9bd528fb721b756cb052265e3d)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bei
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> stati
On Fri, 9 Jun 2023 20:03:23 GMT, Erik Joelsson wrote:
> All our builds succeeded, so this is looking pretty good now. Just a minor
> suggestion left.
Thanks a lot!
> This combination of conditions is repeated 3 times. Maybe we could assign the
> result to a variable (e.g. `$1_ENABLE_PARTIAL_L
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
Agree with the analysis that this race looks benign, and the slight change in
On Thu, 8 Jun 2023 20:34:15 GMT, Jiangli Zhou wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
Hi all,
This pull request contains a backport of commit
[cee5724d](https://github.com/openjdk/jdk/commit/cee5724d09b9ef9bd528fb721b756cb052265e3d)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Chris Hegarty on 9 Jun 2023 and was
rev
> A trivial use of the Vector API when run with the security manager and a
> domain that does not grant permissions fails with
> java.security.AccessControlException: access denied
> ("java.util.PropertyPermission"
> "jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK" "read").
>
> The fix it minima
On Fri, 9 Jun 2023 18:12:36 GMT, Paul Sandoz wrote:
>> Chris Hegarty has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add at bug and remove newline
>
> test/jdk/jdk/incubator/vector/VectorRuns.java line 74:
>
>> 72: return a.
On Fri, 9 Jun 2023 13:02:18 GMT, Chris Hegarty wrote:
> A trivial use of the Vector API when run with the security manager and a
> domain that does not grant permissions fails with
> java.security.AccessControlException: access denied
> ("java.util.PropertyPermission"
> "jdk.incubator.vector.
On Fri, 9 Jun 2023 13:39:26 GMT, Matthias Baesken wrote:
> On AIX , new jtreg test
> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java always failed with
> the output :
>
> --System.err:(294/28579)--
> STARTED DynamicLoadWarningTest::testLoadJavaAgent 'testLoadJavaAg
On Thu, 8 Jun 2023 01:32:20 GMT, Chen Liang wrote:
>> Also fixed the bug with NPE in `IndirectVarHandle::isAccessModeSupported`.
>>
>> A few implementation-detail methods in VarHandle are now documented with the
>> implied constraints to avoid subtle problems in the future. Changed
>> `Indirec
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Did you consider only showing the security settings if the "security" option is
specified? Seems like a lot of data to show in t
On Fri, 9 Jun 2023 18:20:51 GMT, Jorn Vernee wrote:
>> Note that the javadoc has been rectified here (as part of the PR) as I think
>> it has always been wrong in the past (probably cut and paste issue from the
>> non-MH version?)
>
> But, the implementation of `byteOffsetHandle` rejects range
On Fri, 9 Jun 2023 13:42:17 GMT, Maurizio Cimadamore
wrote:
>> Note sure - javadoc says:
>>
>> * @throws IllegalArgumentException if the layout path is not > href="#well-formedness">well-formed for this layout.
>> * @throws IllegalArgumentException if the layout path contains one or
>> mo
On Fri, 9 Jun 2023 13:18:07 GMT, Chris Hegarty wrote:
>> A trivial use of the Vector API when run with the security manager and a
>> domain that does not grant permissions fails with
>> java.security.AccessControlException: access denied
>> ("java.util.PropertyPermission"
>> "jdk.incubator.ve
On Fri, 9 Jun 2023 13:18:07 GMT, Chris Hegarty wrote:
>> A trivial use of the Vector API when run with the security manager and a
>> domain that does not grant permissions fails with
>> java.security.AccessControlException: access denied
>> ("java.util.PropertyPermission"
>> "jdk.incubator.ve
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
I think the race is benign also but the change maintains the essential
semanti
On Fri, 9 Jun 2023 15:47:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8308184?
>>
>> When an application is launched, the `app` classloader internally uses a
>> `jdk.internal.loader.URLCl
On Fri, 9 Jun 2023 13:39:26 GMT, Matthias Baesken wrote:
> On AIX , new jtreg test
> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java always failed with
> the output :
>
> --System.err:(294/28579)--
> STARTED DynamicLoadWarningTest::testLoadJavaAgent 'testLoadJavaAg
On Fri, 9 Jun 2023 16:53:15 GMT, Andrew Haley wrote:
> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>
> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
> error occurs it can not recover scoped values.
>
> Moving `runWith()` into the common subclass
On Fri, 9 Jun 2023 16:53:15 GMT, Andrew Haley wrote:
> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>
> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
> error occurs it can not recover scoped values.
>
> Moving `runWith()` into the common subclass
Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
`BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
error occurs it can not recover scoped values.
Moving `runWith()` into the common subclass of both `VirtualThread` and
`BoundVirtualThread` fixes the problem
On Fri, 9 Jun 2023 10:07:31 GMT, Viktor Klang wrote:
>> The test used a too-small heap for generic testing, and coupled with looking
>> at `freeMemory()` it led to a less-than-ideal determinism of execution of
>> the test.
>
> Viktor Klang has updated the pull request incrementally with one add
On Thu, 8 Jun 2023 18:56:28 GMT, Mandy Chung wrote:
> The `RuntimeArguments` test verifies the VM arguments returned by
> `jdk.internal.misc.VM::getRuntimeArguments` as expected.This test fails
> when running with GraalVM as it was created with `jlink --add-options` and
> the application w
On Fri, 9 Jun 2023 15:47:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8308184?
>>
>> When an application is launched, the `app` classloader internally uses a
>> `jdk.internal.loader.URLCl
On Fri, 2 Jun 2023 14:04:23 GMT, Erik Joelsson wrote:
> > Sounds good for solving the macosx `ar` limitation differently. I'll change
> > that. We can also exclude the partial linking part for gcc (due the older
> > tool issue that you've found). Any concerns with including partial linking
> >
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Fri, 9 Jun 2023 13:07:27 GMT, Chris Hegarty wrote:
>> A trivial use of the Vector API when run with the security manager and a
>> domain that does not grant permissions fails with
>> java.security.AccessControlException: access denied
>> ("java.util.PropertyPermission"
>> "jdk.incubator.ve
On Fri, 9 Jun 2023 13:18:07 GMT, Chris Hegarty wrote:
>> A trivial use of the Vector API when run with the security manager and a
>> domain that does not grant permissions fails with
>> java.security.AccessControlException: access denied
>> ("java.util.PropertyPermission"
>> "jdk.incubator.ve
On Fri, 9 Jun 2023 13:44:20 GMT, Tobias Holenstein
wrote:
>> At the moment `CompileCommand` and `CompileOnly` use different syntax for
>> matching methods.
>>
>> ### Old CompileOnly format
>> - matching a **method name** with **class name** and **package name**:
>> `-XX:CompileOnly=package/pa
On Fri, 9 Jun 2023 13:18:07 GMT, Chris Hegarty wrote:
>> A trivial use of the Vector API when run with the security manager and a
>> domain that does not grant permissions fails with
>> java.security.AccessControlException: access denied
>> ("java.util.PropertyPermission"
>> "jdk.incubator.ve
On Mon, 19 Dec 2022 11:26:25 GMT, Romain Manni-Bucau wrote:
> enumeration(list) will create an enumeration, a list and an iterator whereas
> the impl only requires an iterator
> this PR drops the enumeration wrapper for binary constructor and just maps
> the enumeration to an iterator for the o
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.org/browse/JDK-8308184?
>
> When an application is launched, the `app` classloader internally uses a
> `jdk.internal.loader.URLClassPath` to find and load the main class being
> launched.
On Fri, 9 Jun 2023 15:01:47 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> newline at end of test file
>
> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 186:
>
>> 184:
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
src/java.base/share/classes/sun/launcher/LauncherHelper.java line 65:
> 63: import java.text.MessageFormat;
> 64: import java.te
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.org/browse/JDK-8308184?
>
> When an application is launched, the `app` classloader internally uses a
> `jdk.internal.loader.URLClassPath` to find and load the main class being
> launched.
On Fri, 9 Jun 2023 14:55:50 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.org/browse/JDK-8308184?
>
> When an application is launched, the `app` classloader internally uses a
> `jdk.internal.loader.URLClassPa
Can I please get a review of this change which proposes to fix the issue noted
in https://bugs.openjdk.org/browse/JDK-8308184?
When an application is launched, the `app` classloader internally uses a
`jdk.internal.loader.URLClassPath` to find and load the main class being
launched. The `URLClas
New functionality in the -XshowSettings menu to display relevant information
about JDK security configuration
-
Commit messages:
- minor edits, copyright, descriptions etc
- Merge branch 'master' into 8281658-showsettings-security
- Merge branch 'master' into 8281658-showsettings-
On Fri, 9 Jun 2023 13:44:20 GMT, Tobias Holenstein
wrote:
>> At the moment `CompileCommand` and `CompileOnly` use different syntax for
>> matching methods.
>>
>> ### Old CompileOnly format
>> - matching a **method name** with **class name** and **package name**:
>> `-XX:CompileOnly=package/pa
On Fri, 9 Jun 2023 13:39:26 GMT, Matthias Baesken wrote:
> On AIX , new jtreg test
> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java always failed with
> the output :
>
> --System.err:(294/28579)--
> STARTED DynamicLoadWarningTest::testLoadJavaAgent 'testLoadJavaAg
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote:
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
If I read the existing code correctly, ClassCache::get can't return null. If
there are two
On AIX , new jtreg test
com/sun/tools/attach/warnings/DynamicLoadWarningTest.java always failed with
the output :
--System.err:(294/28579)--
STARTED DynamicLoadWarningTest::testLoadJavaAgent 'testLoadJavaAgent()'
SUCCESSFUL DynamicLoadWarningTest::testLoadJavaAgent 'testLoadJa
On Fri, 9 Jun 2023 13:40:47 GMT, Maurizio Cimadamore
wrote:
>> FWIW, it looks like this needs `@Test(expectedExceptions =
>> IllegalArgumentException.class)` since range elements are not allowed for
>> `byteOffsetHandle`
>
> Note sure - javadoc says:
>
> * @throws IllegalArgumentException if
On Thu, 8 Jun 2023 20:21:48 GMT, Jorn Vernee wrote:
>> test/jdk/java/foreign/TestLayoutPaths.java line 125:
>>
>>> 123: }
>>> 124:
>>> 125: public void testByteOffsetHandleRange() {
>>
>> Missing `@Test`?
>
> FWIW, it looks like this needs `@Test(expectedExceptions =
> IllegalArgument
> At the moment `CompileCommand` and `CompileOnly` use different syntax for
> matching methods.
>
> ### Old CompileOnly format
> - matching a **method name** with **class name** and **package name**:
> `-XX:CompileOnly=package/path/Class.method`
> `-XX:CompileOnly=package/path/Class::method`
> `
On Fri, 9 Jun 2023 11:53:32 GMT, Stefan Karlsson wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Decresing the number of iterations proportional to the increase in the max
>> memory size
>
> I'm happy with the cha
On Fri, 9 Jun 2023 13:24:20 GMT, Tobias Holenstein
wrote:
>> At the moment `CompileCommand` and `CompileOnly` use different syntax for
>> matching methods.
>>
>> ### Old CompileOnly format
>> - matching a **method name** with **class name** and **package name**:
>> `-XX:CompileOnly=package/pa
> At the moment `CompileCommand` and `CompileOnly` use different syntax for
> matching methods.
>
> ### Old CompileOnly format
> - matching a **method name** with **class name** and **package name**:
> `-XX:CompileOnly=package/path/Class.method`
> `-XX:CompileOnly=package/path/Class::method`
> `
From: kulla-dev on behalf of Brian Goetz
> I think there's something fishy going on.
Yes, transformation lambdas become significantly slower when moved from
ClassModel to Classfile (unless I missed anything else).
I’ll do some experiments to get the performance back.
> A trivial use of the Vector API when run with the security manager and a
> domain that does not grant permissions fails with
> java.security.AccessControlException: access denied
> ("java.util.PropertyPermission"
> "jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK" "read").
>
> The fix it minima
A trivial use of the Vector API when run with the security manager and a domain
that does not grant permissions fails with
java.security.AccessControlException: access denied
("java.util.PropertyPermission" "jdk.incubator.vector.VECTOR_ACCESS_OOB_CHECK"
"read").
The fix it minimal, as consiste
On Fri, 9 Jun 2023 13:02:18 GMT, Chris Hegarty wrote:
> A trivial use of the Vector API when run with the security manager and a
> domain that does not grant permissions fails with
> java.security.AccessControlException: access denied
> ("java.util.PropertyPermission"
> "jdk.incubator.vector.
On Wed, 17 May 2023 16:52:17 GMT, Vladimir Kozlov wrote:
>> Tobias Holenstein has updated the pull request incrementally with 11
>> additional commits since the last revision:
>>
>> - Update TestStableUShort.java
>> - Update TestStableUByte.java
>> - Update TestStableShort.java
>> - Update
On Fri, 9 Jun 2023 10:07:31 GMT, Viktor Klang wrote:
>> The test used a too-small heap for generic testing, and coupled with looking
>> at `freeMemory()` it led to a less-than-ideal determinism of execution of
>> the test.
>
> Viktor Klang has updated the pull request incrementally with one add
On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected co
On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected co
Observation: It's dramatic how injecting a tiny amount of shared mutable
state ripples throughout the design.
After thinking about this some more, I think the main problem is that we
are still trying to have the cache be transparent, which means that
Classfile is taking on all the complexity o
On Thu, 8 Jun 2023 18:56:28 GMT, Mandy Chung wrote:
> The `RuntimeArguments` test verifies the VM arguments returned by
> `jdk.internal.misc.VM::getRuntimeArguments` as expected.This test fails
> when running with GraalVM as it was created with `jlink --add-options` and
> the application w
On Fri, 9 Jun 2023 09:45:33 GMT, Stefan Karlsson wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Decresing the number of iterations proportional to the increase in the max
>> memory size
>
> Did you test if this s
> The test used a too-small heap for generic testing, and coupled with looking
> at `freeMemory()` it led to a less-than-ideal determinism of execution of the
> test.
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Decresing the num
On Thu, 8 Jun 2023 16:15:21 GMT, Brett Okken wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove pointless comments
>
> src/java.base/share/classes/java/util/Arrays.java line 3845:
>
>> 3843: */
>> 3844:
On Thu, 8 Jun 2023 15:08:28 GMT, Claes Redestad wrote:
> https://bugs.openjdk.org/browse/JDK-8301958 and later changes improved
> Arrays.copyOf/-Range methods to improve peak performance in microbenchmarks
> when copying the entire array, but it's resulted in a few lurking footprint
> benchmar
> https://bugs.openjdk.org/browse/JDK-8301958 and later changes improved
> Arrays.copyOf/-Range methods to improve peak performance in microbenchmarks
> when copying the entire array, but it's resulted in a few lurking footprint
> benchmark issues that come down to incurring slightly more JIT ac
On Fri, 9 Jun 2023 09:13:08 GMT, Viktor Klang wrote:
> The test used a too-small heap for generic testing, and coupled with looking
> at `freeMemory()` it led to a less-than-ideal determinism of execution of the
> test.
Did you test if this significantly changed the execution time of the test?
The test used a too-small heap for generic testing, and coupled with looking at
`freeMemory()` it led to a less-than-ideal determinism of execution of the test.
-
Commit messages:
- Increasing minimum heap size to make the BasicCancelTest complete more
timely,
Changes: https://git
Dear Maintainers,
test/jdk/java/foreign/TestLayouts.java assumes little endian
architecture and hardcoded string representation of int.
This results in the following failure:
-cut-
test TestLayouts.testStructToString(): failure
java.lang.AssertionError: expected [[i4](struct)] but found [[
On Wed, 26 Apr 2023 14:46:53 GMT, Chen Liang wrote:
>> This patch aims to correct handling of annotations on parameters with the
>> help of `MethodParameters` attribute, which will be always available once
>> #9862 is integrated.
>>
>> It utilizes and expands upon the existing parameter matchi
On Fri, 9 Jun 2023 07:51:03 GMT, Alan Bateman wrote:
> This test moved from test/jdk/jdk/incubator/concurrent to test/jdk/java/lang
> as part of the JEP 446 integration so it is running in a lot more
> configurations now. It's unstable in some configurations, including
> JTREG_TEST_THREAD_FACT
On Fri, 9 Jun 2023 07:51:03 GMT, Alan Bateman wrote:
> This test moved from test/jdk/jdk/incubator/concurrent to test/jdk/java/lang
> as part of the JEP 446 integration so it is running in a lot more
> configurations now. It's unstable in some configurations, including
> JTREG_TEST_THREAD_FACT
This test moved from test/jdk/jdk/incubator/concurrent to test/jdk/java/lang as
part of the JEP 446 integration so it is running in a lot more configurations
now. It's unstable in some configurations, including
JTREG_TEST_THREAD_FACTORY=Virtual runs. The implementation may need more
@DontInline
On Wed, 7 Jun 2023 15:12:40 GMT, Alan Bateman wrote:
> Thread.interrupted is used to "get and clear" the current thread's interrupt
> status. When called from a virtual thread, the current implementation always
> clears the carrier's interrupt status. There is no need to do this when the
> int
On Tue, 11 Apr 2023 07:48:45 GMT, Jens Lidestrom wrote:
>> enumeration(list) will create an enumeration, a list and an iterator whereas
>> the impl only requires an iterator
>> this PR drops the enumeration wrapper for binary constructor and just maps
>> the enumeration to an iterator for the o
On Mon, 19 Dec 2022 11:26:25 GMT, Romain Manni-Bucau wrote:
> enumeration(list) will create an enumeration, a list and an iterator whereas
> the impl only requires an iterator
> this PR drops the enumeration wrapper for binary constructor and just maps
> the enumeration to an iterator for the o
On Tue, 24 Jan 2023 06:54:19 GMT, Jaikiran Pai wrote:
> PRs which do not have a corresponding bug tracker issue
Will write to the mailing list
-
PR Comment: https://git.openjdk.org/jdk/pull/11718#issuecomment-1464897988
On Mon, 19 Dec 2022 11:26:25 GMT, Romain Manni-Bucau wrote:
> enumeration(list) will create an enumeration, a list and an iterator whereas
> the impl only requires an iterator
> this PR drops the enumeration wrapper for binary constructor and just maps
> the enumeration to an iterator for the o
On Mon, 16 Jan 2023 19:21:36 GMT, Romain Manni-Bucau wrote:
>> enumeration(list) will create an enumeration, a list and an iterator whereas
>> the impl only requires an iterator
>> this PR drops the enumeration wrapper for binary constructor and just maps
>> the enumeration to an iterator for t
On Mon, 19 Dec 2022 11:26:25 GMT, Romain Manni-Bucau wrote:
> enumeration(list) will create an enumeration, a list and an iterator whereas
> the impl only requires an iterator
> this PR drops the enumeration wrapper for binary constructor and just maps
> the enumeration to an iterator for the o
On Mon, 19 Dec 2022 11:26:25 GMT, Romain Manni-Bucau wrote:
> enumeration(list) will create an enumeration, a list and an iterator whereas
> the impl only requires an iterator
> this PR drops the enumeration wrapper for binary constructor and just maps
> the enumeration to an iterator for the o
enumeration(list) will create an enumeration, a list and an iterator whereas
the impl only requires an iterator
this PR drops the enumeration wrapper for binary constructor and just maps the
enumeration to an iterator for the other case which should be a better
compromise in practise.
Another s
90 matches
Mail list logo
