Re: RFR: 8304871: Use default visibility for static library builds

2023-03-26 Thread David Holmes
On Fri, 24 Mar 2023 15:31:32 GMT, Severin Gehwolf wrote: > Please review this change for symbol visibility of static library artefacts. > This fixes an issue when > OpenJDK is being used as a base for generating native images preventing the > symbols from being > exported and looked up from the

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-26 Thread David Holmes
On 25/03/2023 3:06 am, Roger Riggs wrote: On Fri, 24 Mar 2023 16:53:05 GMT, Michael Osipov wrote: If you are referring to "Red Hat Enterprise Linux", it'd be correct (AFAIK) to say that Red Hat identifies "Red Hat Enterprise Linux" as an operating system, but I wouldn't go so far as to say th

Integrated: 8304013: Add a fast, non-manual alternative to test/jdk/java/util/zip/ZipFile/TestTooManyEntries

2023-03-26 Thread Eirik Bjorsnos
On Thu, 26 Jan 2023 18:49:47 GMT, Eirik Bjorsnos wrote: > The TestTooManyEntries test was originally added to validate that ZIP64 files > with CEN sizes exceeding what ZipFile supports are rejected with a > ZipException. The test does this by creating a large ZIP file (several > gigabytes) wi

Re: RFR: 8304932: MethodTypeDescImpl can be mutated by argument passed to MethodTypeDesc.of [v2]

2023-03-26 Thread Chen Liang
> Fixed the bug where if a caller keeps a reference to the array passed into > `MethodTypeDesc.of`, the caller may mutate the Desc via the array and can > create invalid MethodTypeDesc. > > Unfortunately, since the input array now needs to be copied, the `of` factory > suffers from a performanc

RFR: 8304937: BufferedFieldBuilder.Model missing writeTo(DirectClassBuilder)

2023-03-26 Thread Chen Liang
Please review this simple patch to Classfile API that fixes a missing override that otherwise affects usage of chained class transforms. A test is included, that it fails on the missing method without this patch. Please review a few other patches fixing bugs affecting normal usage of the Classf

Re: RFR: 8304013: Add a fast, non-manual alternative to test/jdk/java/util/zip/ZipFile/TestTooManyEntries [v4]

2023-03-26 Thread Martin Buchholz
On Sat, 25 Mar 2023 12:18:46 GMT, Eirik Bjorsnos wrote: >> So I changed the references to this ultimate ZIP structure to read like this: >> >> 'End of central directory record' (END header) >> >> Example: >> >> >> /** >> * Validate that an 'End of central directory record' (END header) >

Re: RFR: 8304013: Add a fast, non-manual alternative to test/jdk/java/util/zip/ZipFile/TestTooManyEntries [v4]

2023-03-26 Thread Martin Buchholz
On Sat, 25 Mar 2023 12:12:21 GMT, Eirik Bjorsnos wrote: >> The TestTooManyEntries test was originally added to validate that ZIP64 >> files with CEN sizes exceeding what ZipFile supports are rejected with a >> ZipException. The test does this by creating a large ZIP file (several >> gigabytes

Re: RFR: 8304846: Provide a shared utility to dump generated classes defined via Lookup API

2023-03-26 Thread Brian Goetz
Since LMF goes through Lookup::defineHiddenClass, does this mean that they will be potentially dumped twice, once through Lookup, and once through LMF? Now that there is a shared implementation, perhaps we should migrate use in LMF to something more like -Djava.lang.invoke.MethodHandle.DU

Re: RFR: 8304013: Add a fast, non-manual alternative to test/jdk/java/util/zip/ZipFile/TestTooManyEntries [v4]

2023-03-26 Thread Eirik Bjorsnos
On Sun, 26 Mar 2023 16:51:28 GMT, Martin Buchholz wrote: >> So, what I would suggest is adding a comment somewhere regarding _end of >> central directory record_ and note the reference to _ENDHDR_ or _END Header_ >> >> I don't think you want to spend too much time here just the wording >> refe

Re: RFR: 8304013: Add a fast, non-manual alternative to test/jdk/java/util/zip/ZipFile/TestTooManyEntries [v4]

2023-03-26 Thread Martin Buchholz
On Sat, 25 Mar 2023 10:59:36 GMT, Lance Andersen wrote: >> If by "standard" you mean "APPNOTE.TXT", then that uses "end of central >> directory record" which is a bit long. >> >> The Java implementation seems to use END, like in `ZipFile.ENDHDR`, "END >> header", etc. >> >> It is probably bet

Re: The non-deterministic iteration order of Immutable Collections

2023-03-26 Thread Bernd
If you need order using List instead of Set/Map is perfectly fine decision of your students. It’s good if they learn that early. :) -- http://bernd.eckenfels.net  Von: core-libs-dev im Auftrag von Remi Forax Gesendet: Sonntag, März 26, 2023 1:42 PMAn: Jens L

Re: The non-deterministic iteration order of Immutable Collections

2023-03-26 Thread Alan Bateman
On 26/03/2023 10:38, Jens Lideström wrote: : I encountered this as a problem when I tried to generate a module dependency graph using jdeps. I had my classpath wrong and got an error message. The error message contained a list of modules or jar-files (I don't remember the details, unfortunate

Re: The non-deterministic iteration order of Immutable Collections

2023-03-26 Thread Jens Lideström
> The problem is that everyone will have to pay for the extra storage cost for maintaining insertion order. Even if people don't need it. I understand that. The main point of my message is that I think it is worth the cost, that a fixed iteration order should be the default, and that it should

Re: RFD: Should jextract be extracted from the JDK?

2023-03-26 Thread Eirik Bjørsnøs
Sorry Maurizio, It's not your understanding that is lacking, it is mine. I did not get the news. Mea culpa for not understanding the current situation properly. Thanks, Eirik On Sun, Mar 26, 2023 at 2:41 PM Maurizio Cimadamore < maurizio.cimadam...@oracle.com> wrote: > Hi, > not sure I underst

Re: RFD: Should jextract be extracted from the JDK?

2023-03-26 Thread Maurizio Cimadamore
Hi, not sure I understand your question correctly. But if you are referring to the fact that jextract should *not* be part of the JDK, please note that the FFM API does _not_ include jextract. The jextract tool is instead made available in a standalone repository: https://github.com/openjdk/j

Re: The non-deterministic iteration order of Immutable Collections

2023-03-26 Thread Remi Forax
- Original Message - > From: "Jens Lideström" > To: "core-libs-dev" > Sent: Sunday, March 26, 2023 11:38:07 AM > Subject: Re: The non-deterministic iteration order of Immutable Collections > I think Map#of and friends would be more useful and less error prone if they > where to return co

Re: The non-deterministic iteration order of Immutable Collections

2023-03-26 Thread Kasper Nielsen
On Sun, 26 Mar 2023 at 10:38, Jens Lideström wrote: > > I think Map#of and friends would be more useful and less error prone if they > where to return collections that have a fixed iteration order, where the > order is defined by the insertion order when the map is created. The problem is that

Re: The non-deterministic iteration order of Immutable Collections

2023-03-26 Thread Jens Lideström
I think Map#of and friends would be more useful and less error prone if they where to return collections that have a fixed iteration order, where the order is defined by the insertion order when the map is created. ### My experience with jdeps I encountered this as a problem when I tried to ge

Re: RFR: 8304932: MethodTypeDescImpl can be mutated by argument passed to MethodTypeDesc.of

2023-03-26 Thread Chen Liang
On Sun, 26 Mar 2023 05:23:54 GMT, Chen Liang wrote: > Fixed the bug where if a caller keeps a reference to the array passed into > `MethodTypeDesc.of`, the caller may mutate the Desc via the array and can > create invalid MethodTypeDesc. > > Unfortunately, since the input array now needs to be