On Mon, 13 Mar 2023 01:31:20 GMT, Martin Buchholz wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - MAX_EXTRA_FIELD_SIZE can be better expressed as 0x
>> - Bring back '@requires sun.arch.data.model == 64' fo
On Sun, 12 Mar 2023 21:25:46 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
> Sorting:
>
> - adopt radix sort for sequential and parallel sorts on int/long/float/double
> arrays (almost random and length > 6K)
> - fix tryMergeRuns() to better handle case when the last run is a single
> element
> - minor javadoc and comment changes
>
> Testing:
> - add new data inputs i
> Please review this PR which speeds up TestTooManyEntries and clarifies its
> purpose:
>
> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
> test. What is tested is the validation that the total CEN size fits in a Java
> byte array. Suggested rename: CenSizeTooLarge
> Please review this PR which speeds up TestTooManyEntries and clarifies its
> purpose:
>
> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
> test. What is tested is the validation that the total CEN size fits in a Java
> byte array. Suggested rename: CenSizeTooLarge
On Sun, 12 Mar 2023 14:12:08 GMT, Lance Andersen wrote:
> I think this is probably OK. I would probably create a constant with the Data
> Size to make it clearer and add more of a detailed comment of this method
> (laying out the structure of the Extra field) along with pointing to 4.6.1 of
>
On Sun, 12 Mar 2023 16:41:33 GMT, Martin Buchholz wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use Integer.toString instead of Long.toString
>
> test/jdk/java/util/zip/ZipFile/CenSizeTooLarge.java line 67:
>
On Sun, 12 Mar 2023 10:00:50 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
> Please review this PR which speeds up TestTooManyEntries and clarifies its
> purpose:
>
> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
> test. What is tested is the validation that the total CEN size fits in a Java
> byte array. Suggested rename: CenSizeTooLarge
On Sun, 12 Mar 2023 10:00:50 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
On Fri, 10 Mar 2023 21:21:56 GMT, Roger Riggs wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>> CDS)
>
On Fri, 10 Mar 2023 14:22:17 GMT, Justin King wrote:
> > > Has this totally killed of BSD support on the JDK side? I thought
> > > building non-macOS BSD was still viable, but perhaps not - certainly not
> > > after this change.
> >
> >
> > The macOS port in 7u4 was based on a BSD port and th
On Sun, 12 Mar 2023 11:47:47 GMT, Alan Bateman wrote:
> It would be great if we could change this to be an automatic test. Maybe we
> could create a sub-directory in test/jdk/java/util/zip/ZipFile for the
> resource hogs and put this here, exclude this directory from tier1, and add
> it to tie
On Sat, 11 Mar 2023 11:11:05 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Sun, 12 Mar 2023 10:00:50 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
On Sun, 12 Mar 2023 10:00:50 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
On Sun, 12 Mar 2023 11:13:51 GMT, Lance Andersen wrote:
> I think the changes look good overall. Thank you for this. I am not sure that
> the `@requires` is needed at this point.
I think it is still needed. ZipOutputStream needs to keep all entries in memory
until it can write the CEN entries.
On Sun, 12 Mar 2023 10:00:50 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
> Please review this PR which speeds up TestTooManyEntries and clarifies its
> purpose:
>
> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
> test. What is tested here is the validation that the total CEN size fits in a
> Java byte array. Suggested rename: CenSizeTooL
> Please review this PR which speeds up TestTooManyEntries and clarifies its
> purpose:
>
> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
> test. What is tested here is the validation that the total CEN size fits in a
> Java byte array. Suggested rename: CenSizeTooL
On Sat, 11 Mar 2023 12:16:04 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
Please review this test which speeds up TestTooManyEntries and clarifies its
purpose:
- The name 'TestTooManyEntries' does not clearly convey the purpose of the
test. What is tested here is the validation that the total CEN size fits in a
Java byte array. Suggested rename: CenSizeTooLarge
- The
22 matches
Mail list logo
