On Sun, 12 Mar 2023 14:12:08 GMT, Lance Andersen <lan...@openjdk.org> wrote:
> I think this is probably OK. I would probably create a constant with the Data > Size to make it clearer and add more of a detailed comment of this method > (laying out the structure of the Extra field) along with pointing to 4.6.1 of > the APP.note I pushed an implementation of this with improved comments, referencing APPNOTE.txt and using more constants where appropriate. I also remembered that ZIP shorts are unsigned, so we can double the size of the extra field for an extra little gain in performance/memory usage. Take a look at it, I'm sure there is room for improvements in my comments. ------------- PR: https://git.openjdk.org/jdk/pull/12991
