On Fri, 18 Nov 2022 17:57:39 GMT, Mandy Chung wrote:
> I believe there is no need to update the localized versions as they will be
> updated in bulk toward the end of the release.
@asotona - I see you integrated the change with the localized properties? Did
you mean to do that? I support the
> The can_support_virtual_thread was initially implemented as an onload
> capability.
> It is why this capability does not work for the agents loaded into running VM.
> The fix is to move it from `onload` to `always`capabilities list.
>
> Testing:
> New test is added: VirtualStartThreadTest.
> TB
The can_support_virtual_thread was initially implemented as an onload
capability.
It is why this capability does not work for the agents loaded into running VM.
The fix is to move it from `onload` to `always`capabilities list.
Testing:
New test is added: VirtualStartThreadTest.
TBD: mach5 jvmti,
On Fri, 18 Nov 2022 21:22:05 GMT, Brent Christian wrote:
>> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
>> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
>> sequence and immediately terminates the VM. Thus, "threads' current methods
>> do
On Tue, 15 Nov 2022 02:10:01 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8292317?
>
> The `java.util.Iterator` has a `forEachRemaining(Consumer action)`
> method. As per its contract, the implementations are ex
On Thu, 17 Nov 2022 06:05:40 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8292317?
>>
>> The `java.util.Iterator` has a `forEachRemaining(Consumer
>> action)` method. As per its contract, the implementations a
On Fri, 18 Nov 2022 14:10:11 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
On Thu, 17 Nov 2022 17:12:53 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/template/StringTemplate.java line 233:
>>
>>> 231:
>>> 232: /**
>>> 233: * Returns a StringTemplate with the given fragments and values.
>>
>> Suggestion:
>>
>> * Returns a {@code String
On Thu, 17 Nov 2022 06:05:40 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8292317?
>>
>> The `java.util.Iterator` has a `forEachRemaining(Consumer
>> action)` method. As per its contract, the implementations a
On Fri, 18 Nov 2022 21:22:05 GMT, Brent Christian wrote:
>> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
>> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
>> sequence and immediately terminates the VM. Thus, "threads' current methods
>> do
On Fri, 18 Nov 2022 18:36:51 GMT, Weibing Xiao wrote:
>> print warning message for java.io.tmpdir when it is set through the command
>> line and the value is not good for creating file folder.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the las
On Fri, 18 Nov 2022 09:57:39 GMT, Alan Bateman wrote:
> JEP 436 proposes a second preview of Virtual Threads to allow time for more
> feedback and to get more experience with this feature. There is no change in
> direction, no API changes, and no bulk update of the implementation. For the
> im
On Fri, 18 Nov 2022 03:26:38 GMT, Joe Darcy wrote:
> Update the spec of Class.getModifiers to match long-standing behavior for
> primitive and array classes. Remove unneeded implementation flexibility with
> regard to setting other bit positions. This work was prompted to better
> support anti
> Update the spec of Class.getModifiers to match long-standing behavior for
> primitive and array classes. Remove unneeded implementation flexibility with
> regard to setting other bit positions. This work was prompted to better
> support anticipated future Valhalla changes.
>
> Please also rev
On Fri, 18 Nov 2022 11:57:40 GMT, Adam Sotona wrote:
> There is a typo in `java -help` referencing -disable-@files instead of
> --disable-@files option.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: 3a15e848
Author:Adam Sotona
URL:
ht
On Fri, 18 Nov 2022 19:40:40 GMT, Pavel Rappo wrote:
>
> Feeling stupid for asking this, but does it make any sense to keep the order
> of modifiers "blessed" in text and tests?
>
> public protected private abstract static final transient volatile
> synchronized native strictfp
Will addre
On Fri, 18 Nov 2022 19:06:02 GMT, Alan Bateman wrote:
>> Right; ideally when the feature becomes non-preview the test update would
>> just be removing the "@enablePreview" line. I didn't author these tests so I
>> initially left any "othervm" directives in place since they aren't
>> incorrect,
On Thu, 17 Nov 2022 22:06:47 GMT, Brent Christian wrote:
> > Is a CSR needed here?
> I will check
A CSR is not needed.
-
PR: https://git.openjdk.org/jdk/pull/11218
On Thu, 17 Nov 2022 20:32:15 GMT, Brent Christian wrote:
>> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
>> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
>> sequence and immediately terminates the VM. Thus, "threads' current methods
>> do
> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
> sequence and immediately terminates the VM. Thus, "threads' current methods
> do not complete normally or abruptly; no finally clause of any me
Hi,
I agree the exception message could be added to facilitate the
understanding and the resolution of UnsupportedOperationExceptions from
List implementations.
New issue: https://bugs.openjdk.org/browse/JDK-8297283
As to what should be included in the message, that will need more
discussio
On Fri, 18 Nov 2022 18:36:51 GMT, Weibing Xiao wrote:
>> print warning message for java.io.tmpdir when it is set through the command
>> line and the value is not good for creating file folder.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the las
On Fri, 18 Nov 2022 18:12:56 GMT, Joe Darcy wrote:
>> Update the spec of Class.getModifiers to match long-standing behavior for
>> primitive and array classes. Remove unneeded implementation flexibility with
>> regard to setting other bit positions. This work was prompted to better
>> support
On Fri, 18 Nov 2022 18:12:56 GMT, Joe Darcy wrote:
>> Update the spec of Class.getModifiers to match long-standing behavior for
>> primitive and array classes. Remove unneeded implementation flexibility with
>> regard to setting other bit positions. This work was prompted to better
>> support
On Fri, 18 Nov 2022 18:38:46 GMT, Joe Darcy wrote:
>> test/jdk/java/lang/Thread/BuilderTest.java line 29:
>>
>>> 27: * @enablePreview
>>> 28: * @compile BuilderTest.java
>>> 29: * @run testng/othervm BuilderTest
>>
>> I assume `@compile` can be dropped from most of these tests now. Also I
>
On Fri, 18 Nov 2022 18:12:56 GMT, Joe Darcy wrote:
>> Update the spec of Class.getModifiers to match long-standing behavior for
>> primitive and array classes. Remove unneeded implementation flexibility with
>> regard to setting other bit positions. This work was prompted to better
>> support
On Fri, 18 Nov 2022 02:31:19 GMT, David Holmes wrote:
> Hi @jonathan-gibbons ,
>
> I notice that in the new version dash characters are no longer escaped as
> `-`, do these still display correctly?
Yes, at least in all the files I verified and I have no reason to believe it
might be different
On Fri, 18 Nov 2022 08:28:22 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> test/jdk/java/lang/Thread/BuilderTest.java line 29:
>
>> 27: * @enablePreview
>> 28: *
> Similar to an update recently done for langtools tests, update the libraries
> regression tests to take advantage of the @enablePreview jtreg feature.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
--
On Fri, 18 Nov 2022 18:12:56 GMT, Joe Darcy wrote:
>> Update the spec of Class.getModifiers to match long-standing behavior for
>> primitive and array classes. Remove unneeded implementation flexibility with
>> regard to setting other bit positions. This work was prompted to better
>> support
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Add ensureMaterializedForStackWalk kludge for AArch64
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjd
> print warning message for java.io.tmpdir when it is set through the command
> line and the value is not good for creating file folder.
Weibing Xiao has updated the pull request incrementally with one additional
commit since the last revision:
updated from the review comment
-
> Update the spec of Class.getModifiers to match long-standing behavior for
> primitive and array classes. Remove unneeded implementation flexibility with
> regard to setting other bit positions. This work was prompted to better
> support anticipated future Valhalla changes.
>
> Please also rev
On Fri, 18 Nov 2022 17:42:41 GMT, Mandy Chung wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/java/lang/Class.java line 1311:
>
>> 1309: * void, its {@
The problem is that would necessitate a new public class that is *only*
used as a return value. Since it would then come up with auto complete for
people searching for ArrayList, that's non trivial.
Deprecated also isn't the right concept. Mechanically it puts a line
through a method invocation, b
On Fri, 18 Nov 2022 11:57:40 GMT, Adam Sotona wrote:
> There is a typo in `java -help` referencing -disable-@files instead of
> --disable-@files option.
>
> Please review.
>
> Thanks,
> Adam
I believe there is no need to update the localized versions as they will be
updated in bulk toward th
On Fri, 18 Nov 2022 09:19:26 GMT, Matthias Baesken wrote:
> As discussed in https://bugs.openjdk.org/browse/JDK-8296945 , let us switch
> off VerifyDependencies in this test because of slow machines when
> (fast)debug builds are used, the test sometimes times out after the
> [JDK-8266074](htt
On Fri, 18 Nov 2022 17:46:33 GMT, Joe Darcy wrote:
>> Update the spec of Class.getModifiers to match long-standing behavior for
>> primitive and array classes. Remove unneeded implementation flexibility with
>> regard to setting other bit positions. This work was prompted to better
>> support
How about this as a proposed solution to avoid
UnsupportedOperationException:
1. Renamed the internal ArrayList to ArrayWrappingList
2. Override add() in ArrayWrappingList and make it deprecated to warn
people from using it.
On Fri, Nov 18, 2022 at 6:23 PM Ethan McCue wrote:
> I think there is
> Update the spec of Class.getModifiers to match long-standing behavior for
> primitive and array classes. Remove unneeded implementation flexibility with
> regard to setting other bit positions. This work was prompted to better
> support anticipated future Valhalla changes.
>
> Please also rev
JEP 436 proposes a second preview of Virtual Threads to allow time for more
feedback and to get more experience with this feature. There is no change in
direction, no API changes, and no bulk update of the implementation. For the
implementation, there has been ~35 changes/issues pushed to the ma
On Fri, 18 Nov 2022 15:04:13 GMT, Roger Riggs wrote:
>> Update the spec of Class.getModifiers to match long-standing behavior for
>> primitive and array classes. Remove unneeded implementation flexibility with
>> regard to setting other bit positions. This work was prompted to better
>> suppor
On Fri, 18 Nov 2022 15:47:37 GMT, Dan Heidinga wrote:
>> Update the spec of Class.getModifiers to match long-standing behavior for
>> primitive and array classes. Remove unneeded implementation flexibility with
>> regard to setting other bit positions. This work was prompted to better
>> suppo
On Fri, 18 Nov 2022 17:19:24 GMT, Andrew Haley wrote:
>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Reviewer feedback
> - Reviewer feedback Javadoc fixes
src/java.base/share/classes/java/lan
On Fri, 18 Nov 2022 11:57:40 GMT, Adam Sotona wrote:
> There is a typo in `java -help` referencing -disable-@files instead of
> --disable-@files option.
>
> Please review.
>
> Thanks,
> Adam
Changes in English resource bundles are automatically detected by the
translation process, and each J
I think there is potentially actionable feedback in that the exception
thrown when users bump into this limitation kinda sucks
jshell> Arrays.asList(1, 2, 3).add(4);
| Exception java.lang.UnsupportedOperationException
|at AbstractList.add (AbstractList.java:155)
|at AbstractList.a
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Reviewer feedback
- Reviewer feedback Javadoc fixes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openj
`new ArrayList<>(Arrays.asList(array))` is quite complex syntax to convert
an array to an java.util.ArrayList,
so a suggestion could be to add a new method to Arrays to convert an array
to a normal java.util.ArrayList which is modifiable.
Are there any low-hanging-fruit issues in core-libs-dev in
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Thu, 17 Nov 2022 20:18:42 GMT, Paul Sandoz wrote:
>> Andrew Haley has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Javadoc changes.
>> - ProblemList.txt cleanup
>
> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent
On Wed, 16 Nov 2022 19:04:29 GMT, Andrew Haley wrote:
>> Probably so, yes. I'll have a look at that along with caching failure.
>
> So I just did the experiment of caching failures and the result of
> `isBound()`.
>
> This test:
>
>
> @Benchmark
> @OutputTimeUnit(TimeUnit.NANOSECONDS)
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Merge branch 'JDK-828' of https://github.com/theRealAph/jdk into
JDK-828
- Reviewer feedback
-
Changes:
- all: https://git.openjdk.o
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
new ArrayList<>(Arrays.asList(theArray));
I'm not intending to be pithy - just this is one of the "known
deficiencies" of the collections framework. If you look hard enough you can
find some spitballing I did on how to address it in the core-libs mailing
list (which would be the place to go for th
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/StructuredTaskScope.java
Co-authored-by: Alan Bateman
-
Changes:
On Fri, 18 Nov 2022 14:45:56 GMT, Weibing Xiao wrote:
>> print warning message for java.io.tmpdir when it is set through the command
>> line and the value is not good for creating file folder.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the las
On Wed, 16 Nov 2022 15:03:37 GMT, Roger Riggs wrote:
>> Weibing Xiao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> the change according to review comment
>
> src/java.base/share/classes/jdk/internal/util/SystemProps.java line 70:
>
>>
On Thu, 17 Nov 2022 18:58:11 GMT, Andrew Haley wrote:
>> src/hotspot/share/utilities/exceptions.cpp line 166:
>>
>>> 164: // Remove the ScopedValue cache in case we got a virtual machine
>>> 165: // Error while we were trying to manipulate ScopedValue bindings.
>>> 166: thread->set_s
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Reviewer feedback
- Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pul
On Fri, 18 Nov 2022 14:45:56 GMT, Weibing Xiao wrote:
>> print warning message for java.io.tmpdir when it is set through the command
>> line and the value is not good for creating file folder.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the las
On Fri, 18 Nov 2022 03:26:38 GMT, Joe Darcy wrote:
> Update the spec of Class.getModifiers to match long-standing behavior for
> primitive and array classes. Remove unneeded implementation flexibility with
> regard to setting other bit positions. This work was prompted to better
> support anti
On Fri, 18 Nov 2022 11:57:40 GMT, Adam Sotona wrote:
> There is a typo in `java -help` referencing -disable-@files instead of
> --disable-@files option.
>
> Please review.
>
> Thanks,
> Adam
@alisenchung Would it be possible to comment on whether changes like this
should be touching the tran
On Fri, 18 Nov 2022 15:05:42 GMT, Andrew Haley wrote:
>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reviewer feedback
src/java.base/share/classes/java/lang/Thread.java line 787:
> 785:
> 786:
On Fri, 18 Nov 2022 03:26:38 GMT, Joe Darcy wrote:
> Update the spec of Class.getModifiers to match long-standing behavior for
> primitive and array classes. Remove unneeded implementation flexibility with
> regard to setting other bit positions. This work was prompted to better
> support anti
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/280cd6c5.
On Wed, 16 Nov 2022 12:34:29 GMT, Adam Sotona wrote:
> Option --disable-@files is passed to VM option causing it to fail.
> Proposed patch skips --disable-@files option in
> src/java.base/share/native/libjli/java.c ParseArguments processing, so it is
> not passed to the VM.
> The patch also add
> Pull in linker implementation changes, that include non-trivial changes to VM
> code, from the panama-foreign repo into the main JDK.
>
> This is split off from the main JEP integration to make reviewing easier.
>
> This includes the following patches:
>
> 1. https://github.com/openjdk/panama
On Wed, 16 Nov 2022 17:04:03 GMT, Jorn Vernee wrote:
>> Pull in linker implementation changes, that include non-trivial changes to
>> VM code, from the panama-foreign repo into the main JDK.
>>
>> This is split off from the main JEP integration to make reviewing easier.
>>
>> This includes the
> print warning message for java.io.tmpdir when it is set through the command
> line and the value is not good for creating file folder.
Weibing Xiao has updated the pull request incrementally with one additional
commit since the last revision:
update according to review comment
On Fri, 18 Nov 2022 11:43:56 GMT, Adam Sotona wrote:
>> Option --disable-@files is passed to VM option causing it to fail.
>> Proposed patch skips --disable-@files option in
>> src/java.base/share/native/libjli/java.c ParseArguments processing, so it is
>> not passed to the VM.
>> The patch als
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
On Wed, 16 Nov 2022 18:32:19 GMT, Jim Laskey wrote:
>> And, `StringTemplate` is missing a surrounding code/link tag
>
> Changing.
Changing.
-
PR: https://git.openjdk.org/jdk/pull/10889
On Wed, 16 Nov 2022 18:31:28 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/util/FormatProcessor.java line 39:
>>
>>> 37: /**
>>> 38: * This {@linkplain ValidatingProcessor template processor} constructs
>>> a String
>>> 39: * result using {@link Formatter}. Unlike {@link Formatte
On Wed, 9 Nov 2022 22:44:38 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/util/FormatProcessor.java line 38:
>>
>>> 36:
>>> 37: /**
>>> 38: * This {@linkplain ValidatingProcessor yemplate processor} constructs
>>> a String
>>
>> Typo: "yemplate processor".
>
> Changing
Changing
On Wed, 9 Nov 2022 22:43:40 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/util/FormatItem.java line 75:
>>
>>> 73: try {
>>> 74: return (long)CHAR_MIX.invokeExact(lengthCoder, value);
>>> 75: } catch (RuntimeException ex) {
>>
>> This should also rethrow
On Thu, 17 Nov 2022 15:46:14 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Requested changes #8
>> - Update StringTemplate javadoc
>
> src/java.base/share/classes/java/lang/template/StringTempla
On Fri, 18 Nov 2022 06:44:03 GMT, Jaikiran Pai wrote:
> Can I please get a review for this doc only change which fixes the javadoc of
> java.util.zip.Inflater class? As noted in
> https://bugs.openjdk.org/browse/JDK-8297129, there's a typo in the javadoc.
> This commit fixes that.
This pull r
There is a typo in `java -help` referencing -disable-@files instead of
--disable-@files option.
Please review.
Thanks,
Adam
-
Commit messages:
- 8297258: Typo in `java -help` referencing -disable-@files instead of
--disable-@files
Changes: https://git.openjdk.org/jdk/pull/11236/
On Fri, 18 Nov 2022 06:44:03 GMT, Jaikiran Pai wrote:
> Can I please get a review for this doc only change which fixes the javadoc of
> java.util.zip.Inflater class? As noted in
> https://bugs.openjdk.org/browse/JDK-8297129, there's a typo in the javadoc.
> This commit fixes that.
Thank you A
On Fri, 18 Nov 2022 06:44:03 GMT, Jaikiran Pai wrote:
> Can I please get a review for this doc only change which fixes the javadoc of
> java.util.zip.Inflater class? As noted in
> https://bugs.openjdk.org/browse/JDK-8297129, there's a typo in the javadoc.
> This commit fixes that.
Marked as r
On Thu, 17 Nov 2022 01:26:51 GMT, David Holmes wrote:
>> Option --disable-@files is not recognised as valid JVM option, however it is
>> already implemented in the launcher.
>> Proposed patch skips --disable-@files option in
>> src/hotspot/share/runtime/arguments.cpp processing, so it does not
> Option --disable-@files is not recognised as valid JVM option, however it is
> already implemented in the launcher.
> Proposed patch skips --disable-@files option in
> src/hotspot/share/runtime/arguments.cpp processing, so it does not fall into
> the category of unknown options.
> The patch al
As discussed in https://bugs.openjdk.org/browse/JDK-8296945 , let us switch off
VerifyDependencies in this test because of slow machines when (fast)debug
builds are used, the test sometimes times out after the
[JDK-8266074](https://bugs.openjdk.org/browse/JDK-8266074) Vtable-based CHA
implemen
On Fri, 18 Nov 2022 08:39:05 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/Inflater.java line 49:
>>
>>> 47: * sequence is provided in either byte array or byte buffer, via one of
>>> the
>>> 48: * {@code setInput()} methods. The output byte sequence is written to
>>>
On Fri, 18 Nov 2022 06:44:03 GMT, Jaikiran Pai wrote:
> Can I please get a review for this doc only change which fixes the javadoc of
> java.util.zip.Inflater class? As noted in
> https://bugs.openjdk.org/browse/JDK-8297129, there's a typo in the javadoc.
> This commit fixes that.
Marked as r
On Fri, 18 Nov 2022 08:33:40 GMT, Alan Bateman wrote:
>> Can I please get a review for this doc only change which fixes the javadoc
>> of java.util.zip.Inflater class? As noted in
>> https://bugs.openjdk.org/browse/JDK-8297129, there's a typo in the javadoc.
>> This commit fixes that.
>
> src/
On Fri, 18 Nov 2022 06:44:03 GMT, Jaikiran Pai wrote:
> Can I please get a review for this doc only change which fixes the javadoc of
> java.util.zip.Inflater class? As noted in
> https://bugs.openjdk.org/browse/JDK-8297129, there's a typo in the javadoc.
> This commit fixes that.
src/java.ba
On Thu, 17 Nov 2022 21:48:11 GMT, Joe Darcy wrote:
> Similar to an update recently done for langtools tests, update the libraries
> regression tests to take advantage of the @enablePreview jtreg feature.
test/jdk/java/lang/Thread/BuilderTest.java line 29:
> 27: * @enablePreview
> 28: * @comp
89 matches
Mail list logo
