On Wed, 9 Nov 2022 07:11:53 GMT, Markus KARG wrote:
>> This PR implements JDK-8296431
>
> Markus KARG has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed unused imports
@bplb Is there more you like to get changed?
-
PR: h
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Fri, 11 Nov 2022 01:41:15 GMT, Jim Laskey wrote:
>> Thanks, I think benchmarks like this are useful. The `interpolate()` case is
>> not something I considered when I made my earlier comment. Please add any
>> benchmarks to the patch as well, so that performance experiments can be
>> reliab
On Fri, 11 Nov 2022 00:55:24 GMT, Jorn Vernee wrote:
>> Fair comment. Initially, 99% of template processing will be through `STR``.
>> However, that
>> will likely change as libraries expand to include template processing. In
>> fact, creating
>> processors is so trivially easy that users will
On Thu, 10 Nov 2022 22:56:22 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/template/Carriers.java line 415:
>>
>>> 413: */
>>> 414: @Stable
>>> 415: private final Object[] objects;
>>
>> Looking at all this, I'm skeptical that carriers are worth the co
On Wed, 9 Nov 2022 13:24:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Tue, 8 Nov 2022 12:03:06 GMT, Erik Gahlin wrote:
> Could I have a review of PR that fixes so unsigned numbers are printed
> correctly in the jfr tool.
>
> Testing:
> test/jdk/jdk/jfr
> test/jdk/jdk/security/logging/
>
> Thanks
> Erik
This pull request has been closed without being integrat
> Could I have a review of PR that fixes so unsigned numbers are printed
> correctly in the jfr tool.
>
> Testing:
> test/jdk/jdk/jfr
> test/jdk/jdk/security/logging/
>
> Thanks
> Erik
Erik Gahlin has updated the pull request with a new target base due to a merge
or a rebase. The pull request
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Thu, 10 Nov 2022 19:54:30 GMT, Jorn Vernee wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Requested changes #5
>
> src/java.base/share/classes/java/lang/template/Carriers.java line 415:
>
>> 413: */
>>
On Thu, 10 Nov 2022 16:33:09 GMT, AJ1062910 wrote:
> did you changed 420 files ?
I ran a custom utility that edited these files, yes.
-
PR: https://git.openjdk.org/jdk/pull/11073
On Thu, 10 Nov 2022 12:01:11 GMT, Alan Bateman wrote:
> I'm trying to understand what "fix-ups" will be needed if the automated patch
> is applied. In some cases, it looks the same spec will be linked from "See
> also" and "External Specifications", e.g.
> http://cr.openjdk.java.net/~jjg/82965
On Thu, 10 Nov 2022 11:45:39 GMT, Alan Bateman wrote:
> > When referencing an RFC, it might be good to keep the RFC number in the
> > text link. For instance I see that java.net.URL now has this:
>
> I agree and also to add that some RFCs have commas in their titles, the same
> separator used
On Thu, 10 Nov 2022 11:30:51 GMT, Daniel Fuchs wrote:
> Hi Jon,
>
> When referencing an RFC, it might be good to keep the RFC number in the text
> link. For instance I see that java.net.URL now has this:
>
> http://cr.openjdk.java.net/~jjg/8296546/api.00/java.base/java/net/URL.html
>
> Extern
On Thu, 10 Nov 2022 11:45:39 GMT, Alan Bateman wrote:
> When referencing an RFC, it might be good to keep the RFC number in the text
> link.
+1.
-
PR: https://git.openjdk.org/jdk/pull/11073
On Thu, 10 Nov 2022 17:42:04 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
On Sun, 6 Nov 2022 16:39:48 GMT, Aleksei Efimov wrote:
> ### The Proposed Change
>
> The proposed change updates JNDI's `DnsClient` internal implementation to use
> `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS).
> The main motivation behind this change is to make JNDI/DNS lo
On Mon, 7 Nov 2022 16:05:28 GMT, Lance Andersen wrote:
> The javadoc for the checked exceptions will be inherited
Thank you Lance, I wasn't aware of that.
-
PR: https://git.openjdk.org/jdk/pull/10995
On Mon, 7 Nov 2022 10:08:16 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 210:
>>
>>> 208: * Reads all remaining bytes from the input stream for the current
>>> ZIP entry.
>>> 209: * This method blocks until all remaining bytes have bee
On Mon, 7 Nov 2022 09:58:03 GMT, Jaikiran Pai wrote:
>> Please review the following PR which updates several of the ZipInputStream
>> methods whose javadoc is inherited to clarify the methods are acting on
>> the current ZIP Entry.
>>
>> There are no changes in behavior. The main descriptio
On Mon, 7 Nov 2022 09:55:52 GMT, Jaikiran Pai wrote:
>> Please review the following PR which updates several of the ZipInputStream
>> methods whose javadoc is inherited to clarify the methods are acting on
>> the current ZIP Entry.
>>
>> There are no changes in behavior. The main descriptio
On Fri, 4 Nov 2022 18:13:23 GMT, Lance Andersen wrote:
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The main description f
Please review the following PR which updates several of the ZipInputStream
methods whose javadoc is inherited to clarify the methods are acting on the
current ZIP Entry.
There are no changes in behavior. The main description for the method's
javadoc that has been copied has been clarified an
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
On Thu, 10 Nov 2022 16:44:18 GMT, Rémi Forax wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up new StringTemplate creation
>>
>> Centralized StringTemplate creation in StringTemplateImplFactory. Added
>>
On Wed, 9 Nov 2022 18:58:30 GMT, Naoto Sato wrote:
> Pick up the fix in the upstream CLDR v42 maintenance branch for their
> tzdata2022f changes.
This pull request has now been integrated.
Changeset: 54c986e7
Author:Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/54c986e7d5d0b48
On Thu, 10 Nov 2022 15:03:48 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Work around x86 failures
>> - Review comments
>
> src/java.base/share/classes/jdk/internal/foreign/abi/aarch6
> Pull in linker implementation changes, that include non-trivial changes to VM
> code, from the panama-foreign repo into the main JDK.
>
> This is split off from the main JEP integration to make reviewing easier.
>
> This includes the following patches:
>
> 1. https://github.com/openjdk/panama
On Thu, 10 Nov 2022 15:09:14 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
*+serviceability-dev*
Firstly, thank you both for your time and work in this space. Apologies if this
should be a separate thread, but the new title “Extend Native Memory Tracking
over the JDK” aligns directly with some work I’ve been investigating, and I
hope my feedback will be helpful for pr
On Thu, 10 Nov 2022 14:59:20 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Work around x86 failures
>> - Review comments
>
> src/java.base/share/classes/jdk/internal/foreign/abi/Callin
> Pull in linker implementation changes, that include non-trivial changes to VM
> code, from the panama-foreign repo into the main JDK.
>
> This is split off from the main JEP integration to make reviewing easier.
>
> This includes the following patches:
>
> 1. https://github.com/openjdk/panama
On Tue, 25 Oct 2022 16:03:28 GMT, Ludovic Henry wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they a
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
On Wed, 9 Nov 2022 18:16:59 GMT, Jorn Vernee wrote:
>> Pull in linker implementation changes, that include non-trivial changes to
>> VM code, from the panama-foreign repo into the main JDK.
>>
>> This is split off from the main JEP integration to make reviewing easier.
>>
>> This includes the
On Wed, 9 Nov 2022 23:24:32 GMT, Jim Laskey wrote:
>> Changing
>
> Have to backtrack short term. This change forces StringTemplate.values() to
> return List. Will have to think this through (affects the JLS et al)
Worked this through for both StringTemplate.of and StringTemplate.interpolate
--
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are invoked so that
> there's less special handling and checks
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are invoked so that
> there's less special handling and checks
On Wed, 9 Nov 2022 02:35:24 GMT, David Schlosnagle wrote:
>> Claes Redestad has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 55 commits:
>>
>> - Revert accidental ModuleHashes change
>> - Merge branch 'master' into 8282664-polyha
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are invoked so that
> there's less special handling and checks
On Tue, 8 Nov 2022 16:04:25 GMT, Roger Riggs wrote:
>> Process.waitFor() throws IllegalThreadStateException when a process returns
>> an exit code of 259.
>> As described in the bug report, `waitFor()` should not be sensitive to the
>> exit value.
>> Previously, it erroneously threw IllegalStat
On Tue, 8 Nov 2022 16:04:25 GMT, Roger Riggs wrote:
>> Process.waitFor() throws IllegalThreadStateException when a process returns
>> an exit code of 259.
>> As described in the bug report, `waitFor()` should not be sensitive to the
>> exit value.
>> Previously, it erroneously threw IllegalStat
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Thu, 10 Nov 2022 11:30:51 GMT, Daniel Fuchs wrote:
> When referencing an RFC, it might be good to keep the RFC number in the text
> link. For instance I see that java.net.URL now has this:
I agree and also to add that some RFCs have commas in their titles, the same
separator used when there
47 matches
Mail list logo
