On Tue, 8 Nov 2022 16:04:25 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Process.waitFor() throws IllegalThreadStateException when a process returns >> an exit code of 259. >> As described in the bug report, `waitFor()` should not be sensitive to the >> exit value. >> Previously, it erroneously threw IllegalStateException. >> Added a test to verify. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Test cleanup as suggested by review comments. One final question - Now with this change, `Process.waitFor()` won't throw the `IllegalThreadStateException` for such programs that return `STILL_ACTIVE` exit code. However, looking at the code a subsequent Process.exitValue() call on that same process instance will still throw this exception. Should we be changing that too? ------------- PR: https://git.openjdk.org/jdk/pull/10680
