On Tue, 8 Nov 2022 00:58:44 GMT, Coleen Phillimore wrote:
> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
> Call a method in the ThreadGroup to call the synchronized method instead.
> Tested with tier 1-4.
This is a nice simplification of the VM side of the code!
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
Call a method in the ThreadGroup to call the synchronized method instead.
Tested with tier 1-4.
-
Commit messages:
- 8296492: Remove ObjectLocker in JVMTI get_subgroups call
Changes: https://git.openjdk.or
> ### The Proposed Change
>
> The proposed change updates JNDI's `DnsClient` internal implementation to use
> `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS).
> The main motivation behind this change is to make JNDI/DNS lookups friendly
> to virtual-thread environments and upda
On Mon, 7 Nov 2022 20:39:27 GMT, Daniel Fuchs wrote:
>> Thanks for spotting that, Jai.
>> You're correct that in its current version the fix changed an old logic of
>> `doUdpQuery`/`query` methods:
>> Before this change the method was returning `null` not when a receive is
>> timed out but when
On Mon, 7 Nov 2022 20:26:54 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DNSDatagramChannelFactory.java
> line 2
On Mon, 7 Nov 2022 23:20:15 GMT, Serguei Spitsyn wrote:
>> There is no new changes in the open portion of JDK, but extracting common
>> functionalities in bootstrap Utils to test/lib/Utils which can be used in
>> the closed part.
>
> The refactoring looks pretty good.
> But I have a couple of q
On Mon, 24 Oct 2022 12:16:54 GMT, Coleen Phillimore wrote:
> This change adds an option **EnableWaitForParallelLoad** to enable the legacy
> behavior where the VM will manage synchronization for multiple threads
> loading the same class using a non-parallel capable class loader that have
> rel
On Thu, 3 Nov 2022 16:48:36 GMT, Mandy Chung wrote:
>> This change adds an option **EnableWaitForParallelLoad** to enable the
>> legacy behavior where the VM will manage synchronization for multiple
>> threads loading the same class using a non-parallel capable class loader
>> that have releas
On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang wrote:
> There is no new changes in the open portion of JDK, but extracting common
> functionalities in bootstrap Utils to test/lib/Utils which can be used in the
> closed part.
The refactoring looks pretty good.
But I have a couple of questions.
Q1:
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Fri, 4 Nov 2022 17:40:27 GMT, Naoto Sato wrote:
>> Incorporated ISO 174 Amendment update: Update Croatia's currency from Kuna
>> to Euro (to take place on 1/1/2023).
>
> src/java.base/share/data/currency/CurrencyData.properties line 192:
>
>> 190: CI=XOF
>> 191: # CROATIA
>> 192: HR=HRK;2022
On Fri, 4 Nov 2022 17:21:04 GMT, Justin Lu wrote:
> Incorporated ISO 174 Amendment update: Update Croatia's currency from Kuna to
> Euro (to take place on 1/1/2023).
Changes requested by naoto (Reviewer).
src/java.base/share/data/currency/CurrencyData.properties line 192:
> 190: CI=XOF
> 191:
Incorporated ISO 174 Amendment update: Update Croatia's currency from Kuna to
Euro (to take place on 1/1/2023).
-
Commit messages:
- Actually change to GMT+1
- Convert time to Croatia/GMT+1
- Reflect future change date in table
- Add future date, remove localedata changes
- Init
On Tue, 10 May 2022 12:29:10 GMT, Severin Gehwolf wrote:
> Please review this change to the cgroup v1 subsystem which makes it more
> resilient on some of the stranger systems. Unfortunately, I wasn't able to
> re-create a similar system as the reporter. The idea of using the longest
> substri
On Fri, 4 Nov 2022 23:26:00 GMT, Alexander Matveev wrote:
> Changed names of symbolic links for drag and drop location in DMG image. See
> attached images in JBS.
> "/Applications" -> "Applications" for app DMG image.
> "/Library/Java/JavaVirtualMachines" -> "JavaVirtualMachines" for runtime DMG
On Mon, 7 Nov 2022 15:39:55 GMT, Aleksei Efimov wrote:
>> src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsClient.java line 470:
>>
>>> 468: } while (timeoutLeft > MIN_TIMEOUT);
>>> 469: // no matching packet received within the timeout
>>> 470:
On Mon, 7 Nov 2022 15:00:02 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Mon, 7 Nov 2022 19:28:56 GMT, Aleksei Efimov wrote:
>> ### The Proposed Change
>>
>> The proposed change updates JNDI's `DnsClient` internal implementation to
>> use `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS).
>> The main motivation behind this change is to make JNDI/D
On Mon, 7 Nov 2022 15:00:02 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
> This patch moves the acquisition of the boot class loader lock out of the JVM
> and into the Java function.
> Tested with tier1-4, and jvmti and jdi tests locally.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
really revert
On Mon, 7 Nov 2022 19:04:36 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Mon, 7 Nov 2022 14:59:27 GMT, Maurizio Cimadamore
wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Bring windows CallArranger in sync with panama repo
>
> I have incorporated additional API changes, descr
On Mon, 7 Nov 2022 15:00:02 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Mon, 7 Nov 2022 15:00:02 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Mon, 7 Nov 2022 19:00:40 GMT, Coleen Phillimore wrote:
> I reran jvmti tests on the change to revert ClassLoaders.java.
You can revert the comment too because it would be confusing to say that it
locks the class loader when it doesn't.
-
PR: https://git.openjdk.org/jdk/pull/110
There is no new changes in the open portion of JDK, but extracting common
functionalities in bootstrap Utils to test/lib/Utils.
-
Commit messages:
- JDK-8293450 Convert test/closed/sun/management/ shell tests to Java version
Changes: https://git.openjdk.org/jdk/pull/11029/files
We
On Mon, 7 Nov 2022 15:00:02 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
> ### The Proposed Change
>
> The proposed change updates JNDI's `DnsClient` internal implementation to use
> `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS).
> The main motivation behind this change is to make JNDI/DNS lookups friendly
> to virtual-thread environments and upda
On Mon, 7 Nov 2022 15:41:40 GMT, Aleksei Efimov wrote:
>> src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsClient.java line 185:
>>
>>> 183: public void close() {
>>> 184: try {
>>> 185: udpChannelSelector.close();
>>
>> Do you think we should now maintain a `closed`
On Mon, 7 Nov 2022 15:00:02 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Mon, 7 Nov 2022 15:00:02 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Mon, 7 Nov 2022 17:07:01 GMT, Coleen Phillimore wrote:
> This patch moves the acquisition of the boot class loader lock out of the JVM
> and into the Java function.
> Tested with tier1-4, and jvmti and jdi tests locally.
I reran jvmti tests on the change to revert ClassLoaders.java.
---
> This patch moves the acquisition of the boot class loader lock out of the JVM
> and into the Java function.
> Tested with tier1-4, and jvmti and jdi tests locally.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Revert ClassLo
On Mon, 7 Nov 2022 18:29:56 GMT, Alan Bateman wrote:
>> I traced it down to this: Is this why it's already synchronized ?
>> appendClassPath -> ucp.addFile -> addURL
>> public synchronized void addURL(URL url) {
>> if (closed || url == null)
>> return;
>>
On Mon, 7 Nov 2022 18:11:29 GMT, Coleen Phillimore wrote:
>> src/java.base/share/classes/jdk/internal/loader/ClassLoaders.java line 204:
>>
>>> 202: * @see
>>> java.lang.instrument.Instrumentation#appendToSystemClassLoaderSearch
>>> 203: */
>>> 204: synchronized void a
On Mon, 7 Nov 2022 17:56:00 GMT, Alan Bateman wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> src/java.base/share/classes/jdk/internal/loader/ClassLoaders.java line
On Thu, 3 Nov 2022 17:23:53 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalua
On Sat, 5 Nov 2022 01:08:11 GMT, Alexander Matveev wrote:
>> Changed names of symbolic links for drag and drop location in DMG image. See
>> attached images in JBS.
>> "/Applications" -> "Applications" for app DMG image.
>> "/Library/Java/JavaVirtualMachines" -> "JavaVirtualMachines" for runtime
On Mon, 7 Nov 2022 17:07:01 GMT, Coleen Phillimore wrote:
> This patch moves the acquisition of the boot class loader lock out of the JVM
> and into the Java function.
> Tested with tier1-4, and jvmti and jdi tests locally.
src/java.base/share/classes/jdk/internal/loader/ClassLoaders.java line
On Sat, 5 Nov 2022 18:29:47 GMT, Markus KARG wrote:
>> This PR implements JDK-8296431
>
> Markus KARG has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed typo
test/jdk/java/io/PushbackInputStream/TransferTo.java line 24:
> 22: */
> 23:
This patch moves the acquisition of the boot class loader lock out of the JVM
and into the Java function.
Tested with tier1-4, and jvmti and jdi tests locally.
-
Commit messages:
- 8296472: Remove a JVMTI ObjectLocker
Changes: https://git.openjdk.org/jdk/pull/11023/files
Webrev: h
On Mon, 7 Nov 2022 16:21:48 GMT, Magnus Ihse Bursie wrote:
>> Patched interim Preview and TransPatterns is a temporary workaround to allow
>> internal use of pattern switch in the JDK sources.
>
> So this will be removed later on in one of the follow up "chicken" PRs?
It will be removed in this
On Mon, 7 Nov 2022 12:52:38 GMT, Adam Sotona wrote:
>> To be more specific: is there some way the code in Preview.java and
>> TransPatterns.java can be modified so this transmogrification is not needed?
>
> Patched interim Preview and TransPatterns is a temporary workaround to allow
> internal
On Tue, 25 Oct 2022 16:03:28 GMT, Ludovic Henry wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they a
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are invoked so that
> there's less special handling and checks
On Mon, 7 Nov 2022 07:13:04 GMT, Jaikiran Pai wrote:
>> ### The Proposed Change
>>
>> The proposed change updates JNDI's `DnsClient` internal implementation to
>> use `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS).
>> The main motivation behind this change is to make JNDI/DNS
On Mon, 7 Nov 2022 14:17:40 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Sat, 5 Nov 2022 18:29:47 GMT, Markus KARG wrote:
>> This PR implements JDK-8296431
>
> Markus KARG has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed typo
@AlanBateman I fixed what you asked for. Kindly requesting review. :-)
--
On Tue, 25 Oct 2022 16:03:28 GMT, Ludovic Henry wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they a
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are invoked so that
> there's less special handling and checks
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Mon, 7 Nov 2022 13:43:17 GMT, Jorn Vernee wrote:
>> Actually, this patch is missing most of the stuff in PR 728. I was under the
>> impression that, in order to fully support that, some VM changes were needed
>> (e.g. to have better granularity in call shuffling - as per
>> https://github.c
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are invoked so that
> there's less special handling and checks
On Mon, 7 Nov 2022 09:40:03 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/x64/windows/CallArranger.java
>> line 165:
>>
>>> 163: assert forArguments : "no stack returns";
>>> 164: // stack
>>> 165: long a
On Mon, 7 Nov 2022 12:13:08 GMT, Magnus Ihse Bursie wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](http
On Mon, 7 Nov 2022 12:45:00 GMT, Adam Sotona wrote:
>> make/test/BuildMicrobenchmark.gmk line 106:
>>
>>> 104: --add-exports java.base/jdk.classfile.components=ALL-UNNAMED \
>>> 105: --add-exports java.base/jdk.classfile.impl=ALL-UNNAMED \
>>> 106: --add-exports
>>> java
On Mon, 7 Nov 2022 12:15:35 GMT, Magnus Ihse Bursie wrote:
>> make/CompileInterimLangtools.gmk line 78:
>>
>>> 76: $(call LogInfo, Generating Preview.java for
>>> jdk.compiler.interim)
>>> 77: $(call MakeDir, $(@D))
>>> 78: $(GREP) -v 'case PATTERN_SWITCH ->' $< > $@
>>
On Mon, 7 Nov 2022 12:16:29 GMT, Magnus Ihse Bursie wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](http
On Fri, 4 Nov 2022 12:38:04 GMT, Adam Sotona wrote:
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Mon, 7 Nov 2022 12:10:56 GMT, Magnus Ihse Bursie wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](http
On Fri, 4 Nov 2022 12:38:04 GMT, Adam Sotona wrote:
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk
> This change adds an option **EnableWaitForParallelLoad** to enable the legacy
> behavior where the VM will manage synchronization for multiple threads
> loading the same class using a non-parallel capable class loader that have
> released the class loader lock. The VM will break the class loa
On Fri, 4 Nov 2022 12:38:04 GMT, Adam Sotona wrote:
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk
On Fri, 4 Nov 2022 12:38:04 GMT, Adam Sotona wrote:
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Sat, 5 Nov 2022 18:40:56 GMT, Jorn Vernee wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 17
>> additional comm
On Sat, 5 Nov 2022 18:04:38 GMT, Jorn Vernee wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 17
>> additional comm
On Sat, 5 Nov 2022 18:02:33 GMT, Jorn Vernee wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 17
>> additional comm
On Sun, 6 Nov 2022 16:39:48 GMT, Aleksei Efimov wrote:
> ### The Proposed Change
>
> The proposed change updates JNDI's `DnsClient` internal implementation to use
> `DatagramChannel` (DC) as a replacement for `DatagramSocket` (DS).
> The main motivation behind this change is to make JNDI/DNS lo
72 matches
Mail list logo
