Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Alan Bateman
On 26/10/2022 23:53, Peter Firmstone wrote: The change will have some performance impact, by requiring redundant parsing. Just thought I'd mention it, in case it hasn't been thought of. If you do an internet search there are other implementations of RFC3986 in java also. https://github.com/

Re: RFR: 8295537: Debug tracing for resolved java.lang.invoke.CallSite [v4]

2022-10-26 Thread Ioi Lam
> I've added a `java.lang.invoke.MethodHandle.TRACE_CALLSITE` property to show > how invokedynamic call sites are resolved. > > For example: > > > public class StrConcat { > static String hello = "Hello"; > static String world = "World"; > public static void main(String args[]) { >

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread ExE Boss
On Wed, 26 Oct 2022 16:41:29 GMT, Michael McMahon wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism de

Re: Jpackage OS/X DMG install Application folder alias name incorrectly shows as path with /

2022-10-26 Thread Michael Hall
> On Oct 26, 2022, at 4:31 PM, Michael Hall wrote: > > At jpackage 19, I filed a bug on this but don’t have a number yet. I seem to remember this as a regression it happened before. Strange since every occurrence of DMGSetup.scpt I can find looks like it handles the Application folder alias

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Peter Firmstone
Interesting.  Is this RFR a done deal? While I like the concept and and understand the reasoning of URL not having a public constructor, I think this may have been thought of in isolation, I'm not sure how a custom URI, that strictly complies with RFC 3986 will behave, if it must also be parse

Re: RFR: 8295000: java/util/Formatter/Basic test cleanup [v2]

2022-10-26 Thread Naoto Sato
On Wed, 26 Oct 2022 21:00:43 GMT, Justin Lu wrote: >> Issue: java/util/Formatter/Basic regression test emits lots of warning >> messages (~60). >> >> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files >> where the errors originate from are generated from the template.

Re: RFR: 8295537: Debug tracing for resolved java.lang.invoke.CallSite [v3]

2022-10-26 Thread Claes Redestad
On Wed, 26 Oct 2022 05:18:45 GMT, Ioi Lam wrote: >> I've added a `java.lang.invoke.MethodHandle.TRACE_CALLSITE` property to show >> how invokedynamic call sites are resolved. >> >> For example: >> >> >> public class StrConcat { >> static String hello = "Hello"; >> static String world

Re: RFR: 8295000: java/util/Formatter/Basic test cleanup [v2]

2022-10-26 Thread Brent Christian
On Wed, 26 Oct 2022 21:00:43 GMT, Justin Lu wrote: >> Issue: java/util/Formatter/Basic regression test emits lots of warning >> messages (~60). >> >> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files >> where the errors originate from are generated from the template.

Jpackage OS/X DMG install Application folder alias name incorrectly shows as path with /

2022-10-26 Thread Michael Hall
At jpackage 19, I filed a bug on this but don’t have a number yet. I did do a little looking at the DMGSetup.scpt AppleScript on my own. I was thinking this… -- Create alias for install location make new alias file at POSIX file "DEPLOY_VOLUME_PATH" to POSIX file "DEPLOY_INSTAL

Re: RFR: 8295000: java/util/Formatter/Basic test cleanup [v2]

2022-10-26 Thread Justin Lu
> Issue: java/util/Formatter/Basic regression test emits lots of warning > messages (~60). > > Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files > where the errors originate from are generated from the template. > > Note: The reason why there is white space added (and

Re: RFR: JDK-8295859: Update Manual Test Groups

2022-10-26 Thread Bill Huang
On Wed, 26 Oct 2022 08:16:37 GMT, Alan Bateman wrote: >> This task is created to add manual tests to the manual test groups. >> >> In addition, fix is provided for TestMatrix.java#Downcall-F and >> TestMatrix.java#Downcall-T which are failing due to missing >> TestDowncall.java >> ([JDK-82871

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Daniel Fuchs
On Wed, 26 Oct 2022 17:39:56 GMT, Xue-Lei Andrew Fan wrote: >> `URLStreamHandler` really belongs to `java.net.URL`, and is an >> implementation detail of the infrastructure/SPI that makes it possible to >> eventually call `URL::openConnection`. I do not think it would be >> appropriate to have

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Xue-Lei Andrew Fan
On Wed, 26 Oct 2022 17:24:59 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/java/net/URL.java line 852: >> >>> 850: * @since 20 >>> 851: */ >>> 852: public static URL fromURI(URI uri, URLStreamHandler streamHandler) >> >> What do you think to have this method in URI inste

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Daniel Fuchs
On Wed, 26 Oct 2022 17:09:20 GMT, Xue-Lei Andrew Fan wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Xue-Lei Andrew Fan
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote: > Deprecate URL constructors. Developers are encouraged to use `java.net.URI` > to parse or construct any URL. > > The `java.net.URL` class does not itself encode or decode any URL components > according to the escaping mechanism defined in

Integrated: 8295823: Use enhanced-for cycle instead of Enumeration in java.naming

2022-10-26 Thread Andrey Turbanov
On Thu, 20 Oct 2022 20:28:37 GMT, Andrey Turbanov wrote: > `java.util.Enumeration` is a legacy interface from java 1.0. > There are couple of cycles which use it to iterate over collections. We can > replace this manual cycle with enchanced-for, which is shorter and easier to > read. This pull

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Weijun Wang
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote: > Deprecate URL constructors. Developers are encouraged to use `java.net.URI` > to parse or construct any URL. > > The `java.net.URL` class does not itself encode or decode any URL components > according to the escaping mechanism defined in

Re: RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Michael McMahon
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote: > Deprecate URL constructors. Developers are encouraged to use `java.net.URI` > to parse or construct any URL. > > The `java.net.URL` class does not itself encode or decode any URL components > according to the escaping mechanism defined in

RFR: 8294241: Deprecate URL public constructors

2022-10-26 Thread Daniel Fuchs
Deprecate URL constructors. Developers are encouraged to use `java.net.URI` to parse or construct any URL. The `java.net.URL` class does not itself encode or decode any URL components according to the escaping mechanism defined in RFC2396. It is the responsibility of the caller to encode any fi

Re: RFR: 8295537: Debug tracing for resolved java.lang.invoke.CallSite [v3]

2022-10-26 Thread Jorn Vernee
On Wed, 26 Oct 2022 05:18:45 GMT, Ioi Lam wrote: >> I've added a `java.lang.invoke.MethodHandle.TRACE_CALLSITE` property to show >> how invokedynamic call sites are resolved. >> >> For example: >> >> >> public class StrConcat { >> static String hello = "Hello"; >> static String world

Re: RFR: 8292937: Improve performance of some read operations of RandomAccessFile [v6]

2022-10-26 Thread Сергей Цыпанов
> Currently some operations of RandomAccessFile are implemented with multiple > read() invocations: > > public final int readInt() throws IOException { > int ch1 = this.read(); > int ch2 = this.read(); > int ch3 = this.read(); > int ch4 = this.read(); > if ((ch1 | ch2 | ch3 |

Re: RFR - Implementation of JEP-430 String Templates (Preview) CSR

2022-10-26 Thread Remi Forax
Each time i re-read this JEP, i'm more and more sorry about its state. - we are breaking how Strings worked, now everything in between "..." is not a String anymore. As an example, given a String s, only one of the following lines compiles System.out.println("s = \{s}".toUpperCase()); System.o

Re: RFR: JDK-8295859: Update Manual Test Groups

2022-10-26 Thread Alan Bateman
On Tue, 25 Oct 2022 23:10:53 GMT, Bill Huang wrote: > This task is created to add manual tests to the manual test groups. > > In addition, fix is provided for TestMatrix.java#Downcall-F and > TestMatrix.java#Downcall-T which are failing due to missing TestDowncall.java > ([JDK-8287158](https:/

Withdrawn: 8294394: running jlink in GraalVM must copy libgraal into the output image

2022-10-26 Thread Doug Simon
On Tue, 27 Sep 2022 11:30:26 GMT, Doug Simon wrote: > This PR adds a new jlink plugin (`--copy-files=`) that copies > specified files from the current image into the output image. > This is useful in the context of GraalVM where libgraal (e.g. > `lib/libjvmcicompiler.so`) is produced after the