On Tue, 18 Oct 2022 02:03:06 GMT, Mandy Chung wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains four additional commits
>> since
On Mon, 17 Oct 2022 21:48:42 GMT, Ioi Lam wrote:
>> Please review this small optimization. As shown in the JBS issue, most of
>> the generated LambdaForm classes have a single ClassData, so we can get a
>> small footprint/speed improvement.
>
> Ioi Lam has updated the pull request with a new ta
On Sat, 15 Oct 2022 07:30:54 GMT, Tagir F. Valeev wrote:
> For unsorted sets like LinkedHashSet, it's unclear how to behave if
> replaceAll returns identical elements. Throw an exception? Shrink the set
> size via deduplication?
I would assume the spec for replaceAll would be borrowed from
Ma
On Thu, 13 Oct 2022 07:04:25 GMT, Jatin Bhateja wrote:
>> Xiaohong Gong has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> comm
On Mon, 19 Sep 2022 08:51:24 GMT, Xiaohong Gong wrote:
> "`VectorSupport.indexVector()`" is used to compute a vector that contains the
> index values based on a given vector and a scale value (`i.e. index = vec +
> iota * scale`). This function is widely used in other APIs like
> "`VectorMask.
> "`VectorSupport.indexVector()`" is used to compute a vector that contains the
> index values based on a given vector and a scale value (`i.e. index = vec +
> iota * scale`). This function is widely used in other APIs like
> "`VectorMask.indexInRange`" which is useful to the tail loop vectoriza
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
On Mon, 17 Oct 2022 23:57:11 GMT, Iris Clark wrote:
>> Thank you Lance, will take a look at this and the rest of the comments
>
> Careful. I suspect that "fail" is the number of tests that are expected to
> fail.
Thanks Iris,
It got hidden in the code snippet, but line 89 is `if (fail != 0)`,
On Mon, 17 Oct 2022 23:34:22 GMT, Justin Lu wrote:
>> test/jdk/java/util/Formatter/Basic.java line 93:
>>
>>> 91:+ fail + " failure(s), first",
>>> first);
>>> 92: else
>>> 93: System.out.println("all " + (fail + pass) + " tests
>>> p
On Mon, 17 Oct 2022 22:18:01 GMT, Lance Andersen wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used with
On Mon, 17 Oct 2022 22:20:11 GMT, Lance Andersen wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used with
On Fri, 14 Oct 2022 20:38:32 GMT, Justin Lu wrote:
> Issue: Formatter unit tests are launched via basic.sh
>
> Fix: Replace basic.sh with a Java test launcher
>
> Note: Java.internal.math was included in the original configuration of Basic,
> but I removed it as it was not used within the Basi
On Fri, 14 Oct 2022 21:48:06 GMT, Naoto Sato wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within t
On Fri, 14 Oct 2022 20:38:32 GMT, Justin Lu wrote:
> Issue: Formatter unit tests are launched via basic.sh
>
> Fix: Replace basic.sh with a Java test launcher
>
> Note: Java.internal.math was included in the original configuration of Basic,
> but I removed it as it was not used within the Basi
Issue: Formatter unit tests are launched via basic.sh
Fix: Replace basic.sh with a Java test launcher
Note: Java.internal.math was included in the original configuration of Basic,
but I removed it as it was not used within the Basic unit tests
Original output on success
https://user-images.gi
On Fri, 14 Oct 2022 17:12:51 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java
>> line 291:
>>
>>> 289: final List cd = classData;
>>> 290: return switch(cd.size()) {
>>> 291: case 0 -> null;
>>
>> `List.of()` alwa
> Please review this small optimization. As shown in the JBS issue, most of the
> generated LambdaForm classes have a single ClassData, so we can get a small
> footprint/speed improvement.
Ioi Lam has updated the pull request with a new target base due to a merge or a
rebase. The incremental we
On Mon, 17 Oct 2022 19:28:09 GMT, Claes Redestad wrote:
> Looks good, assuming there are tests calling in with no class data to check
> that `defineClass` is fine with `null` inputs?
Yes, we have two existing test cases that has no class data:
- java/lang/invoke/CompileThresholdBootstrapTest
-
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote:
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place,
On Mon, 17 Oct 2022 10:19:26 GMT, Сергей Цыпанов wrote:
>> We can use `Comparator.naturalOrder()` for cases when a `TreeMap` instance
>> is constructed without comparator. This allows to squash two branches in
>> `TreeMap.get()` into one.
>>
>> P.S. I think the comment of `TreeMap.getEntryUsin
On Fri, 14 Oct 2022 04:37:22 GMT, Ioi Lam wrote:
>> Please review this small optimization. As shown in the JBS issue, most of
>> the generated LambdaForm classes have a single ClassData, so we can get a
>> small footprint/speed improvement.
>
> Ioi Lam has updated the pull request incrementally
On Mon, 17 Oct 2022 17:37:11 GMT, Erik Joelsson wrote:
> I believe this is part of the effort for
> https://bugs.openjdk.org/browse/JDK-8288293.
Agree. I'd prefer to have a different description of the bug though to make it
clear that this is necessary for decoupling a compiler and an OS.
---
On Mon, 17 Oct 2022 17:16:21 GMT, Alexey Semenyuk wrote:
> The change looks harmless. Howevere I don't understand how searching for the
> standard Windows libs can then become frustrating.
I believe this is part of the effort for
https://bugs.openjdk.org/browse/JDK-8288293.
-
PR:
On Mon, 17 Oct 2022 14:41:06 GMT, Julian Waters wrote:
>> Some external libraries required by native code are linked via linker
>> comments embedded in pragmas. Searching for which libraries are linked can
>> then become frustrating and confusing since they may be included in an
>> obscure pla
On Mon, 17 Oct 2022 14:41:06 GMT, Julian Waters wrote:
>> Some external libraries required by native code are linked via linker
>> comments embedded in pragmas. Searching for which libraries are linked can
>> then become frustrating and confusing since they may be included in an
>> obscure pla
On Mon, 3 Oct 2022 18:32:29 GMT, Raffaello Giulietti
wrote:
> Completes the spec of [PR 10541](https://github.com/openjdk/jdk/pull/10541)
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10543
> This task converts 5 manual tests to automated tests.
>
> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
> sun/security/provider/PolicyParser/ExtDirsChange.java
> sun/security/provider/PolicyParser/ExtDirs.java
> java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.
On Mon, 3 Oct 2022 18:32:29 GMT, Raffaello Giulietti
wrote:
> Completes the spec of [PR 10541](https://github.com/openjdk/jdk/pull/10541)
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10543
The fix is contributed by @plummercj actually.
-
Commit messages:
- fix
Changes: https://git.openjdk.org/jdk/pull/10730/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10730&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8284614
Stats: 2 lines in 1 file changed: 0 i
On Fri, 14 Oct 2022 15:50:30 GMT, Bill Huang wrote:
>> test/jdk/java/security/Policy/Root/Root.java line 48:
>>
>>> 46: private static final Path TARGET = Paths.get(ROOT, ".java.policy");
>>> 47: public static void main(String[] args) throws Exception {
>>> 48: Files.copy(SOURCE,
> This task converts 5 manual tests to automated tests.
>
> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
> sun/security/provider/PolicyParser/ExtDirsChange.java
> sun/security/provider/PolicyParser/ExtDirs.java
> java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote:
>> 8290313: Produce warning when user specified java.io.tmpdir directory
>> doesn't exist
>
> Weibing Xiao has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 11 commits:
>
> - Me
On Mon, 17 Oct 2022 09:38:01 GMT, Сергей Цыпанов wrote:
>> I saw this code many times and always thought that it exists for performance
>> purposes, to avoid extra indirection via likely megamorphic naturalOrder
>> comparator which will slow down the operations on common path. I think such
>>
On Fri, 14 Oct 2022 17:45:50 GMT, Roger Riggs wrote:
> In the general composition of filters, it is preferable that UNDECIDED is
> treated as REJECTED.
> That keeps unintentional holes in a filter from being permissive.
That is a good point Roger. The "java.security" file was updated (4449dda)
> ### Summary of the change
> This change introduces new system and security properties for specifying
> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
> implementations.
>
> These new properties allow more granular control over the set of object
> factories allowed to reconst
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place, and for all relevant compilers there is no difference bet
On Mon, 17 Oct 2022 14:31:46 GMT, Julian Waters wrote:
>> Some external libraries required by native code are linked via linker
>> comments embedded in pragmas. Searching for which libraries are linked can
>> then become frustrating and confusing since they may be included in an
>> obscure pla
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place, and for all relevant compilers there is no difference bet
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place, and for all relevant compilers there is no difference bet
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote:
>> 8290313: Produce warning when user specified java.io.tmpdir directory
>> doesn't exist
>
> Weibing Xiao has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 11 commits:
>
> - Me
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place, and for all relevant compilers there is no difference bet
On Sun, 16 Oct 2022 13:18:14 GMT, Alan Bateman wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update Guid.cpp
>
> src/java.base/windows/native/libnio/ch/FileDispatcherImpl.c line 38:
>
>> 36:
>> 37: #include
>
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place, and for all relevant compilers there is no difference bet
On Mon, 17 Oct 2022 09:24:58 GMT, Magnus Ihse Bursie wrote:
> @TheShermanTanker Question: is this a Windows-specific thing, or are there
> pragma-loaded libraries for other compilers as well?
To my knowledge only Visual C++ has the ability to perform linking through
pragmas, the comment pragma
On Sun, 18 Sep 2022 11:52:28 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test only change which proposes to fix the
> recent intermittent failures in `RmiBootstrapTest` reported in
> https://bugs.openjdk.org/browse/JDK-8030616?
>
> The test has been intermittently failing with
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
waiting for review
-
PR: https://git.openjdk.org/jdk/pu
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
On Mon, 17 Oct 2022 10:59:21 GMT, Roman Kennke wrote:
> Which kind of sources would do that, and is there a way to check it and
> prevent it?
>
> The whole issue points to an insufficiency in the API: it is lacking a way to
> transfer buffers in a read-only fashion (like NIO could do). I don't
Hello Volker,
On 17/10/22 4:32 pm, Volker Simonis wrote:
Hi Jaikiran,
Thanks for the quick response. Unfortunately I can't find it online.
Is this a private issue or does Apple not provide public access to
submitted bugs at all?
As far as I know, Apple doesn't provide public access to these i
On Sat, 15 Oct 2022 14:38:04 GMT, Alan Bateman wrote:
> > @AlanBateman WDYT? Is such a test mandatory to include this rather simple
> > PR?
>
> I think it means checking that
> test/jdk/java/io/BufferedInputStream/TransferTo.java exercises this code
> path, I expect it should.
>
> It might s
Hi Jaikiran,
Thanks for the quick response. Unfortunately I can't find it online.
Is this a private issue or does Apple not provide public access to
submitted bugs at all?
Regards,
Volker
On Mon, Oct 17, 2022 at 11:09 AM Jaikiran Pai wrote:
>
> Hello Volker,
>
> I've now commented on that JBS i
On Sat, 15 Oct 2022 13:17:27 GMT, Markus KARG wrote:
> Isn't a test needed here which fails without but passes with the proposed
> change?
If you are saying, that a test should verify that, e.g. the wrapped OS receives
the buffer upon calling BIS.transferTo() under certain circumstances, then
> We can use `Comparator.naturalOrder()` for cases when a `TreeMap` instance is
> constructed without comparator. This allows to squash two branches in
> `TreeMap.get()` into one.
>
> P.S. I think the comment of `TreeMap.getEntryUsingComparator()` is outdated.
> Should we also change it?
Серге
On Sun, 16 Oct 2022 19:43:54 GMT, Tagir F. Valeev wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/java.base/share/classes/java/util/TreeMap.java
>>
>> Co-authored-by: ExE Boss <3889017+exe-b...@us
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote:
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place,
Hello Volker,
I've now commented on that JBS issue with the Apple bug id - it's FB9997771.
-Jaikiran
On 17/10/22 2:24 pm, Volker Simonis wrote:
I can't find a link to the bug that has been filed with Apple in the
issue https://bugs.openjdk.org/browse/JDK-8282954.
Can somebody please post the
Yes, sorry about that. This is with JDK17. I looked at the bundled zlib
before posting and saw it hadn't been upgraded recently, so thought the
issue wasn't known, but wasn't aware that the bundled zlib was dead on
macOS ARM.
Jai's investigation is superb and matches what we see almost exactly (o
I can't find a link to the bug that has been filed with Apple in the
issue https://bugs.openjdk.org/browse/JDK-8282954.
Can somebody please post the link to corresponding Apple issue here
and/or update JDK-8282954 with that information?
Thanks,
Volker
On Mon, Oct 17, 2022 at 10:49 AM Alan Batema
On 17/10/2022 10:26, Mike Hearn wrote:
For some time now we've been chasing a very rare data corruption bug
in java.util.zip.Inflater that we think must be a bug in the bundled
native zlib. It gets detected by the CRC32 checks and so surfaces as a
failure to inflate. We believe this because:
Hello Mike,
On 17/10/22 1:56 pm, Mike Hearn wrote:
For some time now we've been chasing a very rare data corruption bug
in java.util.zip.Inflater that we think must be a bug in the bundled
native zlib.
When you say "bundled native zlib", do you mean the zlib is bundled
within the JDK distrib
For some time now we've been chasing a very rare data corruption bug in
java.util.zip.Inflater that we think must be a bug in the bundled native
zlib. It gets detected by the CRC32 checks and so surfaces as a failure to
inflate. We believe this because:
1. It only seems to happen on ARM Macs (thou
61 matches
Mail list logo
