On Mon, 19 Sep 2022 08:51:24 GMT, Xiaohong Gong wrote:
> "`VectorSupport.indexVector()`" is used to compute a vector that contains the
> index values based on a given vector and a scale value (`i.e. index = vec +
> iota * scale`). This function is widely used in other APIs like
> "`VectorMask.
On Wed, 12 Oct 2022 00:01:50 GMT, David Alvarez wrote:
> Please, review this PR for an update of timezone data. No changes besides the
> import were needed.
Thanks for the explanation!. I've run that Makefile and i can see the new
files, including a displaynames.txt that matches what you're se
> Please, review this PR for an update of timezone data. No changes besides the
> import were needed.
David Alvarez has updated the pull request incrementally with one additional
commit since the last revision:
Update displaynames.txt
-
Changes:
- all: https://git.openjdk.org/
On Wed, 12 Oct 2022 00:01:50 GMT, David Alvarez wrote:
> Please, review this PR for an update of timezone data. No changes besides the
> import were needed.
We normally run test/jdk/java/util/TimeZone/tools/share/Makefile with the JDK
integrating new timezone data in order to generate
test/jd
On Tue, 11 Oct 2022 15:17:13 GMT, Weijun Wang wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implemented review comments.
>
> I have a question, why must this test be manual? Can't we compare the
> localized texts?
Please, review this PR for an update of timezone data. No changes besides the
import were needed.
-
Commit messages:
- (tz) Update Timezone Data to 2022e
Changes: https://git.openjdk.org/jdk/pull/10666/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10666&range=00
Issue:
https://openjdk.org/jeps/431
Summary: Introduce new interfaces to represent collections with a
defined encounter order. Each such collection has a well-defined first
element, second element, and so forth, up to the last element. It also
provides uniform APIs for accessing its first and las
On Tue, 11 Oct 2022 20:50:15 GMT, Brian Burkhalter wrote:
>> On Windows, suppress failure if the total space indicated by `df` is less
>> than `FileStore::getTotalSpace` and the free space indicated by `df` equals
>> `FileStore::getUnallocatedSpace`.
>
> Brian Burkhalter has updated the pull re
> On Windows, suppress failure if the total space indicated by `df` is less
> than `FileStore::getTotalSpace` and the free space indicated by `df` equals
> `FileStore::getUnallocatedSpace`.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The incr
On Mon, 10 Oct 2022 23:16:20 GMT, Mandy Chung wrote:
> This separates `@run` into its own `@test` that they can be run concurrently.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/10641
On Mon, 10 Oct 2022 14:28:07 GMT, Aleksei Efimov wrote:
>> ### Summary of the change
>> This change introduces new system and security properties for specifying
>> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
>> implementations.
>>
>> These new properties allow more granula
On Tue, 11 Oct 2022 17:11:49 GMT, Pavel Rappo wrote:
> Please review this utmost trivial fix for an issue discovered while working
> on something else in jdk.javadoc. As far as I can see, this is the only case
> of `{@inheritDoc}` not being the sole content of a `@throws` description in
> JDK.
On Tue, 11 Oct 2022 11:31:53 GMT, Mahendra Chhipa wrote:
>> Added test cases for xpath Axis:
>> 1. descendant
>> 2. descendant-or-self
>> 3. following
>> 4. following-sibling
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Tue, 11 Oct 2022 17:11:49 GMT, Pavel Rappo wrote:
> Please review this utmost trivial fix for an issue discovered while working
> on something else in jdk.javadoc. As far as I can see, this is the only case
> of `{@inheritDoc}` not being the sole content of a `@throws` description in
> JDK.
On Tue, 11 Oct 2022 11:31:53 GMT, Mahendra Chhipa wrote:
>> Added test cases for xpath Axis:
>> 1. descendant
>> 2. descendant-or-self
>> 3. following
>> 4. following-sibling
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Tue, 11 Oct 2022 17:11:49 GMT, Pavel Rappo wrote:
> Please review this utmost trivial fix for an issue discovered while working
> on something else in jdk.javadoc. As far as I can see, this is the only case
> of `{@inheritDoc}` not being the sole content of a `@throws` description in
> JDK.
On Tue, 11 Oct 2022 17:11:49 GMT, Pavel Rappo wrote:
> Please review this utmost trivial fix for an issue discovered while working
> on something else in jdk.javadoc. As far as I can see, this is the only case
> of `{@inheritDoc}` not being the sole content of a `@throws` description in
> JDK.
On Tue, 11 Oct 2022 17:11:49 GMT, Pavel Rappo wrote:
> Please review this utmost trivial fix for an issue discovered while working
> on something else in jdk.javadoc. As far as I can see, this is the only case
> of `{@inheritDoc}` not being the sole content of a `@throws` description in
> JDK.
On Mon, 10 Oct 2022 23:16:20 GMT, Mandy Chung wrote:
> This separates `@run` into its own `@test` that they can be run concurrently.
Ok, thanks for the input. Instead of breaking into separate `@test` blocks, we
should look at how these tests can be broken up and which cases really need to
ex
Please review this utmost trivial fix for an issue discovered while working on
something else in jdk.javadoc. As far as I can see, this is the only case of
`{@inheritDoc}` not being the sole content of a `@throws` description in JDK.
-
Commit messages:
- Initial commit
Changes: ht
On Fri, 5 Aug 2022 16:36:23 GMT, Smita Kamath wrote:
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
This pull request has now been integrated.
Changeset: 07946aa4
Author:Smita Kamath
Committer: Sandhya Viswanathan
URL:
https
On Tue, 11 Oct 2022 15:17:13 GMT, Weijun Wang wrote:
> I have a question, why must this test be manual? Can't we compare the
> localized texts?
Thought about that, but it could be a nuisance if we compared word-to-word
translations, considering the situation if an engineer made some changes in
On Tue, 11 Oct 2022 17:03:47 GMT, Naoto Sato wrote:
> I have a question, why must this test be manual? Can't we compare the
> localized texts?
@wangweij Good question. We can definitely compare the localized texts at least
some keywords. The fact that automation is one of the goals of this tas
On Mon, 10 Oct 2022 21:05:58 GMT, Vladimir Kozlov wrote:
>> Smita Kamath has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated instruct to use kmovw
>
> I started new testing.
@vnkozlov Thank you for reviewing the patch.
On Tue, 11 Oct 2022 15:48:56 GMT, Raffaello Giulietti
wrote:
> Simple doc correction.
This pull request has now been integrated.
Changeset: 2586b1a3
Author:Raffaello Giulietti
URL:
https://git.openjdk.org/jdk/commit/2586b1a3c1e1c653e2e7e3398a1955882161193e
Stats: 2 lines in 1 f
On Tue, 11 Oct 2022 15:48:56 GMT, Raffaello Giulietti
wrote:
> Simple doc correction.
Marked as reviewed by jvernee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10658
On Tue, 11 Oct 2022 15:48:56 GMT, Raffaello Giulietti
wrote:
> Simple doc correction.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10658
On Tue, 11 Oct 2022 15:48:56 GMT, Raffaello Giulietti
wrote:
> Simple doc correction.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10658
On Tue, 11 Oct 2022 15:48:56 GMT, Raffaello Giulietti
wrote:
> Simple doc correction.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10658
On Tue, 11 Oct 2022 15:48:56 GMT, Raffaello Giulietti
wrote:
> Simple doc correction.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10658
On Mon, 3 Oct 2022 07:29:02 GMT, Markus KARG wrote:
> Fixes JDK-8294702
This pull request has now been integrated.
Changeset: 619cd825
Author:Markus Karg
Committer: Brian Burkhalter
URL:
https://git.openjdk.org/jdk/commit/619cd825b53465c4d533d5cab70070c08964fa91
Stats: 3 lines
Simple doc correction.
-
Commit messages:
- 8295155: Incorrect javadoc of java.base module
Changes: https://git.openjdk.org/jdk/pull/10658/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10658&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8295155
Stats: 2 lines in
On Tue, 11 Oct 2022 15:40:36 GMT, Brian Burkhalter wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modified to < 0 as proposed by Alan Batement
>
> Marked as reviewed by bpb (Reviewer).
@bplb Kindly requesting to r
On Tue, 4 Oct 2022 15:53:04 GMT, Alan Bateman wrote:
>> This is true, but if a broken subclass sets markpos to less than -1 then
>> lots of code lines will work incorrectly -- including `transferTo` which was
>> the starting point of your change proposal. So do you really only want undo
>> the
On Sun, 9 Oct 2022 14:08:40 GMT, Markus KARG wrote:
>> Fixes JDK-8294702
>
> Markus KARG has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Modified to < 0 as proposed by Alan Batement
Marked as reviewed by bpb (Reviewer).
-
PR:
On Tue, 11 Oct 2022 01:38:52 GMT, David Holmes wrote:
>> I left that in there since it would possibly be a useful utility to have for
>> other JLI code that might need to work with Windows errors in the future
>
> In that case shouldn't the `JLI_xxx` naming scheme be retained?
$0.02, leave it f
On Mon, 10 Oct 2022 23:23:00 GMT, Bill Huang wrote:
>> The jarsigner and keytool are localized into English, German, Japanese and
>> Simplified Chinese. This task is to modify the existing i18n tests to
>> validate i18n compliance in these tools.
>>
>> In addition, this task also contains cha
On Tue, 11 Oct 2022 12:39:14 GMT, Sean Mullan wrote:
>> @seanjmullan - I looked at that approach. The
>> `SharedSecrets.getJavaSecurityAccess().getInitialProperties();` call may
>> trigger early initialization of the `java.security.Security` class - I'm not
>> sure if we want that. Protection
On Tue, 4 Oct 2022 15:53:04 GMT, Alan Bateman wrote:
>> This is true, but if a broken subclass sets markpos to less than -1 then
>> lots of code lines will work incorrectly -- including `transferTo` which was
>> the starting point of your change proposal. So do you really only want undo
>> the
On Mon, 10 Oct 2022 20:41:39 GMT, Brian Burkhalter wrote:
> Isn't a test needed here which fails without but passes with the proposed
> change?
I do not see such a *need*, as this is solely a performance improvement, not a
fixed bug or added functionality. If the majority of this team wants to
On Tue, 11 Oct 2022 11:28:10 GMT, Sean Coffey wrote:
>> What about creating a new `JavaSecurityPropertiesAccess` class and moving
>> the accessor method there? It seems it would be cleaner to remove the
>> dependency on PD in the long run.
>
> @seanjmullan - I looked at that approach. The
> `
On Tue, 11 Oct 2022 11:31:51 GMT, Alan Bateman wrote:
> I wouldn't expect it to change the execution time of tier1_part1
I have *seen* the change in total CPU time when I tried to do the same thing
this PR does. This is why I bailed on doing the same thing PR proposes. Cutting
out the tests in
On Mon, 10 Oct 2022 23:16:20 GMT, Mandy Chung wrote:
> This separates `@run` into its own `@test` that they can be run concurrently.
I wouldn't expect it to change the execution time of tier1_part1 but it may
help with test selection, maybe combined with putting understandable ids or
jtreg key
> Added test cases for xpath Axis:
> 1. descendant
> 2. descendant-or-self
> 3. following
> 4. following-sibling
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Added predicate tests.
-
Changes:
- all: https://git.o
On Mon, 10 Oct 2022 20:54:58 GMT, Sean Mullan wrote:
>> modified code to have Security class hold the initial properties and
>> provided an accessor method
>
> What about creating a new `JavaSecurityPropertiesAccess` class and moving the
> accessor method there? It seems it would be cleaner to
It's still there.
https://github.com/openjdk/jdk/tree/master/src/demo/share/jfc/SwingSet2
Btw, client-libs-...@openjdk.org (included) is the relevant mailing list
for this message, not core-libs-dev.
-- Kevin
On 10/11/2022 1:54 AM, David Holmes wrote:
On 11/10/2022 4:38 pm, Amit wrote:
Cod
On Mon, 10 Oct 2022 23:16:20 GMT, Mandy Chung wrote:
> This separates `@run` into its own `@test` that they can be run concurrently.
I did consider when working on `VarHandle` tests recently, but figured this
split penalizes the total CPU time quite significantly. Given that these tests
run in
On 11/10/2022 4:38 pm, Amit wrote:
Code for many Java Swing Components In One Program in case someone needs it.
We used to have a Swing demo in the JDK ... don't know what happened to it.
David
Description: The program
Examples_Of_Many_Swing_Components_In_One_Program contains examples of
man
On Mon, 10 Oct 2022 19:23:51 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
On Fri, 7 Oct 2022 15:36:16 GMT, Mahendra Chhipa wrote:
>> Added test cases for xpath Axis:
>> 1. descendant
>> 2. descendant-or-self
>> 3. following
>> 4. following-sibling
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
50 matches
Mail list logo