On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
On Tue, 4 Oct 2022 09:07:42 GMT, Quan Anh Mai wrote:
>>> You can use `kmovwl` instead which will relax the avx512bw constraint,
>>> however, you will need avx512vl for `evcvtps2ph`. Thanks.
>>
>> Yes, in general all AVX512VL targets support AVX512BW, but cloud instances
>> give freedom to enab
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request incrementally with one additional
commit since the last revision:
Updated instruct to use kmovw
-
Changes:
- all: https://git.openj
On Wed, 5 Oct 2022 21:26:09 GMT, Justin Lu wrote:
>> Problem: Outdated doc does not match code. Claimed to throw exception and
>> compared to Long method.
>> Fix: Update doc to match code, compared to Double.parseDouble() accordingly.
>
> Justin Lu has updated the pull request incrementally with
On Wed, 5 Oct 2022 14:05:38 GMT, Alan Bateman wrote:
> This is a test-only change. ThreadAPI.testGetStackTrace2 tests the stack
> trace of a virtual thread that has started but has not executed it. The test
> currently attempts to saturate all carrier threads before starting a target
> thread.
Test failure is a duplicate of
[JDK-8284777](https://bugs.openjdk.org/browse/JDK-8284777), but the test needs
to be updated:
- the test instruments all loaded classes, so need to updated ASM version to
support records and permits;
Instrumentor.addNativeMethodTrackingInjection is used only by t
On 3 Oct 2022, at 14:32, Stuart Marks wrote:
> …
> The Arrays class does need some attention and probably should be considered
> separately. It's lacking some other things too, like reverse(). One issue
> with modifying the Arrays class is providing overloads for some or all of the
> primitives
On Fri, 8 Jul 2022 23:00:15 GMT, Stuart Marks wrote:
> The concept of the shutdown sequence needs to be specified more clearly. This
> PR adds text for this into the class specification of `java.lang.Runtime`.
> Also includes adjustments to related areas in `addShutdownHook`, `halt`, and
> in
On Wed, 5 Oct 2022 03:34:47 GMT, Stuart Marks wrote:
>> The concept of the shutdown sequence needs to be specified more clearly.
>> This PR adds text for this into the class specification of
>> `java.lang.Runtime`. Also includes adjustments to related areas in
>> `addShutdownHook`, `halt`, and
On 10/5/22 9:34 AM, Stuart Marks wrote:
On 10/4/22 9:38 PM, Ernie Rael wrote:
Summary of key points (maybe the mail was TL;DR)
OK thanks, I was still mulling over the previous email wondering which
parts were significant enough to reply to.
* SequencedCollection methods addFirst,addLas
On Wed, 5 Oct 2022 17:28:08 GMT, Bill Huang wrote:
>> Added test cases for xpath Axis:
>> 1. descendant
>> 2. descendant-or-self
>> 3. following
>> 4. following-sibling
>
> test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpDescendantTest.java line 65:
>
>> 63:
>> {"/Customers/Cust
On Tue, 4 Oct 2022 13:01:40 GMT, Mahendra Chhipa wrote:
> Added test cases for xpath Axis:
> 1. descendant
> 2. descendant-or-self
> 3. following
> 4. following-sibling
test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpDescendantTest.java line 41:
> 39: /*
> 40: * @test
> 41: * @bug 8289510
s/
> Problem: Outdated doc does not match code. Claimed to throw exception and
> compared to Long method.
> Fix: Update doc to match code, compared to Double.parseDouble() accordingly.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Update
On Wed, 5 Oct 2022 20:57:12 GMT, Lance Andersen wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update doc code
>
> src/java.base/share/classes/java/text/DigitList.java line 198:
>
>> 196:
>> 197: /**
>> 198:
On Wed, 5 Oct 2022 20:49:52 GMT, Justin Lu wrote:
>> Problem: Outdated doc does not match code. Claimed to throw exception and
>> compared to Long method.
>> Fix: Update doc to match code, compared to Double.parseDouble() accordingly.
>
> Justin Lu has updated the pull request incrementally with
> Problem: Outdated doc does not match code. Claimed to throw exception and
> compared to Long method.
> Fix: Update doc to match code, compared to Double.parseDouble() accordingly.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Update
On Tue, 4 Oct 2022 17:59:36 GMT, Alan Bateman wrote:
> This is a test only change for two tests for virtual threads that
> hang/timeout on single core systems. The two tests involve pinning and
> require at least two carrier threads. The test lib used by these tests is
> updated to define a ne
On Wed, 5 Oct 2022 19:58:24 GMT, Alan Bateman wrote:
>> It's not a matter of whether or not the test needs to restore it. It _will_
>> restore it if there is a GC, and if this happens before the test completes,
>> it could find itself without enough carrier threads.
>
> No, restoration requires
On Wed, 5 Oct 2022 19:44:44 GMT, Chris Plummer wrote:
>> This test doesn't need to restore it so it doesn't keep a reference and not
>> an issue if it is GC'ed.
>
> It's not a matter of whether or not the test needs to restore it. It _will_
> restore it if there is a GC, and if this happens bef
On Wed, 5 Oct 2022 19:30:46 GMT, Alan Bateman wrote:
>> test/jdk/java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java line
>> 30:
>>
>>> 28: * platform and virtual threads in deadlock
>>> 29: * @enablePreview
>>> 30: * @modules java.base/java.lang:+open java.management
>>
>> Can
On Wed, 5 Oct 2022 19:02:04 GMT, Chris Plummer wrote:
>> This is a test only change for two tests for virtual threads that
>> hang/timeout on single core systems. The two tests involve pinning and
>> require at least two carrier threads. The test lib used by these tests is
>> updated to define
On Tue, 4 Oct 2022 17:59:36 GMT, Alan Bateman wrote:
> This is a test only change for two tests for virtual threads that
> hang/timeout on single core systems. The two tests involve pinning and
> require at least two carrier threads. The test lib used by these tests is
> updated to define a ne
On Wed, 28 Sep 2022 22:54:33 GMT, Justin Lu wrote:
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
This pull request has now been integrated.
Changeset: 87acfee3
Author
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote:
> This is a test only change to remove the granting of
> RuntimePermission("stopThread") from the tests. With Thread.stop changed to
> throw UOE it means there is nothing that requires this permission.
LGTM
-
Marked as reviewed
On Tue, 4 Oct 2022 23:11:57 GMT, Justin Lu wrote:
> Problem: Outdated doc does not match code. Claimed to throw exception and
> compared to Long method.
> Fix: Update doc to match code, compared to Double.parseDouble() accordingly.
Turned out that the comment was not aligning with the behavior
On Wed, 5 Oct 2022 18:09:53 GMT, Bill Huang wrote:
>> Added test cases for xpath Axis:
>> 1. descendant
>> 2. descendant-or-self
>> 3. following
>> 4. following-sibling
>
> test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpFollowingTest.java line 108:
>
>> 106: };
>> 107: }
>> 108:
>
On Tue, 4 Oct 2022 13:01:40 GMT, Mahendra Chhipa wrote:
> Added test cases for xpath Axis:
> 1. descendant
> 2. descendant-or-self
> 3. following
> 4. following-sibling
test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpDescendantTest.java line 59:
> 57: {"/Customers/Customer[@id='
On Wed, 5 Oct 2022 03:40:27 GMT, liach wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
>> values by identity. Updated API documentation of these two methods
>> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Objec
On Wed, 5 Oct 2022 08:33:40 GMT, Alan Bateman wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> enhance test
>
> test/langtools/tools/jdeps/optionalDependency/OptionalDependencyTest.java
> line 74:
>
>> 72:
On Tue, 4 Oct 2022 23:11:57 GMT, Justin Lu wrote:
> Problem: Outdated doc does not match code. Claimed to throw exception and
> compared to Long method.
> Fix: Update doc to match code, compared to Double.parseDouble() accordingly.
Looks good to me. Since you are only modifying the comments, pl
On Fri, 30 Sep 2022 00:33:57 GMT, Joe Darcy wrote:
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
This pull request has now been i
> Please review a small patch for dumping the failure reason when the MSVCRT
> libraries or the Java Virtual Machine fails to load on Windows, which can
> provide invaluable insight when debugging related launcher issues.
>
> See https://bugs.openjdk.org/browse/JDK-8292016 and the related Pull R
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target base due to a merge or
a re
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote:
> This is a test only change to remove the granting of
> RuntimePermission("stopThread") from the tests. With Thread.stop changed to
> throw UOE it means there is nothing that requires this permission.
Marked as reviewed by mullan (Reviewer)
On 10/4/22 9:38 PM, Ernie Rael wrote:
Summary of key points (maybe the mail was TL;DR)
OK thanks, I was still mulling over the previous email wondering which parts were
significant enough to reply to.
* SequencedCollection methods addFirst,addLast are the only methods in
Collection
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote:
> This is a test only change to remove the granting of
> RuntimePermission("stopThread") from the tests. With Thread.stop changed to
> throw UOE it means there is nothing that requires this permission.
Changes to java.net and javax.managemen
On Wed, 5 Oct 2022 14:05:38 GMT, Alan Bateman wrote:
> This is a test-only change. ThreadAPI.testGetStackTrace2 tests the stack
> trace of a virtual thread that has started but has not executed it. The test
> currently attempts to saturate all carrier threads before starting a target
> thread.
### Summary of the change
This change introduces new system and security properties for specifying
factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
implementations.
These new properties allow more granular control over the set of object
factories allowed to reconstruct Java obje
This is a test-only change. ThreadAPI.testGetStackTrace2 tests the stack trace
of a virtual thread that has started but has not executed it. The test
currently attempts to saturate all carrier threads before starting a target
thread. The test is not reliable and failed at least once with a debug
This is a test only change to remove the granting of
RuntimePermission("stopThread") from the tests. With Thread.stop changed to
throw UOE it means there is nothing that requires this permission.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/10577/f
On Mon, 29 Aug 2022 08:46:20 GMT, Сергей Цыпанов wrote:
>> I found out that reading from `DataInputStream` wrapping
>> `ByteArrayInputStream` (as well as `BufferedInputStream` or any
>> `InputStream` relying on `byte[]`) can be significantly improved by
>> accessing volatile `in` field only on
On Wed, 5 Oct 2022 14:06:21 GMT, Raffaello Giulietti
wrote:
>> This fixes misleading indentations, which allows enabling the (currently
>> disabled) `misleading-indentation` warning flag on two `.gmk` files.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> addition
On Wed, 5 Oct 2022 11:01:35 GMT, Matthias Baesken wrote:
> The test/langtools/tools/jdeps/optionalDependency/OptionalDependencyTest.java:
> introduced with 8293701 needs to use File.pathSeparator instead of ":" to
> work on all platforms.
This pull request has now been integrated.
Changeset: f
On Wed, 5 Oct 2022 09:21:50 GMT, Matthias Baesken wrote:
> Currently the buildNumber check for Windows 2019 server differs in
> os_windows.cpp and java_props_md.c ( java_props_md.c still checks pre GA
> versions , this is probably not necessary any more ).
> The check should be unified.
LGTM
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Wed, 5 Oct 2022 09:21:50 GMT, Matthias Baesken wrote:
> Currently the buildNumber check for Windows 2019 server differs in
> os_windows.cpp and java_props_md.c ( java_props_md.c still checks pre GA
> versions , this is probably not necessary any more ).
> The check should be unified.
Marked
On Wed, 5 Oct 2022 10:02:49 GMT, Raffaello Giulietti
wrote:
>> This fixes misleading indentations, which allows enabling the (currently
>> disabled) `misleading-indentation` warning flag on two `.gmk` files.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8294456: Fix misleading-indentat
On Wed, 5 Oct 2022 13:46:23 GMT, Raffaello Giulietti
wrote:
>> I am not completely sure all `misleading-indentation` warnings are fixed in
>> Awt2d, this would require some more testing. I'd defer that to #10453.
>
> Awt2dLibraries.gmk in https://github.com/openjdk/jdk/pull/10453 seems more
>
On Wed, 5 Oct 2022 12:07:13 GMT, Aleksey Shipilev wrote:
>> What is the problem with Awt2d? Other conflicts?
>
> I am not completely sure all `misleading-indentation` warnings are fixed in
> Awt2d, this would require some more testing. I'd defer that to #10453.
Awt2dLibraries.gmk in https://git
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Wed, 5 Oct 2022 12:01:00 GMT, Raffaello Giulietti
wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 298:
>>
>>> 296: HEADERS_FROM_SRC := $(LIBLCMS_HEADERS_FROM_SRC), \
>>> 297: DISABLED_WARNINGS_gcc := format-nonliteral type-limits \
>>> 298: undef unused-functi
On Wed, 5 Oct 2022 10:16:10 GMT, Aleksey Shipilev wrote:
>> Raffaello Giulietti has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains two commits:
>>
>> - 8294456: Fix misleading-indentation warnings in JDK
>>
>>Merge branch 'm
On Wed, 5 Oct 2022 11:00:16 GMT, Julian Waters wrote:
>> Please review a small patch for dumping the failure reason when the MSVCRT
>> libraries or the Java Virtual Machine fails to load on Windows, which can
>> provide invaluable insight when debugging related launcher issues.
>>
>> See https
> Please review a small patch for dumping the failure reason when the MSVCRT
> libraries or the Java Virtual Machine fails to load on Windows, which can
> provide invaluable insight when debugging related launcher issues.
>
> See https://bugs.openjdk.org/browse/JDK-8292016 and the related Pull R
> Please review a small patch for dumping the failure reason when the MSVCRT
> libraries or the Java Virtual Machine fails to load on Windows, which can
> provide invaluable insight when debugging related launcher issues.
>
> See https://bugs.openjdk.org/browse/JDK-8292016 and the related Pull R
On Wed, 5 Oct 2022 10:02:49 GMT, Raffaello Giulietti
wrote:
>> This fixes misleading indentations, which allows enabling the (currently
>> disabled) `misleading-indentation` warning flag on two `.gmk` files.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a
On Wed, 5 Oct 2022 10:02:49 GMT, Raffaello Giulietti
wrote:
>> This fixes misleading indentations, which allows enabling the (currently
>> disabled) `misleading-indentation` warning flag on two `.gmk` files.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
Raffaello Giulietti has updated the pull request with a new target base due to
a merge or a rebase. The pull request now contains two commits:
- 829
Currently the buildNumber check for Windows 2019 server differs in
os_windows.cpp and java_props_md.c ( java_props_md.c still checks pre GA
versions , this is probably not necessary any more ).
The check should be unified.
-
Commit messages:
- unify Win 2019 build number check in o
On Wed, 5 Oct 2022 08:33:40 GMT, Alan Bateman wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> enhance test
>
> test/langtools/tools/jdeps/optionalDependency/OptionalDependencyTest.java
> line 74:
>
>> 72:
On Tue, 4 Oct 2022 08:00:21 GMT, Matthias Baesken wrote:
>> We noticed that with certain jar file input, jdeps runs into the following
>> exception, this happens with jdk11, 17 and 20.
>>
>> jdeps.exe --multi-release 11 --module-path . --inverse --package
>> com.sap.nw.performance.supa.client
This is a test only change for two tests for virtual threads that hang/timeout
on single core systems. The two tests involve pinning and require at least two
carrier threads. The test lib used by these tests is updated to define a new
method that ensures parallelism is at least a given value and
On Mon, 3 Oct 2022 20:37:11 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated the
On Fri, 16 Sep 2022 08:26:00 GMT, Matthias Baesken wrote:
> We noticed that with certain jar file input, jdeps runs into the following
> exception, this happens with jdk11, 17 and 20.
>
> jdeps.exe --multi-release 11 --module-path . --inverse --package
> com.sap.nw.performance.supa.client test
On Wed, 5 Oct 2022 07:24:56 GMT, Matthias Baesken wrote:
> > Looks good. Thanks for fixing this.
>
> Thanks for the review ! Do I need a second review for those tools like in
> hotspot ?
One reviewer is okay here and Mandy is the expert on this tool. So I think you
are good to go.
--
On Tue, 4 Oct 2022 18:26:50 GMT, Mandy Chung wrote:
> Looks good. Thanks for fixing this.
Thanks for the review ! Do I need a second review for those tools like in
hotspot ?
-
PR: https://git.openjdk.org/jdk/pull/10300
67 matches
Mail list logo
