Re: RFR: 8294695: Remove redundant deprecation suppression in ThreadGroup

On Sat, 1 Oct 2022 16:17:58 GMT, Andrey Turbanov wrote: > This suppression were added with Loom integration, but method > `Thread.getThreadGroup()` is not deprecated. > Let's cleanup code a bit. > https://mail.openjdk.org/pipermail/core-libs-dev/2022-September/094907.html Marked as reviewed by

Re: RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set

On Mon, 3 Oct 2022 05:50:50 GMT, Alan Bateman wrote: > > Regarding the `-1` check: I did that to align it with _all other_ checks of > > `markpos` in the existing source code of BIS. I can undo that change, but > > following your warning, shouldn't we fix _all other_ checks (independent of > >

Re: RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set

On Sun, 2 Oct 2022 17:57:35 GMT, Markus KARG wrote: > I think the leak is actually not a problem. BAIS is a fixed size. This is different to BIS where it wraps an input stream that may be changing, e.g. write an input stream to a file that is growing and call transferTo several times then you

Re: RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set [v2]

> This PR implements JDK-8294696. Markus KARG has updated the pull request incrementally with one additional commit since the last revision: Checking explicitly -1 instead of < 0 - Changes: - all: https://git.openjdk.org/jdk/pull/10525/files - new: https://git.openjdk.org/jdk

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v12]

> 8289552: Make intrinsic conversions between bit representations of half > precision values and floats Smita Kamath has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull req

Re: RFR: 8294698: Remove unused 'checkedExceptions' param from MethodAccessorGenerator.generateMethod()

On Sun, 2 Oct 2022 20:45:02 GMT, Сергей Цыпанов wrote: > `checkedExceptions` param of `MethodAccessorGenerator.generateMethod()` is > unused and should be removed in order to prevent allocations from > `Method.getExceptionTypes()` Seems reasonable, although these generators should only rarely

Re: RFR: 8294456: Fix misleading-indentation warnings in JDK

On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti wrote: > This fixes misleading indentations, which allows enabling the (currently > disabled) `misleading-indentation` warning flag on two `.gmk` files. Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.org/jdk

RFR: 8294698: Remove unused 'checkedExceptions' param from MethodAccessorGenerator.generateMethod()

`checkedExceptions` param of `MethodAccessorGenerator.generateMethod()` is unused and should be removed in order to prevent allocations from `Method.getExceptionTypes()` - Commit messages: - 8294698: Remove unused 'checkedExceptions' param from MethodAccessorGenerator.generateMeth

Re: RFR: 8292016: Split Windows API error handling from errors passed through the runtime in the JDK [v34]

> WIP Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Cast to void instead of void pointer - Changes: - all: https://git.openjdk.org/jdk/pull/9870/files - new: https://git.openjdk.org/jdk/pull/9870/files/a92df1d6..b

Re: RFR: 8292016: Split Windows API error handling from errors passed through the runtime in the JDK [v33]

> WIP Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Missing include on Windows - Changes: - all: https://git.openjdk.org/jdk/pull/9870/files - new: https://git.openjdk.org/jdk/pull/9870/files/a14c55c8..a92df1d6 W

Re: RFR: 8294696 - draining buffer instead of falling back to super.transferTo

On Sat, 1 Oct 2022 20:29:23 GMT, Markus KARG wrote: > This PR implements JDK-8294696. I think the leak is actually not a problem. `ByteArrayInputStream::transferTo` does the same BTW, see https://github.com/openjdk/jdk/blob/68da02c7b536799ccca49e889c22f3e9a2691fb7/src/java.base/share/classes/j

Re: RFR: 8294696 - draining buffer instead of falling back to super.transferTo

On Sat, 1 Oct 2022 20:29:23 GMT, Markus KARG wrote: > This PR implements JDK-8294696. This change leaks a reference to the internal buffer to the wrapped class so I think we have to be cautious and make sure that it doesn't introduce any security concerns. Also you've changed the check for a m

Re: RFR: 8292016: Split Windows API error handling from errors passed through the runtime in the JDK [v32]

> WIP Julian Waters has updated the pull request incrementally with two additional commits since the last revision: - Aesthetic - Fix JLI_Perror and JLI_Snprintf - Changes: - all: https://git.openjdk.org/jdk/pull/9870/files - new: https://git.openjdk.org/jdk/pull/9870/files/6

Re: [External] : Re: RFR: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image

> On Sep 27, 2022, at 4:27 PM, Michael Hall wrote: > > > >> On Sep 27, 2022, at 2:48 PM, Alexander Matveev > > wrote: >> >> Hi Michael, >> >> It is not possible to provide a unique or hashed CFBundleIdentifier. We >> already implemented to throw error i

Re: RFR: 8292016: Split Windows API error handling from errors passed through the runtime in the JDK [v31]

> WIP Julian Waters has updated the pull request incrementally with one additional commit since the last revision: NET_ThrowByNameWithLastError - Changes: - all: https://git.openjdk.org/jdk/pull/9870/files - new: https://git.openjdk.org/jdk/pull/9870/files/962b90ca..67169553

Re: RFR: 8292016: Split Windows API error handling from errors passed through the runtime in the JDK [v30]

> EDIT: Cave and add the ErrorOrigin enum, to differentiate which error type > the error reporting functions in libjava will look up. RUNTIME refers to > errors passed through the runtime via errno, and SYSTEM is for native errors > not visible to the runtime. Julian Waters has updated the pull

Re: RFR: 8292016: Split Windows API error handling from errors passed through the runtime in the JDK [v29]

> EDIT: Cave and add the ErrorOrigin enum, to differentiate which error type > the error reporting functions in libjava will look up. RUNTIME refers to > errors passed through the runtime via errno, and SYSTEM is for native errors > not visible to the runtime. Julian Waters has updated the pull