On Mon, 3 Oct 2022 05:50:50 GMT, Alan Bateman <al...@openjdk.org> wrote:

> > Regarding the `-1` check: I did that to align it with _all other_ checks of 
> > `markpos` in the existing source code of BIS. I can undo that change, but 
> > following your warning, shouldn't we fix _all other_ checks (independent of 
> > this PR) from `markpos < 0` to `markpos == -1` then?
> 
> Probably yes.

I propose that I open another PR for that as those code locations are unrelated 
to the current PR, and this cross-method change might make the review more 
complex.

-------------

PR: https://git.openjdk.org/jdk/pull/10525

Reply via email to