Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms"

2022-08-11 Thread Jie Fu
On Thu, 11 Aug 2022 20:02:06 GMT, Daniel D. Daugherty wrote: > A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG > setting > when waiting for a compilation to finish. > > This fix is being tested in my jdk-20+10 stress testing run. > > The usual Mach5 timeoutFactor i

Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms"

2022-08-11 Thread Jie Fu
On Fri, 12 Aug 2022 04:03:56 GMT, Jie Fu wrote: >> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG >> setting >> when waiting for a compilation to finish. >> >> This fix is being tested in my jdk-20+10 stress testing run. >> >> The usual Mach5 timeoutFactor is 4.0 w

Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms"

2022-08-11 Thread Leonid Mesnik
On Thu, 11 Aug 2022 20:02:06 GMT, Daniel D. Daugherty wrote: > A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG > setting > when waiting for a compilation to finish. > > This fix is being tested in my jdk-20+10 stress testing run. > > The usual Mach5 timeoutFactor i

RFR: JDK-8292066 Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version

2022-08-11 Thread Bill Huang
This task converts 2 shell tests to java version. test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh test/java/lang/management/RuntimeMXBean/TestInputArgument.sh - Commit messages: - Updated copyright header. - Converted TestInputArgument.sh to java version. - C

RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug

2022-08-11 Thread Daniel D . Daugherty
Split the java/util/stream/SpinedBufferTest.java test into two parts: - java/util/stream/SpinedBufferTest1.java has the first 6 test cases - java/util/stream/SpinedBufferTes2.java has the second 6 test cases I couldn't figure out a way to set a larger timeout value for the entirety of java/util/st

RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int,int) in 5000ms"

2022-08-11 Thread Daniel D . Daugherty
A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG setting when waiting for a compilation to finish. - Commit messages: - 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int,int) in 5000ms" Ch

Integrated: JDK-8292064 Convert java/lang/management/MemoryMXBean shell tests to java version

2022-08-11 Thread Bill Huang
On Tue, 9 Aug 2022 21:14:39 GMT, Bill Huang wrote: > This task converts 5 shell tests below to java version. > test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh > test/java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh > test/java/lang/management/MemoryMXBean/MemoryManageme

Re: RFR: 8290041: ModuleDescriptor.hashCode is inconsistent [v2]

2022-08-11 Thread Jaikiran Pai
On Wed, 10 Aug 2022 15:23:12 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> incorporate review comments and add more testing > > test/jdk/java/lang/module/ModuleDescriptorHashCodeTest.java line 7

Re: RFR: 8290041: ModuleDescriptor.hashCode is inconsistent

2022-08-11 Thread Jaikiran Pai
On Sat, 6 Aug 2022 08:08:43 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix > https://bugs.openjdk.org/browse/JDK-8290041? > > As noted by the reporter, the current implementation is buggy since the > calculation can result in a different value of the

Re: RFR: 8290041: ModuleDescriptor.hashCode is inconsistent [v2]

2022-08-11 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to fix > https://bugs.openjdk.org/browse/JDK-8290041? > > As noted by the reporter, the current implementation is buggy since the > calculation can result in a different value of the hashcode depending on the > order of iteration of the

Re: RFR: 8290036: Define and specify Runtime shutdown sequence [v6]

2022-08-11 Thread Daniel Fuchs
On Thu, 11 Aug 2022 04:00:39 GMT, Stuart Marks wrote: >> The concept of the shutdown sequence needs to be specified more clearly. >> This PR adds text for this into the class specification of >> `java.lang.Runtime`. Also includes adjustments to related areas in >> `addShutdownHook`, `halt`, an

Re: RFR: 8290036: Define and specify Runtime shutdown sequence [v4]

2022-08-11 Thread David Holmes
On Tue, 9 Aug 2022 13:56:44 GMT, Alan Bateman wrote: >> Thread.State was added (in Java 5) for monitoring and management purposes, >> it's not an API that most libraries or programs would use. It could be >> introduced in the class description and referenced from other APIs that >> change/test

Re: RFR: 8290036: Define and specify Runtime shutdown sequence [v6]

2022-08-11 Thread David Holmes
On Thu, 11 Aug 2022 04:00:39 GMT, Stuart Marks wrote: >> The concept of the shutdown sequence needs to be specified more clearly. >> This PR adds text for this into the class specification of >> `java.lang.Runtime`. Also includes adjustments to related areas in >> `addShutdownHook`, `halt`, an