Re: RFR: 8291916: Unexpected output on Arabic Windows command prompt

2022-08-04 Thread Alan Bateman
On Fri, 5 Aug 2022 02:15:21 GMT, Ichiroh Takiguchi wrote: > To support Windows command prompt's codepage, following charsets should be > moved from jdk.charsets module to java.base module. > > - IBM860 > - IBM861 > - IBM863 > - IBM864 > - IBM865 > - IBM869 IBM860 is Portuguese, IBM861 is Icel

Re: RFR: JDK-8290836 Improve test coverage for XPath functions: String Functions

2022-08-04 Thread Joe Wang
On Thu, 4 Aug 2022 17:40:43 GMT, Bill Huang wrote: > Improve test coverage for XPath functions: > [JDK-8290836](https://bugs.openjdk.org/browse/JDK-8290836), > [JDK-8290837](https://bugs.openjdk.org/browse/JDK-8290837), > [JDK-8290838](https://bugs.openjdk.org/browse/JDK-8290838). Overall, ni

RFR: 8291941: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on linux-all

2022-08-04 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on linux-all. - Commit messages: - 8291941: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on linux-all Changes: https://git.openjdk.org/jdk/pull/9757/files Webrev: https://webrevs.openjdk.org/?

Integrated: 8291941: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on linux-all

2022-08-04 Thread Daniel D . Daugherty
On Thu, 4 Aug 2022 22:23:29 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on > linux-all. This pull request has now been integrated. Changeset: 6e6c64c6 Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk/commit

Re: RFR: 8291941: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on linux-all

2022-08-04 Thread Daniel D . Daugherty
On Thu, 4 Aug 2022 22:28:20 GMT, David Holmes wrote: >> A trivial fix to ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java >> on linux-all. > > Marked as reviewed by dholmes (Reviewer). @dholmes-ora - Thanks for the lightning fast review. - PR: https://git.openjdk.org/jdk/

Re: RFR: 8291941: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on linux-all

2022-08-04 Thread David Holmes
On Thu, 4 Aug 2022 22:23:29 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on > linux-all. Marked as reviewed by dholmes (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9757

Re: RFR: 8291915: jpackage: use multiple Features in MSI installer

2022-08-04 Thread Alexey Semenyuk
On Thu, 4 Aug 2022 17:00:38 GMT, Alex Kasko wrote: > This change splits existing single Feature `DefaultFeature` into 3 different > feautures: > > - `DefaultFeature_Files`: application and runtime files > - `DefaultFeature_Shortcuts`: application Desktop and Start Menu shortcuts > - `Default

Re: RFR: 8291915: jpackage: use multiple Features in MSI installer

2022-08-04 Thread Alexey Semenyuk
On Thu, 4 Aug 2022 17:00:38 GMT, Alex Kasko wrote: > This change splits existing single Feature `DefaultFeature` into 3 different > feautures: > > - `DefaultFeature_Files`: application and runtime files > - `DefaultFeature_Shortcuts`: application Desktop and Start Menu shortcuts > - `Default

Re: RFR: 8291924: jpackage: l10n for Windows context menu label

2022-08-04 Thread Naoto Sato
On Thu, 4 Aug 2022 18:10:18 GMT, Alex Kasko wrote: > This change adds `ContextMenuCommandLabel` l10n property for file association > context menu label. It is a follow-up to [this PR > comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082). > > Note, non-EN l10n values were

Re: RFR: 8291924: jpackage: l10n for Windows context menu label

2022-08-04 Thread Alexey Semenyuk
On Thu, 4 Aug 2022 18:10:18 GMT, Alex Kasko wrote: > This change adds `ContextMenuCommandLabel` l10n property for file association > context menu label. It is a follow-up to [this PR > comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082). > > Note, non-EN l10n values were

Re: RFR: 8291915: jpackage: use multiple Features in MSI installer

2022-08-04 Thread Alex Kasko
On Thu, 4 Aug 2022 17:00:38 GMT, Alex Kasko wrote: > This change splits existing single Feature `DefaultFeature` into 3 different > feautures: > > - `DefaultFeature_Files`: application and runtime files > - `DefaultFeature_Shortcuts`: application Desktop and Start Menu shortcuts > - `Default

Re: RFR: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)

2022-08-04 Thread Alan Bateman
On Thu, 4 Aug 2022 10:57:53 GMT, Peter Levart wrote: > This is an attempt to fix inconsistent behavior of TerminatingThreadLocal(s) > when used internally in JDK for per-carrier-thread caches of native > ByteBuffer(s) and NativeBuffer(s). If used from virtual thread, such > TerminatingThreadLo

Re: Coupling in ExtentLocal

2022-08-04 Thread Holo The Sage Wolf
It looks pretty inconsistent to have the API of the structured concurrency and of ExtentLocal have different design, especially when it seems like the 2 APIs have the same base assumptions. >From my understanding those 2 features are meant for each other. I actually agree that allowing “weak” TwR

Integrated: 8288377: [REDO] DST not applying properly with zone id offset set with TZ env variable

2022-08-04 Thread Gaurav Chaudhari
On Tue, 28 Jun 2022 18:52:32 GMT, Gaurav Chaudhari wrote: > This is a REDO of the Fix that was incompletely implemented earlier: > [8285838: Fix for TZ environment variable DST > rules](https://github.com/openjdk/jdk/pull/8660) > > Offset calculation now accounts all the way upto year in order

RFR: 8291924: jpackage: l10n for Windows context menu label

2022-08-04 Thread Alex Kasko
This change adds `ContextMenuCommandLabel` l10n property for file association context menu label. It is a follow-up to [this PR comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082). Note, non-EN l10n values were filled using auto-translator and may need to be corrected. T

Re: RFR: 8291915: jpackage: use multiple Features in MSI installer

2022-08-04 Thread Alexey Semenyuk
On Thu, 4 Aug 2022 17:00:38 GMT, Alex Kasko wrote: > This change splits existing single Feature `DefaultFeature` into 3 different > feautures: > > - `DefaultFeature_Files`: application and runtime files > - `DefaultFeature_Shortcuts`: application Desktop and Start Menu shortcuts > - `Default

RFR: JDK-8290836 Improve test coverage for XPath functions: String Functions

2022-08-04 Thread Bill Huang
Improve test coverage for XPath functions: [JDK-8290836](https://bugs.openjdk.org/browse/JDK-8290836), [JDK-8290837](https://bugs.openjdk.org/browse/JDK-8290837), [JDK-8290838](https://bugs.openjdk.org/browse/JDK-8290838). - Commit messages: - Added exception test cases for node s

Re: RFR: 8291917: Dump error diagnostics when runtime libraries fail to load (win) [v3]

2022-08-04 Thread Julian Waters
> Please review a small patch for dumping the failure reason when the MSVCRT > libraries or the JVM fails to load on Windows, which have been very helpful > in my personal fork of the JDK so far This also fixes a small bug in the > Windows implementation of JLI_ErrorMessageSys where C runtime er

Re: RFR: 8291915: jpackage: use multiple Features in MSI installer

2022-08-04 Thread Alexey Semenyuk
On Thu, 4 Aug 2022 17:00:38 GMT, Alex Kasko wrote: > This change splits existing single Feature `DefaultFeature` into 3 different > feautures: > > - `DefaultFeature_Files`: application and runtime files > - `DefaultFeature_Shortcuts`: application Desktop and Start Menu shortcuts > - `Default

Re: RFR: 8291917: Dump error diagnostics when runtime libraries fail to load (win) [v2]

2022-08-04 Thread Julian Waters
> Please review a small patch for dumping the failure reason when the MSVCRT > libraries or the JVM fails to load on Windows, which have been very helpful > in my personal fork of the JDK so far This also fixes a small bug in the > Windows implementation of JLI_ErrorMessageSys where C runtime er

RFR: 8291915: jpackage: use multiple Features in MSI installer

2022-08-04 Thread Alex Kasko
This change splits existing single Feature `DefaultFeature` into 3 different feautures: - `DefaultFeature_Files`: application and runtime files - `DefaultFeature_Shortcuts`: application Desktop and Start Menu shortcuts - `DefaultFeature_FileAssociations`: File Association components These 3 F

[jdk19] Integrated: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

2022-08-04 Thread Peter Levart
On Thu, 4 Aug 2022 13:38:08 GMT, Peter Levart wrote: > Hi all, > > This pull request contains a backport of commit > [d4a795d7](https://github.com/openjdk/jdk/commit/d4a795d75aef8d787934f5c05e146c61138a408a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The com

RFR: 8291917: [WINDOWS] Dump error diagnostics when runtime libraries fail to load

2022-08-04 Thread Julian Waters
Please review a small patch for dumping the failure reason when the MSVCRT libraries or the JVM fails to load on Windows, which have been very helpful in my personal fork of the JDK so far This also fixes a small bug in the Windows implementation of JLI_ErrorMessageSys where C runtime errors are

Integrated: 8288327: Executable.hasRealParameterData should not be volatile

2022-08-04 Thread Сергей Цыпанов
On Mon, 13 Jun 2022 18:42:24 GMT, Сергей Цыпанов wrote: > If there are two threads calling `Executable.hasRealParameterData()` under > race and the first one writes into volatile `Executable.parameters` field > (doing _releasing store_) and the second thread reads non-null value from the > sam

[jdk19] RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

2022-08-04 Thread Peter Levart
Hi all, This pull request contains a backport of commit [d4a795d7](https://github.com/openjdk/jdk/commit/d4a795d75aef8d787934f5c05e146c61138a408a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Peter Levart on 4 Aug 2022 and

Integrated: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

2022-08-04 Thread Peter Levart
On Fri, 29 Jul 2022 09:05:53 GMT, Peter Levart wrote: > This is a continuation of effort from > https://github.com/openjdk/jdk/pull/9533 to fix the ObjectStreamClassCaching > test which is failing with various GCs != G1. The test class contains 2 test > methods: > - test2CacheReleaseUnderMemor

Integrated: 8291360: Create entry points to expose low-level class file information

2022-08-04 Thread Harold Seigel
On Fri, 29 Jul 2022 18:02:46 GMT, Harold Seigel wrote: > Please review this change to fix JDK-8291360. This fix adds entry points > getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. > The new entry points return the current class's class file version and its > raw

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread Harold Seigel
On Thu, 4 Aug 2022 12:51:33 GMT, Harold Seigel wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> r

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread David Holmes
On Thu, 4 Aug 2022 12:47:13 GMT, Harold Seigel wrote: >> I think it should match the underlying representation else it may cause >> someone trying to debug a failure to look at the wrong part of the flags >> value, not realizing the printed value has the opposite format of the actual >> raw va

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread David Holmes
On Thu, 4 Aug 2022 12:51:33 GMT, Harold Seigel wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> r

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread Harold Seigel
On Thu, 4 Aug 2022 12:28:51 GMT, David Holmes wrote: >> I think it seems more natural to display the major version first, but I can >> change it if you prefer. > > I think it should match the underlying representation else it may cause > someone trying to debug a failure to look at the wrong pa

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread Harold Seigel
> Please review this change to fix JDK-8291360. This fix adds entry points > getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. > The new entry points return the current class's class file version and its > raw access flags. > > The fix was tested by running Mach5 ti

Re: RFR: 8291360: Create entry points to expose low-level class file information [v3]

2022-08-04 Thread Coleen Phillimore
On Thu, 4 Aug 2022 12:28:51 GMT, David Holmes wrote: >> I think it seems more natural to display the major version first, but I can >> change it if you prefer. > > I think it should match the underlying representation else it may cause > someone trying to debug a failure to look at the wrong pa

Re: RFR: 8291360: Create entry points to expose low-level class file information [v3]

2022-08-04 Thread David Holmes
On Tue, 2 Aug 2022 12:45:49 GMT, Harold Seigel wrote: >> Seems odd to display as major:minor when it is stored as minor:major > > I think it seems more natural to display the major version first, but I can > change it if you prefer. I think it should match the underlying representation else it

RFR: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)

2022-08-04 Thread Peter Levart
This is an attempt to fix inconsistent behavior of TerminatingThreadLocal(s) when used internally in JDK for per-carrier-thread caches of native ByteBuffer(s) and NativeBuffer(s). If used from virtual thread, such TerminatingThreadLocal(s) are not registered with the carrier thread for the clea

Re: [jdk19] RFR: 8288769: Revert unintentional change to deflate.c

2022-08-04 Thread Lance Andersen
On Thu, 4 Aug 2022 06:59:27 GMT, Alan Bateman wrote: > The revert looks okay but it is concerning that the original change was not > caught by a test. Are there tests that could have caught this? Not that I am aware of. per open/src/java.base/share/native/libzip/zlib/patches/ChangeLog_java JD

Re: RFR: 8290036: Define and specify Runtime shutdown sequence [v2]

2022-08-04 Thread Alan Bateman
On Thu, 4 Aug 2022 02:51:03 GMT, Stuart Marks wrote: >> src/java.base/share/classes/java/lang/Runtime.java line 79: >> >>> 77: * terminate the JVM via the {@link #halt halt} method. >>> 78: * Virtual Machine Termination >>> 79: * When the JVM terminates, all threads (daemon, non-daemon, and

Re: RFR: 8290036: Define and specify Runtime shutdown sequence [v2]

2022-08-04 Thread Alan Bateman
On Thu, 4 Aug 2022 03:09:09 GMT, Stuart Marks wrote: >> Initial edits to addShutdownHook from Alex. >> >> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036). > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Upda

Re: Coupling in ExtentLocal

2022-08-04 Thread Andrew Haley
On 7/29/22 21:37, Ron Pressler wrote: Yes, we are thinking about a "strong” TwR, but we’re busy with so many things so it might take a while. Until then, we might introduce a weaker, or less trustworthy version of ExtentLocals that uses the existing TwR and wouldn’t be used for critical things

Re: [jdk19] RFR: 8288769: Revert unintentional change to deflate.c

2022-08-04 Thread Alan Bateman
On Wed, 3 Aug 2022 10:21:43 GMT, Lance Andersen wrote: > Hi, > > Please review this patch to deflate.c which reverts an unintentional change > that was part of JDK-8284371, which reverted the reworking of (7) deflate.c > undo (6), replaced withe the official zlib repo fix see#305/#f969409 >

Integrated: 8291825: java/time/nontestng/java/time/zone/CustomZoneNameTest.java fails if defaultLocale and defaultFormatLocale are different

2022-08-04 Thread Daniel Jeliński
On Wed, 3 Aug 2022 13:55:04 GMT, Daniel Jeliński wrote: > This patch fixes the test to use the same locale as the tested code This pull request has now been integrated. Changeset: 4772354f Author:Daniel Jeliński URL: https://git.openjdk.org/jdk/commit/4772354f4caf5eb314eda81217e5bc4