On Wed, 13 Jul 2022 12:28:29 GMT, Raffaello Giulietti wrote:
>> Initial implementation.
>
> src/java.base/share/classes/java/lang/Float.java line 1090:
>
>> 1088: public static short floatToBinary16AsShortBits(float f) {
>> 1089: if (Float.isNaN(f)) {
>> 1090: // Arbitrar
On 7/14/22 4:07 PM, Bernd Eckenfels wrote:
The XMLOutputFactoryImpl does not allow to share the writer instances:
https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d07414537b6c0/src/java.xml/share/classes/com/sun/xml/internal/stream/XMLOutputFactoryImpl.java#L167
Sounds like a b
On Thu, 14 Jul 2022 20:52:18 GMT, Bill Huang wrote:
>> This is a subtask of
>> [JDK-8286091](https://bugs.openjdk.org/browse/JDK-8286091) which is aiming
>> to improve XPath expression test coverage. The goal of this subtask is
>> validating the XPath child axis specifier in various ways.
>
>
It's expected that [JDK-8287596](https://bugs.openjdk.org/browse/JDK-8287596)
has resolved [JDK-8288286](https://bugs.openjdk.org/browse/JDK-8288286). Remove
ReflectionCallerCacheTest.java from the problem list for test execution.
-
Commit messages:
- 8290327: Remove java/lang/refl
The XMLOutputFactoryImpl does not allow to share the writer instances:
https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d07414537b6c0/src/java.xml/share/classes/com/sun/xml/internal/stream/XMLOutputFactoryImpl.java#L167
So this is initialized and set to false:
https://github.com/op
On Thu, 14 Jul 2022 21:56:27 GMT, Joe Wang wrote:
> > Please rename the issue to something more meaningful.
>
> Pls refer to the main issue. This is one of the subtasks.
The problem is when this commit is integrated into the JDK repo, it does not
show up as a subtask of another commit. When br
On Thu, 14 Jul 2022 21:41:24 GMT, Ioi Lam wrote:
> Please rename the issue to something more meaningful.
Pls refer to the main issue. This is one of the subtasks.
-
PR: https://git.openjdk.org/jdk/pull/9484
On Thu, 14 Jul 2022 20:52:18 GMT, Bill Huang wrote:
>> This is a subtask of
>> [JDK-8286091](https://bugs.openjdk.org/browse/JDK-8286091) which is aiming
>> to improve XPath expression test coverage. The goal of this subtask is
>> validating the XPath child axis specifier in various ways.
>
>
On Thu, 14 Jul 2022 20:52:18 GMT, Bill Huang wrote:
>> This is a subtask of
>> [JDK-8286091](https://bugs.openjdk.org/browse/JDK-8286091) which is aiming
>> to improve XPath expression test coverage. The goal of this subtask is
>> validating the XPath child axis specifier in various ways.
>
>
On Thu, 14 Jul 2022 20:59:33 GMT, Joe Wang wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed XPahtExpChildTest.java and moved NPE test cases from invalid test
>> case to zero children test case.
>
> test/jaxp/
On Wed, 13 Jul 2022 14:33:49 GMT, Raffaello Giulietti wrote:
>> Initial implementation.
>
> test/jdk/java/lang/Float/SixteenBitFormats.java line 239:
>
>> 237: public static boolean isNaN(short binary16) {
>> 238: return ((binary16 & 0x7c00) == 0x7c00) // Max exponent
>> and
On Wed, 13 Jul 2022 12:38:23 GMT, Raffaello Giulietti wrote:
>> Initial implementation.
>
> src/java.base/share/classes/java/lang/Float.java line 1100:
>
>> 1098:
>> 1099: // The overflow threshold is binary16 MAX_VALUE + 1/2 ulp
>> 1100: if (abs_f > (65504.0f + 16.0f) ) {
>
>
On Thu, 14 Jul 2022 20:54:59 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/Float.java line 1100:
>>
>>> 1098:
>>> 1099: // The overflow threshold is binary16 MAX_VALUE + 1/2 ulp
>>> 1100: if (abs_f > (65504.0f + 16.0f) ) {
>>
>> if (abs_f >= (65504.0f + 16.0f)
On Thu, 14 Jul 2022 20:52:18 GMT, Bill Huang wrote:
>> This is a subtask of
>> [JDK-8286091](https://bugs.openjdk.org/browse/JDK-8286091) which is aiming
>> to improve XPath expression test coverage. The goal of this subtask is
>> validating the XPath child axis specifier in various ways.
>
>
> This is a subtask of
> [JDK-8286091](https://bugs.openjdk.org/browse/JDK-8286091) which is aiming to
> improve XPath expression test coverage. The goal of this subtask is
> validating the XPath child axis specifier in various ways.
Bill Huang has updated the pull request incrementally with on
On Thu, 14 Jul 2022 01:25:38 GMT, Joe Wang wrote:
>> Bill Huang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits sinc
On Thu, 14 Jul 2022 01:16:43 GMT, Joe Wang wrote:
>> Bill Huang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits sinc
On Thu, 14 Jul 2022 11:57:37 GMT, Doug Lea wrote:
> This test now conforms to jtreg rules about not using System.exit to cover
> untested OutOfMemoryErrors
This pull request has now been integrated.
Changeset: 890bcedd
Author:Doug Lea
URL:
https://git.openjdk.org/jdk/commit/890bced
On Wed, 13 Jul 2022 04:30:39 GMT, Yoshiki Sato wrote:
> Please review this PR. The PR open sources the closed timezone tests.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9476
On Thu, 14 Jul 2022 16:15:48 GMT, Doug Lea wrote:
>> This test now conforms to jtreg rules about not using System.exit to cover
>> untested OutOfMemoryErrors
>
> Doug Lea has updated the pull request incrementally with one additional
> commit since the last revision:
>
> try/lock() style
Th
On Thu, 14 Jul 2022 13:02:21 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 19 -> JDK 20
This pull request has now been integrated.
Changeset: 3ad39505
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/3ad39505605f8eab74adec9c68f211dd44796759
Stats: 242 lines
On Thu, 14 Jul 2022 16:15:48 GMT, Doug Lea wrote:
>> This test now conforms to jtreg rules about not using System.exit to cover
>> untested OutOfMemoryErrors
>
> Doug Lea has updated the pull request incrementally with one additional
> commit since the last revision:
>
> try/lock() style
So
On Thu, 14 Jul 2022 13:29:50 GMT, David Holmes wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> try/lock() style
>
> test/jdk/java/util/concurrent/locks/Lock/OOMEInAQS.java line 108:
>
>> 106: cond.
> This test now conforms to jtreg rules about not using System.exit to cover
> untested OutOfMemoryErrors
Doug Lea has updated the pull request incrementally with one additional commit
since the last revision:
try/lock() style
-
Changes:
- all: https://git.openjdk.org/jdk/pull
On Thu, 14 Jul 2022 15:24:20 GMT, Roger Riggs wrote:
>> The test `java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnloadTest.java`
>> Fails intermittently when expected output from a subprocess is not found.
>>
>> I suspect a race between the Cleaner that is going to call JNI_OnUnload (in
>>
> The test `java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnloadTest.java`
> Fails intermittently when expected output from a subprocess is not found.
>
> I suspect a race between the Cleaner that is going to call JNI_OnUnload (in
> NativeLibraries.java:377) when the ClassLoader is no longer
On Thu, 14 Jul 2022 12:54:43 GMT, Jaikiran Pai wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup waiting for library unload
>
> test/jdk/java/lang/ClassLoader/loadLibraryUnload/libloadLibraryUnload.c line
> 4
On Wed, 13 Jul 2022 20:39:53 GMT, Mandy Chung wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup waiting for library unload
>
> test/jdk/java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload.java line
> 16
On Thu, 14 Jul 2022 11:57:37 GMT, Doug Lea wrote:
> This test now conforms to jtreg rules about not using System.exit to cover
> untested OutOfMemoryErrors
Hi Doug,
One pre-existing style nit but otherwise the termination logic seems okay.
Thanks.
test/jdk/java/util/concurrent/locks/Lock/OOM
Forwardport JDK 19 -> JDK 20
-
Commit messages:
- Merge
- 8288112: C2: Error: ShouldNotReachHere() in Type::typerr()
- 8290209: jcup.md missing additional text
- 8290207: Missing notice in dom.md
The webrevs contain the adjustments done while merging with regards to each
parent
On Wed, 13 Jul 2022 14:06:00 GMT, Roger Riggs wrote:
>> The test `java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnloadTest.java`
>> Fails intermittently when expected output from a subprocess is not found.
>>
>> I suspect a race between the Cleaner that is going to call JNI_OnUnload (in
>>
On Thu, 14 Jul 2022 08:23:37 GMT, Alan Bateman wrote:
>>> > Thanks for review.
>>> > I add mBeans using the registerMBean method.
>>> > We can get configuration information through JConsole, JMX exporter
>>>
>>> This iteration is a bit confusing because it adds a public interface to
>>> java.la
This test now conforms to jtreg rules about not using System.exit to cover
untested OutOfMemoryErrors
-
Commit messages:
- Avoid System.exit in jtreg tests
Changes: https://git.openjdk.org/jdk/pull/9491/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9491&range=00
Issue:
On Wed, 13 Jul 2022 17:42:18 GMT, Сергей Цыпанов wrote:
>> We can skip bounds check and null check for Charset in case we use the array
>> entirely and the Charset is either default one or proven to be non-null.
>>
>> Benchmark results:
>>
>> before
>>
>> Benchmark
On Thu, 14 Jul 2022 07:54:56 GMT, xpbob wrote:
> Thanks for review. The runtime information is already fetched through the
> OperatingSystemMXBean, and I'm wrapped through the interface, keeping only
> the configuration data.Such an interface could be part of management.
I don't think this fea
On Wed, 13 Jul 2022 04:30:39 GMT, Yoshiki Sato wrote:
> Please review this PR. The PR open sources the closed timezone tests.
Marked as reviewed by coffeys (Reviewer).
test/jdk/java/util/TimeZone/tools/share/makeZoneData.pl line 32:
> 30: # static TimeZoneData.
> 31: # For J2SE since JDK1.4,
On Thu, 14 Jul 2022 07:05:25 GMT, Alan Bateman wrote:
> > Thanks for review.
> > I add mBeans using the registerMBean method.
> > We can get configuration information through JConsole, JMX exporter
>
> This iteration is a bit confusing because it adds a public interface to
> java.lang.managemen
On Thu, 14 Jul 2022 03:32:35 GMT, xpbob wrote:
> Thanks for review.
> I add mBeans using the registerMBean method.
> We can get configuration information through JConsole, JMX exporter
This iteration is a bit confusing because it adds a public interface to
java.lang.management. For the register
38 matches
Mail list logo
