On Thu, 14 Jul 2022 20:52:18 GMT, Bill Huang <d...@openjdk.org> wrote:
>> This is a subtask of >> [JDK-8286091](https://bugs.openjdk.org/browse/JDK-8286091) which is aiming >> to improve XPath expression test coverage. The goal of this subtask is >> validating the XPath child axis specifier in various ways. > > Bill Huang has updated the pull request incrementally with one additional > commit since the last revision: > > Renamed XPahtExpChildTest.java and moved NPE test cases from invalid test > case to zero children test case. Thanks for the update. The update looks good. One more comment below. test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpChildTest.java line 99: > 97: // position > 98: {"/store/child::book[position()=1]/author", AUTHOR_1}, > 99: {"/store/child::book[last()]/author", AUTHOR_2}, If the intention is to test the last() function, it would be good to have more books than 2 (e.g. at least 3). But if the focus is on Axes: child, plus functions will be tested in the other subtask, I'm ok if you don't want to make further changes. ------------- PR: https://git.openjdk.org/jdk/pull/9484
