This question was asked originally here:
https://stackoverflow.com/questions/72787286/executable-hasrealparameterdata-and-parameter-isnamepresent-dont-work-as-ex
but as soon as I got no answer I've decided to try it here adding some concerns
regarding JavaDoc of Parameter.isNamePresent()
With ad
On Wed, 29 Jun 2022 04:17:00 GMT, liach wrote:
> Would someone review or sponsor this mino improvement?
Hello @liach, I see that Mandy has already reviewed and approved this PR and
there hasn't been any change in this PR after that (which is a good thing).
I'll run some tests internally today
On Wed, 22 Jun 2022 03:01:36 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch implements intrinsics for `Integer/Long::compareUnsigned` using
>> the same approach as the JVM does for long and floating-point comparisons.
>> This allows efficient and reliable usage of unsigned comparison in Java
On Wed, 29 Jun 2022 02:22:02 GMT, Quan Anh Mai wrote:
>> I do not follow your comment, allocation decisions purely based on LRGs
>> interferences and data flow attributes attached to operands and is agnostic
>> to encoding block contents.
>
> Your suggestion requires us having additional `TEMP
On Thu, 26 May 2022 23:20:27 GMT, liach wrote:
>> Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass,
>> the interfaces are iterated twice. The two passes can be merged into one,
>> yielding the whole proxy definition context (module, package, whether
>> there's package
Fixed 3 issues which made signature invalid:
- We should not remove .jpackage.xml from signed app image when creating DMG or
PKG otherwise it invalidates signature.
- .package should be created when app image is generated, so this file can be
signed.
- Copying predefine app image for DMG and PKG
On Wed, 29 Jun 2022 02:12:24 GMT, Jatin Bhateja wrote:
>> I realised that by swapping the `mov` and the `cmp` instruction, the rule
>> needs to have `dst` different from `src1` and `src2`, which increases
>> register pressure.
>
> I do not follow your comment, allocation decisions purely based
On Tue, 28 Jun 2022 12:42:57 GMT, Quan Anh Mai wrote:
>> src/hotspot/cpu/x86/x86_64.ad line 13043:
>>
>>> 13041: __ cmpl($src1$$Register, $src2$$Register);
>>> 13042: __ movl($dst$$Register, -1);
>>> 13043: __ jccb(Assembler::below, done);
>>
>> By placing compare adjacent to condit
On Mon, 27 Jun 2022 20:26:52 GMT, Joe Darcy wrote:
> JDK-8289106: Add model of class file versions to core reflection
Sending this enum to model class file format versions out for some review
comments before starting to write the tests and CSR, etc.
The class file format has a rich structure t
JDK-8289106: Add model of class file versions to core reflection
-
Commit messages:
- Update phrasing.
- Augment and correct docs.
- Correct major versions; RELEASE_0 and RELEASE_1 are both 45.
- Make major method public.
- Add AccessFlag.locations(ClassFileFormatVersion)
- Add
On Tue, 28 Jun 2022 18:52:32 GMT, Gaurav Chaudhari wrote:
> This is a REDO of the Fix that was incompletely implemented earlier:
> [8285838: Fix for TZ environment variable DST
> rules](https://github.com/openjdk/jdk/pull/8660)
>
> Offset calculation now accounts all the way upto year in order
On Tue, 28 Jun 2022 21:13:05 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 19 -> JDK 20
This pull request has now been integrated.
Changeset: 86dc760f
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/86dc760f9ec0f403109bef7b06db82b9ed0739dd
Stats: 821 lines
> Forwardport JDK 19 -> JDK 20
Jesper Wilhelmsson has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 166 commits:
- Merge remote-tracking branch 'jdk19/master' into Merge_jdk19
- 8284640: CollectorImpl class could be a record class
On Tue, 28 Jun 2022 21:03:28 GMT, Alex Kasko wrote:
> I assume we will need an additional similar property for a verb label
> displayed in a context menu.
Agree. At least we need to provide l10n for it.
> Can we change the existing default behaviour? Should we? It won't break
> existing usage
Forwardport JDK 19 -> JDK 20
-
Commit messages:
- Merge remote-tracking branch 'jdk19/master' into Merge_jdk19
- 8289398: ProblemList jdk/jfr/api/consumer/recordingstream/TestOnEvent.java
on linux-x64 again
- 8289069: Very slow C1 arraycopy jcstress tests after JDK-8279886
- 8288
On Mon, 27 Jun 2022 17:53:29 GMT, Alexey Semenyuk wrote:
> What would be the alternative to `pass-all-args`?
As this is intended to be a public property, I assume there should be a CSR and
some consistent name, perhaps with `win-` prefix - I assume we will need an
additional similar property
On Mon, 27 Jun 2022 17:57:53 GMT, Alexey Semenyuk wrote:
>> Alex Kasko has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use shortcut to test arguments, add argument with spaces
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/Wi
> jpackage implementation of file association on Windows currently passes a
> selected filename as an only argument to associated executable.
>
> It is proposed to introduce additional option in file association property
> file to allow optionally support additional arguments using `%*` batch
>
On Tue, 28 Jun 2022 20:17:21 GMT, Naoto Sato wrote:
>> This is a leftover documentation fix to the deprecation of `Locale`
>> constructors. `Locale.Builder` class had some texts that suggested using one
>> of those constructors, which need to be replaced with a `Locale.of()`
>> method. A corre
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote:
> Changes the definition of `CollectorImpl` to be a record.
I assumed it was a starter issue in order to learn the patch process.
-
PR: https://git.openjdk.org/jdk/pull/8179
> This is a leftover documentation fix to the deprecation of `Locale`
> constructors. `Locale.Builder` class had some texts that suggested using one
> of those constructors, which need to be replaced with a `Locale.of()` method.
> A corresponding CSR has also been drafted.
Naoto Sato has update
On Tue, 28 Jun 2022 19:45:30 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added `lang` attribute to the snippet
>
> src/java.base/share/classes/java/util/Locale.java line 2608:
>
>> 2606: *
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote:
> Changes the definition of `CollectorImpl` to be a record.
I see this one languished quite a while without a review. Sorry about that; for
the uninteresting, maybe it really is insufficiently interesting to even pursue
except as a starter issue
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote:
> Changes the definition of `CollectorImpl` to be a record.
For some new features, its an obvious yes, though personally, it should add
some value to the code, not just churn the code base to be up-to-date.
Also, there is quite a bit of core cod
On Tue, 28 Jun 2022 17:11:31 GMT, Naoto Sato wrote:
> This is a leftover documentation fix to the deprecation of `Locale`
> constructors. `Locale.Builder` class had some texts that suggested using one
> of those constructors, which need to be replaced with a `Locale.of()` method.
> A correspon
On Tue, 28 Jun 2022 17:11:31 GMT, Naoto Sato wrote:
> This is a leftover documentation fix to the deprecation of `Locale`
> constructors. `Locale.Builder` class had some texts that suggested using one
> of those constructors, which need to be replaced with a `Locale.of()` method.
> A correspon
This is a REDO of the Fix that was incompletely implemented earlier:
[8285838: Fix for TZ environment variable DST
rules](https://github.com/openjdk/jdk/pull/8660)
Offset calculation now accounts all the way upto year in order to avoid
cross-day miscalculations as well as to calculate always in
On Tue, 28 Jun 2022 16:54:54 GMT, Roger Riggs wrote:
>> Changes the definition of `CollectorImpl` to be a record.
>
> Marked as reviewed by rriggs (Reviewer).
Hi @RogerRiggs,
Thanks for reviewing this PR. I have a more general question. Do we have any
recommendations about using new language f
This is a leftover documentation fix to the deprecation of `Locale`
constructors. `Locale.Builder` class had some texts that suggested using one of
those constructors, which need to be replaced with a `Locale.of()` method. A
corresponding CSR has also been drafted.
-
Commit message
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote:
> Changes the definition of `CollectorImpl` to be a record.
This pull request has now been integrated.
Changeset: af008807
Author:altrisi
Committer: Paul Hohensee
URL:
https://git.openjdk.org/jdk/commit/af0088076dd8cb5d5bc47c59838e7f
On Wed, 22 Jun 2022 11:53:39 GMT, Alex Kasko wrote:
> Please review this minor fix to the jpackage test suite.
>
> When `INSTALL` and `UNINSTALL` actions are enabled for jpackage test suite
> runs (disabled by default), installation of `EXE` and `MSI` packages is
> performed. `EXE` package is
On Wed, 8 Jun 2022 11:46:42 GMT, Alex Kasko wrote:
> In jpackage test suite there is a test utility
> WindowsHelper.queryRegistryValue . It is used to verify changes to Windows
> registry that can be done by installer packages. It spawns `reg.exe query`
> process and parses its output. This pa
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote:
> Changes the definition of `CollectorImpl` to be a record.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/8179
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote:
> Changes the definition of `CollectorImpl` to be a record.
I believe we need another reviewer (doesn't have to be a capital-Reviewer).
I'll sponsor after that.
-
PR: https://git.openjdk.org/jdk/pull/8179
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote:
> Changes the definition of `CollectorImpl` to be a record.
Thanks for the review!
-
PR: https://git.openjdk.org/jdk/pull/8179
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote:
> Changes the definition of `CollectorImpl` to be a record.
Lgtm.
-
Marked as reviewed by phh (Reviewer).
PR: https://git.openjdk.org/jdk/pull/8179
On Tue, 28 Jun 2022 14:22:48 GMT, rmartinc wrote:
>> Fixes [JDK-8288895](https://bugs.openjdk.org/browse/JDK-8288895).
>>
>> Any `LimitExceededException` now quits the referral loop.
>>
>> Added class `ReferralLimitSearchTest`. It is a simple jtreg test which
>> checks that `java.naming.ldap.r
> Fixes [JDK-8288895](https://bugs.openjdk.org/browse/JDK-8288895).
>
> Any `LimitExceededException` now quits the referral loop.
>
> Added class `ReferralLimitSearchTest`. It is a simple jtreg test which checks
> that `java.naming.ldap.referral.limit` is really enforced. The dummy ldap
> serve
On Tue, 28 Jun 2022 11:21:44 GMT, Aleksei Efimov wrote:
>> rmartinc has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit
The system property jdk.tracePinnedThreads triggers a stack trace to be printed
when a virtual thread parks while pinned. If a virtual thread is pinned due to
a native frame there is a spurious " <== monitors:0" added to line for the
native method.
A secondary issue is that there is no stack tr
On Tue, 28 Jun 2022 07:10:52 GMT, rmartinc wrote:
>> Fixes [JDK-8288895](https://bugs.openjdk.org/browse/JDK-8288895).
>>
>> Any `LimitExceededException` now quits the referral loop.
>>
>> Added class `ReferralLimitSearchTest`. It is a simple jtreg test which
>> checks that `java.naming.ldap.r
On Tue, 28 Jun 2022 05:20:03 GMT, Jatin Bhateja wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add comparison for direct value of compare
>
> src/hotspot/cpu/x86/x86_64.ad line 13043:
>
>> 13041: __ cmpl($src
On Wed, 22 Jun 2022 03:01:36 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch implements intrinsics for `Integer/Long::compareUnsigned` using
>> the same approach as the JVM does for long and floating-point comparisons.
>> This allows efficient and reliable usage of unsigned comparison in Java
On Tue, 28 Jun 2022 11:46:06 GMT, Claes Redestad wrote:
> 8288425: Footprint regression due MH creation when initializing
> StringConcatFactory
This pull request has now been integrated.
Changeset: 9048cef7
Author:Claes Redestad
URL:
https://git.openjdk.org/jdk19/commit/9048cef7618
On Tue, 28 Jun 2022 12:07:13 GMT, Jim Laskey wrote:
> LGTM
Thanks. FWIW it's a clean backport.
> Is it possible to set up a regression test?
We caught this automatically - albeit a bit later - using our automated startup
and footprint tests.
A functional pass-or-fail test is always a bit a
On Tue, 28 Jun 2022 11:46:06 GMT, Claes Redestad wrote:
> 8288425: Footprint regression due MH creation when initializing
> StringConcatFactory
LGTM
Is it possible to set up a regression test?
-
Marked as reviewed by jlaskey (Reviewer).
PR: https://git.openjdk.org/jdk19/pull/83
8288425: Footprint regression due MH creation when initializing
StringConcatFactory
-
Commit messages:
- 8288425: Footprint regression due MH creation when initializing
StringConcatFactory
Changes: https://git.openjdk.org/jdk19/pull/83/files
Webrev: https://webrevs.openjdk.org/?r
On Wed, 22 Jun 2022 11:53:39 GMT, Alex Kasko wrote:
> Please review this minor fix to the jpackage test suite.
>
> When `INSTALL` and `UNINSTALL` actions are enabled for jpackage test suite
> runs (disabled by default), installation of `EXE` and `MSI` packages is
> performed. `EXE` package is
On Wed, 8 Jun 2022 11:46:42 GMT, Alex Kasko wrote:
> In jpackage test suite there is a test utility
> WindowsHelper.queryRegistryValue . It is used to verify changes to Windows
> registry that can be done by installer packages. It spawns `reg.exe query`
> process and parses its output. This pa
On Mon, 27 Jun 2022 17:02:11 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/java/lang/foreign/package-info.java line 30:
>>
>>> 28: * Provides low-level access to memory and functions outside the
>>> Java runtime.
>>> 29: *
>>> 30: * Foreign memory access
>>
>> I would refrain from
> `BigDecimal.morePoint[Left|Right]()` should return the target `this` when the
> argument is 0 _and_ the scale is non-negative.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8289260: BigDecimal movePointLeft() and movePoint
`BigDecimal.morePoint[Left|Right]()` should return the target `this` when the
argument is 0 _and_ the scale is non-negative.
-
Commit messages:
- 8289260: BigDecimal movePointLeft() and movePointRight() do not follow their
API spec
- 8289260: BigDecimal movePointLeft() and movePoi
On Mon, 27 Jun 2022 16:47:32 GMT, Maurizio Cimadamore
wrote:
> Recent fix for JDK-8289188 relaxed behavior or
> `SegmentAllocator::allocateArray` too much w.r.t. nulls. This patch reverts
> null handling to what it used to be.
This pull request has now been integrated.
Changeset: adbd200d
Au
On Mon, 9 May 2022 09:56:19 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream` spe
On Tue, 28 Jun 2022 07:07:24 GMT, rmartinc wrote:
>> src/java.naming/share/classes/com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java
>> line 339:
>>
>>> 337: break;
>>> 338: } else if (errEx == null) {
>>> 339: errEx = re.ge
On Tue, 28 Jun 2022 06:29:03 GMT, Quan Anh Mai wrote:
>> src/hotspot/share/opto/subnode.hpp line 247:
>>
>>> 245: init_class_id(Class_Sub);
>>> 246: }
>>> 247: virtual int Opcode() const;
>>
>> In-lining may connect the inputs to constant, hence a Value routine may be
>> useful here.
>
On Fri, 24 Jun 2022 07:22:05 GMT, Jaikiran Pai wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8288723: Avoid redundant ConcurrentHashMap.get call in java.time
>> use computeIfAbsent where lambda could be shor
On Mon, 27 Jun 2022 14:57:30 GMT, Daniel Fuchs wrote:
>> rmartinc has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit s
> Fixes [JDK-8288895](https://bugs.openjdk.org/browse/JDK-8288895).
>
> Any `LimitExceededException` now quits the referral loop.
>
> Added class `ReferralLimitSearchTest`. It is a simple jtreg test which checks
> that `java.naming.ldap.referral.limit` is really enforced. The dummy ldap
> serve
59 matches
Mail list logo
