On Tue, 28 Jun 2022 05:51:42 GMT, Jatin Bhateja wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add comparison for direct value of compare
>
> src/hotspot/cpu/x86/x86_64.ad line 13027:
>
>> 13025: // Manifest a Cm
On Wed, 22 Jun 2022 03:01:36 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch implements intrinsics for `Integer/Long::compareUnsigned` using
>> the same approach as the JVM does for long and floating-point comparisons.
>> This allows efficient and reliable usage of unsigned comparison in Java
On Mon, 27 Jun 2022 05:32:01 GMT, Jaikiran Pai wrote:
>> This is a simple change to add some protective code to
>> java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more
>> complete in the event of encountering an any exceptions while running. In
>> the present state, the server
On Mon, 27 Jun 2022 04:50:09 GMT, Thejasvi Voniadka
wrote:
> This is a simple change to add some protective code to
> java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more
> complete in the event of encountering an any exceptions while running. In the
> present state, the serv
On Mon, 27 Jun 2022 20:40:43 GMT, Maurizio Cimadamore
wrote:
>> Recent fix for JDK-8289188 relaxed behavior or
>> `SegmentAllocator::allocateArray` too much w.r.t. nulls. This patch reverts
>> null handling to what it used to be.
>
> Maurizio Cimadamore has updated the pull request incremental
On Mon, 27 Jun 2022 20:40:43 GMT, Maurizio Cimadamore
wrote:
>> Recent fix for JDK-8289188 relaxed behavior or
>> `SegmentAllocator::allocateArray` too much w.r.t. nulls. This patch reverts
>> null handling to what it used to be.
>
> Maurizio Cimadamore has updated the pull request incremental
On Wed, 8 Jun 2022 11:46:42 GMT, Alex Kasko wrote:
> In jpackage test suite there is a test utility
> WindowsHelper.queryRegistryValue . It is used to verify changes to Windows
> registry that can be done by installer packages. It spawns `reg.exe query`
> process and parses its output. This pa
On Wed, 22 Jun 2022 11:53:39 GMT, Alex Kasko wrote:
> Please review this minor fix to the jpackage test suite.
>
> When `INSTALL` and `UNINSTALL` actions are enabled for jpackage test suite
> runs (disabled by default), installation of `EXE` and `MSI` packages is
> performed. `EXE` package is
On Mon, 27 Jun 2022 21:17:40 GMT, David Holmes wrote:
>> A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java.
>
> Marked as reviewed by dholmes (Reviewer).
@dholmes-ora - Thanks for the lightning fast review!
-
PR: https://git.openjdk.org/jdk19/pull/80
On Mon, 27 Jun 2022 21:16:29 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java.
This pull request has now been integrated.
Changeset: 2efa89a8
Author:Daniel D. Daugherty
URL:
https://git.openjdk.org/jdk19/commit/2efa89a89e01003
On Mon, 27 Jun 2022 21:16:29 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java.
Marked as reviewed by dholmes (Reviewer).
-
PR: https://git.openjdk.org/jdk19/pull/80
A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java.
-
Commit messages:
- 8289251: ProblemList java/lang/ref/OOMEInReferenceHandler.java
Changes: https://git.openjdk.org/jdk19/pull/80/files
Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=80&range=00
Issue: h
On Mon, 27 Jun 2022 17:28:13 GMT, Jorn Vernee wrote:
> Should test/jdk/java/foreign/TestNulls.java also be reverted?
Yes, I thought I did that, but the changes got reverted by the merge I did.
Re-added the changes now.
-
PR: https://git.openjdk.org/jdk19/pull/76
> Recent fix for JDK-8289188 relaxed behavior or
> `SegmentAllocator::allocateArray` too much w.r.t. nulls. This patch reverts
> null handling to what it used to be.
Maurizio Cimadamore has updated the pull request incrementally with one
additional commit since the last revision:
Revert test
On Mon, 27 Jun 2022 18:35:53 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode.
This pull request has now been integrated.
Changeset: caa6b74b
Author:Daniel D. Daugherty
URL:
https://git.ope
On Mon, 27 Jun 2022 18:35:53 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.org/jdk19/pull/78
On Mon, 27 Jun 2022 18:38:09 GMT, Brian Burkhalter wrote:
>> A trivial fix to ProblemList
>> java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode.
>
> Marked as reviewed by bpb (Reviewer).
@bplb and @naotoj - Thanks for the fast reviews!
-
PR: https://git.o
On Mon, 27 Jun 2022 18:35:53 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.org/jdk19/pull/78
A trivial fix to ProblemList
java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode.
-
Commit messages:
- 8289240: ProblemList
java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode
Changes: https://git.openjdk.org/jdk19/pull/78/files
Web
On Mon, 27 Jun 2022 11:49:07 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 19 -> JDK 20
This pull request has now been integrated.
Changeset: d4b040f4
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/d4b040f42dd0a9100ad1ffa55de4ae4f20e9f182
Stats: 366 lines
> Forwardport JDK 19 -> JDK 20
Jesper Wilhelmsson has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 146 commits:
- Merge
- 8289126: Cleanup unnecessary null comparison before instanceof check in
jdk.hotspot.agent
Reviewed-by:
On Wed, 8 Jun 2022 13:12:09 GMT, Raffaello Giulietti wrote:
> These 19'545 doubles were generated on purpose by Paul Zimmermann of INRIA as
> hard test cases.
This pull request has now been integrated.
Changeset: 354ed103
Author:Raffaello Giulietti
Committer: Joe Darcy
URL:
https:
On Tue, 21 Jun 2022 09:30:30 GMT, Alex Kasko wrote:
> jpackage implementation of file association on Windows currently passes a
> selected filename as an only argument to associated executable.
>
> It is proposed to introduce additional option in file association property
> file to allow optio
On Tue, 21 Jun 2022 09:30:30 GMT, Alex Kasko wrote:
> jpackage implementation of file association on Windows currently passes a
> selected filename as an only argument to associated executable.
>
> It is proposed to introduce additional option in file association property
> file to allow optio
On Wed, 8 Jun 2022 11:46:42 GMT, Alex Kasko wrote:
> In jpackage test suite there is a test utility
> WindowsHelper.queryRegistryValue . It is used to verify changes to Windows
> registry that can be done by installer packages. It spawns `reg.exe query`
> process and parses its output. This pa
On Wed, 22 Jun 2022 11:53:39 GMT, Alex Kasko wrote:
> Please review this minor fix to the jpackage test suite.
>
> When `INSTALL` and `UNINSTALL` actions are enabled for jpackage test suite
> runs (disabled by default), installation of `EXE` and `MSI` packages is
> performed. `EXE` package is
On Mon, 27 Jun 2022 16:47:32 GMT, Maurizio Cimadamore
wrote:
> Recent fix for JDK-8289188 relaxed behavior or
> `SegmentAllocator::allocateArray` too much w.r.t. nulls. This patch reverts
> null handling to what it used to be.
Should test/jdk/java/foreign/TestNulls.java also be reverted?
---
On Mon, 27 Jun 2022 16:57:10 GMT, Maurizio Cimadamore
wrote:
>> > href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/8817__;!!ACWV5N9M2RV99hQ!Ooc0KcgMe7NsDGNiGbF-wfC_tK6POSNyLNDIHsrms0gVVdXsgnVAAbWZpHXSYWbAAmkJrTeqEh4N1h-1f8ZwKplq$";>https://github.com/openjdk/jdk/pull/8817
>>
On Mon, 27 Jun 2022 16:44:17 GMT, Jorn Vernee wrote:
> href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/8817__;!!ACWV5N9M2RV99hQ!ONT5MC45-Ze5UV3QSWdwMZbC1ssL29-DSmCyj3V9jPWzvOLSZctEnN4Ra-zFow08wzVe_7ufpSsxCxqgx0EIUoneRO4r7w$";>https://github.com/openjdk/jdk/pull/8817
> adde
Recent fix for JDK-8289188 relaxed behavior or
`SegmentAllocator::allocateArray` too much w.r.t. nulls. This patch reverts
null handling to what it used to be.
-
Commit messages:
- Merge branch 'master' into allocateArray_null
- Revert null changes
Changes: https://git.openjdk.or
https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/8817__;!!ACWV5N9M2RV99hQ!Kkp_j7PnK9AJEJUL817VN56eVeunFZsJPCPgXLt_Dgb1QE4PxZokFGCEF_Cf7KNASIrlkM5xZTNXSGd6ve264vZm$
added a button to copy a link to a section of javadoc to the clipboard.
This cleanup PR canonicalizes all header ids
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A readAttributesIfExists(Path
> path, Class type, LinkOption... o
On Mon, 27 Jun 2022 11:01:59 GMT, Maurizio Cimadamore
wrote:
> This patch fixes an issue where the default method implementation of the
> SegmentAllocator::allcoateArray methods do not conform to the javadoc. The
> javadoc says that specific `allocateArray` methods delegate to
> `allocateArra
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote:
> Changes the definition of `CollectorImpl` to be a record.
Hi, is this small PR missing anything in order to be reviewed? Thanks!
-
PR: https://git.openjdk.org/jdk/pull/8179
On Mon, 27 Jun 2022 15:02:36 GMT, Daniel Fuchs wrote:
>> Extend delegation by instance returned by Random.from() to all methods
>> exposed by RandomGenerator.
>
> just a stylistic comment in passing: it's a bit strange to see half of the
> methods call `this.generator` and the other half simply
On Mon, 20 Jun 2022 14:09:27 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a patch that should help the HttpClient's SelectorManager
> thread to terminate more timely, allowing the resources consumed by the
> client to be released earlier.
>
> The idea is to use a Cleaner registered wit
On Thu, 23 Jun 2022 08:20:31 GMT, rmartinc wrote:
> Fixes [JDK-8288895](https://bugs.openjdk.org/browse/JDK-8288895).
>
> Any `LimitExceededException` now quits the referral loop.
>
> Added class `ReferralLimitSearchTest`. It is a simple jtreg test which checks
> that `java.naming.ldap.referra
On Fri, 17 Jun 2022 16:44:30 GMT, Raffaello Giulietti wrote:
> Extend delegation by instance returned by Random.from() to all methods
> exposed by RandomGenerator.
just a stylistic comment in passing: it's a bit strange to see half of the
methods call `this.generator` and the other half simply
On Mon, 27 Jun 2022 11:52:37 GMT, Thejasvi Voniadka
wrote:
>> This is a simple change to add some protective code to
>> java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more
>> complete in the event of encountering an any exceptions while running. In
>> the present state, the
On Mon, 20 Jun 2022 14:09:27 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a patch that should help the HttpClient's SelectorManager
> thread to terminate more timely, allowing the resources consumed by the
> client to be released earlier.
>
> The idea is to use a Cleaner registered wit
On Mon, 27 Jun 2022 11:01:59 GMT, Maurizio Cimadamore
wrote:
> This patch fixes an issue where the default method implementation of the
> SegmentAllocator::allcoateArray methods do not conform to the javadoc. The
> javadoc says that specific `allocateArray` methods delegate to
> `allocateArra
On Mon, 27 Jun 2022 11:52:37 GMT, Thejasvi Voniadka
wrote:
>> This is a simple change to add some protective code to
>> java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more
>> complete in the event of encountering an any exceptions while running. In
>> the present state, the
On Sun, 26 Jun 2022 06:08:07 GMT, Jaikiran Pai wrote:
>> Hi,
>>
>> Please find here a patch that should help the HttpClient's SelectorManager
>> thread to terminate more timely, allowing the resources consumed by the
>> client to be released earlier.
>>
>> The idea is to use a Cleaner registe
On Mon, 20 Jun 2022 14:09:27 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a patch that should help the HttpClient's SelectorManager
> thread to terminate more timely, allowing the resources consumed by the
> client to be released earlier.
>
> The idea is to use a Cleaner registered wit
On Mon, 27 Jun 2022 11:52:37 GMT, Thejasvi Voniadka
wrote:
>> This is a simple change to add some protective code to
>> java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more
>> complete in the event of encountering an any exceptions while running. In
>> the present state, the
This patch fixes an issue where the default method implementation of the
SegmentAllocator::allcoateArray methods do not conform to the javadoc. The
javadoc says that specific `allocateArray` methods delegate to
`allocateArray(MemoryLayout, size)` - but this does not happen; instead these
method
On Sun, 26 Jun 2022 06:08:07 GMT, Jaikiran Pai wrote:
>> Hi,
>>
>> Please find here a patch that should help the HttpClient's SelectorManager
>> thread to terminate more timely, allowing the resources consumed by the
>> client to be released earlier.
>>
>> The idea is to use a Cleaner registe
Forwardport JDK 19 -> JDK 20
-
Commit messages:
- Merge
- 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed
with "RuntimeException: Test failed"
- 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
- 8288983: broken link in com.sun.net.
On Mon, 27 Jun 2022 10:52:58 GMT, Thejasvi Voniadka
wrote:
>> test/jdk/java/util/zip/ZipFile/DeleteTempJar.java line 89:
>>
>>> 87: server.stop(0);
>>> 88: }
>>> 89: }
>>
>> Is there a reason to put the server.start in the try block, I would think
>> this i
> This is a simple change to add some protective code to
> java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more
> complete in the event of encountering an any exceptions while running. In the
> present state, the server.stop() does not get executed in case of
> encountering a f
On Mon, 20 Jun 2022 14:09:27 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a patch that should help the HttpClient's SelectorManager
> thread to terminate more timely, allowing the resources consumed by the
> client to be released earlier.
>
> The idea is to use a Cleaner registered wit
On Mon, 27 Jun 2022 06:34:29 GMT, Alan Bateman wrote:
>> Thejasvi Voniadka has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop
>> HttpServer cleanly in case of excepti
On Mon, 27 Jun 2022 10:53:56 GMT, Thejasvi Voniadka
wrote:
>> This is a simple change to add some protective code to
>> java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more
>> complete in the event of encountering an any exceptions while running. In
>> the present state, the
> This is a simple change to add some protective code to
> java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more
> complete in the event of encountering an any exceptions while running. In the
> present state, the server.stop() does not get executed in case of
> encountering a f
On Sun, 26 Jun 2022 09:50:11 GMT, Alan Bateman wrote:
> This is a fix to a recently added test. The test uses pthread_create to
> create native threads that invoke a Java method via a generated "upcall
> stub". The upcall stub is created in an implicit memory session but the test
> doesn't do
On Sun, 26 Jun 2022 13:33:40 GMT, Lance Andersen wrote:
> I thought about using TestProvider and then talked myself out of it. So yes,
> I can do that. If you have a preferred name other than
> `TestOverRideFSPMethods` please let me know
The only change that should be needed to TestProvider is
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment compatibl
On Sun, 26 Jun 2022 09:50:11 GMT, Alan Bateman wrote:
> This is a fix to a recently added test. The test uses pthread_create to
> create native threads that invoke a Java method via a generated "upcall
> stub". The upcall stub is created in an implicit memory session but the test
> doesn't do
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment compatibl
On Fri, 17 Jun 2022 08:43:00 GMT, Andrey Turbanov wrote:
> Fields `STARTTIME_ANY` and `STARTTIME_PROCESS_UNKNOWN` are actually unused,
> but they are useful as documentation on the interface to native.
> Make them `static` to reduce memory usage.
This pull request has now been integrated.
Chan
60 matches
Mail list logo
