On Mon, 27 Jun 2022 10:52:58 GMT, Thejasvi Voniadka <tvonia...@openjdk.org> 
wrote:

>> test/jdk/java/util/zip/ZipFile/DeleteTempJar.java line 89:
>> 
>>> 87:                 server.stop(0);
>>> 88:             }
>>> 89:         }
>> 
>> Is there a reason to put the server.start in the try block, I would think 
>> this is simpler:
>> 
>> 
>> server.start();
>> try {
>>     :
>> } finally {
>>     server.stop(0);
>> }
>
> Thank you @jaikiran , @AlanBateman for your reviews. I have updated the patch 
> with your inputs.

Sorry @jaikiran , I somehow missed the comment on the null check. Have fixed it 
now, thank you!

-------------

PR: https://git.openjdk.org/jdk/pull/9293

Reply via email to