On Thu, 23 Jun 2022 01:40:57 GMT, Naoto Sato wrote:
>> The RuntimeException from OutputAnalyzer for expected and unexpected exit
>> values should include both the actual and expected values.
>> The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the
>> value expected and the v
Hi Michael,
I filed it as https://bugs.openjdk.org/browse/JDK-8289030
Thanks,
Alexander
On Jun 22, 2022, at 5:40 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Jun 22, 2022, at 7:36 PM, Alexander Matveev
mailto:alexander.matv...@oracle.com>> wrote:
Hi Michael,
I was able to reprod
On Wed, 22 Jun 2022 18:19:56 GMT, Roger Riggs wrote:
> The RuntimeException from OutputAnalyzer for expected and unexpected exit
> values should include both the actual and expected values.
> The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the
> value expected and the valu
On Fri, 10 Jun 2022 08:26:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which addresses
>> https://bugs.openjdk.java.net/browse/JDK-8285405?
>>
>> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the
>> existing `test/jdk/java/util/LinkedHashMap/Basic.
On Wed, 22 Jun 2022 18:19:56 GMT, Roger Riggs wrote:
> The RuntimeException from OutputAnalyzer for expected and unexpected exit
> values should include both the actual and expected values.
> The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the
> value expected and the valu
On Wed, 22 Jun 2022 21:48:35 GMT, Joe Wang wrote:
>> Fix a regression in Document.normalizeDocument() caused by a change in JDK
>> 10.
>>
>> Test: new test (as in the bug report) and Tier2 passed.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the la
> On Jun 22, 2022, at 7:36 PM, Alexander Matveev
> wrote:
>
> Hi Michael,
>
> I was able to reproduce it. Not sure what is wrong. Do you want to file a bug
> for this? Or I can file one myself.
>
> Thanks,
> Alexander
>
You can get it. I have no immediate need again. Just thought I might
Hi Michael,
I was able to reproduce it. Not sure what is wrong. Do you want to file a bug
for this? Or I can file one myself.
Thanks,
Alexander
> On Jun 22, 2022, at 5:22 PM, Michael Hall wrote:
>
>
>
>> On Jun 22, 2022, at 7:15 PM, Michael Hall wrote:
>>
>>
>>
>>> On Jun 22, 2022, at 6
> On Jun 22, 2022, at 7:15 PM, Michael Hall wrote:
>
>
>
>> On Jun 22, 2022, at 6:57 PM, Alexander Matveev
>> wrote:
>>
>> Hi Michael,
>>
>> Did you modified app image after it was signed and before DMG was created?
>> If yes, it is expected behavior and we will not sign app image when
> On Jun 22, 2022, at 6:57 PM, Alexander Matveev
> wrote:
>
> Hi Michael,
>
> Did you modified app image after it was signed and before DMG was created? If
> yes, it is expected behavior and we will not sign app image when generating
> DMG.
>
> Can you provide all steps you did to get to
Hi Michael,
Did you modified app image after it was signed and before DMG was created? If
yes, it is expected behavior and we will not sign app image when generating DMG.
Can you provide all steps you did to get to issue below?
Thanks,
Alexander
> On Jun 22, 2022, at 1:51 PM, Michael Hall wro
On Wed, 22 Jun 2022 21:48:35 GMT, Joe Wang wrote:
>> Fix a regression in Document.normalizeDocument() caused by a change in JDK
>> 10.
>>
>> Test: new test (as in the bug report) and Tier2 passed.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the la
On Wed, 22 Jun 2022 21:25:07 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 19 -> JDK 20
This pull request has now been integrated.
Changeset: 5b583e47
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/5b583e4792b1d59891495a4a050fcdd4d38dfee1
Stats: 434 lines
On Wed, 22 Jun 2022 21:48:35 GMT, Joe Wang wrote:
>> Fix a regression in Document.normalizeDocument() caused by a change in JDK
>> 10.
>>
>> Test: new test (as in the bug report) and Tier2 passed.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the la
On Wed, 22 Jun 2022 19:05:41 GMT, Lance Andersen wrote:
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A readAt
On Wed, 22 Jun 2022 19:05:41 GMT, Lance Andersen wrote:
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A readAt
On Wed, 22 Jun 2022 17:57:44 GMT, Naoto Sato wrote:
>> A stable order is useful when comparing between builds (by a human).
>> It also supports the goal of reproducible builds.
>> @naotoj What do you think?
>
> IIUC, once this fix makes it to the repository, the build will be
> reproducible. M
On Wed, 22 Jun 2022 17:30:48 GMT, Daniel Jeliński wrote:
>> This PR improves the performance of deduplication done by
>> ResourceBundleGenerator.
>>
>> The original implementation compared every pair of values, requiring O(n^2)
>> time. The new implementation uses a HashMap to find duplicates,
On Wed, 22 Jun 2022 20:01:58 GMT, Joe Wang wrote:
> Fix a regression in Document.normalizeDocument() caused by a change in JDK 10.
>
> Test: new test (as in the bug report) and Tier2 passed.
Thanks Lance. Updated the patch, also changed the corresponding nodes.
-
PR: https://git.o
> Fix a regression in Document.normalizeDocument() caused by a change in JDK 10.
>
> Test: new test (as in the bug report) and Tier2 passed.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Remove initialization size, use default instead
Forwardport JDK 19 -> JDK 20
-
Commit messages:
- Merge
- 8288988: ProblemList
serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java in
-Xcomp mode
- 8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep,
short time use only"
- 8288840: St
> Instead of separate ConcurrentHashMap.get call, we can use result of previous
> putIfAbsent call.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8288723: Avoid redundant ConcurrentHashMap.get call in java.time
use computeIfAb
Alexander,
Sorry yet again. I really should have totally completed. While the application
verified on disk immediately after signing. The dmg version does not appear to
verify.
codesign -v --verbose=4 /Applications/BlackJack\ Blastoff_Unsigned.app
/Applications/BlackJack Blastoff_Unsigned.app
>
> Assuming the current JDK19 ea includes this change and dependencies. Possibly
> this is still incorrect.
>
>
>
> codesign -v --verbose=4 BlackJack\ Blastoff_Unsigned.app
> BlackJack Blastoff_Unsigned.app: code has no resources but signature
> indicates they must be present
>
> I think
Fix a regression in Document.normalizeDocument() caused by a change in JDK 10.
Test: new test (as in the bug report) and Tier2 passed.
-
Commit messages:
- 8287076: Document.normalizeDocument() produces different results
Changes: https://git.openjdk.org/jdk19/pull/59/files
Webrev:
On Wed, 22 Jun 2022 19:54:47 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/java/nio/file/spi/FileSystemProvider.java line
>> 1218:
>>
>>> 1216:
>>> 1217: /**
>>> 1218: * Reads a file's attributes as a bulk operation if it exists.
>>
>> Maybe instead "it" put "the file"?
>
On Wed, 22 Jun 2022 19:22:50 GMT, Brian Burkhalter wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> - publi
On Wed, 22 Jun 2022 19:05:41 GMT, Lance Andersen wrote:
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption... options)
> - public A readAt
Hi,
Please review the following patch which will:
- Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
the methods
- public boolean exists(Path path, LinkOption... options)
- public A readAttributesIfExists(Path path,
Class type, LinkOption... options)
This chang
The RuntimeException from OutputAnalyzer for expected and unexpected exit
values should include both the actual and expected values.
The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the value
expected and the value not expected instead of the actual value returned. The
value
On Tue, 21 Jun 2022 22:30:43 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>> dis
On Wed, 22 Jun 2022 17:27:11 GMT, Roger Riggs wrote:
>> True. Which raises the question: do we need any arbitrary order? The
>> original code used a hashmap too. It preserved the original order only when
>> no duplicates were detected.
>
> A stable order is useful when comparing between builds
On Wed, 22 Jun 2022 10:48:47 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved `@Test` annotations
>
> test/jdk/java/nio/file/Files/ReadWriteString.java line 304:
>
>> 302: throws I
On Wed, 22 Jun 2022 10:50:56 GMT, Alan Bateman wrote:
> > > One other thing, this is a regression in 19 so I assume the PR should be
> > > against openjdk/jdk19 rather than the main line.
> >
> >
> > Since this PR already got a few approvals, I will backport the changeset to
> > the jdk19 lin
> This is a regression caused by the fix to
> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed the
> method `String.decodeWithDecoder()` was only invoked with cs.REPLACE mode
> based on the comment "should not happen". Possibly this refers to the
> `String(byte[], int,
On Wed, 22 Jun 2022 17:07:11 GMT, Daniel Jeliński wrote:
>> make/jdk/src/classes/build/tools/cldrconverter/ResourceBundleGenerator.java
>> line 146:
>>
>>> 144: // generic reduction of duplicated values
>>> 145: Map newMap = new HashMap<>(map);
>>> 146: Map d
> This PR improves the performance of deduplication done by
> ResourceBundleGenerator.
>
> The original implementation compared every pair of values, requiring O(n^2)
> time. The new implementation uses a HashMap to find duplicates, trading off
> some extra memory consumption for O(n) computati
On Wed, 22 Jun 2022 16:11:33 GMT, Roger Riggs wrote:
>> This PR improves the performance of deduplication done by
>> ResourceBundleGenerator.
>>
>> The original implementation compared every pair of values, requiring O(n^2)
>> time. The new implementation uses a HashMap to find duplicates, tra
On Wed, 22 Jun 2022 14:24:05 GMT, Daniel Jeliński wrote:
> This PR improves the performance of deduplication done by
> ResourceBundleGenerator.
>
> The original implementation compared every pair of values, requiring O(n^2)
> time. The new implementation uses a HashMap to find duplicates, trad
On Fri, 10 Jun 2022 20:58:03 GMT, Naoto Sato wrote:
> As the name suggests, `COMPAT` locale provider keeps compatibility with
> JDK8's locale data (before CLDR). This is useful for legacy applications,
> but some of its data got obsolete for later locale data updates, such as the
> country na
On Mon, 14 Mar 2022 19:12:29 GMT, iaroslavski wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on
>> int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single
>> element
>> - minor javad
This PR improves the performance of deduplication done by
ResourceBundleGenerator.
The original implementation compared every pair of values, requiring O(n^2)
time. The new implementation uses a HashMap to find duplicates, trading off
some extra memory consumption for O(n) computational complex
Improve the implementation of `Double/Float.isInfinite` to reduce branching.
Using `>` comparison with `MAX_VALUE` instead of `==` with `POSITIVE_INFINITY`
improves code emission on x86 and produces similar code for arm. This is also
the way gcc implements `std::isinf` on x86 and arm (clang uses
Please review this minor fix to the jpackage test suite.
When `INSTALL` and `UNINSTALL` actions are enabled for jpackage test suite runs
(disabled by default), installation of `EXE` and `MSI` packages is performed.
`EXE` package is invoked directly and `MSI` package is installed using
`msiexec`
On Tue, 21 Jun 2022 21:49:58 GMT, Naoto Sato wrote:
>> This is a regression caused by the fix to
>> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed
>> the method `String.decodeWithDecoder()` was only invoked with cs.REPLACE
>> mode based on the comment "should not hap
On Tue, 21 Jun 2022 18:23:35 GMT, Naoto Sato wrote:
> > One other thing, this is a regression in 19 so I assume the PR should be
> > against openjdk/jdk19 rather than the main line.
>
> Since this PR already got a few approvals, I will backport the changeset to
> the jdk19 line after this PR g
> On Jun 8, 2022, at 1:47 AM, Michael Hall wrote:
>
>
>
>> On Jun 7, 2022, at 9:21 PM, Alexander Matveev
>> wrote:
>>
>> Hi Michael,
>>
>> Yes, this is correct. It is a three step process as you outlined it below.
>>
>
> Alexander,
>
> Could you post an example of the three invocation
On Tue, 21 Jun 2022 11:20:49 GMT, Alan Bateman wrote:
> StructureViolationException has a `@see` link to a fork method that does not
> throw this exception. The link should be removed for JDK 19. We'll add the
> link back once the JEP for Extent-Local Variables is integrated.
This pull request
On Thu, 16 Jun 2022 13:34:18 GMT, Alan Bateman wrote:
> If several native threads attach to the VM at around the same time, and
> before any threads get an automatically generated name are created, then the
> VM may crash attempting to access the thread status. The issue exists for
> native th
On Tue, 21 Jun 2022 08:13:29 GMT, Alan Bateman wrote:
> One thing that I'm wondering for the test is whether to move it to
> test/hotspot/jtreg/runtime/jni/ so it lives with the other tests for JNI. I
> had expected to find other tests for AttachCurrentThread in that location but
> we don't.
50 matches
Mail list logo
