On Wed, 22 Jun 2022 10:48:47 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Moved `@Test` annotations
>
> test/jdk/java/nio/file/Files/ReadWriteString.java line 304:
> 
>> 302:             throws IOException {
>> 303:         Path path = Files.createTempFile("illegalInputBytes", null);
>> 304:         path.toFile().deleteOnExit();
> 
> Although this is consistent with the existing tests in this source file, I 
> think it would be better if we change it to create the temporary files in the 
> current directory and not delete it. Leaving the file behind is useful for 
> diagnosing issues where there re test failures. We can do that in a separate 
> issue if you'd like.

Done.

-------------

PR: https://git.openjdk.org/jdk/pull/9193

Reply via email to