I think it would be good in future junit5 upgrades to *not* use the jupiter
assertions but instead move to assertj
The jupiter assertions are backwards-incompatible set of changes which add
needless engineering effort.
https://junit.org/junit5/docs/5.0.1/api/org/junit/jupiter/api/Assertions.html
*To:* ste...@cloudera.com ; Hadoop Common <
> common-dev@hadoop.apache.org>; Ashutosh Gupta ;
> Akira Ajisaka ; mapreduce-dev <
> mapreduce-...@hadoop.apache.org>
> *Subject:* Re: yetus reporting javadoc errors on @InterfaceAudience
> attributes
>
> I think it is 2
I think it is 2.5 months and the Junit upgrade tests are still in a mess[1]
There was an attempt as part of MAPREDUCE-7428, but that didn't fix
everything or some other commits induced these problems again. I don't
think anyone is actively chasing that either.
Can add Junit-vintage dependencies he
>
> Have we stopped
> with the java8 builds?
Nopes, The answer is here just cross posting:
https://github.com/apache/hadoop/pull/5226#issuecomment-1354964948
Regarding dropping Java-8 and adapting Java-11, We just have runtime
support for Java-11 in hadoop, the compile support ain't there, it is
OK, it's a JDK bug
both the java8 and java11 javadocs are now using java11. Have we stopped
with the java8 builds?
as i am happy with that, we just need to make an explicit declaration and
wrap up of anything outstanding.
On Thu, 15 Dec 2022 at 22:30, Ayush Saxena wrote:
> Thanx Ashutosh, Le
for junit you hit the *detail* that -test artifact transitive dependencies
don't get picked up. Now you know...
you can get yetus to test all downstream modules of other modules by adding
some newline in a source file in each one -changes which then MUST be left
out the final build.
On Mon, 12 De
Thanx Ashutosh, Let me know if you need any help there.
Got some time to recheck the Javadoc stuff, it seems like a JDK bug
https://bugs.openjdk.org/browse/JDK-8295850
more details over here:
https://github.com/apache/hadoop/pull/5226#pullrequestreview-1220041496
-Ayush
On Mon, 12 Dec 2022 at 1
Thanks Ayush for pointing out the failures related to the Junit 5 upgrade.
As I have closely worked in upgrading Junit 4 to Junit 5 throughout the
hadoop project. I will create a JIRA for these failures and fix them on
priority.
-Ashutosh
On Mon, Dec 12, 2022 at 1:59 PM Ayush Saxena wrote:
> Tr
Try to fix in the same way it was done here and couple of similar PRs:
https://github.com/apache/hadoop/pull/5179
There are a bunch of PRs in yarn getting the similar error fixed module
wise, the problem would be there in many other modules as well...
The daily JDK-11 build also shows that failur
yetus is now reporting errors on our @InterfaceAudience tags in java8 and
java11 javadoc generation
https://github.com/apache/hadoop/pull/5205#issuecomment-1344664692
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5205/2/artifact/out/branch-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11
10 matches
Mail list logo
