> > I'd be happy to take a look at the tests with a fresh set of eyes. Was > there an existing PR for Junit work?
Awesome, thanx for volunteering. There is a ticket MAPREDUCE-7428 <https://issues.apache.org/jira/browse/MAPREDUCE-7428>, which initially talked about these test failures, they were 150+ that time and had similar issues. You can gather details from there. If you want to figure out the tickets where these Junit upgrades happened, a simple git query might help "git log --grep Junit" Let me know if you need any help, I will be happy to help :-) -Ayush On Tue, 21 Feb 2023 at 21:16, Steve Vaughan <em...@stevevaughan.me> wrote: > I'd be happy to take a look at the tests with a fresh set of eyes. Was > there an existing PR for Junit work? > ------------------------------ > *From:* Ayush Saxena <ayush...@gmail.com> > *Sent:* Tuesday, February 21, 2023 1:24 AM > *To:* ste...@cloudera.com <ste...@cloudera.com>; Hadoop Common < > common-dev@hadoop.apache.org>; Ashutosh Gupta <ashutoshgupta...@gmail.com>; > Akira Ajisaka <aajis...@apache.org>; mapreduce-dev < > mapreduce-...@hadoop.apache.org> > *Subject:* Re: yetus reporting javadoc errors on @InterfaceAudience > attributes > > I think it is 2.5 months and the Junit upgrade tests are still in a mess[1] > There was an attempt as part of MAPREDUCE-7428, but that didn't fix > everything or some other commits induced these problems again. I don't > think anyone is actively chasing that either. > > Can add Junit-vintage dependencies here and there and most probably can fix > this, but last time the approach taken was different, so not exploring in > that way. > > Planning to backtrack and revert/reopen all the Junit upgrades tickets till > I get a green build. Will hold a minimum of 24 hrs, next whenever I find > some time, will revert all of these. > > Shout out if anyone has concerns around this, or is working on the fix > > ++ @Akira Ajisaka <aajis...@apache.org> / @mapreduce-dev > <mapreduce-...@hadoop.apache.org> > > -Ayush > > [1] > > https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1142/testReport/junit/org.apache.hadoop.mapreduce.v2.hs/TestJobHistoryEvents/testEventsFlushOnStop/ > > > On Fri, 23 Dec 2022 at 08:50, Ayush Saxena <ayush...@gmail.com> wrote: > > > Have we stopped > >> with the java8 builds? > > > > > > Nopes, The answer is here just cross posting: > > https://github.com/apache/hadoop/pull/5226#issuecomment-1354964948 > > > > Regarding dropping Java-8 and adapting Java-11, We just have runtime > > support for Java-11 in hadoop, the compile support ain't there, it is > being > > tracked here: > > https://issues.apache.org/jira/browse/HADOOP-16795 > > > > Some issues are there, one with Jersey I know and may be a couple of > more. > > > > -Ayush > > > > On Fri, 16 Dec 2022 at 20:07, Steve Loughran <ste...@cloudera.com.invalid > > > > wrote: > > > >> OK, it's a JDK bug > >> > >> both the java8 and java11 javadocs are now using java11. Have we stopped > >> with the java8 builds? > >> > >> as i am happy with that, we just need to make an explicit declaration > and > >> wrap up of anything outstanding. > >> > >> > >> > >> On Thu, 15 Dec 2022 at 22:30, Ayush Saxena <ayush...@gmail.com> wrote: > >> > >> > Thanx Ashutosh, Let me know if you need any help there. > >> > > >> > Got some time to recheck the Javadoc stuff, it seems like a JDK bug > >> > https://bugs.openjdk.org/browse/JDK-8295850 > >> > > >> > more details over here: > >> > > https://github.com/apache/hadoop/pull/5226#pullrequestreview-1220041496 > >> > > >> > -Ayush > >> > > >> > On Mon, 12 Dec 2022 at 19:46, Ashutosh Gupta < > >> ashutoshgupta...@gmail.com> > >> > wrote: > >> > > >> >> Thanks Ayush for pointing out the failures related to the Junit 5 > >> >> upgrade. As I have closely worked in upgrading Junit 4 to Junit 5 > >> >> throughout the hadoop project. I will create a JIRA for these > failures > >> and > >> >> fix them on priority. > >> >> > >> >> -Ashutosh > >> >> > >> >> On Mon, Dec 12, 2022 at 1:59 PM Ayush Saxena <ayush...@gmail.com> > >> wrote: > >> >> > >> >>> Try to fix in the same way it was done here and couple of similar > PRs: > >> >>> https://github.com/apache/hadoop/pull/5179 > >> >>> > >> >>> There are a bunch of PRs in yarn getting the similar error fixed > >> module > >> >>> wise, the problem would be there in many other modules as well... > >> >>> > >> >>> The daily JDK-11 build also shows that failure here: > >> >>> > >> >>> > >> > https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java11-linux-x86_64/410/artifact/out/patch-javadoc-root.txt > >> >>> > >> >>> BTW. the daily build is also broken with some whooping 150+ failures > >> >>> > >> >>> > >> > https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1071/testReport/ > >> >>> > >> >>> Mostly some Junit upgrade patch being the reason. > >> >>> > >> >>> -Ayush > >> >>> > >> >>> On Mon, 12 Dec 2022 at 18:46, Steve Loughran > >> <ste...@cloudera.com.invalid > >> >>> > > >> >>> wrote: > >> >>> > >> >>> > yetus is now reporting errors on our @InterfaceAudience tags in > >> java8 > >> >>> and > >> >>> > java11 javadoc generation > >> >>> > > https://github.com/apache/hadoop/pull/5205#issuecomment-1344664692 > >> >>> > > >> >>> > > >> >>> > >> > https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5205/2/artifact/out/branch-javadoc-hadoop-tools_hadoop-azure-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt > >> >>> > > >> >>> > it looks a bit like the javadocs are both being done in the java11 > >> >>> version, > >> >>> > and is is unhappy. > >> >>> > > >> >>> > any suggestions as to a fix? > >> >>> > > >> >>> > >> >> > >> > > >
