On 16 December 2014 at 16:24, Yongjun Zhang wrote:
> Interesting to see that the setting is not configurable and it is not a
> simple fix.
>
that's the price of closed source software
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which
bout how many digits to use, I personally find it's
> > not
> > > > > > > annoying
> > > > > > > >> to
> > > > > > > >> >> > type
> > > > > > > >> >> > >> one extra digit, but as long as we
>> >> > >> About the rest of the name, as long as we keep it the
> > same
> > > > for
> > > > > > the
> > > > > > >> >> same
> > > > > > >> >> > >> patch, it would work fi
gt; > >> >> > >>
> > > > > >> >> > >> *.[branchName.].patch*
> > > > > >> >> > >>
> > > > > >> >> > >> - Example jiraNameId: HADOOP-1234, HDFS-4321
> > > > &g
n there is
> no
> > > > need
> > > > >> for
> > > > >> >> > the
> > > > >> >> > >> branchName portion, otherwise, specify the branchName
> > > > accordingly.
> > > > >> >> > Example
> > >> >> better
> > > >> >> > >> sorting of different versions of patches.
> > > >> >> > >>
> > > >> >> > >> Would anyone who has the privilege please help to modify the
> > > >> followi
to modify the
> > >> following
> > >> >> > page
> > >> >> > >>
> > >> >> > >>
> http://wiki.apache.org/hadoop/HowToContribute#Naming_your_patch
> > >> >> > >>
> >
lowing
> > >> >> > page
> > >> >> > >>
> > >> >> > >>
> http://wiki.apache.org/hadoop/HowToContribute#Naming_your_patch
> > >> >> > >>
> > >> >> > >> accordingly?
>
t; >>
> >> >> > >> accordingly?
> >> >> > >>
> >> >> > >> Thanks a lot.
> >> >> > >>
> >> >> > >> --Yongjun
> >> >> > >>
> >> >
du
>> >> >
>> >> > >> wrote:
>> >> > >>
>> >> > >>> On Wed, Nov 26, 2014 at 2:58 PM, Karthik Kambatla <
>> >> ka...@cloudera.com>
>> >> > >>> wrote:
>> >> >
ka...@cloudera.com>
> >> > >>> wrote:
> >> > >>>
> >> > >>>> Yongjun, thanks for starting this thread. I personally like
> Steve's
> >> > >>>> suggestions, but think two digits should be enough.
> >
t;>
>> > >>>> Yongjun, thanks for starting this thread. I personally like Steve's
>> > >>>> suggestions, but think two digits should be enough.
>> > >>>>
>> > >>>> I propose we limit the restrictions to vers
e enough.
> > >>>>
> > >>>> I propose we limit the restrictions to versioning the patches with
> > >>> version
> > >>>> numbers and .patch extension. People have their own preferences for
> > the
> > >>>> rest
, mr, mapred) and I
> don't
> >>>> see a gain in forcing everyone to use one.
> >>>>
> >>>> Putting the suggestions (tight and loose) on the wiki would help new
> >>>> contributors as well.
> >>>>
> >>>&g
tributors as well.
>>>>
>>>>
>>> +1
>>>
>>> best,
>>> Colin
>>>
>>>
>>>> On Wed, Nov 26, 2014 at 2:43 PM, Eric Payne
>>> >>>>
>>>> wrote:
>>>>
>&
gt;> > On Wed, Nov 26, 2014 at 2:43 PM, Eric Payne
>> > > >
>> > wrote:
>> >
>> > > +1.The "different color for newest patch" doesn't work very well if you
>> > > are color blind, so I do appreciate a revision number in the nam
> > > +1.The "different color for newest patch" doesn't work very well if you
> > > are color blind, so I do appreciate a revision number in the name.
> > >
> > > From: Yongjun Zhang
> > > To: common-dev@hadoop.apache.org
> > > Sent:
Yongjun Zhang
> > To: common-dev@hadoop.apache.org
> > Sent: Tuesday, November 25, 2014 11:37 PM
> > Subject: Re: a friendly suggestion for developers when uploading patches
> >
> > Thanks Harsh for the info and Andrew for sharing the script. It looks
> that
&
ted, leading zeros make it easy to sort in directories when downloaded.
Works well if you download incoming patches to the same dir, or save your
own generated patches to the same folder (which I do to track what number
to use next & maintain that history)
On 26 November 2014 at 23:52, Ted Yu wr
bq. in the format of 001
It is hard to anticipate how many revisions a patch would go through. So
the leading zero's in the rev number should be optional.
Cheers
On Sat, Nov 22, 2014 at 11:11 AM, Yongjun Zhang wrote:
> Hi Steve,
>
> Thanks for the good suggestion.
>
> I like the idea to have e
doesn't work very well if you
> are color blind, so I do appreciate a revision number in the name.
>
> From: Yongjun Zhang
> To: common-dev@hadoop.apache.org
> Sent: Tuesday, November 25, 2014 11:37 PM
> Subject: Re: a friendly suggestion for developers when uploa
+1.The "different color for newest patch" doesn't work very well if you are
color blind, so I do appreciate a revision number in the name.
From: Yongjun Zhang
To: common-dev@hadoop.apache.org
Sent: Tuesday, November 25, 2014 11:37 PM
Subject: Re: a friendly suggestion
Thanks Harsh for the info and Andrew for sharing the script. It looks that
the script is intelligent enough to pick the latest attachment even if all
attachments have the same name.
Yet, I hope we use the following as the guideline for patch names:
<*projectName*>-<*jiraNum*>-<*revNum*>.patch
S
This might be a good time to mention my fetch-patch script, I use it to
easily download the latest attachment on a jira:
https://github.com/umbrant/dotfiles/blob/master/bin/fetch-patch
On Tue, Nov 25, 2014 at 5:44 PM, Harsh J wrote:
> For the same filename, you can observe also that the JIRA co
For the same filename, you can observe also that the JIRA colors the
latest one to be different than the older ones automatically - this is
what I rely on.
On Sat, Nov 22, 2014 at 12:36 AM, Yongjun Zhang wrote:
> Hi,
>
> When I look at patches uploaded to jiras, from time to time I notice that
>
Hi Ted,
Thanks for sharing, this is a good tool to view the patch.
For those who haven't tried: once you install it, then when you mouse-click
on an uploaded patch in Chrome, Chrome will render the patch as if you are
diffing the patch against the base side by side, with left side showing the
bas
Hi Steve,
Thanks for the good suggestion.
I like the idea to have even a more specific guideline for patch file
naming, and I agree using 3-digit is a good choice here:
<*projectName*>-<*jiraNum*>-<*revNum*>.patch
where revNum is 3-digit, in the format of 001, 002, ..., 010, 011, ...
Thanks.
For patch viewing, David Deng has a Chrome extension for rendering patch on
JIRA.
See this thread:
http://search-hadoop.com/m/DHED4LHEYI
FYI
On Sat, Nov 22, 2014 at 10:24 AM, Steve Loughran
wrote:
> can we do HADOOP--001.patch
>
> with the 001 being the revision.
>
> -That numbering scheme
can we do HADOOP--001.patch
with the 001 being the revision.
-That numbering scheme guarantees listing order in directories &c
-having .patch come after ensures that those people who have .patch bound
in their browser to a text editor (e.g. textmate) can view the patch with
ease
I know havin
bq. include a revision number in the patch file name
+1
On Fri, Nov 21, 2014 at 11:06 AM, Yongjun Zhang wrote:
> Hi,
>
> When I look at patches uploaded to jiras, from time to time I notice that
> different revisions of the patch is uploaded with the same patch file name,
> some time for quite
Hi,
When I look at patches uploaded to jiras, from time to time I notice that
different revisions of the patch is uploaded with the same patch file name,
some time for quite a few times. It's confusing which is which.
I'd suggest that as a guideline, we do the following when uploading a patch:
31 matches
Mail list logo
