bq. in the format of 001 It is hard to anticipate how many revisions a patch would go through. So the leading zero's in the rev number should be optional.
Cheers On Sat, Nov 22, 2014 at 11:11 AM, Yongjun Zhang <yzh...@cloudera.com> wrote: > Hi Steve, > > Thanks for the good suggestion. > > I like the idea to have even a more specific guideline for patch file > naming, and I agree using 3-digit is a good choice here: > > <*projectName*>-<*jiraNum*>-<*revNum*>.patch > > where revNum is 3-digit, in the format of 001, 002, ..., 010, 011, ... > > Thanks. > > --Yongjun > > On Sat, Nov 22, 2014 at 10:24 AM, Steve Loughran <ste...@hortonworks.com> > wrote: > > > can we do HADOOP-1111-001.patch > > > > with the 001 being the revision. > > > > -That numbering scheme guarantees listing order in directories &c > > -having .patch come after ensures that those people who have .patch bound > > in their browser to a text editor (e.g. textmate) can view the patch with > > ease > > > > I know having a 3 digit number is pessimistic -I've never got past 70+, > but > > you never know > > > > For anyone doing patches off their own repo, I'd recommend tagging the > > commit with the same revision number —but that 's just a personal choice > > > > > > > > On 21 November 2014 at 19:10, Ted Yu <yuzhih...@gmail.com> wrote: > > > > > bq. include a revision number in the patch file name > > > > > > +1 > > > > > > On Fri, Nov 21, 2014 at 11:06 AM, Yongjun Zhang <yzh...@cloudera.com> > > > wrote: > > > > > > > Hi, > > > > > > > > When I look at patches uploaded to jiras, from time to time I notice > > that > > > > different revisions of the patch is uploaded with the same patch file > > > name, > > > > some time for quite a few times. It's confusing which is which. > > > > > > > > I'd suggest that as a guideline, we do the following when uploading a > > > > patch: > > > > > > > > - include a revision number in the patch file name.A > > > > - include a comment, stating that a new patch is uploaded, > including > > > the > > > > revision number of the patch in the comment. > > > > > > > > This way, it's easier to refer to a specific version of a patch, and > to > > > > know which patch a comment is made about. > > > > > > > > Hope that makes sense to you. > > > > > > > > Thanks. > > > > > > > > --Yongjun > > > > > > > > > > > -- > > CONFIDENTIALITY NOTICE > > NOTICE: This message is intended for the use of the individual or entity > to > > which it is addressed and may contain information that is confidential, > > privileged and exempt from disclosure under applicable law. If the reader > > of this message is not the intended recipient, you are hereby notified > that > > any printing, copying, dissemination, distribution, disclosure or > > forwarding of this communication is strictly prohibited. If you have > > received this communication in error, please contact the sender > immediately > > and delete it from your system. Thank You. > > >
