Re: JUnit5 parameterization pain

2025-07-07 Thread Steve Loughran
I've got one paramterized contract test working now, a new one for a PoC PR https://github.com/apache/hadoop/pull/7316 https://github.com/apache/hadoop/blob/3a3e6f3159473456e449678adfcab938a1cc95c0/hadoop-tools/hadoop-aws/src/test/formats/org/apache/hadoop/fs/contract/s3a/ITestIcebergBulkDelete.ja

RE: JUnit5 parameterization pain

2025-07-07 Thread Shilun Fan
I believe it’s best to proceed step by step. I suggest we tackle this in phases, avoiding the mixing of tasks like upgrading Junit unit tests, the Maven version, and Junit5 versions. Since I’m unsure whether combining these tasks could introduce new issues, I propose that we first focus on mig

RE: JUnit5 parameterization pain

2025-07-06 Thread Cheng Pan
Upgrading JUnit from 5.8 to 5.13 sounds like a straightforward version bumping, and should be low risk, so just do it? Thanks, Cheng Pan On 2025/07/04 14:55:38 Steve Loughran wrote: > I see that Junit5 completely breaks parameterization because its test > running is completely different...the val

Re: JUnit5 parameterization pain

2025-07-05 Thread Shilun Fan
Hi Steve, Thanks a lot for pointing out this issue. Indeed, JUnit 5 introduces significant differences compared to JUnit 4—one could even say the changes are quite drastic. That said, I think we’ll have to embrace this trend, as communities like Spark 4.0, Iceberg, and Flink are all moving in t