I believe it’s best to proceed step by step. I suggest we tackle this in phases, avoiding the mixing of tasks like upgrading Junit unit tests, the Maven version, and Junit5 versions. Since I’m unsure whether combining these tasks could introduce new issues, I propose that we first focus on migrating the Junit unit tests. Let’s start by upgrading the tests based on Junit 5.8, removing Junit 4, and then move on to upgrading other components.
Best, Shilun Fan. On 2025/07/06 19:26:18 Cheng Pan wrote: > Upgrading JUnit from 5.8 to 5.13 sounds like a straightforward > version bumping, and should be low risk, so just do it? > > Thanks, > Cheng Pan > > On 2025/07/04 14:55:38 Steve Loughran wrote: > > I see that Junit5 completely breaks parameterization because its test > > running is completely different...the value gets passed as a parameter to > > the test method, which is too late for any test setup. As a result, all s3a > > ITests are broken. > > > > The good news, JUnit 5.13 appears to restore this functionality, somehow > > > > https://docs.junit.org/current/api/org.junit.jupiter.params/org/junit/jupiter/params/ParameterizedClass.html > > > > I'm trying this on a new test suite I'm writing; if it works we will have > > to move all those parameterized test cases in hadoop-aws, maybe elsewhere > > back to it. > > > > I'm a bit disappointed with the Junit team here, though their key > > contribution to software development "make writing tests easy" is profound. > > Pity they left out "make upgrading existing test suites easy" > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org > For additional commands, e-mail: common-dev-h...@hadoop.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org
