Re: Checkstyle 80 char limit

2015-05-06 Thread Rich Haase
Thanks for sharing that links Steve! On May 6, 2015, at 3:45 AM, Steve Loughran mailto:ste...@hortonworks.com>> wrote: I find it restrictive too, but recognise why it is so critical for side-by-side patch review grab this plugin to browse JIRA patches and then you'll really appreciate it.

Re: Checkstyle 80 char limit

2015-05-06 Thread Steve Loughran
I find it restrictive too, but recognise why it is so critical for side-by-side patch review grab this plugin to browse JIRA patches and then you'll really appreciate it. https://chrome.google.com/webstore/detail/git-patch-viewer/hkoggakcdopbgnaeeidcmopfekipkleg Similarly, it's good for In

Re: Checkstyle 80 char limit

2015-05-05 Thread Andrew Wang
I typically split my IDE into two side-by-side panes, the 80 char limit works pretty well once you factor in the side panes too. I've worked on a project with a 100 char limit, and that's about the point where even my 30" monitor needs side scrolling. I think Colin pretty much nailed it with his r

Re: Checkstyle 80 char limit

2015-05-05 Thread Rich Haase
Jay, Does bigtop use a line length limit at all? I was mostly hoping that we could update to using a limit that was more appropriate (IMO) to modern IDEs, like 100-120 chars perhaps? On May 5, 2015, at 4:38 PM, jay vyas mailto:jayunit100.apa...@gmail.com>> wrote: im glad you've started thi

Re: Checkstyle 80 char limit

2015-05-05 Thread jay vyas
im glad you've started this thread. 1) i like the idea of dropping the 80 char limit ! 2) and indeed, we've now adopted it in ASF BigTop, where we try to take queues from hadoop when possible. On Tue, May 5, 2015 at 3:53 PM, Rich Haase wrote: > Arun, > > I use my IDE split vertically all the t

Re: Checkstyle 80 char limit

2015-05-05 Thread Colin P. McCabe
Historical issues aside, the reasons are: * When doing vertical, side-by-side diffs, you need some reasonable length length standard or else it Just Doesn't Work. And vertical, side-by-side diffs are how most people prefer to do code reviews. * Really long lines are visually difficult to follow.

Re: Checkstyle 80 char limit

2015-05-05 Thread Jake Low
Quoting Niels Basjes (2015-05-05 11:29:03) > So the 80 chars thing was at best reconsidered 16 years ago. > > Things have changed ... Limiting text to a particular width isn't just a byzantine coding convention. It arose in programming from much older practices, and it has persisted through the ye

Re: Checkstyle 80 char limit

2015-05-05 Thread Rich Haase
Arun, I use my IDE split vertically all the time on projects without strict line limits and I have never had a problem seeing the code from multiple classes in such a setup. I can certainly setup my IDE to only do 80 characters a line, although I think it hurts readability in many cases where

Re: Checkstyle 80 char limit

2015-05-05 Thread Arun Suresh
My 2 cents : I actually like the lower char limit. Since most of the time, I end up having to switch between classes, I end up splitting my screen vertically and having multiple files open. for some reason, I find splitting vertically is better for readability than horizontally. In anycase, my IDE

Re: Checkstyle 80 char limit

2015-05-05 Thread Niels Basjes
> I respect immensely the contributions Doug has made to many Apache projects, Hear hear! I fully agree with that one. On Tue, May 5, 2015 at 8:30 PM, Rich Haase wrote: > I respect immensely the contributions Doug has made to many Apache > projects, but I don’t think that should be a reason to

Re: Checkstyle 80 char limit

2015-05-05 Thread Rich Haase
I respect immensely the contributions Doug has made to many Apache projects, but I don’t think that should be a reason to force everyone to write code as if our screen sizes can’t support more than 80 characters. On May 5, 2015, at 12:21 PM, Niels Basjes mailto:ni...@basjes.nl>> wrote: Perhaps

Re: Checkstyle 80 char limit

2015-05-05 Thread Niels Basjes
Quote from that page (i.e. the big block in RED at the top): The information on this page is for Archive Purposes Only This page is not being actively maintained. Links within the documentation may not work and the information itself may no longer be valid. The last revision to this document was m

Re: Checkstyle 80 char limit

2015-05-05 Thread Niels Basjes
Perhaps we should tell him these screens can also be turned landscape ? ;) But seriously: 1) Does Doug still actively work on code? From my perspective; Only very infrequently. 2) In the 200+ people IT department where I work I know only 1 colleague who uses his screen in portrait mode and he does

Re: Checkstyle 80 char limit

2015-05-05 Thread Jonathan Eagles
More formally, we follow the sun java coding standards which follow the 80 character limit. There is recent discussion over this, so it is a very relevant comment. http://wiki.apache.org/hadoop/HowToContribute http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html#

Re: Checkstyle 80 char limit

2015-05-05 Thread Allen Wittenauer
On May 5, 2015, at 11:05 AM, Rich Haase wrote: > Can someone explain to me why on earth we care about limiting line length to > 80 characters? Are there hadoop developers out there working from teletype > terminals? Can we perhaps update this limit to something sane, like 120 > chars? >

Checkstyle 80 char limit

2015-05-05 Thread Rich Haase
Can someone explain to me why on earth we care about limiting line length to 80 characters? Are there hadoop developers out there working from teletype terminals? Can we perhaps update this limit to something sane, like 120 chars? Rich Haase| Sr. Software Engineer | Pandora m (303) 887-1146